Commit Graph

134 Commits

Author SHA1 Message Date
Jean Bisutti 2535a758f7
Add smoke test for the OTel Spring starter (#8965)
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-07-20 09:55:02 -07:00
Trask Stalnaker 2bdddafdc4
Apply Prettier to markdown files (#8968) 2023-07-19 12:22:35 -07:00
Trask Stalnaker 3e087e8206
Add note about Optional/Stream usage to style guide (#8193)
Based on #8190 and
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/8131#discussion_r1151528583

---------

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-04-03 20:15:59 +00:00
Jean Bisutti c5ef8ffd60
Add GraalVM native tests (#8163)
This PR allows:
* Executing the OTel Logback appender tests as GraalVM native
executables
* Executing the native tests once a day on Github

---------

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-03-30 14:10:48 -07:00
Tyler Benson 1b4b47a576
Add `disableShadowRelocate` build setting (#8117)
This is helpful for debugging.

Fixes #4672

Add the following to enable locally `~/.gradle/gradle.properties`

```
disableShadowRelocate=true
```
2023-03-28 19:42:45 +03:00
kaibocai bbb6482979
Update contributing doc for instrumentationModule (#7803)
As `helperResourceNames()` method is replaced by
`registerHelperResources(HelperResourceBuilder)` method, replacing it to
use `registerHelperResources(HelperResourceBuilder)` in
[writing-instrumentation-module.md](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/contributing/writing-instrumentation-module.md#inject-additional-resources-using-the-helperresourcenames-method)
2023-02-11 12:43:06 -08:00
Gregor Zeitlinger dcc9795a2e
modules must be public (#7744)
modules must be public
2023-02-06 14:45:42 -08:00
sodared b18a250250
Update intellij-setup-and-troubleshooting.md (#7504)
fix wrong spell **'due ot'** in the doc
2023-01-03 12:05:31 +01:00
Lauri Tulmin d38bc4d2a4
Correct link to OpenTelemetry schemas (#7453)
was moved in
https://github.com/open-telemetry/opentelemetry-specification/pull/3046
2022-12-20 16:51:02 +01:00
Trask Stalnaker 66a112de30
Move repository-settings.md file (#7352)
I think this is a better location (and I'm going to suggest this as a
general practice for other repos where maintainers have admin rights)
2022-12-01 15:04:03 -08:00
Aaron Ai 2d7395c44b
Introduce markdown lint check (#7175)
Fixes #7129
2022-11-16 20:48:42 -08:00
Trask Stalnaker 19ce0f87b9
GitHub action sync (#7150) 2022-11-15 09:35:30 -08:00
Trask Stalnaker d7df94ad5b
Fix branch protection rules (#6973)
(in particular it was the dependabot rule that was not matching and so
dependabot was failing)
2022-10-26 11:22:16 -07:00
Trask Stalnaker d18a05b5a2
Add section to coding guidelines on Optional usage (#6894)
This was discussed a long while back, but never documented (and recently
came up in #6889)

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
2022-10-22 18:07:00 -07:00
Trask Stalnaker 9ce68fb937
Fix metric units (#6931)
Follow-up to #6930
2022-10-22 10:00:48 -07:00
Trask Stalnaker 3601a84b3d
Update repo settings doc (#6877)
Added new "Restrict pushes that create matching branches: UNCHECKED",
which I discovered is needed during contrib release.

Removed the old `v*` branch protections since we don't need to make any
more patch releases from those old branch names anymore.
2022-10-14 08:53:42 -07:00
Trask Stalnaker 9621ea08cf
Update repo settings (#6862)
it seems that github recently tightened up the branch protection
restrictions (in a way that makes more sense than the prior behavior)
2022-10-13 20:07:36 -07:00
jack-berg aeac361816
Upgrade to otel java 1.19.0 (#6757)
Working PR to capture all the changes required to update to otel java
1.19.0. The new log API force allows
`:instrumentation-appender-api-internal` and
`:instrumentation-appender-sdk-internal`, but necessitates a decent
amount of refactoring as a result.

The PR points at the `1.19.0-SNAPSHOT`, which I'll update upon
publication.

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2022-10-12 09:19:37 -07:00
Trask Stalnaker f4c5719c99
Allow auto-merge on PRs (#6812)
This seems nice for after pushing `spotlessApply` on an otherwise
approved and passing PR. I just enabled it and tried it on #6774.

(somewhat related to #6743)

Btw, I thought this was helpful explanation

> After you enable auto-merge for a pull request, if someone who does
not have write permissions to the repository pushes new changes to the
head branch or switches the base branch of the pull request, auto-merge
will be disabled. For example, if a maintainer enables auto-merge for a
pull request from a fork, auto-merge will be disabled after a
contributor pushes new changes to the pull request.


https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request#about-auto-merge
2022-10-06 16:02:27 -07:00
Trask Stalnaker 32d7febed5
Update repository settings for dependabot (#6715) 2022-09-22 16:03:36 -07:00
Trask Stalnaker 2d79f7903c
Branch protection rules for dependabot (#6674) 2022-09-20 08:39:07 -07:00
Trask Stalnaker fc0d94ce4a
Update squash merge message setting (#6649)
Resolves #6624

I've updated the setting already
2022-09-19 08:39:11 -07:00
Trask Stalnaker 906f31f56e
Update Intellij doc (#6451) 2022-08-10 11:40:37 +03:00
Trask Stalnaker 13305532bf
Document docker disk space (#6435) 2022-08-09 12:13:34 +02:00
Trask Stalnaker 177f0aec7c
Rename instrumentation-api-annotation-support (#6288) 2022-07-08 17:07:41 -07:00
Trask Stalnaker 701ed54311
Use "class loader" instead of "classloader" consistently in docs and comments (#6236)
* Use "class loader" consistently instead of classloader

* Java comments too

* Fix bad merge
2022-06-30 14:57:07 -07:00
Mateusz Rzeszutek c978ce22f5
Update (rewrite) the javaagent structure doc; document bootstrap modules (#6227) 2022-06-28 20:23:27 -07:00
Mateusz Rzeszutek 512a040025
Remove TimeExtractor and use internal API for setting start/end timestamps (#6051)
* Remove TimeExtractor and use internal API for setting start/end timestamps

* code review comments
2022-05-19 09:03:11 -07:00
Trask Stalnaker 59618783a2
Remove tag protection rule (#6048) 2022-05-17 09:53:32 +03:00
Trask Stalnaker 18367e72a0
Doc tag protections (#6026) 2022-05-16 11:58:32 +03:00
Mateusz Rzeszutek 87b412fb40
Instrumentation API changes: OperationMetrics, OperationListener (#6016)
* Instrumentation API changes: OperationMetrics, OperationListener

* errorprone
2022-05-12 11:16:46 -07:00
Mateusz Rzeszutek 802f5aa3ea
Instrumentation API and Javadoc cleanup (#5954) 2022-05-09 22:13:45 -07:00
Mateusz Rzeszutek d919f84cf8
Merge javaagent-instrumentation-api into javaagent-extension-api (#5936)
* Merge javaagent-instrumentation-api into javaagent-extension-api

* remove some leftover references to javaagent-instrumentation-api

* add missing instrumentation-api to distro example
2022-04-28 20:11:15 -07:00
Mateusz Rzeszutek 2ce1162eac
Instrumenter instrumentation version and schema url (#5752)
* Instrumenter instrumentation version and schema url

* nullable instrumentation version

* Apply suggestions from code review

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>

* reformat

* code review comments

* instrumentation properties files

* Apply suggestions from code review

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>

* code review comments

* Apply suggestions from code review

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-04-11 10:29:58 +02:00
Mateusz Rzeszutek 39e1fcb48e
Rename view and controller suppression config properties (#5747)
* Rename view and controller suppression config properties

* code review comments
2022-04-05 14:24:24 -07:00
Trask Stalnaker 5b0d9e31ce
Remove old status check (#5750) 2022-04-04 14:22:51 -07:00
Patrice Chalin e908b7fc71
docs: drop suppressing-instrumentation page and script (#5694) 2022-03-25 11:10:21 -07:00
Trask Stalnaker c73da76ec1
Document another repo setting (#5654) 2022-03-21 18:29:06 -07:00
Trask Stalnaker 38ad4136ee
Move update gradle doc to script (#5642) 2022-03-21 08:48:43 -07:00
Trask Stalnaker 3fc684ade6
Document repository settings (#5614) 2022-03-18 10:32:39 +02:00
Trask Stalnaker 3ab1b8516f
Add markdown spell check (#5450)
* Add markdown link check

* Fix links

* update workflows

* move comment

* Add misspell check

* Fix misspellings

* Fix more misspellings

* Run against all files

* Spotless
2022-03-01 19:18:53 -08:00
Trask Stalnaker c3e0c258d7
Update style guide regarding final local vars (#5055) 2022-01-10 10:01:08 +02:00
Trask Stalnaker d930971adf
Fix Quarkus correlation (#4883)
* Fix Quarkus correlation

* Add Quarkus smoke test image

* Add Quarkus smoke test

* Fix permission on gradlew

* Update to gradle 7.3.1

* Fix Jib build

* Bump compilation to Java 11

* Better comment

* Fix comment placement

* Fix
2021-12-13 09:26:44 -08:00
Trask Stalnaker f7efe07b06
Merge start and end time extractors (#4692) 2021-11-29 22:07:49 -08:00
Trask Stalnaker 09d5883fb8
Update supported application servers (#4715)
* Update naming to Payara

* Alphabetize

* Update supported application servers

* A little more clarity?
2021-11-25 08:15:35 -08:00
Trask Stalnaker f9146bcf48
Update other gradle wrappers to 7.3 (#4705) 2021-11-24 13:19:53 -08:00
Lauri Tulmin 16728e2445
Add a ClassAndMethod class to Instrumentation API (#4619)
* Add a ClassAndMethod class to Instrumentation API

* remove sentence

* Update docs/contributing/writing-instrumentation.md

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* address review comment

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-11-10 13:33:11 -08:00
Mateusz Rzeszutek f3ec9a215b
Document Instrumenter API (#4544)
* Document Instrumenter API

* Apply suggestions from code review

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>

* reformat and code review comments

* code review comments

* Apply suggestions from code review

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* formatting

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-11-05 15:15:48 +01:00
Fabrizio Ferri-Benedetti 114a1b455c
Review "writing-instrumentation-module.md" (#4507)
* Review "writing-instrumentation-module.md"

A peer review of "writing-instrumentation-module" for language and style, as requested by @mateuszrzeszutek .

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

* Update docs/contributing/writing-instrumentation-module.md

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update writing-instrumentation-module.md

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Update docs/contributing/writing-instrumentation-module.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Apply suggestions from code review

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Spotless

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-27 21:07:22 -07:00
Mateusz Rzeszutek 23b95901f5
Update and extend the writing-instrumentation.md doc (#4443)
* Update and extend the writing-instrumentation.md doc

* Apply suggestions from code review

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>

* Reformat; added a tiny bit of explanation about the classloader separation thing

* Apply suggestions from code review

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* fix that 'testing strategy' part

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-25 13:21:50 -07:00