8066f2787c
Add context customizer hook to Instrumenter API ( #4167 )
...
* Add context customizer hook to Instrumenter API
* Use in tomcat instrumentation
* Some of servlet
* Use in rest of servlet
* Feedback
2021-09-22 14:54:04 -07:00
dc4ddf7932
Remove ContextStore.Factory interface; use Supplier instead ( #4157 )
2021-09-17 13:00:23 -07:00
59439cb464
Make servlet context path key private ( #4125 )
...
* Make servlet context path key private
* remove accidentally added files
* fix servlet2.2
* use non capturing lambda
* Update instrumentation/servlet/servlet-common/library/src/main/java/io/opentelemetry/instrumentation/servlet/ServletHttpServerTracer.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* use method reference
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-09-16 10:23:29 -07:00
15277cf8f5
Convert servlet instrumentation to instrumenter api ( #4078 )
...
* Convert servlet to instrumenter api
* make classes final
* Remove some tracer files
* remove xxx
* fix liberty and wildfly exception smoke test
* fix async smoke test on liberty
* Apply suggestions from code review
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* generic TextMapGetter for servlets
* not going to use http.route for servlets
* simplify
* add servlet timeout in attribute extractor
* move classes from library to javaagent
* remove unneeded dependency
* make method private
* move helper class initialization to singleton, remove helpers that don't have any methods, add shouldStart checks
* Update instrumentation/servlet/servlet-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/ServletRequestContext.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* add import
* rename methods that start and end spans
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-09-13 10:12:34 -07:00
dca77b6ae3
Remove unused method ( #4058 )
2021-09-07 14:56:12 -07:00
c91eda59b5
Small reduction in context lookups ( #4006 )
2021-08-30 09:02:52 -07:00
5c71d28ed7
Remove deprecated Config methods ( #3908 )
2021-08-23 16:44:54 -07:00
9b56fc9051
Clean up AgentElementMatchers ( #3527 )
...
* Clean up AgentElementMatchers
* remove a TODO
* moved method
2021-07-09 10:02:21 +03:00
9e4da754c2
Use consistent logger field name ( #3515 )
2021-07-07 10:47:46 -07:00
b304cc2912
Deprecate CallDepth.reset() and get() ( #3511 )
...
* Deprecate CallDepth.reset() and get()
* Don't pass CallDepth around
2021-07-07 09:24:50 -07:00
c5ba5c3a71
Use local variable for passing CallDepth between advice enter/exit me… ( #3504 )
...
* Use local variable for passing CallDepth between advice enter/exit methods
* fix broken call depth tracking
* checkstyle
* fix javadocs
2021-07-06 12:05:14 -07:00
b9fcb6b498
Reduce CallDepth classes' API surface ( #3497 )
2021-07-06 09:24:19 +02:00
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
bcb282a220
Conform to google style guide checkstyle ( #3399 )
2021-06-24 10:53:23 +03:00
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
b7bfbf0cc6
Migrate instrumentation-library / common to plugins ( #3320 )
2021-06-15 11:54:48 -07:00
62f1f49bcd
Intellij cleanup (Java and Groovy) ( #3285 )
...
* Intellij cleanup
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/messaging/MessagingAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/spring/spring-web-3.1/library/src/test/java/io/opentelemetry/instrumentation/spring/httpclients/RestTemplateInterceptorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Use glassfish version that supports lambdas
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 10:23:01 -07:00
2436499a09
Update to Errorprone 2.7 ( #3181 )
...
* Update to errorprone 2.7
* ToString
* Finish
2021-06-04 10:40:55 +09:00
b8aec6a671
Remove no longer needed NameMatchers class ( #3179 )
2021-06-03 14:36:36 -07:00
ed88cca533
Migrate from spotbugs to errorprone ( #3122 )
...
* Migrate from spotbugs to errorprone
* Fix hashtable
* try-with-resources
* Fix from merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
c358a35414
Use dependency management pattern for dependency versions ( #3113 )
...
* Use dependency management pattern for dependency versions.
* Add groovy bom too
* Update dependencyManagement/dependencyManagement.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
fd132d463d
Change Async Servlet span end logic to fix race condition on Undertow ( #2992 )
...
* Attach servlet async listener with asyncStart instrumentation
* Exclude Spring packages containing servlet request classes from global ignores
* Exclude Tapestry HSR proxy with global ignore
* Improve comments.
* Fix for Liberty - request response when adding async listener
* Removed unused methods
* Explicit response to async listeners on all servlet engines
* Attach response to request on Jetty
* Fix broken build due to rebase, improved a comment
* Address PR comments
* Added a comment.
* Addressed PR comments
2021-05-25 20:46:37 -07:00
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
f413e5a3aa
Remove RequestDispatcherAdvice ( #2942 )
2021-05-12 21:37:48 -07:00
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
357140c081
Server span naming for servlet filters ( #2887 )
...
* Server span naming for servlet filters
* wildfly default servlet has empty mappings
* jetty11 requires java11
* try a differnt way to disable jetty11 tests on java8
* Update instrumentation/servlet/servlet-5.0/javaagent/src/test/groovy/TomcatServlet5FilterMappingTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* review fix
* rework to use InstrumentationContext
* remove debugging code
* move MappingResolver to avoid ClassCastException on wildfly
* Update instrumentation/servlet/servlet-3.0/javaagent/src/test/groovy/TomcatServlet3FilterMappingTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* review fixes
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-06 13:25:17 +03:00
1824e36b96
Better server span name for Grails and Wicket ( #2814 )
2021-04-22 14:16:54 -07:00
3bd46091bc
Clean up request dispatcher instrumentation ( #2724 )
2021-04-06 13:36:38 -07:00
7027006f66
Request handlers and test images for Tomcat 10 and Jetty 11 (Servlet API 5) ( #2703 )
...
* Tomcat 10 and Jetty 11 handlers with Servlet API 5
* Jetty 11 and Tomcat 10 Windows images
2021-04-05 09:45:02 -07:00
cc47da585b
New Instrumenter API ( #2596 )
...
* Instrumenter
* Spotless
* More instrumenter
* More
* Instrumenter API
* New Instrumenter API - InstrumenterBuilder (#20 )
* New Instrumenter API - InstrumenterBuilder
* New Instrumenter API - InstrumenterBuilder - code review comments
* Start doccing
* Docs
* Most tests
* Last test
* Stick with current hostName lookup for now
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpClientTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* New Instrumenter API - code review comments (#21 )
* Doc
* Checkstyle
* Cleanups
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-04-05 15:45:07 +09:00
69c2644774
Servlet 5 API, reorganize servlet modules ( #2609 )
...
* Servlet 5.0 API support, refactored other servlet modules
* Include correct servlet instrumentation module for grails tests
* Reapply spotless after rebase
* Fix checkstyle
* Spotless
* Addressed PR suggestions
* Fixed files in wrong package.
* Fixed mixed up instrumentation names.
* Fixed incomplete instrumentation name.
* Addressed PR suggestions
* Addressed PR suggestions
2021-03-23 14:11:43 +02:00
8242a01b3a
Clean up and document BaseTracer ( #2482 )
2021-03-04 11:21:46 +01:00
0adeb85f43
Refactor InMemoryExporter and move some of its methods … ( #2264 )
...
* Refactor InMemoryExporter and move some of its methods to spock base class & junit extension
* codenarc
* spotless
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* fix armeria library tests
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-15 17:36:14 +01:00
0fbdcad1dd
Make BaseTracer#startSpan() return Context ( #2232 )
...
* Make BaseTracer#startSpan() return Context
* Update instrumentation/apache-camel-2.20/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachecamel/CamelEventNotifier.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* spotless
* Add Javadocs to BaseTracer
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-12 12:12:40 +01:00
ecf64c25f3
Remove BaseTracer#startScope() method ( #2224 )
...
* Remove BaseTracer#startScope() method
* fix compilation failure
2021-02-10 11:39:38 +01:00
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
93b3a3b289
testing-common refactoring: replace direct AgentTestRunner usage with… ( #2134 )
...
* testing-common refactoring: replace direct AgentTestRunner usage with spock spec
* Updated instrumentation docs
* Fix reactor-core library tests
ReactorCoreTest was getting a tracer from GlobalOpenTelemetry before LibraryTestTrait had a change to initialize the SDK
2021-02-01 11:32:25 +01:00
4c1144ce78
Distinguish between the various servlet tracers for easier debugging. ( #1979 )
...
* Distinguish between the various servlet tracers for easier debugging.
* change to use the `common` suffix for that module
* Update instrumentation/servlet/servlet-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v2_2/Servlet2HttpServerTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/Servlet3HttpServerTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/dispatcher/RequestDispatcherTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/http/HttpServletResponseTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-01-20 16:33:13 +02:00
077d8b64f6
Move common matchers to tooling/bytebuddy/matcher and ignore matchers to tooling/matcher ( #1965 )
2021-01-10 12:35:53 -08:00
8d74baa2e4
Run tests with javaagent. ( #1643 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-01-04 13:13:24 -08:00
65f54e450b
Use Context more in HttpClientTracer ( #1811 )
...
* Use Context more in HttpClientTracer
* Better http-url-connection response object
* Follow database semantic conv for elasticsearch-rest
* Remove unnecessary CallDepth tracking
2020-12-03 11:47:08 -08:00
41bd489a77
Format groovy files ( #1793 )
2020-11-28 21:22:14 -08:00
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00
9a64a628ea
Make instrumentations non final ( #1752 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-11-26 11:22:25 -08:00
50c8ab499d
Remove no longer needed helperClassNames() methods ( #1755 )
2020-11-24 20:50:32 -08:00
45646ff367
Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization() ( #1741 )
...
* Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization()
* Removed no longer needed comments & improved JavaDoc
* Improve TypeInstrumentation Javadoc
2020-11-24 14:27:58 +02:00
79f76c78ad
Move java files to java source folder and groovy files to groovy source folder ( #1735 )
...
* Move java files to java source folder
* Move groovy files to groovy source folder
* Too much
* Move another one back
* Codenarc
* Move test resource to where test is
* Spotless
2020-11-23 15:42:04 +02:00
e092e87d6b
Remove disabled by default servlet instrumentation ( #1684 )
2020-11-19 11:22:02 -08:00
cecdfc2cd0
Update instrumentation names to be consistent ( #1671 )
...
* Update instrumentation names to be consistent
* Remove amqp from rabbitmq package name
2020-11-18 19:53:31 -08:00
9d2db827b9
Refactor Instrumenters into InstrumentationModules - R, S, T, V ( #1576 )
2020-11-09 18:48:52 -08:00
71f91877ab
Fix muzzle and add missing helper classes ( #1585 )
...
* Fix muzzle
* Fix jdbc instrumentation
* Fix jms instrumentation
* Fix couchbase instrumentation
* Fix servlet instrumentation
2020-11-08 13:54:00 -08:00
d3b60a5e33
Rename TRACER to tracer() ( #1540 )
2020-11-02 20:49:51 -08:00
c6eee70660
Update to latest snapshot. ( #1524 )
2020-10-29 18:54:09 -07:00
a2dccf2316
Update to latest SDK snapshot. ( #1479 )
2020-10-26 19:29:46 -07:00
3565775b00
Format groovy ( #1475 )
...
* Apply Intellij format to groovy
* spotless
2020-10-26 11:47:12 +09:00
f6ad05b8e3
Update to latest SDK snapshot ( #1384 )
...
* Update to latest SDK snapshot
* Use published snapshot
* Fixes
* Cleans
* spotless
* Most
* Clean
* Merge
* Temporarily remove context interop
* WIP
* Prepare for intercepting propagated span
* Bump SDK
* IDE updates
* Lots
* compileJava
* Done?
* bar
* Spot
* drugs
* Groovy--
* green for me
* Spot
* Remove grpc import
* Scrub
2020-10-25 15:14:32 +09:00
57301e3fe7
Rename "integration" to "instrumentation" ( #1412 )
...
* Rename integration to instrumentation
* Revert doc changes, need to wait for release
* spotless
2020-10-19 14:36:30 +09:00
c739f7db6b
Remove unnecessary scopes ( #1351 )
2020-10-11 14:31:37 -07:00
1b51d4a6b1
Rename packages ( #1367 )
2020-10-11 13:54:35 -07:00
409530629f
Refactor all tests that use Config so that they don't fail locally ( #1310 )
...
* Refactor all tests that use Config so that they don't fail locally
* Use ConfigUtils in tests for all config-related things
* Fix spotless and codenarc
* Fix spotless
* PR comments: remove unnecessary config
2020-10-08 20:01:31 +03:00
f2de47a150
SpanAssert method names should reflect underlying Span method names ( #1307 )
2020-10-05 16:04:08 +09:00
dadaac9a8c
Use 2-line license header to match SDK repo ( #1321 )
...
* Use 2-line license header to match SDK repo
* Apply change
2020-10-05 14:29:56 +09:00
7b1b399a29
Convert more decorators to tracers ( #1275 )
...
* More decorators to tracers
* Convert more decorators to tracers
* Fixes
2020-09-29 09:41:09 +03:00
8954f222c0
Update to the latest opentelemetry-java 0.9.0-SNAPSHOT ( #1266 )
2020-09-26 20:44:28 -07:00
912a159c19
Update to latest SDK snapshot. ( #1202 )
2020-09-15 17:49:10 +09:00
fbd4018e4b
Don't run latest deps test for servlet-common ( #1051 )
2020-08-19 14:55:09 +09:00
bbfdbb39c0
Create abstraction for library dependencies for instrumentation. ( #977 )
...
* Create abstraction for library dependencies for instrumentation.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-08-19 08:57:31 +09:00
7159d04b8d
Change groovy import order ( #1013 )
...
* Update docs
* Format all groovy code
* Organize imports
2020-08-15 23:19:27 -07:00
414213f2d1
Remove final from parameters ( #1003 )
2020-08-15 22:35:51 -07:00
f893ca540b
Scripted package renaming ( #988 )
2020-08-15 21:55:01 -07:00
bb235a0aa3
Update package name for tracers ( #991 )
2020-08-14 21:07:18 -07:00
f940b2d2de
Use OpenTelemetry.getTracer() shortcut ( #965 )
2020-08-14 07:11:06 +03:00
7818e33178
Package renaming ( #970 )
2020-08-13 20:14:46 -07:00
b5fbf90977
Extract instrumentation api module ( #884 )
2020-08-09 22:52:33 -07:00
5dc2ca350a
Update config property prefix from ota to otel ( #841 )
...
* Update config property prefix from ota to otel
* more
* format
* more
2020-07-31 08:29:29 +03:00
f6594e1a67
Use Span.recordException for logging throwable ( #813 )
...
* Use Span.recordException
* Fix tests
* Cleanup
* Update instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Spotless (IntelliJ acts weird with groovy files for me :()
* Update for merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-07-28 14:44:42 +09:00
fcf4319aac
Faster tests ( #725 )
...
🎉
2020-07-22 10:10:34 -07:00
86c438b154
Remove final from local variables ( #732 )
...
* Remove final from local variables
2020-07-20 13:53:34 +09:00
d8355c672d
Docs for writing new instrumentation... ( #652 )
...
* Docs for writing new instrumentation
2020-07-19 14:21:19 +09:00
763779e08a
Move servlet instrumentations around ( #601 )
2020-07-08 16:43:36 -07:00
b78abac82c
#598 Rename "tags" to "attributes" ( #645 )
2020-07-07 21:03:41 -07:00
a62801649f
More fixes for Gradle warnings ( #643 )
...
* More gradle deprecation warnings fixed
* More gradle deprecation warnings fixed
* More fixes
* More fixes
Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
2020-07-07 15:02:07 +03:00
3a4470f800
Server spans ( #634 )
...
* Milestone 1
* Netty 4.1 done
* Netty 4.0 done
* Netty 3.8 done
* All tests pass
* Test fix
* Last proper server tracers done
* Format fix
* Tests fixed
* Polish
* Polish
2020-07-07 13:48:51 +03:00
bfd7f4428d
Propagate full Context while processing http server requests ( #573 )
...
* Propagate full Context while processing http server requests
2020-06-26 20:13:12 +03:00
874b157fe5
Newline between license and package. ( #581 )
2020-06-25 13:31:16 -07:00
4a26bd3ce7
Simplify setting of user.principal attribute ( #509 )
2020-06-13 12:11:03 +03:00
4b665dcbe2
Changed instrumentation tracer" TRACER.startSpan() to never return `null` ( #499 )
2020-06-12 16:15:38 -07:00
1b29184e7c
Make rootDir usage consistent ( DataDog/dd-trace-java#1518 )
2020-06-11 10:14:02 -07:00
357fb6e989
Deduplicate servlets ( #469 )
...
* Servlet instrumentations unified
* Grizzly migrated
* Fix tests after merge
* Polish and fix tests
* Polish and fix tests
* Muzzle fixes
* Muzzle fixes
* Muzzle fixes
* Test fixes
* One more check fixed
* Stop using SpanWithScope
* Test fix
* Compilation fix
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Update agent-bootstrap/src/main/java/io/opentelemetry/auto/bootstrap/instrumentation/decorator/HttpServerTracer.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Polish
* Tracer does not manage scope anymore
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-06-08 10:49:58 +03:00
Trask Stalnaker
Mateusz Rzeszutek
Lauri Tulmin
Anuraag Agrawal
Ago Allikmaa
John Watson
Pavol Loffay
Ioannis Mavroukakis
Nikita Salnikov-Tarnovski
Helen Y
Sergei Malafeev
Tyler Benson