9f1d22ea6b
Register TracerBridge in TracerInstaller instead of DDTracer init
2018-08-27 12:04:26 -07:00
9338faa013
Muzzle inverse assertions
2018-08-24 10:47:37 -07:00
26705142bb
Muzzle pass and fail directives in the same collection
2018-08-24 10:47:37 -07:00
b6d1c18af9
Allow muzzle directives to have extra dependencies
2018-08-24 10:47:37 -07:00
f06eb57449
Convert apache-http, akka, and play to muzzle plugin
2018-08-24 10:47:37 -07:00
c6841c9d06
Add maven version scanning to muzzle
2018-08-24 10:47:37 -07:00
63bee3737c
Enable executor instrumentation for gRPC server calls
...
This might be more than is needed. Maybe cut back later.
2018-08-24 20:25:13 +10:00
51d74f6147
Begin 0.14.0
2018-08-24 11:35:47 +10:00
6b71340b5b
Enable new netty instrumentation by default
...
Enabled the others in a separate PR and forgot to come back and enable this.
2018-08-24 09:32:51 +10:00
5a6215971a
Merge pull request #455 from DataDog/tyler/enable-integrations
...
Enable netty by default
2018-08-23 16:04:23 +10:00
36b49c7de3
Merge pull request #451 from DataDog/tyler/netty-client-fixes
...
Allow trace to persist across netty connect.
2018-08-23 16:03:58 +10:00
69c04ea4c3
Enable netty instrumentation by default
2018-08-23 08:43:31 +10:00
898647e000
Allow trace to persist across netty connect.
...
Also create span with error on connection failure.
Add tests for connection failure.
2018-08-22 09:45:33 +10:00
c95baef487
Wait for given reference to get GCed in `waitGC`
...
This should help to make sure that object we are interested in
actually gets GCed.
This change also improves tests for PendingTrace and ScopeManager to
make sure that trace gets cleaned up.
2018-08-21 10:05:10 -04:00
520676538c
Merge pull request #449 from DataDog/mar-kolya/add-distributed-tracing-tests
...
Add some tests for distributed tracing in Tomcat and Jetty
2018-08-20 20:30:27 -04:00
e28ee5f9e8
Add timeout to datadog classloader test
2018-08-20 11:10:08 -07:00
a0036a76cc
Add `runFinalization` to `waitForGC`
2018-08-19 00:49:27 -04:00
a4cded9b4f
Add some tests for distributed tracing in Tomcat and Jetty
2018-08-18 13:38:06 -04:00
2d8102c8f5
Register Datadog classloader as parallel capable
2018-08-17 15:42:49 -07:00
f7407708a3
Merge pull request #444 from DataDog/tyler/test-http-server
...
Replace Ratpack test server with Jetty wrapped with groovy
2018-08-17 11:38:21 +10:00
f60d71f379
Fix ServerTest from messing up AgentTestRunnerTest if ran first.
2018-08-17 11:14:04 +10:00
0b289205f8
Add fixme to adapter.
2018-08-17 10:53:12 +10:00
3fc2738179
Improve test coverage and reduce duplication
2018-08-17 10:36:45 +10:00
138f78ce4b
Make Muzzle log class being instrumented
2018-08-16 17:28:32 -04:00
0b6c1bc3d3
Fix tests for Java 7, 9, and 10
2018-08-16 14:23:58 +10:00
20993e7e16
Allow tests to run on all JDKs
2018-08-16 14:23:58 +10:00
e07dfffe5f
Migrate tests to new TestHttpServer
2018-08-16 14:23:58 +10:00
63746907e4
Add TestHttpServer
2018-08-16 14:23:58 +10:00
3f2ec7dc48
Move to separate packages
2018-08-16 12:24:27 +10:00
3c1bf569ea
Add reference pretty-printer to muzzle plugin
2018-08-15 10:01:19 -07:00
c351a4825e
Regenerate muzzle bytecode when run multiple times
2018-08-15 09:49:50 -07:00
36ec5d51e5
SafeHasSuperTypeMatcher: handle exceptions when getting class erasure
2018-08-15 09:49:50 -07:00
a7c63b9261
Clarify comment for safe interface iteration.
2018-08-15 09:49:50 -07:00
57e85d4a13
Catch and log instrumentation matcher exception
...
Catching instrumentation matcher exceptions at the Instrumenter level
allows other, unrelated instrumentation to match.
2018-08-15 09:49:50 -07:00
d64b162539
Remove safeMatch from element matcher and document bb cache class
2018-08-15 09:49:50 -07:00
260e3520aa
Fix classloading integration tests
2018-08-15 09:49:50 -07:00
35c6fa2343
More error catching in safe matcher and reduce log level
2018-08-15 09:49:50 -07:00
75a6cee068
Add DDCachingPoolStrategy to reuse type descriptions
2018-08-15 09:49:50 -07:00
f01c8349cc
Deep-merge Reference fields and methods
...
Plus misc cleanup.
2018-08-15 09:49:50 -07:00
e7bb7cfb3e
Remove findLoadedClass
2018-08-15 09:49:50 -07:00
50c5a57c49
Replace UnloadedType with ByteBuddy TypeDescription
2018-08-15 09:49:50 -07:00
937e9a6cef
Add more methods to PatchLogger
2018-08-15 09:49:37 -07:00
27cade057c
Delegate bootstrap resource loading for unloaded types
2018-08-15 09:49:37 -07:00
f8f45d7f14
Muzzle field matching
2018-08-15 09:49:37 -07:00
c4daf007e3
Muzzle method and access matching
2018-08-15 09:49:37 -07:00
4887822eba
Muzzle method ref creation and matching
2018-08-15 09:46:30 -07:00
0f6761dd4b
Optimize Instrumenter logging
2018-08-15 09:46:30 -07:00
55a0abce68
Add notes of potential references to ReferenceCreator
2018-08-15 09:46:30 -07:00
2893eb6035
Merge pull request #435 from DataDog/tyler/jax-rs-improvements
...
Add span for jax-rs representing controller execution
2018-08-15 14:03:31 +10:00
67c0f2fa03
Merge pull request #431 from DataDog/gary/okhttp-log
...
Remove Util Logger and Refactor test
2018-08-14 18:11:59 -04:00
84d38a8270
Merge pull request #439 from DataDog/tyler/method-signatures
...
Cleanup method signatures and servlet 2 instrumentation
2018-08-13 17:29:02 +10:00
f801cbd466
Merge pull request #428 from DataDog/tyler/use-WeakConcurrentMap
...
Use WeakConcurrentMap
2018-08-13 16:44:16 +10:00
dd11429575
Remove unused fields
2018-08-13 16:43:32 +10:00
232708e457
Prevent abstract classes from going through the muzzle plugin.
2018-08-13 15:35:46 +10:00
4583d12b31
Cleanup method signatures and servlet 2 instrumentation
...
adding the abstract servlet instrumentation reduces code duplication and makes it more similar to servlet 3 instrumentation.
2018-08-13 15:14:10 +10:00
44f501fa53
Fix resources directory name in lagom tests
2018-08-11 06:42:53 -07:00
fc8cc47f85
WeakMap improvements
...
* Improve tests to not depend on thread schedulting
* Test all underlying implementations
* Reduce number of static values
2018-08-10 22:16:21 -07:00
6cef9b89b0
Make some things non-static
2018-08-10 15:41:26 +10:00
b220309a68
PR review changes.
2018-08-10 12:23:13 +10:00
984bc7563d
Add span.origin.type for JSP too.
...
Might be slightly redundant given `jsp.requestURL` but consistent with other instrumentation.
2018-08-10 12:14:16 +10:00
d5cc84ea9f
Add span for jax-rs representing controller execution
...
Also add additional `span.origin.type` tags for better visibility.
2018-08-10 10:36:42 +10:00
a3875aff2c
Logging improvements and other misc
...
from reviewing a customer’s logs.
2018-08-09 15:59:59 +10:00
ae9d4619a4
Add instrumentation showing the rendering time
2018-08-09 13:10:45 +10:00
eacc2d6402
Restructure how WeakMap is implemented
...
Use an interface.
Use a provider/supplier to avoid loading more onto the bootstrap classpath.
2018-08-08 16:54:44 +10:00
2041d56de8
use Slf4j annotation.
2018-08-07 18:29:55 -04:00
abffe1779b
Remove Util Logger and Refactor test
...
OKHttp instrumentation will not be using the java util logger, also applies the string representaiton of ip address for IPV4/6 tags. Refactored test.
2018-08-07 18:29:22 -04:00
5e55defeb3
Fix bootstrap classpath.
2018-08-07 17:11:42 +10:00
d05e2cfe86
Add span for spring web controller.
2018-08-07 17:03:07 +10:00
fff3118dec
separate spring web and error instrumentation.
2018-08-07 16:33:51 +10:00
05dc51633a
Update Spring Tests
2018-08-07 16:04:28 +10:00
9b00a27dce
add javadoc and comparison
2018-08-07 12:42:14 +10:00
847484cd47
Use WeakConcurrentMap
...
Instead of `Collections.synchronizedMap(new WeakHashMap<>())`.
2018-08-06 14:14:57 +10:00
e7aa7c52b4
Improve comments and add synchronization.
2018-08-06 11:38:28 +10:00
064ae4c238
Separate span for input and output streams.
2018-08-03 15:41:16 +10:00
911ad5f231
Merge pull request #417 from DataDog/mar-kolya/apache-http-client-fix-exception-handling
...
Apache http client fix exception handling
2018-08-01 14:58:28 -04:00
7ad9305927
Add some integration tests to check ByteBuddy's behavoir on class loading and parsing
2018-08-01 14:17:12 -04:00
50fde4c382
Begin 0.13.0
2018-08-01 13:03:37 +10:00
bb2126bd9a
Improve ByteBuddyElementMatchers javadoc
2018-07-31 20:14:03 -04:00
2bfb7b93ec
Disable Lagom circuit breaker
...
It looks like they fail tests from time to time
2018-07-31 20:14:03 -04:00
78e6a9c336
Get rid of DDAdvice
...
Newer ByteBuddy api simplifies things.
2018-07-31 20:14:03 -04:00
c66bd24d3a
Use `safeHasSuperType` instead of `isSubType`
...
`isSubType` may fail on certain class lookup problems, even on classes
unrelated to given instrumentation, preventing instrumentation from
being applied.
2018-07-31 20:14:03 -04:00
6693a93485
Remove onInstrumentationError from LagomTest
...
We not longer need it since our instrumentation can handle underlying
loading problem.
2018-07-31 20:14:03 -04:00
6bc1d1ab8e
Implement `saveHasSuperType` and use it instead of `hasSuperType`
...
The idea is to just 'trim' type hierarchy 'up-trees' that we cannot
resolve dring instrumentation instead of failing to instrument completely.
2018-07-31 20:13:59 -04:00
deec4a795c
Improve Apache HTTP client
...
Properly open and close outer span in multi-request cases
2018-07-31 20:12:17 -04:00
1ebe4732f8
Stop using `failSafe` matcher
...
It should not be necessary after we jave fixed class location issue
for ByteBuddy
2018-07-31 20:12:17 -04:00
bae79514c0
Fix DDLocationStrategy to use DataDog ClassLoader
...
This allows ByteBuddy to properly find classes injected into the
agent.
Thanks @realark for providing a fix!
2018-07-31 20:12:17 -04:00
4ae9263e1c
Set POOL_ONLY DescriptionStrategy for ByteBuddy
...
This makes sure no classes are loaded during instrumentation
transformation which allows us to safely instrument depndent classes.
2018-07-31 20:12:17 -04:00
b6118f0397
Apache HTTP Client: add test for redirected request
2018-07-31 20:12:17 -04:00
9a6efe69f4
Fix netty dependency and class version checking
2018-07-31 17:42:40 +10:00
b1304b478a
Change http server span type back to `web`
2018-07-31 12:53:50 +10:00
e6da80bb12
datastores
2018-07-31 12:53:50 +10:00
00a2e891b0
http servers
2018-07-31 12:53:50 +10:00
3856e7fd1a
http clients
2018-07-31 12:53:50 +10:00
01d57fb497
elasticsearch
2018-07-31 12:53:50 +10:00
d3ce57d84f
mongo
2018-07-31 12:53:50 +10:00
094552cad3
memcache
2018-07-31 12:53:50 +10:00
2e7899b405
redis
2018-07-31 12:40:47 +10:00
ff9ef671f3
Apply formatter on groovy files.
2018-07-31 12:09:28 +10:00
51919a77bb
Apply formatter on java files.
2018-07-31 12:07:43 +10:00
bc3af56b08
Apply formatter on scala files.
2018-07-31 12:07:30 +10:00
b5c8a8b8fc
Apply formatter on gradle files.
2018-07-31 12:04:00 +10:00
4c88e1a0a8
Merge pull request #392 from DataDog/gary/uint64-id-support
...
Change the internal storage and handling of trace ID, span ID, and pa…
2018-07-30 15:01:10 -04:00
4e60246e17
Merge pull request #405 from DataDog/tyler/servlet-async
...
Refactor servlet instrumentation and disable async on response.
2018-07-30 10:27:54 +10:00
f6edf913b7
Remove functions that do reflection which is not Java10 compliant
...
These functions are not used anylonger
2018-07-27 14:56:28 -04:00
b64be6228c
Don't check for helper classes in muzzle reference check
2018-07-27 11:03:02 -07:00
fadce5c6b3
Merge pull request #400 from DataDog/mar-kolya/java10-support
...
Java10 support
2018-07-27 13:38:39 -04:00
ee594f8567
Use connect operationName in httpurlconnection connect-first case
2018-07-26 15:34:27 -07:00
54485c3296
Don't trace httpurlconnection as a top-level trace
2018-07-26 15:34:27 -07:00
d598515d09
Handle cases where connect() is called first
2018-07-26 15:34:27 -07:00
df95af53a7
Remove getResponseCode() from httpurlconneciton instrumentation
2018-07-26 15:34:27 -07:00
2a35ecb497
Use connected field to determine io status of httpurlconnection
2018-07-26 15:34:27 -07:00
2780ac7ac1
POC sun JDK http urlconnection instrumentation, currently creates one span.
2018-07-26 15:34:27 -07:00
0f80f7dd40
Remove old checks from HelperInjector
...
They are not really producing anything useful anf they depend on API
that is forbidden in Java9+
2018-07-26 10:11:24 -04:00
44b364332a
Remove unused field and method
2018-07-26 10:11:20 -04:00
3f158bb47f
Fix `SpockRunner` BootstrapJar creation under Java9+
2018-07-26 10:01:55 -04:00
8cc2f6cbb2
Skip `jdk.internal.reflect.DelegatingClassLoader` in `ClassLoaderMatcher`
...
This is the same thing as `sun.reflect.DelegatingClassLoader` in older JVMs
2018-07-26 10:01:55 -04:00
6317b21d5c
Fix merge conflicts with service mapping change
2018-07-26 09:16:41 -04:00
1e36343485
Null or empty tags should remove previously set values.
...
Add context to servlet2 test.
Clean up some declared tracers that mess up the classpath.
2018-07-26 12:20:37 +10:00
fb2817a134
Refactor servlet instrumentation and disable async on response.
...
Separate out common advice between instrumentation.
2018-07-25 15:12:55 +10:00
b30ed0dfa0
Merge pull request #404 from DataDog/mar-kolya/fix-kafka-streaming-flaky-test
...
Fix flaky test in kafka streaming
2018-07-25 00:17:01 -04:00
5c1ac58c3f
Fix flaky test in kafka streaming
2018-07-24 23:41:01 -04:00
7b644161d3
Migrate ApacheHttpClientTest to use span assertion api
2018-07-24 23:28:37 -04:00
c98d5ef64b
Increase ElasticSearch timeout in tests
...
Hopefully this would improve build stability
2018-07-24 23:07:18 -04:00
93e70dcef6
Address comments and add test case for extracting non numeric IDs
2018-07-24 14:04:52 -04:00
3d8e76c2a4
Get rid of `WRITER_PHASER`
...
We have alternative way of doing the same thing and `Phaser` seems to be
not very correct way of doing this anyway.
2018-07-24 11:41:48 -04:00
dcbf8d674a
Akka-http-client: handle `singleRquest` throwing an exception
2018-07-24 11:41:48 -04:00
642b862c13
Do not reference `AkkaHttpClientTransformFlow` in instrumentation code
...
to avoid class loader problems
2018-07-24 11:41:48 -04:00
35b980ea89
Fix ElasticSearch config for 2.x client
2018-07-24 11:41:45 -04:00
732bce82d0
Fix typo
2018-07-23 10:04:53 -04:00
7794eacc91
Increase Cassandra request timeout in tests
2018-07-23 10:04:53 -04:00
b4b99d991c
Move AkkaHttpServerInstrumentation into Scala compilation
...
This is a hack to work around the problem of `auto-service` annotation
processing creating files with same name in `java` and `scala`
directories. This results in Jar having two files with the same name
instead of one concatenated file.
2018-07-23 10:04:53 -04:00
68ce09b461
Add missing Scala classes to list in injection classes
2018-07-23 10:04:53 -04:00
fd5d80ba86
Make muzzle plugin apply to Scala code
2018-07-23 10:04:53 -04:00
161847752f
Pass Span instead of Scope
2018-07-23 10:04:53 -04:00
5e67e6e5ba
Migrate to new instrumentation API
2018-07-23 10:04:53 -04:00
277e7a1a3c
Typo fix
2018-07-23 10:04:53 -04:00
db895f2e34
Remove redundant plugin from akka gradle file
2018-07-23 10:04:53 -04:00
ae37ca4b02
Add akka-http-client instrumentation: superPool
2018-07-23 10:04:53 -04:00
2b25de966a
Add akka-http-client instrumentation
...
This is a very-very first pass: instrument single request
2018-07-23 10:04:53 -04:00
6932d581ed
Add some helpful messages to AgentTestRunner assertions
2018-07-23 10:04:53 -04:00
f9f135cbd6
Do not run Spymemcached tests locally under Java7
...
since it requires external Memcached container running because
testcontainers doesn't work on Java7.
2018-07-23 10:04:53 -04:00
c844501bc5
Fixes for some minor checkstyle complaints
2018-07-23 10:04:53 -04:00
ce7866d018
Use `io.opentracing.log.Fields.*` instead of hardcoded strings
2018-07-23 10:04:53 -04:00
d4d770fe42
Pull out ratpack helper into seprate class to avoid copy-paste
2018-07-23 10:04:53 -04:00
a882a5439c
OkHttp instumentation: simplify error case
2018-07-23 10:04:53 -04:00
9d2755be17
Fix Google Java Formater violations
...
Some changes landed on master that do not comply with new formatter rules
2018-07-23 13:43:29 +10:00
4283e3acb1
Merge pull request #396 from DataDog/mar-kolya/test-http-client-timeout-increase
...
Increase build stability by increasing some http client timeouts
2018-07-22 21:35:32 -04:00
9988c8775f
Merge pull request #388 from DataDog/tyler/grpc
...
Instrument gRPC 1.5.0+
2018-07-23 11:19:48 +10:00
564b4e9dc3
Increase build stability by increasing some http client timeouts
...
This makes build more resilient to slow boxes and high parallelism
2018-07-22 00:41:37 -04:00
f1466304e8
Move random port generation to actual usage in tests using listening ports
2018-07-20 11:57:37 -04:00
c3825d9d52
Improve tmp dir handling in ES tests
...
Also make sure ES ports are allocated right before ES is started
2018-07-20 11:53:33 -04:00
a34f7b849b
Instrument gRPC
...
Adds spans for the duration of the connection and child spans for each message.
Also propagates the trace using the metadata object.
2018-07-20 12:25:04 +10:00
aa3fc0717e
Fix some formatting changes.
2018-07-20 10:31:14 +10:00
7c62e10542
Do not use advice class names in Lettuce instrumentation directly
...
Since this leads to Java8 code loaded into Java7 JVM in tests.
Insted reference class names by string.
2018-07-19 10:45:21 -04:00
12a2fce96d
Upgrade java formatter version.
2018-07-19 14:10:53 +10:00
46428dc6a3
Enable Lettuce instrumentation by default
2018-07-18 18:45:46 -07:00
23d0439b12
Remove muzzle dead code, doc cleanup, and better logging
2018-07-13 16:24:01 -07:00
2925df8de5
Clean up and document
2018-07-10 17:26:49 -04:00
8e182edc03
Replace BIPUSH with LDC to prevent overflow
2018-07-10 17:26:49 -04:00
33ec3f0304
Add missing ratpack helper
2018-07-10 17:26:49 -04:00
6faf63d6d8
Add missing memcached helper
2018-07-10 17:26:49 -04:00
ce73c403bf
Elasticsearch5 helpers
2018-07-10 17:26:49 -04:00
628f4929dc
Muzzle Assertions and gradle plugin
2018-07-10 17:26:49 -04:00
541a6998a4
Hook up muzzle to Instrumenter.Default's matcher
2018-07-10 17:26:49 -04:00
d61f65f4ff
Muzzle outline in Instrumenter.Default
2018-07-10 17:26:49 -04:00
836f49205b
TraceConfigInstrumentation implements Instrumenter directly
2018-07-10 17:26:49 -04:00
bfc49e869e
Make connections always close on test case completion.
2018-07-09 17:55:52 -04:00
6bd7cf0675
Fixes #379 .
...
Connection pools were creating proxy connection objects, so the proxy objects were cached. By unwrapping the proxies, the connection objects will be correctly cached and identified.
Refactored tests to use connection pools, and hsqldb connections only on statements (since they will not make a USER() query in a getMetaData call).
2018-07-09 17:55:52 -04:00
02a3e6a5d3
New Instrumentation API
2018-07-06 17:17:32 -04:00
33a139cdcb
New Instrumentation outline
2018-06-28 14:54:14 -07:00
f8e3ac3097
New instrumentation api outline
2018-06-28 14:54:14 -07:00
0360bd01ee
Merge pull request #378 from DataDog/ark/cassandra-fix
...
Remove most shadow relocates
2018-06-27 11:56:33 -07:00
3894f829bb
Remove most shadow relocates
...
Shadow relocates are no longer needed because of our new bootstrapping
process.
It's no longer possible for agent dependencies to interfere with the
user's classpath.
The immediate reason for this change is a bug created in the Cassandra
instrumentation.
The Cassandra instrumentation references guava transitive deps from
the datastax driver. These references are re-written by shadow,
causing the instrumentation to reference 'datadog.agent.deps.google.*'
instead of the guava class.
2018-06-27 09:35:54 -07:00
cc7bb7943f
Merge pull request #354 from DataDog/gary/jsp-integration-branch
...
Generic JSP instrumentation with Tomcat Jasper compilation instrumentation.
2018-06-26 18:35:09 -04:00
8d6392fa94
Remove timeouts from lagom tests
...
It looks like server is started lazily and on laptop it may take over
5 seconds in parallel build. This means in may take long time on CI as
well.
It is in fact unikely that server will never return so adding timeout
introduces flakiness and doesn't really protect from any real-life
problems. Instead of hardcoding timeouts just rely on build eventually
giving up on its own one way or another.
2018-06-26 15:48:04 -04:00
44b63ea5ca
Rename AkkaHttpInstrumentation to AkkaHttpServerInstrumentation
...
To be able to put client instrumentation in more consistent way
2018-06-26 15:41:59 -04:00
3ac866b0f9
Merge pull request #371 from DataDog/tyler/servlet-user
...
Set servlet’s user-principal as a tag when available
2018-06-26 13:41:13 -04:00
15c0f9a6b2
Akka-http-server renames
2018-06-26 09:55:32 -07:00
a0d99e70fb
Add tests to servlet intrumentation to verify that username is set correctly
2018-06-25 21:54:20 -04:00
46e7036701
fix version scan and test versions
2018-06-25 16:54:45 -04:00
9899256381
Set servlet’s user-principal as a tag when available
2018-06-25 11:24:35 +10:00
eddb48f3e2
refactored tests, added parent-children relationship between spans in tests. Still need to figure out version scan and versions to support.
2018-06-22 18:24:06 -04:00
e90bcf624a
add unit tests for jsp rendering (servicing requests), change to instrument generic jsp level rendering.
2018-06-22 18:24:06 -04:00
b1d06299cc
JSP instrumentation
...
WIP: more unit tests to come
2018-06-22 18:24:06 -04:00
7405b7711b
Merge pull request #369 from DataDog/mar-kolya/increase-timeouts-in-url-connection-test
...
Increase timeouts in UrlConnection test
2018-06-22 17:17:04 -04:00
60a0722390
Increase timeouts in UrlConnection test
...
Before those timeouts where set to 10ms which legitimatelly can come
before server (even localhost) has a chance to reply with 'connection
refused'.
This should fix flaky test.
2018-06-22 16:57:31 -04:00
1fbb33d182
More fixes to Lettuce tests
...
Lettuce intrumentatio is implemented in a way that after operation has
been performed `span` is not closed syncronously - in fact this happens
on separate thread. This means `spans` for even syncronous operations
may be closed on opposite order.
This means that writing tests that pefrom two operations and expect
two traces is slightly more complicated. In many places we can just
avoid doing that by preparing necessary data in `setup`.
This fixes some of the false negatives in tests.
2018-06-22 16:44:58 -04:00
770f77a7ff
Merge pull request #367 from DataDog/mar-kolya/reduce-number-of-compile-workers
...
Reduce number of gradle workers during compile
2018-06-22 16:07:46 -04:00
8a666784a6
Close Jetty Handler scope
2018-06-22 11:53:39 -07:00
7882e4fe23
Make ES tests more deterministic by using listener pool with 1 thread
...
This should reduce number of false negatives in ES tests
2018-06-22 14:23:06 -04:00
c050b4acd8
Merge pull request #366 from DataDog/mar-kolya/fixes-for-lettuce-tests
...
Fix some flakiness in Lettuce tests
2018-06-22 11:01:30 -04:00
389f65687a
Fix some flakiness in Lettuce tests
...
It looks like automatic reconnection was enabled which lead to random
traces popping up in random places when Redis server was shutdown.
Also make sure that server persists only during single test to weedout
all inter-test dependencies.
2018-06-21 17:44:19 -04:00
79d7b9c062
JMS1/2: change resource names according to PR comments
2018-06-21 14:10:50 -04:00
37fdbf9188
JMS2: Fix `receiveNoWait` instrumentation and instrument `receive(timeout)`
2018-06-21 13:28:19 -04:00
3be5a78a53
JMS1: make resouce names more descriptive
2018-06-21 13:28:19 -04:00
fe118adc6e
JMS1: Fix `receiveNoWait` instrumentation and instrument `receive(timeout)`
2018-06-21 13:28:19 -04:00
bb4026234d
Refactor JMS1 integration tests
2018-06-21 13:28:19 -04:00
beb91446c7
Increase Cassandra embedded server start up timeout
...
To try to make tests less prone to false positives.
2018-06-21 12:00:26 -04:00
83db4e8c4d
Merge pull request #352 from DataDog/tyler/netty
...
Netty HTTP client and server instrumentation
2018-06-21 14:11:12 +10:00
9cc99bafbf
Simplify Jacoco configuration
2018-06-20 17:13:30 -04:00
e070a9be4a
Fix jacoco excluded classes concatenation
2018-06-20 17:05:16 -04:00
71a991fcaa
Update jacoco exclusions to exclude things not hit during test runs
2018-06-20 17:01:01 -04:00
da5cd0724b
Merge pull request #362 from DataDog/mar-kolya/enable-coverage-in-CI
...
Enable coverage checks in CI for java8
2018-06-20 15:15:49 -04:00
21d58768cb
Lettuce: properly close connection instead of letting it being GCed
2018-06-19 22:41:58 -04:00
46b9cd35b9
Merge pull request #350 from DataDog/ark/lagom
...
akka-http instrumentation and lagom tests
2018-06-19 15:17:09 -07:00
b0c2ab9b68
Lettuce: wait for trace after setup code
...
Otherwise that trace may land at some random point in time after and
cause flaky tests.
2018-06-19 15:15:29 -04:00
519f15bcc6
Merge pull request #357 from DataDog/ark/servlet-async
...
Close scope for async servlet requests
2018-06-17 23:44:24 -07:00
c0da1f7093
Add version scan.
2018-06-18 12:52:42 +10:00
43e31eae80
Separate out instrumentation for netty 4.0 from 4.1
2018-06-18 12:52:42 +10:00
9b3df4ff9e
Netty HTTP client and server instrumentation first pass
...
Doesn’t target right versions. Needs lots of testing.
2018-06-18 12:52:42 +10:00
93281f775a
Clean up akkahttp-server/lagom tests
2018-06-15 14:30:23 -07:00
2cfd7bf911
Allow Unit tests to skip expected instrumentation errors.
2018-06-15 13:25:41 -07:00
7ac2bdfc22
Add akka-http to play 2.6 tests
2018-06-15 12:48:57 -07:00
5a77ac3749
akka-http sync and async tests
2018-06-15 12:48:57 -07:00
6b7dda3657
Instrument akka-http function handler instead of akka-streams
2018-06-15 12:48:57 -07:00
004b88f634
Initial Lagom Test
2018-06-15 12:48:57 -07:00
109f2cead4
Akka-http instrumentation and test
2018-06-15 12:48:57 -07:00
d278cd48a7
Merge pull request #359 from DataDog/mar-kolya/spymemcached-instrumentation
...
Make spymemcached disabled by default
2018-06-15 15:29:52 -04:00
0e62ee8ec6
Make spymemcached instrumentation disabled by default
2018-06-15 14:25:51 -04:00
f9cc33c7c8
Merge pull request #353 from DataDog/mar-kolya/spymemcached-instrumentation
...
Mar kolya/spymemcached instrumentation
2018-06-15 12:44:42 -04:00
6cd8be67d5
Close scope for async servlet requests
2018-06-14 20:23:54 -07:00
f28445c45f
CorrelationIdentifier for MDC frameworks.
2018-06-14 15:33:15 -07:00
1e4c88ffcb
Merge branch 'master' into mar-kolya/spymemcached-instrumentation
2018-06-14 15:38:01 -04:00
dd8f5ced07
Spymemcached: be slightly mode defensive in instumentation
2018-06-14 13:37:35 -04:00
ba37ccc552
Spymemcached: use cache span type
2018-06-14 13:37:35 -04:00
940633b388
Spymemcached: Make abstract method in CompletionListener
2018-06-14 13:37:31 -04:00
2c9f8a2b71
Fix ES rest client latest dep tests by forcing 6.2.+ since our instrumentation doesnt work properly with 6.3.+
2018-06-14 10:31:45 -04:00
30695555f9
Spymemcached: remove unnecessary unboxing and minor cleanup
2018-06-13 22:43:36 -04:00
dafd52cb7a
Spymemcached: add instumentation
2018-06-13 22:38:18 -04:00
ff56389a56
Upgrade some versions.
2018-06-14 11:56:56 +10:00
63c4cdff87
Memcached testing: add support for testoingcontainers
2018-06-13 13:06:23 -04:00
adbab8692c
Merge pull request #336 from DataDog/gary/lettuce-integration-branch
...
lettuce 5 redis client integration
2018-06-13 09:18:01 -04:00
0fa972ec77
Merge branch 'master' into mar-kolya/slick-instrumentation
2018-06-09 00:06:17 -04:00
429ee40f81
add workaround to avoid certain commands from crashing the trace agent.
2018-06-08 23:53:13 -04:00
fdc56c0e13
change the way classes are loaded so that classLoaderHasClasses would still work for the classes that are being instrumented and being matched at the same time.
2018-06-08 23:53:13 -04:00
42b586badf
remove recording of redis command arguments for now to avoid leaking sensitive data
2018-06-08 23:53:13 -04:00
0bc9d9c08d
remove string constants in advice class and comment fixes
2018-06-08 23:53:13 -04:00
b694ecdf79
add version scan and rename instrumentation classes
2018-06-08 23:53:13 -04:00
3d61d839c8
make commands with no return values (void or Mono<Void>) to finish spans early in order to record command ran.
...
added support for cancellation of commands in async and reactive APIs.
since flux is a stream of events, when the stream is complete, the number of events emitted are recorded in the tag db.command.results.count
created helper class LettuceInstrumentationUtil
2018-06-08 23:53:13 -04:00
bfdf4c858a
lettuce reactive api for mono publishers completed.
2018-06-08 23:53:13 -04:00
989a259ec2
Fix code with suggestions from Tyler regarding previous commit.
...
no longer includes the command argument if the redis command being called is AUTH since it contains sensitive information.
2018-06-08 23:53:13 -04:00
ae1d9d7c52
complete async unit test and changes to implementation
...
using handleAsync with BiFunction because lettuce futures almost never throw exceptions on futures
improvement changes to come
2018-06-08 23:53:13 -04:00
1213311418
lettuce redis client sync and async api instrumentation with sync unit tests complete
2018-06-08 23:53:13 -04:00
c475ac688c
Add additional Elasticsearch tests for Spring Data.
2018-06-09 10:59:08 +10:00
206de0fb54
Add some more missing helper classes
2018-06-09 10:59:08 +10:00
c2771753b7
Suggested changes.
2018-06-08 16:38:51 +10:00
28c7c30af4
[HttpUrlConnection] Fix HEAD responses
...
Explain to ratpack that sending body for HEAD requests is not up to
spec [1] and seems to be confusing to clients. This resolves 'Keep-Alive'
mistery and makes disabling 'keepa-live' unnecessary.
[1] https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html
2018-06-07 12:24:16 -04:00
9ff09b93e1
Refactor HttpUrlConnection Instrumentation
...
getOutputStream shouldn’t call getResponseCode, otherwise the request gets screwed up.
2018-06-07 16:25:38 +10:00
93a41b5064
Fix some typos
2018-06-06 20:47:49 -04:00
7a280d7e13
Fix some code formatting
2018-06-06 17:11:17 -04:00
ca6fabfd64
Move code from `WrapAdviceUtils` to `DatadogWrapper`
2018-06-06 16:42:23 -04:00
5f82776fc5
Use assertTraces api in slick tests
2018-06-06 16:41:03 -04:00
30d640e7ee
Provide way to use CLosure to assert tags values
2018-06-06 16:40:34 -04:00
b1bc24dd67
Raname function in TraceAssert to match actual action
2018-06-06 16:40:12 -04:00
d6aaee1bee
Check for java concurrent classes prefixes match only if class was not whitelisted already
2018-06-06 15:51:30 -04:00
bbcc2882ab
Use test set instead of submodule for Slick tests
2018-06-06 15:49:39 -04:00
2e5007fbd8
Fix function name in TagsAssert
2018-06-06 10:43:23 -04:00
f92af7d860
Fix Scala Slick instrumentation
2018-06-06 10:43:23 -04:00
b8fdb4acd5
Added Scala Slick test that fails due to executor wrapping problems
2018-06-06 10:43:19 -04:00
3187f7350f
Simplify Calldepththreadlocalmap to not use atomic integers
2018-06-06 09:31:25 -04:00
d235618a6e
Add instrumentation for Java’s UrlConnection
...
For HttpUrlConnection, trace propagation headers are added to the outgoing request.
Due to the awkward design of the API, the ability to instrument in a natural way was limited, thus the main points instrumented are the get{Input,Output}Stream methods.
2018-06-06 09:12:48 +10:00
979aa7838f
Clear TEST_WRITER before waiting to ensure accurate timing
...
Otherwise the waitForTraces at the end might be triggered prematurely.
2018-06-05 14:49:17 +10:00
5fe58dc344
Merge pull request #338 from DataDog/tyler/es-meta
...
Add additional metadata to ES client calls.
2018-05-30 11:58:41 +10:00
682fb01350
Wait for initial traces before starting tests
...
to ensure a late reported trace doesn’t mess up the test assertions.
2018-05-30 11:40:31 +10:00
b58a7db7a7
Add another helper used by Joiner.
2018-05-30 10:31:00 +10:00
b5346e89a3
Begin 0.10.0
2018-05-29 18:41:37 +10:00
cda86ca4ea
Wait for cluster to be ready before starting test.
2018-05-29 15:40:05 +10:00
f9ab729f92
Forgot to inject the helpers.
2018-05-25 20:27:57 +10:00
de74eb1938
Add additional metadata to ES client calls.
2018-05-25 13:58:44 +10:00
c03e894870
Merge pull request #329 from DataDog/tyler/elasticsearch-client
...
Elasticsearch Client Instrumentation
2018-05-24 09:03:20 +10:00
d9dce43728
Merge pull request #332 from DataDog/ark/playtime
...
Enable Play, Hystrix, and JaxRS Client Instrumentation
2018-05-22 18:56:00 -07:00
ec9ce10ca1
Limit version compatibility.
2018-05-23 11:29:13 +10:00
0cf8fef8d8
Elasticsearch Instrumentation
2018-05-23 11:29:13 +10:00
164689eeb3
Merge pull request #333 from DataDog/tyler/force-latest-tests
...
Fix version upgrading for latestDepTests
2018-05-23 11:21:28 +10:00
d90de5741f
Enable JaxRS Instrumentation
2018-05-22 18:02:30 -07:00
066aac761c
Enable Hystrix
2018-05-22 18:01:43 -07:00
c11de3003d
Enable Play Instrumentation
2018-05-22 15:29:46 -07:00
ce0ef409d8
Merge pull request #330 from DataDog/tyler/aws-versions
...
Fix AWS version ranges
2018-05-23 07:30:16 +10:00
03392f2138
Merge pull request #331 from DataDog/tyler/move-apache-httpclient-tests
...
Move Apache HttpClient tests to instrumentation
2018-05-23 07:28:04 +10:00
176b071300
Merge pull request #324 from DataDog/ark/default_service_name
...
Remove unknown feature-flag and use generic names as fallback
2018-05-22 14:19:50 -07:00
c7a5bdcdbb
Remove unknown feature-flag and use generic names as fallback
2018-05-22 14:01:08 -07:00
5d6fe43dc6
TestHttpServer is no longer used
...
Move the java version ignores.
2018-05-22 17:12:54 +10:00
e481092f25
Avoid occasional false test failure.
2018-05-22 16:47:36 +10:00
a3a1b08fa9
Fix AWS version ranges
2018-05-22 16:45:01 +10:00
3781a71e5f
Fix version upgrading for latestDepTests
2018-05-22 15:14:11 +10:00
b7570c7152
Merge pull request #319 from DataDog/ark/muzzle-integration-branch
...
muzzle integration branch
2018-05-21 11:32:00 -07:00
217dd411de
Disable muzzle
2018-05-21 10:58:30 -07:00
1641c54448
Skip instrumenting slick thread pool
2018-05-18 11:17:27 -07:00
0bd7a62464
Flags, Fields, Methods, and builder logic for References
2018-05-18 10:45:05 -07:00
bf70b3031b
Cache classloaders for reference checking
2018-05-18 10:45:05 -07:00
ad7f6a5e71
Generate at compile-time and lazy-load reference matchers
2018-05-18 10:45:05 -07:00
98b44c1dfb
Remove ReplaceIsSafeVisitor
2018-05-18 10:45:05 -07:00
08df3cef35
Use bytebuddy plugin to add safety checks to instrumentation
2018-05-18 10:45:05 -07:00
024d414844
Move Apache HttpClient tests to instrumentation
...
And add latest test.
2018-05-18 12:01:12 +10:00
71396aee01
Moved JDBC integration tests to become unit tests
2018-05-15 16:37:55 -04:00
38dfe96eb0
Fixed java 9 JDBC integration test issue.
...
Refactored JDBCMaps's getDBInfo utlity function because JDBCMaps is in the bootstrap classloader, and the use of java.sql.* packages in getDBInfo is failing because java.sql.* packages are part of the platform classloader in java 9.
2018-05-15 16:18:55 -04:00
4b71a21487
Fixed unknown database issue from JDBC Connection constructor exception
...
Client will now report correct database if JDBC connection is recovered from exception.
2018-05-15 16:18:55 -04:00
b154f8366c
Begin 0.8.1
2018-05-15 12:27:02 +10:00
dc814aeb6d
Fix tests.
2018-05-11 15:19:30 +10:00
46878d24d3
Name service based on servlet context
...
This only applies if a service name hasn’t been set or is empty.
This is particularly useful for environments that deploy multiple war files to the same app server.
2018-05-11 13:59:03 +10:00
632d9b8da4
Merge pull request #316 from DataDog/tyler/async-flag
...
Enable async tracking for some non-async frameworks
2018-05-11 09:30:17 +10:00
d5d24c50c7
Replace @Unroll’s with a rule to always unroll.
2018-05-10 15:24:59 +10:00
9e5e48b96e
Add a feature flag to gate the name change
2018-05-10 10:54:15 +10:00
b9db79e251
Enable async tracking for some non-async frameworks
...
This will allow tracing of additional work being done inside the servlet context.
2018-05-09 10:40:50 +10:00
5e6259233e
Remove some other unknowns.
2018-05-08 16:29:55 +10:00
bae79a0c3a
Rename unknown to database to reduce confusion
2018-05-08 16:16:02 +10:00
9606dd3467
Fix TraceConfig tests
2018-05-08 11:00:59 +10:00
2dd36c2b79
Give more distinct names and migrate test style
2018-05-08 10:03:22 +10:00
c81615b255
Allow configuration of additional trace annotations
...
List can be set to empty if needed.
2018-05-07 13:27:23 +10:00
441bf59e80
Add tracing for other annotations and config
...
Allows for specifying additional traced methods via env var or sys prop config.
2018-05-07 13:27:23 +10:00
c1ac920e97
Change from enum to object for map lookup key
2018-05-07 13:25:08 +10:00
122c482dd5
Queue should block.
2018-05-07 13:23:29 +10:00
9a52303376
Apply jacoco to every java project
...
Some projects have ignores/whitelists, but generally coverage is pretty high.
AFAIK, this doesn’t really capture instrumentation test coverage though.
2018-05-04 16:23:32 +10:00
7dfdc2d50e
Missing autoservice annotation processor
2018-05-04 15:38:41 +10:00
114f088766
Fix TLS usage
2018-05-04 14:05:06 +10:00
f35e2e6ebe
Remove various warnings and other cleanup
...
Also upgrade some plugins.
2018-05-04 14:05:06 +10:00
7c4d42ef8a
Add additional test task for testing latest versions of a dependency
2018-05-04 14:04:30 +10:00
660dfc834c
It actually isn’t compatable until 1.4
2018-05-04 14:03:48 +10:00
2561e72824
Do we do want to ignore proxies?
...
If so, we have to change the test to be compatible.
2018-05-04 14:03:48 +10:00
be34eaf032
Instrument HystrixCommand and HystrixThreadPool
2018-05-04 14:03:48 +10:00
6baf09588e
Merge pull request #302 from DataDog/tyler/jdbc-depth
...
Prevent JDBC spans from nesting
2018-05-04 08:07:28 +10:00
30b70d8939
Prevent case where call depth might never be reset
2018-05-03 14:53:33 +10:00
732f0f2185
Merge pull request #299 from DataDog/tyler/aws-naming
...
Use different resource naming for aws spans
2018-05-03 13:59:09 +10:00
82353ad7d1
Use different resource naming for aws spans
...
Uses the pattern of `service.operation`, so for an S3 get object request, the resource name would be `S3.GetObject`.
2018-05-03 13:38:16 +10:00
84b7080860
Fix AgentInstaller ignores and @Trace naming
2018-05-03 13:03:53 +10:00
0f77ccd797
Merge pull request #297 from DataDog/tyler/kafka
...
Add null check to kafka
2018-05-02 08:06:37 +10:00
6f64b0e021
Prevent JDBC spans from nesting
2018-05-01 11:18:53 +10:00
3c7d4f5b13
Enable executor instrumentation by default
...
Executor instrumentation does not need to be turned off by default
because the instrumentation will not apply unless the TraceScope is
activated.
2018-04-30 17:27:51 -07:00
63d308e50d
Misc cleanup/minor changes
2018-05-01 10:24:14 +10:00
21e26d9463
Merge pull request #301 from jonmort/ratpack-instrumentation-exceptions
...
Fix NoClassDefFound errors for ratpack
2018-05-01 09:57:16 +10:00
a34d8f7876
Merge pull request #293 from DataDog/tyler/upgrade
...
Upgrade Byte-buddy to 1.8.8
2018-04-30 15:42:21 -07:00
c1a7f58aaf
Fix NoClassDefFound errors for ratpack
2018-04-30 15:24:42 +01:00
8abbccc09c
Upgrade shadow plugin version.
2018-04-30 16:18:48 +10:00
cd289308bb
Remove timeouts.
...
Not helping as much as was hoped. Causing extra noise in CI.
2018-04-30 11:10:18 +10:00
e6179f6555
Use hardcoded operation names for integrations
...
Backend has issues with variable operation names.
Also reduce dependencies on OT-contribs.
2018-04-27 12:37:19 +10:00
353bc1be07
Merge pull request #294 from DataDog/ark/fix_jax
...
Inject jax InjectAdapter helper class.
2018-04-26 14:39:15 -07:00
5f19a56683
Inject jax InjectAdapter helper class.
2018-04-26 09:52:45 -07:00
57eade612f
Upgrade Byte-buddy to 1.8.8
...
Also remove some erronously checked in files.
2018-04-26 22:53:45 +10:00
3db2d654f1
Fix spark instrumentation
...
and rebase off master.
2018-04-26 17:01:45 +10:00
de350c7c4f
fix: attempt to enable instrumentations
2018-04-26 14:53:32 +10:00
bb5c413be1
fix: create a test to verify that spark is indeed responding
2018-04-26 14:53:32 +10:00
ede4620b52
feat: get tests running, although failing due to instrumentation not being loaded properly
2018-04-26 14:53:32 +10:00
7e233ac3c7
feat: find oldest supported spark, update version, make tests run
2018-04-26 14:53:32 +10:00
8b289c7036
fix: add versionScan for sparkjava
2018-04-26 14:53:32 +10:00
d0822c7458
fix: support jetty 8+, sparkjava 2.5+
2018-04-26 14:53:32 +10:00
8bfeae4a82
fix: formatting and add version to spark java instrumentation
2018-04-26 14:53:32 +10:00
593a9b71ad
fix: use google java format
2018-04-26 14:53:32 +10:00
79f1226867
fix: use correct jetty version
2018-04-26 14:53:32 +10:00
c49d4f6dd8
fix: add jetty handler instrumentaiton. remove filter3instrumentation. add sparkjava routematch instrumentation
2018-04-26 14:53:32 +10:00
6c4b90965c
fix: support java 7 in test
2018-04-26 14:53:32 +10:00
Andrew Kent
Tyler Benson
Tyler Benson
Nikolay Martynov
Ark
Gary Huang
Gary Huang
Gary Huang
Andrew Kent
Gary Huang
Tyler Benson
Jon Mort
Jørgen Grøndal