f181fa721f
Add classloader matcher to muzzle scan
2019-12-20 16:17:08 -05:00
97b947919f
Add a comment
2019-12-20 15:27:32 -05:00
7338bbdd06
Register on JAX-RS client instead of builder
2019-12-20 13:15:04 -05:00
3f21f6419d
[rmi] Split context propagation to server and client instrumentation
...
+ Separate extra code from advices
+ cleanup helper definitions
2019-12-20 16:16:53 +01:00
c3308042d3
[rmi] use ObjectEndpoint#toString() to avoid need for reflection to be able to compare object identifiers.
2019-12-20 12:10:35 +01:00
32db01200c
Merge pull request #1131 from fujigon/feature/debugging
...
apply comma split logic to servlet request extract adapter
2019-12-19 09:06:12 -08:00
bb05700806
[rmi] Improve connection overhead and add additional metadata
...
- Cache response per connection to ensure as little communication overhead as possible is needed
- change context payload serialization to use plain hashmap
+ add more logging
- only set parent context on root entry point
+ use decorator to create spans
- Use Instrumentation context to avoid reflection
- separate integration parts into packages
2019-12-19 17:21:16 +01:00
832605a01a
[rmi] Add distributed context propagation
...
The flow for context propagation is as follows.
* <p>We inject into StreamRemoteCall constructor used for invoking remote tasks and performs a
* backwards compatible check to ensure if the other side is prepared to receive context propagation
* messages then if successful sends a context propagation message
*
* <p>Context propagation consist of a Serialized HashMap with all data set by usual context
* injection, which includes things like sampling priority, trace and parent id
*
* <p>As well as optional baggage items
*
* <p>On the other side of the communication a special Dispatcher is created when a message with
* DD_CONTEXT_CALL_ID is received.
*
* <p>If the server is not instrumented first call will gracefully fail just like any other unknown
* call. With small caveat that this first call needs to *not* have any parameters, since those will
* not be read from connection and instead will be interpreted as another remote instruction, but
* that instruction will essentially be garbage data and will cause the parsing loop to throw exception
* and shutdown the connection which we do not want
2019-12-19 17:21:07 +01:00
0ee80a0b95
[rmi] Instrumentation for RMI 1.2 and later
...
includes instrumentation of client and server endpoints
currently missing passing of execution context from client to server
2019-12-19 17:20:50 +01:00
fb8f7af342
Merge pull request #1149 from DataDog/tyler/jdk-muzzle
...
Add option for muzzle validation on the specific JDK version
2019-12-19 08:14:54 -08:00
b707a3aab9
move multi-value aware logic to Extractor.
2019-12-19 13:33:08 +09:00
0f3125498c
add test case
2019-12-19 13:33:03 +09:00
a5e693bb92
assert fix same as JettyServlet3Test
2019-12-19 13:32:09 +09:00
dc0cbeb95d
apply comma split logic to servlet request extract adapter
2019-12-19 13:32:09 +09:00
31b77cbd7b
Capture error message even if no exception object provided.
...
This is currently only used by the GoogleHttpClient instrumentation, but may be used by customers too.
2019-12-18 13:49:24 -08:00
ded28674d3
Add option for muzzle validation on the specific JDK version
...
This is still useful to validate various aspects of the integrations even if it doesn't need to check against maven.
2019-12-18 13:40:19 -08:00
7095ea3426
Add async propagation flags for kafka consumer.
2019-12-18 10:40:54 -08:00
96edbe8b8a
Add better exception handling in Agent initialization
...
An invalid statsd hostname causes an exception for jmxfetch. This should be an error, but not prevent the app from starting.
Also improved log variable name consistency.
2019-12-17 14:15:42 -08:00
99992df998
Fix tagging query string for additional servers
...
Add test to common test suite and adapt each test.
2019-12-17 09:33:27 -08:00
a2b86e6b96
Pin kafka latestDepTest version to 2.3.x
...
2.4.0 introduces test failures:
```
Caused by: java.lang.NoClassDefFoundError: org.I0Itec.zkclient.ZkClient
```
when executing `compileLatestDepTestGroovy`.
2019-12-16 08:51:30 -08:00
839de614a5
Merge pull request #1136 from DataDog/tyler/tag-query
...
Capture full servlet URL in decorator
2019-12-12 15:16:38 -08:00
86c3e80121
End Play 2.6 muzzle at 2.8 because its breaking
2019-12-12 17:47:21 -05:00
b00cdee54a
Capture full servlet URL in decorator
...
This is needed in order to tag the query string (when configured).
Full test suite will follow in future PR.
2019-12-12 13:47:40 -08:00
cf3f04f509
Merge pull request #1129 from DataDog/brian.devinssuresh/jedis-3.0
...
Add support for jedis 3.0+
2019-12-11 11:22:16 -05:00
8cae56219b
Adding some implementation comments
2019-12-10 18:28:21 -05:00
f836f8976a
Combine onControllerStart and onAbort
2019-12-10 18:07:26 -05:00
73062199b0
Move constants to decorator
2019-12-10 14:00:31 -05:00
5d2d19af75
Rename class since they instrument the context
2019-12-10 14:00:31 -05:00
54ba905224
Add a Resteasy 3.1 test set
2019-12-10 14:00:31 -05:00
498d2bd461
Add ContextRequestFilter instrumentation to JAX-RS
2019-12-10 14:00:31 -05:00
307e56714e
Merge pull request #1133 from DataDog/tyler/move-dropwizard-tests
...
Move dropwizard tests to dropwizard project
2019-12-10 10:51:42 -08:00
55fe3ba228
Move dropwizard tests to dropwizard project
...
This separate directory helps to avoid conflicts with JerseyTest.
ResourceTestRule usage in JerseyTest was causing some odd interactions which resulted in traces not being reported.
2019-12-10 10:08:04 -08:00
7717dbf5d8
Merge pull request #1115 from trask/fix-sporadic-test-failure
...
Fix sporadic test failure in Elasticsearch53SpringRepositoryTest
2019-12-10 12:58:25 -05:00
fa14af40c3
Fix muzzle issue with async instrumentation
2019-12-06 18:18:34 -05:00
c7329e4b6b
Work around muzzle feature missing
2019-12-06 14:12:46 -05:00
d2db6b6fd9
Merge pull request #1098 from DataDog/tyler/jax-rs-annotation-inheritance
...
Support JAX-RS Annotation Inheritance
2019-12-06 13:49:46 -05:00
c72f2d3b45
Fix muzzle test for 3.0
2019-12-06 13:45:05 -05:00
73eb217721
Make matchers more strict
2019-12-05 17:02:39 -05:00
2e5aff391d
Use random ports for embedded redis
2019-12-05 16:23:22 -05:00
00fb29f528
Some clean up
2019-12-05 15:59:12 -05:00
7b92c40cbc
Add support for jedis 3.0+
2019-12-05 15:09:58 -05:00
42ac5fc024
Remove synchronization and static helper map
2019-12-04 15:43:28 -05:00
57c3ec196f
Merge pull request #1104 from trask/normalize-tag-verification
...
Normalize tag verification
2019-12-02 10:58:03 -08:00
ae0eb52cd7
Fix sporadic test failure
2019-11-27 10:31:59 -08:00
847a76cb04
Add missing tag verification
2019-11-22 10:59:47 -08:00
1987e86ebf
Normalize tag verification order
2019-11-22 10:59:45 -08:00
2d87882724
Merge pull request #1112 from DataDog/dougqh/jmxfetch-config-resource-leak
...
Closing metricconfigs.txt
2019-11-22 13:51:50 -05:00
75727840df
Closing metricsconfigs.txt
2019-11-22 13:08:56 -05:00
10b0f35235
Merge pull request #1090 from DataDog/tyler/servlet-path
...
Add servlet.path tag
2019-11-22 09:18:14 -08:00
be9743b86b
Eliminate class expression to Advice class
...
Changing Jasper instrumentation to not load the advice class.
This class was missed originally because it doesn't end in Advice.
2019-11-22 09:51:05 -05:00
f0bbd46097
Typo in merge conflict resolution
2019-11-21 13:07:02 -05:00
f1362a7d57
Merge branch 'master' into tyler/jax-rs-annotation-inheritance
2019-11-21 12:51:01 -05:00
45c16a1c55
Create Play WS 2.1 Project
2019-11-20 18:13:41 -05:00
c4cebc30c8
Merge pull request #1097 from DataDog/ZStriker19/remove_duplicate_okhttp_span_and_okhttp_separate_service
...
Remove duplicate Okhttp span and stop separate service creation of ok…
2019-11-20 17:01:18 -06:00
aa46e81e19
Copy instrumentation to jax-rs2
2019-11-20 15:38:17 -05:00
75d66dee21
clean and fix tests
2019-11-20 13:14:35 -05:00
7640e68337
The same classwalking is necessary for @Path
2019-11-20 13:07:04 -05:00
fd4e2d09e1
Fix method iterable logic. methodPath, httpMethod working
2019-11-20 10:18:00 -05:00
99acb52589
Merge pull request #1103 from DataDog/landerson/load-generator
...
Simple load generator tool
2019-11-19 10:19:14 -05:00
6b096c2240
Replacing Advice.class references
...
Replacing Advice.class references with string construction.
This stops the JVM from loading the Advice classes which are used as templates for byte buddy and doesn't ever need to be run directly.
This eliminates ~130 class loads at start-up -- and saves 0.5MiB in metaspace
2019-11-18 16:09:30 -05:00
022257ee55
Fixing resource leak
...
To check for existence, switching from getResourceAsStream to getResource
2019-11-18 10:52:23 -05:00
caaff02c87
Needed to run Java google format.
2019-11-15 15:30:39 -05:00
393a88585a
First pass at supporting annotations inheritance for JAX-RS
...
[skip ci]
2019-11-15 11:53:16 -08:00
c0ba1d3446
Changed test file permissions to match master.
2019-11-15 13:42:28 -05:00
348cbc74c2
Changed okhttp file permissions back to original settings.
2019-11-15 13:29:51 -05:00
a77045b9dc
Add more complexity to jersey resource test
...
This demonstrates a matching failure in our current instrumentation.
2019-11-14 16:01:16 -08:00
8fb32b5730
Remove duplicate Okhttp span and stop separate service creation of okhttp. Instead okhttp will now appear as part of the service that is using okhttp to make the call.
2019-11-14 17:29:28 -05:00
509e655518
Move play-ws-1 and play-ws-2 into separate packages
2019-11-13 16:41:12 -05:00
03b3fa6651
Merge pull request #1092 from DataDog/landerson/debug-instrumentation-names
...
Print all instrumentation names when muzzled
2019-11-13 16:36:40 -05:00
251ceeb978
Print all instrumentation names when muzzled
2019-11-13 14:12:26 -05:00
53b4e5db19
fix test
2019-11-12 15:17:35 -08:00
2c4422aa04
Upgradle to gradle 6.0
2019-11-12 16:26:46 -05:00
bff8303e18
Remove duplicate onRequest call.
...
This info should already be populated by the servlet framework.
2019-11-11 15:58:31 -08:00
fdf2241e5f
Add servlet.path tag
2019-11-11 15:54:21 -08:00
88902046ce
simple load generator tool
2019-11-07 16:50:23 -05:00
2789324cd5
Merge pull request #1084 from DataDog/mar-kolya/fix-agent-for-zulu8
...
fix agent for zulu8
2019-11-07 14:39:03 -05:00
8f80a42c4d
Do not delay tracer on OpenJDK8 with JBOSS
2019-11-07 13:45:56 -05:00
f371e391a8
Fix typo
2019-11-07 06:55:31 -05:00
b002f0c190
Merge pull request #1085 from DataDog/tyler/remove-beta-integrations
...
Remove experimental jdbc and servlet integrations until further evaluation
2019-11-06 14:31:08 -08:00
df6cb663d4
Fix test for case when tracer install is not delayed
2019-11-06 15:35:01 -05:00
fdfe4b1dc3
More renames due to shadow clashes
2019-11-06 15:12:07 -05:00
2432a92230
Remove experimental jdbc and servlet integrations until further evaluation
2019-11-06 11:45:00 -08:00
599d1e0fab
Merge pull request #1082 from DataDog/dougqh/sisu-exclusion
...
Excluded classes generated by Eclipse Sisu
2019-11-06 14:41:36 -05:00
42cece67c2
Fix namespace clashes
...
Using `datadog.trace.agent` to hold agent class causes problems due to
shadowing into this package of other classes.
2019-11-06 13:58:20 -05:00
17155f7d57
Fix scala warning
2019-11-06 13:58:20 -05:00
15c1e67334
Fix agent on latest zulu8
...
The problem was that on zulu8 loading OkHttp touches JFR which in turn
touches log manager - which would break things like JBOSS.
The fix is to delay installing agent (and writer) until log manager
things have settled down - in way similar to jmxfetch.
Unfortunately for 'main' agent this turns out to be more involved
because of classloader shenanigans.
2019-11-06 10:09:50 -05:00
3715a3df53
Fix ClassLoadingTest
...
It should use real class to try to load
2019-11-06 09:57:09 -05:00
58d6103361
Allow big outputs in forked test processes
2019-11-06 09:38:53 -05:00
270a440162
Excluded classes generated by Eclipse Sisu
...
This change excludes classes generated by Eclipse Sisu (part of Equinox DS).
These classes are created by https://github.com/eclipse/sisu.inject/blob/master/org.eclipse.sisu.inject/src/org/eclipse/sisu/space/CloningClassSpace.java
2019-11-05 15:20:52 -05:00
415a875dfc
Add generic is-before-java9 check
2019-11-05 13:08:21 -05:00
b31778a05e
Do not use `printStackTrace()`
2019-11-05 13:08:21 -05:00
f236c0e8e0
Reformat some comments
2019-11-05 13:08:21 -05:00
acfa861e4a
Fix some typos
2019-11-05 13:08:21 -05:00
7f5b270c67
Call class loading callbacks from onComplete
...
This should make things more clear
2019-11-05 13:08:21 -05:00
2d3b644c84
Merge pull request #1080 from DataDog/tyler/rename-beta-configs
...
Rename config key for beta/experimental instrumentation.
2019-11-05 08:44:33 -08:00
4f853f5f0c
Rename config key for beta/experimental instrumentation.
...
Postfix the existing config names with `-beta` for `servlet` and `jdbc`.
To avoid any risk that the config was explicitly enabled for an unrelated reason resulting in unexpected behavior when upgrading to the latest version.
2019-11-04 13:41:33 -08:00
4ba0ca0f9d
Merge pull request #1078 from DataDog/landerson/big-integer-ids
...
Change TraceId/SpanId to BigInteger
2019-11-04 16:34:09 -05:00
bc2978e8d8
Use groovy literals for BigInteger
2019-11-04 16:16:03 -05:00
a3cd46708b
Merge pull request #1075 from DataDog/landerson/wsclient
...
Play WS Client instrumentation
2019-11-04 13:57:46 -05:00
bf4587c23d
Missed a few test helper methods
2019-11-04 12:49:35 -05:00
cfc19facf5
Change String ids to BigInteger ids
2019-11-04 11:21:32 -05:00
92f62ca954
Fix scala warning
2019-11-04 08:22:20 -05:00
9e26da85be
wsclient -> play-ws
2019-11-01 14:37:06 -04:00
68f8607dbf
Fix latestDepTest dependencies
2019-10-31 11:48:52 -04:00
3a1d331525
WSClient instrumentation
2019-10-31 11:12:00 -04:00
64d6d39e78
Merge pull request #1074 from DataDog/landerson/circular-redirect
...
Add "testCircularRedirects" option to HttpClientTest
2019-10-31 10:29:36 -04:00
8a2594eeab
Add "testCircularRedirects" option to HttpClientTest
2019-10-30 18:17:49 -04:00
8e48a70c6d
Fix jax-rs Path annotation inheritance
...
Turns out the class level path annotation overrides parent classes, so we only need to find the nearest one.
We also need to look from the instance’s class, not from where the method is defined.
Commented out a test case because we still need to compile against java 7. That case will be added back when we upgrade to java 8.
2019-10-30 11:39:06 -07:00
b0e7e6a3f9
- fix test compile setting
...
- code format with google formatter
2019-10-30 08:57:13 -07:00
d8bd12bef8
This patch fixes NPE in jaxrs instrument which occurs when we use interfaces with default method and its impl class.
...
- reproduce NPE error with JaxRs class and interfaces in JavaInterfaces
- fix the logic target class of method with @Path annotation to avoid NPE
- setting java 1.8 for jaxrs's test
2019-10-30 08:57:13 -07:00
607dd553d4
Attempt to remove span-ordering race condition with NettyClientTest
2019-10-28 09:50:56 -07:00
e4bc90d15d
Merge pull request #1067 from DataDog/tyler/db-connection
...
Add span when calling DataSource.getConnection with a trace.
2019-10-28 08:41:55 -07:00
a903f20dc4
Merge pull request #1050 from DataDog/tyler/servlet-depth
...
Add new integration for Servlet Filters, HttpServlet, and RequestDispatcher
2019-10-28 08:39:56 -07:00
6703bd96bb
Fix servlet propagation for “tail-call” situations
...
Sometimes servlets will call another servlet by “resetting” the request object. This maintains the attributes previously set, including the span. We want to allow the trace to start if there’s no “active trace” even if there is a span attribute.
2019-10-25 17:01:47 -07:00
a3a1467192
Add span when calling DataSource.getConnection with a trace.
...
Disabled by default, and only creates a span if existing trace detected.
To enable:
* System Property: `-Ddd.integration.jdbc.enabled=true`
* Environment Variable: `DD_INTEGRATION_JDBC_ENABLED=true`
(Or more specifically with `jdbc-datasource`.)
2019-10-25 16:02:39 -07:00
425156115c
Add new integration for Servlet Filters, HttpServlet, and RequestDispatcher
...
Disabled by default, and only creates a span if existing trace detected.
To enable all of them:
* System Property: `-Ddd.integration.servlet.enabled=true`
* Environment Variable: `DD_INTEGRATION_SERVLET_ENABLED=true`
(They have independent configs as well. If needed, view the source below.)
2019-10-25 14:47:48 -07:00
df387b486a
Merge pull request #1064 from DataDog/tyler/spring-controller-refactor
...
Refactor JAX-RS Annotation and Spring Controller/Handler Instrumentation
2019-10-25 14:44:07 -07:00
fa80fee15d
Refactor JAX-RS Annotation and Spring Controller/Handler Instrumentation
...
For spring:
* Move more logic to the decorator.
* Use a fixed operation name, but set the resource name.
* Rename the root span instead of the parent span (If there are other spans in between this could make a difference.) Not sure what impact this would have if multiple controllers are called (ie, forward/include).
For Jax-rs:
* Rename the root span instead of the parent span (same concern as above with spring)
2019-10-25 10:19:25 -07:00
7ae5de1fc6
Refactor Servlet Advice
...
Moving directory structure around.
Combining advice, trying to make it propagate better.
2019-10-25 10:09:19 -07:00
8c558fa00e
Format
2019-10-24 21:05:01 -07:00
e32bf1816a
Organize imports
2019-10-24 21:05:01 -07:00
e06bb1db1f
Remove OpenTracing gradle dependency
2019-10-24 21:05:01 -07:00
5bf5950bf7
Remove dependency on Tracer
2019-10-24 21:05:01 -07:00
da80be693c
Switch to new Tags class in testing module
2019-10-24 21:05:01 -07:00
a45dc34c5c
Remove testing module dependencies on GlobalTracer
2019-10-24 21:05:00 -07:00
86bd9793bd
Switch to new Tags class in instrumetation
2019-10-24 21:05:00 -07:00
9182b64078
Switch to new Tags class in tests
2019-10-24 21:04:57 -07:00
002db5a170
Introduce Tags class
...
To remove dependency on OpenTracing Tags class.
2019-10-24 21:04:10 -07:00
99ddc497e7
Remove baggage item test
...
The new agent api does not have baggage item support.
2019-10-24 21:01:59 -07:00
a9d3360701
Remove test dependency on GlobalTracer
2019-10-24 20:53:14 -07:00
d45b571996
Remove unused code
2019-10-24 20:53:13 -07:00
a8ca47ed03
Skip spring controller and dropwizard trace if no trace present
...
Also prefer early return instead of deep nesting for null check.
2019-10-24 14:40:08 -07:00
079dfd24bd
ES deploy workaround.
2019-10-23 14:09:01 -07:00
fbd16d8cb7
Add assert to ensure muzzle range not empty and update spring-data
...
Also fix a few muzzle definitions that are now broken with the new requirement.
Moved a few projects around to match correct version numbers.
2019-10-23 14:09:01 -07:00
7db4602253
Fix jax-rs-client minimum supported version
...
Can’t be completely sure since many of these versions don’t show up in a maven range query used by muzzle.
2019-10-23 14:02:04 -07:00
29f7288954
Merge pull request #1020 from trask/agent-api
...
Integration API to decouple from OpenTracing
2019-10-23 14:01:18 -07:00
30367c79cf
Split up MessagePropertyTextMap
2019-10-21 18:46:58 -07:00
0107551c0e
Remove outdated comment
2019-10-21 18:36:14 -07:00
8bb0f2c2f0
Use header objects directly where possible
2019-10-21 18:21:01 -07:00
cc31c5a505
Remove unused code
2019-10-21 16:59:43 -07:00
f6d2c1c1ef
Fix two beforeFinish() calls
2019-10-21 16:59:36 -07:00
b0c5b2cd78
Remove deprecated methods
2019-10-19 16:52:43 -07:00
299c396eab
Update testing module to new agent api
2019-10-19 16:52:43 -07:00
41185662df
Update twilio to new agent api
2019-10-19 16:52:43 -07:00
377df7b789
Update trace-annotation to new agent api
2019-10-19 16:52:42 -07:00
05e6544ded
Update spymemcached-2.12 to new agent api
2019-10-19 16:52:42 -07:00
f0c29adb61
Update spring-webflux to new agent api
2019-10-19 16:52:42 -07:00
51fe9f48b9
Update spring-web to new agent api
2019-10-19 16:52:42 -07:00
7775c1e132
Update spring-data-1.9 to new agent api
2019-10-19 16:52:42 -07:00
9b14f7198f
Update sparkjava-2.3 to new agent api
2019-10-19 16:52:42 -07:00
Laplie Anderson
Pawel Chojnacki
Tyler Benson
kfujita
Brian Devins-Suresh
Laplie Anderson
Trask Stalnaker
Douglas Q Hawkins
dougqh
Zachary Groves
ZStriker19
Nikolay Martynov