f06eb57449
Convert apache-http, akka, and play to muzzle plugin
2018-08-24 10:47:37 -07:00
c6841c9d06
Add maven version scanning to muzzle
2018-08-24 10:47:37 -07:00
63bee3737c
Enable executor instrumentation for gRPC server calls
...
This might be more than is needed. Maybe cut back later.
2018-08-24 20:25:13 +10:00
51d74f6147
Begin 0.14.0
2018-08-24 11:35:47 +10:00
6b71340b5b
Enable new netty instrumentation by default
...
Enabled the others in a separate PR and forgot to come back and enable this.
2018-08-24 09:32:51 +10:00
5a6215971a
Merge pull request #455 from DataDog/tyler/enable-integrations
...
Enable netty by default
2018-08-23 16:04:23 +10:00
36b49c7de3
Merge pull request #451 from DataDog/tyler/netty-client-fixes
...
Allow trace to persist across netty connect.
2018-08-23 16:03:58 +10:00
69c04ea4c3
Enable netty instrumentation by default
2018-08-23 08:43:31 +10:00
898647e000
Allow trace to persist across netty connect.
...
Also create span with error on connection failure.
Add tests for connection failure.
2018-08-22 09:45:33 +10:00
c95baef487
Wait for given reference to get GCed in `waitGC`
...
This should help to make sure that object we are interested in
actually gets GCed.
This change also improves tests for PendingTrace and ScopeManager to
make sure that trace gets cleaned up.
2018-08-21 10:05:10 -04:00
520676538c
Merge pull request #449 from DataDog/mar-kolya/add-distributed-tracing-tests
...
Add some tests for distributed tracing in Tomcat and Jetty
2018-08-20 20:30:27 -04:00
e28ee5f9e8
Add timeout to datadog classloader test
2018-08-20 11:10:08 -07:00
a0036a76cc
Add `runFinalization` to `waitForGC`
2018-08-19 00:49:27 -04:00
a4cded9b4f
Add some tests for distributed tracing in Tomcat and Jetty
2018-08-18 13:38:06 -04:00
2d8102c8f5
Register Datadog classloader as parallel capable
2018-08-17 15:42:49 -07:00
f7407708a3
Merge pull request #444 from DataDog/tyler/test-http-server
...
Replace Ratpack test server with Jetty wrapped with groovy
2018-08-17 11:38:21 +10:00
f60d71f379
Fix ServerTest from messing up AgentTestRunnerTest if ran first.
2018-08-17 11:14:04 +10:00
0b289205f8
Add fixme to adapter.
2018-08-17 10:53:12 +10:00
3fc2738179
Improve test coverage and reduce duplication
2018-08-17 10:36:45 +10:00
138f78ce4b
Make Muzzle log class being instrumented
2018-08-16 17:28:32 -04:00
0b6c1bc3d3
Fix tests for Java 7, 9, and 10
2018-08-16 14:23:58 +10:00
20993e7e16
Allow tests to run on all JDKs
2018-08-16 14:23:58 +10:00
e07dfffe5f
Migrate tests to new TestHttpServer
2018-08-16 14:23:58 +10:00
63746907e4
Add TestHttpServer
2018-08-16 14:23:58 +10:00
3f2ec7dc48
Move to separate packages
2018-08-16 12:24:27 +10:00
3c1bf569ea
Add reference pretty-printer to muzzle plugin
2018-08-15 10:01:19 -07:00
c351a4825e
Regenerate muzzle bytecode when run multiple times
2018-08-15 09:49:50 -07:00
36ec5d51e5
SafeHasSuperTypeMatcher: handle exceptions when getting class erasure
2018-08-15 09:49:50 -07:00
a7c63b9261
Clarify comment for safe interface iteration.
2018-08-15 09:49:50 -07:00
57e85d4a13
Catch and log instrumentation matcher exception
...
Catching instrumentation matcher exceptions at the Instrumenter level
allows other, unrelated instrumentation to match.
2018-08-15 09:49:50 -07:00
d64b162539
Remove safeMatch from element matcher and document bb cache class
2018-08-15 09:49:50 -07:00
260e3520aa
Fix classloading integration tests
2018-08-15 09:49:50 -07:00
35c6fa2343
More error catching in safe matcher and reduce log level
2018-08-15 09:49:50 -07:00
75a6cee068
Add DDCachingPoolStrategy to reuse type descriptions
2018-08-15 09:49:50 -07:00
f01c8349cc
Deep-merge Reference fields and methods
...
Plus misc cleanup.
2018-08-15 09:49:50 -07:00
e7bb7cfb3e
Remove findLoadedClass
2018-08-15 09:49:50 -07:00
50c5a57c49
Replace UnloadedType with ByteBuddy TypeDescription
2018-08-15 09:49:50 -07:00
937e9a6cef
Add more methods to PatchLogger
2018-08-15 09:49:37 -07:00
27cade057c
Delegate bootstrap resource loading for unloaded types
2018-08-15 09:49:37 -07:00
f8f45d7f14
Muzzle field matching
2018-08-15 09:49:37 -07:00
c4daf007e3
Muzzle method and access matching
2018-08-15 09:49:37 -07:00
4887822eba
Muzzle method ref creation and matching
2018-08-15 09:46:30 -07:00
0f6761dd4b
Optimize Instrumenter logging
2018-08-15 09:46:30 -07:00
55a0abce68
Add notes of potential references to ReferenceCreator
2018-08-15 09:46:30 -07:00
2893eb6035
Merge pull request #435 from DataDog/tyler/jax-rs-improvements
...
Add span for jax-rs representing controller execution
2018-08-15 14:03:31 +10:00
67c0f2fa03
Merge pull request #431 from DataDog/gary/okhttp-log
...
Remove Util Logger and Refactor test
2018-08-14 18:11:59 -04:00
84d38a8270
Merge pull request #439 from DataDog/tyler/method-signatures
...
Cleanup method signatures and servlet 2 instrumentation
2018-08-13 17:29:02 +10:00
f801cbd466
Merge pull request #428 from DataDog/tyler/use-WeakConcurrentMap
...
Use WeakConcurrentMap
2018-08-13 16:44:16 +10:00
dd11429575
Remove unused fields
2018-08-13 16:43:32 +10:00
232708e457
Prevent abstract classes from going through the muzzle plugin.
2018-08-13 15:35:46 +10:00
4583d12b31
Cleanup method signatures and servlet 2 instrumentation
...
adding the abstract servlet instrumentation reduces code duplication and makes it more similar to servlet 3 instrumentation.
2018-08-13 15:14:10 +10:00
44f501fa53
Fix resources directory name in lagom tests
2018-08-11 06:42:53 -07:00
fc8cc47f85
WeakMap improvements
...
* Improve tests to not depend on thread schedulting
* Test all underlying implementations
* Reduce number of static values
2018-08-10 22:16:21 -07:00
6cef9b89b0
Make some things non-static
2018-08-10 15:41:26 +10:00
b220309a68
PR review changes.
2018-08-10 12:23:13 +10:00
984bc7563d
Add span.origin.type for JSP too.
...
Might be slightly redundant given `jsp.requestURL` but consistent with other instrumentation.
2018-08-10 12:14:16 +10:00
d5cc84ea9f
Add span for jax-rs representing controller execution
...
Also add additional `span.origin.type` tags for better visibility.
2018-08-10 10:36:42 +10:00
a3875aff2c
Logging improvements and other misc
...
from reviewing a customer’s logs.
2018-08-09 15:59:59 +10:00
ae9d4619a4
Add instrumentation showing the rendering time
2018-08-09 13:10:45 +10:00
eacc2d6402
Restructure how WeakMap is implemented
...
Use an interface.
Use a provider/supplier to avoid loading more onto the bootstrap classpath.
2018-08-08 16:54:44 +10:00
2041d56de8
use Slf4j annotation.
2018-08-07 18:29:55 -04:00
abffe1779b
Remove Util Logger and Refactor test
...
OKHttp instrumentation will not be using the java util logger, also applies the string representaiton of ip address for IPV4/6 tags. Refactored test.
2018-08-07 18:29:22 -04:00
5e55defeb3
Fix bootstrap classpath.
2018-08-07 17:11:42 +10:00
d05e2cfe86
Add span for spring web controller.
2018-08-07 17:03:07 +10:00
fff3118dec
separate spring web and error instrumentation.
2018-08-07 16:33:51 +10:00
05dc51633a
Update Spring Tests
2018-08-07 16:04:28 +10:00
9b00a27dce
add javadoc and comparison
2018-08-07 12:42:14 +10:00
847484cd47
Use WeakConcurrentMap
...
Instead of `Collections.synchronizedMap(new WeakHashMap<>())`.
2018-08-06 14:14:57 +10:00
e7aa7c52b4
Improve comments and add synchronization.
2018-08-06 11:38:28 +10:00
064ae4c238
Separate span for input and output streams.
2018-08-03 15:41:16 +10:00
911ad5f231
Merge pull request #417 from DataDog/mar-kolya/apache-http-client-fix-exception-handling
...
Apache http client fix exception handling
2018-08-01 14:58:28 -04:00
7ad9305927
Add some integration tests to check ByteBuddy's behavoir on class loading and parsing
2018-08-01 14:17:12 -04:00
50fde4c382
Begin 0.13.0
2018-08-01 13:03:37 +10:00
bb2126bd9a
Improve ByteBuddyElementMatchers javadoc
2018-07-31 20:14:03 -04:00
2bfb7b93ec
Disable Lagom circuit breaker
...
It looks like they fail tests from time to time
2018-07-31 20:14:03 -04:00
78e6a9c336
Get rid of DDAdvice
...
Newer ByteBuddy api simplifies things.
2018-07-31 20:14:03 -04:00
c66bd24d3a
Use `safeHasSuperType` instead of `isSubType`
...
`isSubType` may fail on certain class lookup problems, even on classes
unrelated to given instrumentation, preventing instrumentation from
being applied.
2018-07-31 20:14:03 -04:00
6693a93485
Remove onInstrumentationError from LagomTest
...
We not longer need it since our instrumentation can handle underlying
loading problem.
2018-07-31 20:14:03 -04:00
6bc1d1ab8e
Implement `saveHasSuperType` and use it instead of `hasSuperType`
...
The idea is to just 'trim' type hierarchy 'up-trees' that we cannot
resolve dring instrumentation instead of failing to instrument completely.
2018-07-31 20:13:59 -04:00
deec4a795c
Improve Apache HTTP client
...
Properly open and close outer span in multi-request cases
2018-07-31 20:12:17 -04:00
1ebe4732f8
Stop using `failSafe` matcher
...
It should not be necessary after we jave fixed class location issue
for ByteBuddy
2018-07-31 20:12:17 -04:00
bae79514c0
Fix DDLocationStrategy to use DataDog ClassLoader
...
This allows ByteBuddy to properly find classes injected into the
agent.
Thanks @realark for providing a fix!
2018-07-31 20:12:17 -04:00
4ae9263e1c
Set POOL_ONLY DescriptionStrategy for ByteBuddy
...
This makes sure no classes are loaded during instrumentation
transformation which allows us to safely instrument depndent classes.
2018-07-31 20:12:17 -04:00
b6118f0397
Apache HTTP Client: add test for redirected request
2018-07-31 20:12:17 -04:00
9a6efe69f4
Fix netty dependency and class version checking
2018-07-31 17:42:40 +10:00
b1304b478a
Change http server span type back to `web`
2018-07-31 12:53:50 +10:00
e6da80bb12
datastores
2018-07-31 12:53:50 +10:00
00a2e891b0
http servers
2018-07-31 12:53:50 +10:00
3856e7fd1a
http clients
2018-07-31 12:53:50 +10:00
01d57fb497
elasticsearch
2018-07-31 12:53:50 +10:00
d3ce57d84f
mongo
2018-07-31 12:53:50 +10:00
094552cad3
memcache
2018-07-31 12:53:50 +10:00
2e7899b405
redis
2018-07-31 12:40:47 +10:00
ff9ef671f3
Apply formatter on groovy files.
2018-07-31 12:09:28 +10:00
51919a77bb
Apply formatter on java files.
2018-07-31 12:07:43 +10:00
bc3af56b08
Apply formatter on scala files.
2018-07-31 12:07:30 +10:00
b5c8a8b8fc
Apply formatter on gradle files.
2018-07-31 12:04:00 +10:00
4c88e1a0a8
Merge pull request #392 from DataDog/gary/uint64-id-support
...
Change the internal storage and handling of trace ID, span ID, and pa…
2018-07-30 15:01:10 -04:00
4e60246e17
Merge pull request #405 from DataDog/tyler/servlet-async
...
Refactor servlet instrumentation and disable async on response.
2018-07-30 10:27:54 +10:00
f6edf913b7
Remove functions that do reflection which is not Java10 compliant
...
These functions are not used anylonger
2018-07-27 14:56:28 -04:00
b64be6228c
Don't check for helper classes in muzzle reference check
2018-07-27 11:03:02 -07:00
fadce5c6b3
Merge pull request #400 from DataDog/mar-kolya/java10-support
...
Java10 support
2018-07-27 13:38:39 -04:00
ee594f8567
Use connect operationName in httpurlconnection connect-first case
2018-07-26 15:34:27 -07:00
54485c3296
Don't trace httpurlconnection as a top-level trace
2018-07-26 15:34:27 -07:00
d598515d09
Handle cases where connect() is called first
2018-07-26 15:34:27 -07:00
df95af53a7
Remove getResponseCode() from httpurlconneciton instrumentation
2018-07-26 15:34:27 -07:00
2a35ecb497
Use connected field to determine io status of httpurlconnection
2018-07-26 15:34:27 -07:00
2780ac7ac1
POC sun JDK http urlconnection instrumentation, currently creates one span.
2018-07-26 15:34:27 -07:00
0f80f7dd40
Remove old checks from HelperInjector
...
They are not really producing anything useful anf they depend on API
that is forbidden in Java9+
2018-07-26 10:11:24 -04:00
44b364332a
Remove unused field and method
2018-07-26 10:11:20 -04:00
3f158bb47f
Fix `SpockRunner` BootstrapJar creation under Java9+
2018-07-26 10:01:55 -04:00
8cc2f6cbb2
Skip `jdk.internal.reflect.DelegatingClassLoader` in `ClassLoaderMatcher`
...
This is the same thing as `sun.reflect.DelegatingClassLoader` in older JVMs
2018-07-26 10:01:55 -04:00
6317b21d5c
Fix merge conflicts with service mapping change
2018-07-26 09:16:41 -04:00
1e36343485
Null or empty tags should remove previously set values.
...
Add context to servlet2 test.
Clean up some declared tracers that mess up the classpath.
2018-07-26 12:20:37 +10:00
fb2817a134
Refactor servlet instrumentation and disable async on response.
...
Separate out common advice between instrumentation.
2018-07-25 15:12:55 +10:00
b30ed0dfa0
Merge pull request #404 from DataDog/mar-kolya/fix-kafka-streaming-flaky-test
...
Fix flaky test in kafka streaming
2018-07-25 00:17:01 -04:00
5c1ac58c3f
Fix flaky test in kafka streaming
2018-07-24 23:41:01 -04:00
7b644161d3
Migrate ApacheHttpClientTest to use span assertion api
2018-07-24 23:28:37 -04:00
c98d5ef64b
Increase ElasticSearch timeout in tests
...
Hopefully this would improve build stability
2018-07-24 23:07:18 -04:00
93e70dcef6
Address comments and add test case for extracting non numeric IDs
2018-07-24 14:04:52 -04:00
3d8e76c2a4
Get rid of `WRITER_PHASER`
...
We have alternative way of doing the same thing and `Phaser` seems to be
not very correct way of doing this anyway.
2018-07-24 11:41:48 -04:00
dcbf8d674a
Akka-http-client: handle `singleRquest` throwing an exception
2018-07-24 11:41:48 -04:00
642b862c13
Do not reference `AkkaHttpClientTransformFlow` in instrumentation code
...
to avoid class loader problems
2018-07-24 11:41:48 -04:00
35b980ea89
Fix ElasticSearch config for 2.x client
2018-07-24 11:41:45 -04:00
732bce82d0
Fix typo
2018-07-23 10:04:53 -04:00
7794eacc91
Increase Cassandra request timeout in tests
2018-07-23 10:04:53 -04:00
b4b99d991c
Move AkkaHttpServerInstrumentation into Scala compilation
...
This is a hack to work around the problem of `auto-service` annotation
processing creating files with same name in `java` and `scala`
directories. This results in Jar having two files with the same name
instead of one concatenated file.
2018-07-23 10:04:53 -04:00
68ce09b461
Add missing Scala classes to list in injection classes
2018-07-23 10:04:53 -04:00
fd5d80ba86
Make muzzle plugin apply to Scala code
2018-07-23 10:04:53 -04:00
161847752f
Pass Span instead of Scope
2018-07-23 10:04:53 -04:00
5e67e6e5ba
Migrate to new instrumentation API
2018-07-23 10:04:53 -04:00
277e7a1a3c
Typo fix
2018-07-23 10:04:53 -04:00
db895f2e34
Remove redundant plugin from akka gradle file
2018-07-23 10:04:53 -04:00
ae37ca4b02
Add akka-http-client instrumentation: superPool
2018-07-23 10:04:53 -04:00
2b25de966a
Add akka-http-client instrumentation
...
This is a very-very first pass: instrument single request
2018-07-23 10:04:53 -04:00
6932d581ed
Add some helpful messages to AgentTestRunner assertions
2018-07-23 10:04:53 -04:00
f9f135cbd6
Do not run Spymemcached tests locally under Java7
...
since it requires external Memcached container running because
testcontainers doesn't work on Java7.
2018-07-23 10:04:53 -04:00
c844501bc5
Fixes for some minor checkstyle complaints
2018-07-23 10:04:53 -04:00
ce7866d018
Use `io.opentracing.log.Fields.*` instead of hardcoded strings
2018-07-23 10:04:53 -04:00
d4d770fe42
Pull out ratpack helper into seprate class to avoid copy-paste
2018-07-23 10:04:53 -04:00
a882a5439c
OkHttp instumentation: simplify error case
2018-07-23 10:04:53 -04:00
9d2755be17
Fix Google Java Formater violations
...
Some changes landed on master that do not comply with new formatter rules
2018-07-23 13:43:29 +10:00
4283e3acb1
Merge pull request #396 from DataDog/mar-kolya/test-http-client-timeout-increase
...
Increase build stability by increasing some http client timeouts
2018-07-22 21:35:32 -04:00
9988c8775f
Merge pull request #388 from DataDog/tyler/grpc
...
Instrument gRPC 1.5.0+
2018-07-23 11:19:48 +10:00
564b4e9dc3
Increase build stability by increasing some http client timeouts
...
This makes build more resilient to slow boxes and high parallelism
2018-07-22 00:41:37 -04:00
f1466304e8
Move random port generation to actual usage in tests using listening ports
2018-07-20 11:57:37 -04:00
c3825d9d52
Improve tmp dir handling in ES tests
...
Also make sure ES ports are allocated right before ES is started
2018-07-20 11:53:33 -04:00
a34f7b849b
Instrument gRPC
...
Adds spans for the duration of the connection and child spans for each message.
Also propagates the trace using the metadata object.
2018-07-20 12:25:04 +10:00
aa3fc0717e
Fix some formatting changes.
2018-07-20 10:31:14 +10:00
7c62e10542
Do not use advice class names in Lettuce instrumentation directly
...
Since this leads to Java8 code loaded into Java7 JVM in tests.
Insted reference class names by string.
2018-07-19 10:45:21 -04:00
Andrew Kent
Tyler Benson
Tyler Benson
Nikolay Martynov
Ark
Gary Huang
Gary Huang