7c5e74bdf0
Cleaning-up decorator
...
The SpringDataDecorator is really for Spring transactions including non-DB related transactions.
The SpringDataDecorator never really implemented DB or ORM support anyway, since most of the methods just returned null.
Changing the decorator to just extend ClientDecorator instead. Also rename to reflect its true purpose.
2019-09-17 10:51:30 -04:00
0748c10b72
Avoid unnecessary objects creation in Apache Http Client instrumnentation
2019-09-17 10:19:38 -04:00
172ff747cb
Updating muzzle spec
...
Switching muzzle to target spring-tx rather than spring-data (which is logical given the instrumentation point)
Also added extraDependency on aopalliance
This restricts the support the Spring 2.5 when spring-tx & spring-aop using aopalliance were introduced.
2019-09-17 10:06:43 -04:00
e43baf82be
Renaming advice class
...
Renaming advice class to more accurately reflect what is being instrumented
2019-09-17 09:27:39 -04:00
85389b48d8
Google Format
2019-09-17 08:24:57 -04:00
0c3e0579b2
Switching to instrumenting transaction support
...
After experimenting with RepositorySupport$QueryExecutorMethodInterceptor switched to TransactionInterceptor.
QueryExecutorMethodInterceptor was too narrowly scoped and didn't capture the UPDATE or DELETE statement. TransactionInterceptor captures everything, but is still a bit more broadly applicable than I'd like.
2019-09-17 08:19:42 -04:00
8376d83aef
Caching affects network tags
2019-09-16 18:34:23 -04:00
111c44d2da
State can be GCd before exit advice is run
2019-09-16 17:58:29 -04:00
62ea7a59fb
Cant test cross compile because the 2.6 instrumentation gets activated
2019-09-16 17:37:34 -04:00
e244ea633d
Add operation id and network tags to couchbase
2019-09-16 16:59:29 -04:00
122533fde6
Switching to simple concat for efficiency
2019-09-16 11:08:37 -04:00
5f455ead3c
Merge pull request #995 from DataDog/landerson/couchbase-subscribe-again
...
Couchbase Asynchronous Subscriptions revisited
2019-09-13 19:30:41 -04:00
6a40938fe4
Split remove test into two parts
2019-09-13 18:56:00 -04:00
d3ec72922e
Increasing the timeout may fix the spurious failures
2019-09-13 18:35:21 -04:00
fee58e07f2
Original merge
2019-09-13 17:48:22 -04:00
c9cfd9d368
Begin 0.34.0
2019-09-13 17:39:40 -04:00
ae3ba9a2ef
Version 0.33.0
2019-09-13 14:37:25 -04:00
b2a8499ba2
Merge pull request #992 from DataDog/revert-988-landerson/couchbase-subscribe
...
Revert "Couchbase Async Subscriptions"
2019-09-13 12:09:40 -04:00
d063b42491
Revert "Couchbase Async Subscriptions"
2019-09-13 11:51:52 -04:00
b875ae19a2
Merge pull request #988 from DataDog/landerson/couchbase-subscribe
...
Couchbase Async Subscriptions
2019-09-13 09:36:07 -04:00
e8d6928a8c
Dont share environment. Slower but more deterministic
2019-09-12 21:48:36 -04:00
4e5e75ebff
Fix tests
2019-09-12 20:51:50 -04:00
407c973029
Migrate spring-web to base httpserver test
...
Unfortunately 404 test was not consistent and non-trivial to adapt. I also couldn’t get the validation tests to work well either. Revisit if we have time to dig deeper into spring.
2019-09-12 17:28:12 -07:00
3d6d45ba77
Merge pull request #989 from DataDog/landerson/remove-dd-trace
...
Remove dd-trace and dd-trace-ext
2019-09-12 11:55:28 -04:00
717a27080b
Remove dd-trace and dd-trace-ext
2019-09-12 10:40:11 -04:00
6c445ad030
Extract RxJava instrumentation from Hystrix and add to Couchbase
2019-09-11 19:25:08 -04:00
a5b5b0c307
Failing tests WIP
2019-09-11 19:25:08 -04:00
df0838070a
Extract span assertion from couchbase tests
2019-09-11 19:25:08 -04:00
d2ba6af80c
Removing unneecessary dependencies
...
Removing dependencies rendered redundant by clean-up in datadog repo - as per review comment
2019-09-11 14:29:34 -04:00
e895d7c3a7
Merge pull request #983 from DataDog/tyler/cache-soft-refs
...
Optimize DDCachingPoolStrategy
2019-09-11 09:41:48 -07:00
5f5605f6b1
Putting in alphabetical order
2019-09-11 11:53:15 -04:00
ab52988ced
Removing "Modified by SignalFx"
2019-09-11 11:33:14 -04:00
60e9cc249c
Removing "Modified by SignalFx"
...
Removing "Modified by SignalFx" comments, since our integration is current the same.
Added a comment to SpringJpaTest explaining the differences.
2019-09-11 11:23:49 -04:00
7a366f0f01
Added explanatory comments to test
...
Added some explanatory comments for each span -- might turn these into assertions later
Primary aim was to understand the differences from the signalfx fork. They seem to stem deviations in the underlying JDBC integration.
2019-09-11 09:55:40 -04:00
07b58e1cf4
Merge pull request #957 from DataDog/landerson/instrumentation-module-check
...
Java 9 Modules Smoketest
2019-09-10 19:56:12 -04:00
df18c7c0a8
Added some more comments
2019-09-10 19:43:23 -04:00
988b03b2f3
Optimize DDCachingPoolStrategy
...
Reduce default cache size in EvictingCacheProvider, and return a NoOp CacheProvider when classloader is going to be skipped.
2019-09-10 15:52:37 -07:00
d10b99a5db
Merge pull request #986 from DataDog/tyler/sampler-locking
...
Remove synchronization from RateByServiceSampler
2019-09-10 15:43:27 -07:00
3d1f2b9d01
Ensure default sampler is available
...
This avoids the possible null pointer reference.
2019-09-10 15:29:13 -07:00
310ec93135
Minor test fix.
2019-09-10 15:08:55 -07:00
a010d4e095
Remove race condition.
2019-09-10 14:56:03 -07:00
1335296975
Fixing mismatches in spans collected by signalfx fork & datadog
...
There are two main differences...
- "hsqldb" vs "spring-data" as the root test service name
- an extra seemingly spurious sql span in signalfx
2019-09-10 17:42:49 -04:00
6d38831252
Merge branch 'master' into dougqh/spring-data
...
Tweak partially picked from signalfx -- that commit included same other unwanted changes in this file and others (see 636c23ed2c
2019-09-10 17:40:36 -04:00
8cd294dba0
Use ThreadLocalRandom for improved concurrency.
2019-09-10 14:04:37 -07:00
a88182ab3b
fix test
2019-09-10 12:56:42 -07:00
42545a0906
Remove synchronization from RateByServiceSampler
...
This change avoids lock contention in a hot code path.
I also added double check locking in ClassLoaderMatcher to reduce the need of locking there.
2019-09-10 12:44:13 -07:00
5f7e0609ed
Initial spring data instrumentation
2019-09-10 15:13:20 -04:00
8915281de2
Java 9 (and only Java9) requires jmods on the module path
2019-09-10 13:20:19 -04:00
fe7c8a22d4
Merge pull request #985 from DataDog/mar-kolya/rename-service-tag
...
Rename SERVICE -> SERVICE_TAG constant
2019-09-10 13:16:20 -04:00
b50ab7e0dd
Add back deprecated field
2019-09-10 12:57:50 -04:00
dougqh