13fa025de8
Use histogram advice in the Micrometer bridge ( #8334 )
2023-05-11 12:45:53 -07:00
3122897b2e
Bump errorProneVersion from 2.18.0 to 2.19.0 ( #8459 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-05-10 09:49:55 -07:00
d22dd8c5f1
Introduce new incubating `InstrumenterBuilder` methods ( #8392 )
2023-04-28 14:19:15 -07:00
0f258c669a
Use hasAttributesSatisfyingExactly instead of hasAttributesSatisfying ( #8336 )
2023-04-24 11:57:45 +02:00
e3944a53a5
Make net.transport an optional attribute ( #8279 )
2023-04-20 08:14:03 -07:00
f501569106
Switch from http.flavor to net.protocol.* in HTTP client instrumentat… ( #8131 )
2023-04-07 13:39:42 +02:00
04f2e3e9e5
Bridge agent logs into application's slf4j logger ( #7339 )
...
Related discussion #7257
Resolves #3413
Resolves #5059
Resolves #6258
Resolves #7179
Adds a logging implementation that'll collect agent logs in memory until
slf4j is detected in the instrumented application; and when that happens
will dump all the logs into the application slf4j and log directly to
the application logger from that time on.
It's still in a POC state, unfortunately: while it works fine with an
app that uses & initializes slf4j directly, Spring Boot applications
actually reconfigure the logging implementation (e.g. logback) a while
after slf4j is loaded; which causes all the startup agent logs (debug
included) to be dumped with the default logback pattern.
Future work:
* ~~Make sure all logs produces by the agent are sent to loggers named
`io.opentelemetry...`
(https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/7446 )~~
DONE
* Make this work on Spring Boot
* Documentation
* Smoke test?
2023-04-04 17:29:43 +02:00
f1411d1cb3
Share timer class used by messaging instrumentations ( #8009 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/4514
There is also a slightly different timer class in netty instrumentation
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/netty/netty-common/library/src/main/java/io/opentelemetry/instrumentation/netty/common/internal/Timer.java
that I didn't touch.
2023-03-10 10:40:41 +02:00
ff73e9577c
Make the OpenTelemetry Logback appender work with GraalVM native images ( #7989 )
...
I have tried the [OpenTelemetry Logback
appender](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/logback/logback-appender-1.0/library )
with GraalVM native images. The GraalVM configurations of this PR are
required to make it work.
It's my first GraalVM-related PR in this repo. In future works, adding
automatic tests with GraalVM on some [programmatic instrumentation
libraries](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/supported-libraries.md#libraries--frameworks )
may be interesting.
2023-03-08 07:58:37 -08:00
ea237e3a80
Update HTTP span name extractors ( #7730 )
...
Implements
https://github.com/open-telemetry/opentelemetry-specification/issues/2998
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-14 07:40:05 -08:00
e1895e548c
Rename all methods in all Getters to use the `get*()` naming scheme ( #7619 )
...
Resolves #6562
This PR only contains renames; the actual content is in the `*Getter`
interfaces, the rest of changes is just IntelliJ doing its job.
2023-01-23 09:28:11 +00:00
ecacd8c86b
Avoid RejectedExecutionException ( #7516 )
...
TIL (in another repo but applicable here)
2023-01-09 13:22:57 -08:00
0a045e3a00
Bump errorProneVersion from 2.16 to 2.17.0 ( #7489 )
...
Bumps `errorProneVersion` from 2.16 to 2.17.0.
Updates `error_prone_annotations` from 2.16 to 2.17.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/error-prone/releases ">error_prone_annotations's
releases</a>.</em></p>
<blockquote>
<h2>Error Prone 2.17.0</h2>
<p>New Checkers:</p>
<ul>
<li><a
href="https://errorprone.info/bugpattern/AvoidObjectArrays "><code>AvoidObjectArrays</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/Finalize "><code>Finalize</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/IgnoredPureGetter "><code>IgnoredPureGetter</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/ProtoFieldNullComparison "><code>ImpossibleNullComparison</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/MathAbsoluteNegative "><code>MathAbsoluteNegative</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/NewFileSystem "><code>NewFileSystem</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch "><code>StatementSwitchToExpressionSwitch</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/UnqualifiedYield "><code>UnqualifiedYield</code></a></li>
</ul>
<p>Fixed issues: <a
href="https://github-redirect.dependabot.com/google/error-prone/issues/2321 ">#2321</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3144 ">#3144</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3297 ">#3297</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3428 ">#3428</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3437 ">#3437</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3462 ">#3462</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3482 ">#3482</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3494 ">#3494</a></p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/google/error-prone/compare/v2.16...v2.17.0 ">https://github.com/google/error-prone/compare/v2.16...v2.17.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="27de40ba60bcf4dcf7648ddb7cbb051d23141bd7e3602572b05768290a157340bdf01db92c9b1b5563fb30be3f4a5fd7bd5ahttps://github.com/google/error-prone/compare/v2.16...v2.17.0 ">compare
view</a></li>
</ul>
</details>
<br />
Updates `error_prone_core` from 2.16 to 2.17.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/error-prone/releases ">error_prone_core's
releases</a>.</em></p>
<blockquote>
<h2>Error Prone 2.17.0</h2>
<p>New Checkers:</p>
<ul>
<li><a
href="https://errorprone.info/bugpattern/AvoidObjectArrays "><code>AvoidObjectArrays</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/Finalize "><code>Finalize</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/IgnoredPureGetter "><code>IgnoredPureGetter</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/ProtoFieldNullComparison "><code>ImpossibleNullComparison</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/MathAbsoluteNegative "><code>MathAbsoluteNegative</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/NewFileSystem "><code>NewFileSystem</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch "><code>StatementSwitchToExpressionSwitch</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/UnqualifiedYield "><code>UnqualifiedYield</code></a></li>
</ul>
<p>Fixed issues: <a
href="https://github-redirect.dependabot.com/google/error-prone/issues/2321 ">#2321</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3144 ">#3144</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3297 ">#3297</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3428 ">#3428</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3437 ">#3437</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3462 ">#3462</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3482 ">#3482</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3494 ">#3494</a></p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/google/error-prone/compare/v2.16...v2.17.0 ">https://github.com/google/error-prone/compare/v2.16...v2.17.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="27de40ba60bcf4dcf7648ddb7cbb051d23141bd7e3602572b05768290a157340bdf01db92c9b1b5563fb30be3f4a5fd7bd5ahttps://github.com/google/error-prone/compare/v2.16...v2.17.0 ">compare
view</a></li>
</ul>
</details>
<br />
Updates `error_prone_test_helpers` from 2.16 to 2.17.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/error-prone/releases ">error_prone_test_helpers's
releases</a>.</em></p>
<blockquote>
<h2>Error Prone 2.17.0</h2>
<p>New Checkers:</p>
<ul>
<li><a
href="https://errorprone.info/bugpattern/AvoidObjectArrays "><code>AvoidObjectArrays</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/Finalize "><code>Finalize</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/IgnoredPureGetter "><code>IgnoredPureGetter</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/ProtoFieldNullComparison "><code>ImpossibleNullComparison</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/MathAbsoluteNegative "><code>MathAbsoluteNegative</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/NewFileSystem "><code>NewFileSystem</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch "><code>StatementSwitchToExpressionSwitch</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/UnqualifiedYield "><code>UnqualifiedYield</code></a></li>
</ul>
<p>Fixed issues: <a
href="https://github-redirect.dependabot.com/google/error-prone/issues/2321 ">#2321</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3144 ">#3144</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3297 ">#3297</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3428 ">#3428</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3437 ">#3437</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3462 ">#3462</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3482 ">#3482</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3494 ">#3494</a></p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/google/error-prone/compare/v2.16...v2.17.0 ">https://github.com/google/error-prone/compare/v2.16...v2.17.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="27de40ba60bcf4dcf7648ddb7cbb051d23141bd7e3602572b05768290a157340bdf01db92c9b1b5563fb30be3f4a5fd7bd5ahttps://github.com/google/error-prone/compare/v2.16...v2.17.0 ">compare
view</a></li>
</ul>
</details>
<br />
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-01-03 11:49:41 -08:00
7e2924c7cd
Add null check for the return value of `ReferenceQueue#remove()` ( #7304 )
2022-11-25 06:42:11 +01:00
52cfafc44a
Clean WeakConcurrentMap from background thread ( #6240 )
...
Currently our `WeakConcurrentMap` is only cleaned of stale entries when
it is accessed. There is an option to clean from a background thread,
but this creates a separate thread for every map. This pr introduces a
single background thread that cleans all maps.
I removed the option to create a thread per map as we don't use it, if
there is interest I could attempt to find a way to add it back.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-11-23 09:24:51 -08:00
95ec4a8c1f
HTTP semconv: filter out default peer/host ports ( #7258 )
...
After a loooong break, the next part of the HTTP semconv implementation:
filtering out default HTTP ports, client and server.
> [5]: If not default (80 for http scheme, 443 for https).
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client
2022-11-22 17:14:20 +00:00
586261d25a
Run context customizers before span start instead of after ( #6634 )
...
...so that they can have access to the parent span context, and so that
their additions to the context will be visible to span processors
2022-10-06 12:11:17 -07:00
429ecfc713
Update error prone ( #6646 )
...
(note that change from BDDMockito is due to
https://github.com/google/error-prone/issues/3396 )
2022-09-23 11:24:40 -07:00
d5c6453636
Remove external usages of ClassNames (and move it to internal) ( #6584 )
...
* Reduce dependency on simpleName
* Move ClassNames to internal
* Javadoc
* Updates
* Fix
* Spotless
* Rename
* Add test
2022-09-13 13:58:19 -07:00
f50f1fed3b
Fix instrumentation-api-semconv packages ( #6590 )
...
* Fix instrumentation-api-semconv packages
* Move test
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-12 14:51:27 -07:00
cfdbe758f2
Net attributes getters changes (in preparation for HTTP spec impl) ( #6503 )
...
* Net attributes getters changes: instrumentation-api-semconv changes
* Net attributes getters changes: getter implementations
* Net attributes getters changes: test fixes
* Remove net.sock.host.name
* code review comments
* default getter methods & getPeerSocketAddress() method name
* set authority in grpc earlier
2022-09-12 09:20:27 -07:00
23aff05722
Rename two package-private instrumenter-api classes ( #6579 )
2022-09-12 17:37:07 +03:00
ae209d9289
Rename ErrorCauseExtractor.jdk() to getDefault() ( #6580 )
...
* Rename ErrorCauseExtractor.jdk() to ErrorCauseExtractor.getDefault()
* jApiCmp
2022-09-12 17:36:34 +03:00
54c41f7558
Move extractFromRequest() to internal ( #6585 )
...
* Move extractFromRequest() to internal
* Javadoc
2022-09-12 17:36:07 +03:00
af61a8b578
Update to otel 1.18.0 ( #6575 )
2022-09-11 10:35:05 -07:00
edf421ede5
Stabilize instrumentation-api and introduce jApiCmp checks ( #6566 )
...
* Stabilize instrumentation-api and introduce jApiCmp checks
* Update
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-09 15:26:39 -07:00
60d0763af4
Remove a method from instrumenter api ( #6570 )
2022-09-09 12:21:30 -07:00
59cb9ca0df
Remove deprecated code ( #6501 )
...
* Remove deprecated code
* unnecessary semicolon
* fix distro and extension examples
2022-08-24 14:36:57 -07:00
6cd79b2a94
Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode() ( #6466 )
...
* Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode()
* fix liberty
2022-08-12 17:11:11 -07:00
68a9f20eb3
Enable PrivateConstructorForUtilityClass errorprone check ( #6427 )
...
* PrivateConstructorForUtilityClass
* Advice
* More advice
* More
* More advice
* More
* Spotless
* Fix
* Fix
* Fix
* A better solution
* Revert
* More
* Fix
* Spotless
* Fix
2022-08-10 11:30:22 +03:00
b2c90c79b5
Extract HTTP request & response content length from headers ( #6415 )
...
* Extract HTTP request & response content length from headers
* remove unused method
* fix camel tests
* fix google http client tests
* fix HttpUrlConnection tests
* fix k8s and jaxrs tests
* fix aws tests
* actually fix aws tests 🤞
* fix elasticsearch tests
* fix ratpack tests
* fix spring webflux tests
* fix vertx tests
* fix reactor netty tests
2022-08-05 10:55:47 -07:00
06dfd59fcd
Add ParametersAreNonnullByDefault and safety null checks in builder methods ( #6364 )
2022-08-01 22:29:34 -07:00
5a152cd289
Deprecate uncompressed content length HTTP attributes ( #6383 )
2022-07-29 06:17:38 +02:00
976ab9411c
Deprecate Config ( #6360 )
...
* Deprecate Config
* suppress deprecation on ConfigTest
2022-07-25 12:10:11 -07:00
82b39b1012
Rename `newInstrumenter()` into `buildInstrumenter()` ( #6363 )
...
* Rename newInstrumenter() into buildInstrumenter()
* spotless
2022-07-25 12:02:46 -07:00
e7887ac929
Idea: deprecate `Config`, add agent-only `InstrumentationConfig` ( #6264 )
...
* Idea: deprecate Config, add agent-only InstrumentationConfig
* fix
* fix camel test
* fix external-annotation tests
2022-07-08 16:20:49 +02:00
198dad00d6
Prefer using ConfigProperties over Config in AgentListener ( #6202 )
...
* Prefer using ConfigProperties over Config in AgentListener
* normalize property name
* add TODOs
2022-07-07 15:44:32 +02:00
bb25a6c47c
Expunge stale entries on computeIfAbsent ( #6235 )
2022-06-28 20:21:05 -07:00
b0eae3461c
Update spotless ( #6218 )
...
* Update spotless
* Update spotless
2022-06-26 14:44:29 -07:00
defa530c72
Remove deprecated TimeExtractor ( #6196 )
...
* Remove deprecated TimeExtractor
* forgot to add one more class
2022-06-22 16:42:50 -07:00
91dcad68bd
Run tests with play 2.4 ( #6145 )
...
* Run tests with play 2.4
* restore comment
2022-06-14 12:10:53 +03:00
b7fc80c98e
Change SpanStatusExtractor to use a builder that can set status description ( #6035 )
...
* Change SpanStatusExtractor to use a builder that can set status descripion
* Refactor SpanStatusExtractor to only support builder approach to setting status
* Revert setting the exception as the status description
* PR feedback
* Re-fix graghql instrumentation span extractor
* Spotless
2022-05-19 10:00:46 -07:00
512a040025
Remove TimeExtractor and use internal API for setting start/end timestamps ( #6051 )
...
* Remove TimeExtractor and use internal API for setting start/end timestamps
* code review comments
2022-05-19 09:03:11 -07:00
e343b50804
Remove some deprecated code from the main branch ( #6055 )
2022-05-17 12:25:43 -07:00
cb7421c592
Add an SPI for customizing Config just before it's set ( #6010 )
...
* Add an SPI for customizing Config just before it's set
* deprecate ConfigPropertySource in favor of ConfigCustomizer
* errorprone
2022-05-16 11:55:01 -07:00
6a0ca530b7
Instrumentation API changes: VirtualField ( #6017 )
...
* Instrumentation API changes: VirtualField
* change class name in string constant
2022-05-12 11:17:24 -07:00
87b412fb40
Instrumentation API changes: OperationMetrics, OperationListener ( #6016 )
...
* Instrumentation API changes: OperationMetrics, OperationListener
* errorprone
2022-05-12 11:16:46 -07:00
802f5aa3ea
Instrumentation API and Javadoc cleanup ( #5954 )
2022-05-09 22:13:45 -07:00
2c4acd7c81
Introduce LocalRootSpan (replacing ServerSpan) ( #5896 )
...
* Introduce LocalRootSpan (replacing ServerSpan)
* fix tests
* bridge old ServerSpan class
2022-04-21 11:29:10 +02:00
4e3f19d469
Enable span suppression by SpanKey by default ( #5779 )
...
* Enable span suppression by SpanKey by default
* fix HTTP tests (probably)
* add exception for camel
* remove suppression tests from @WithSpan instrumentations
* remove suppression tests from @WithSpan instrumentation; spring boot autoconfigure
* fix twilio tests
* fix netty-based HTTP clients, remove AWS SDK 1.11 unit test
* fix elasticsearch tests
* codenarc
* spotless
* fix AWS SDK 1.11 tests
* remove a TODO
* code review comments
* fix merge conflict
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-04-19 14:13:09 -07:00
Mateusz Rzeszutek
dependabot[bot]
Lauri Tulmin
Jean Bisutti
Trask Stalnaker
HaloFour