Commit Graph

1134 Commits

Author SHA1 Message Date
Anuraag Agrawal 35727bcffe
Remove khttp instrumentation (#3087) 2021-06-01 20:39:51 +09:00
Anuraag Agrawal 5cbade4f42
Migrate GWT to Instrumenter API (#3146)
* Migrate GWT to Instrumenter API

* TODO

* instrumenter()
2021-06-01 20:12:21 +09:00
Anuraag Agrawal c3dedbb64e
Enable all errorprone checks (#3155)
* Enable all errorprone checks

* Fixes

* Finish

* Finish

* Add flag to disable error prone
2021-06-01 17:41:08 +09:00
Lauri Tulmin a746c94b1c
Single connection concurrency test on ratpack (#3151) 2021-06-01 08:55:40 +03:00
Trask Stalnaker 5e8568807b
Update spring-webmvc to Instrumenter API (#3132)
* Update spring-webmvc to Instrumenter API

* Remove hasExceptionOnServerSpan from grails too
2021-05-31 08:57:51 -07:00
Lauri Tulmin d2906841bd
Fix flaky spring webflux tests (#3150) 2021-05-31 08:20:25 -07:00
Trask Stalnaker 7d58dc7b25
Move logic to redisson request object (#3130) 2021-05-31 07:50:18 -07:00
Trask Stalnaker d986981d70
Update cassandra-4.0 to Instrumenter API (#3126)
* Update cassandra-4.0 to Instrumenter API

* Update cassandra-3.0 instrumentation to be consistent
2021-05-31 07:49:59 -07:00
Trask Stalnaker 7d46c336b0
Update lettuce-5.0 to Instrumenter API (#3125) 2021-05-31 07:49:25 -07:00
Trask Stalnaker 3c8874d536
Update jedis-3.0 to Instrumenter API (#3124) 2021-05-31 07:49:02 -07:00
Anuraag Agrawal f755b3f52c
Use AtomicLongUpdater for gRPC message ID (#3137) 2021-05-31 11:31:17 +09:00
Trask Stalnaker fb0d047fce
Last type instrumentations to top-level classes (#3123) 2021-05-30 16:05:31 -07:00
Trask Stalnaker 1a56ddb427
Simplify tomcat version detection (#3129) 2021-05-30 15:08:00 +09:00
Trask Stalnaker c1c052318b
Move more type instrumentations to top-level classes (#3118) 2021-05-28 17:24:19 -07:00
dengliming ca5b792f95
Update methods-javaagent to Instrumenter API (#3070)
* Update methods-javaagent to Instrumenter API

Signed-off-by: dengliming <liming.d.pro@gmail.com>

* introduce SpanNames

Signed-off-by: dengliming <liming.d.pro@gmail.com>

* Add test for SpanNames

Signed-off-by: dengliming <liming.d.pro@gmail.com>

* Fix merge

* Codenarc

* Remove unused dep

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 17:23:50 -07:00
Anuraag Agrawal b5f949afb2
Use testcontainers for ES rest tests and some other ES dependency cleanup (#3119) 2021-05-28 15:55:13 -07:00
Lauri Tulmin 32e28c1b1e
Propagate context to armeria callbacks (#3108) 2021-05-28 15:01:31 -07:00
Lauri Tulmin e16cf3001f
Add attributes to netty connection failure span (#3115) 2021-05-28 15:01:10 -07:00
Anuraag Agrawal ed88cca533
Migrate from spotbugs to errorprone (#3122)
* Migrate from spotbugs to errorprone

* Fix hashtable

* try-with-resources

* Fix from merge

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
Lauri Tulmin 35d6bdb730
Hibernate query span naming (#3106)
* Hibernate query span naming

* remove commented out code

* modify query sanitizer to accept queries that start with from clause

* add sql sanitizer test for queries starting with from

* rename hibernate-4.3 to hibernate-procedure-call-4.3
2021-05-28 11:31:52 -07:00
Anuraag Agrawal 796976a0f1
Workaround glassfish resolution error. (#3116) 2021-05-28 11:56:34 +09:00
Anuraag Agrawal c358a35414
Use dependency management pattern for dependency versions (#3113)
* Use dependency management pattern for dependency versions.

* Add groovy bom too

* Update dependencyManagement/dependencyManagement.gradle.kts

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
Trask Stalnaker 98b566959a
Make TypeInstrumentations top-level classes (#3100) 2021-05-27 13:27:28 -07:00
Ago Allikmaa 165bc1e492
Akka propagation fix and concurrency tests (#3099) 2021-05-27 09:43:09 -07:00
Lauri Tulmin 79e42ad665
Remove unused plugin (#3107) 2021-05-27 09:38:58 -07:00
Lauri Tulmin c49a0bb114
Limit latest dep version for glassfish test (#3109) 2021-05-27 21:31:45 +09:00
Lauri Tulmin 6d26321d75
Fix redisson latest dep test (#3110) 2021-05-27 21:29:57 +09:00
Ago Allikmaa df078f95a9
Extract HttpServerTest INDEXED_CHILD span attribute collection logic (#3095)
* Extrawct HttpServerTest INDEXED_CHILD span attribute collection logic

* Adjust whitespace

* Fix context issue with JAX-RS

* Rerun tests
2021-05-27 11:18:11 +03:00
Anuraag Agrawal acedbff78d
Migrate gRPC to Instrumenter API (#3073)
* Migrate gRPC to Instrumenter API

* Don't unwrap grpc exception

* Fix merge and cleanup
2021-05-27 15:40:53 +09:00
Trask Stalnaker df0d028a32
Remove db.connection_string from redis instrumentation (#3094) 2021-05-26 23:13:55 -07:00
Trask Stalnaker c8ecd9a619
Add response type parameter to db attributes extractor (#3093)
* Add response type parameter to DbAttributesExtractor

* AutoValue

* ResultSet
2021-05-26 23:13:33 -07:00
Ago Allikmaa 0a34b2b056
Enable Spring WebFlux concurrency tests (#3077)
* Enable Spring WebFlux concurrency tests

* Fix Spring WebFlux test application scan scope

* codenarc fix

* Renamed package server.http to server.base

* Addressed PR comments
2021-05-26 08:29:46 -07:00
Lauri Tulmin 38830ea06e
Fix JdbcInstrumentationTest (#3089) 2021-05-26 08:25:20 -07:00
Anuraag Agrawal c1452b907d
Fix merge conflict (#3086) 2021-05-26 18:28:36 +09:00
Anuraag Agrawal 761c739f7f
Remove redundant buildscript block (#3083) 2021-05-26 13:50:44 +09:00
dengliming 8ee085fda4
Update redisson-3.0 to Instrumenter API (#3069)
* Update redisson-3.0 to Instrumenter API

Signed-off-by: dengliming <liming.d.pro@gmail.com>
2021-05-25 21:49:00 -07:00
Trask Stalnaker a6c3d80b50
Update cassandra-3.0 to Instrumenter API (#3066) 2021-05-25 21:45:03 -07:00
Ago Allikmaa fd132d463d
Change Async Servlet span end logic to fix race condition on Undertow (#2992)
* Attach servlet async listener with asyncStart instrumentation

* Exclude Spring packages containing servlet request classes from global ignores

* Exclude Tapestry HSR proxy with global ignore

* Improve comments.

* Fix for Liberty - request response when adding async listener

* Removed unused methods

* Explicit response to async listeners on all servlet engines

* Attach response to request on Jetty

* Fix broken build due to rebase, improved a comment

* Address PR comments

* Added a comment.

* Addressed PR comments
2021-05-25 20:46:37 -07:00
Anuraag Agrawal 5f373b3062
Configure kotlin directly in only project that uses it and enable testLatestDeps (#3081) 2021-05-26 09:58:52 +09:00
Mateusz Rzeszutek d755654c29
[WIP] Add peer.service to Instrumenter API (#3050)
* [WIP] Add peer.service to Instrumenter API

* Move PeerServiceAttributesExtractor to javaagent-api and use reflection to add it

* Finish PeerServiceAttributesExtractor

* Fix tests

* Add peer.service to apache-httpclient-5.0, jedis-1.4, lettuce-4.0
2021-05-25 15:31:41 +02:00
Lauri Tulmin 313f8e1fb8
Fix memory leak on netty (#3059) 2021-05-24 20:32:19 -07:00
Trask Stalnaker b4cab9ba36
Update jedis-1.4 to Instrumenter API (#3064) 2021-05-24 12:22:03 -07:00
Ago Allikmaa c28af1f50e
Vert.x Reactive HTTP server and client concurrency tests (#3061)
* Vert.x Reactive HTTP server and client concurrency tests

* Concurrency test for VertxReactivePropagationTest
2021-05-24 12:01:05 -07:00
Trask Stalnaker 2943acc39a
Update apache-httpclient-5.0 to Instrumenter API (#3062) 2021-05-24 10:17:55 -07:00
Trask Stalnaker e7ef5ba927
Update lettuce-4.0 to Instrumenter API (#3068) 2021-05-24 09:25:56 -07:00
Trask Stalnaker f0e43c9e72
Update geode to Instrumenter API (#3067) 2021-05-24 09:25:21 -07:00
Trask Stalnaker 1583683aec
Add Nullable to Instrumenter API response args (#3041) 2021-05-24 09:14:48 -07:00
Mateusz Rzeszutek 6fb3ec0501
Do not use arrays in InstrumentationModule (#3057)
* Do not use arrays in InstrumentationModule

* add missing cast
2021-05-24 13:51:07 +02:00
Michael Bannister d1b9413d88
Use configured NetPeerAttributes in OkHttp3 client tracer (#3063)
This will make it notice the peer-service-mapping settings to set peer.service span attribute

I know this approach is deprecated but I hope to follow this up with another change to use the
new Instrumenter API.

#3009
2021-05-23 09:29:18 +03:00
Trask Stalnaker f11bd75710
Don't use singleton for propagator getters/setters (#3054) 2021-05-21 11:48:54 -07:00
Trask Stalnaker bdfd22f8a3
Update Apache HttpClient 4.0 to Instrumenter API (#3042)
* Update Apache HttpClient 4.0 to Instrumenter API

* Update instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/ApacheHttpClientHttpAttributesExtractor.java

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-20 15:54:22 -07:00
Ago Allikmaa b8a8db49c0
RxJava concurrency test (#3036) 2021-05-20 14:34:08 -07:00
Trask Stalnaker 329233e576
Change a couple of Longs to Integers in Instrumenter API (#3043) 2021-05-20 14:33:22 -07:00
Lauri Tulmin 119697b131
Share some code between netty 4.0 and 4.1 instrumentation (#3048) 2021-05-20 14:32:37 -07:00
Lauri Tulmin 1313abe5cd
Fix flaky spring batch test (#3051)
* Fix flaky spring batch test

* Update instrumentation/spring/spring-batch-3.0/javaagent/src/test/groovy/ItemLevelSpanTest.groovy

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-20 14:31:27 -07:00
Trask Stalnaker b436611217
Exclude failing netty dep from netty-3.8 also (#3045) 2021-05-20 14:30:04 -07:00
Trask Stalnaker 6efae9ad28
Remove duplicate method (#3032) 2021-05-19 11:56:34 -07:00
Lauri Tulmin 23a40d926c
Netty4.1: remove our handler when original handler is removed (#3026)
* Netty4.1: remove our handler when orignal handler is removed

* Update instrumentation/netty/netty-4.1/javaagent/src/test/groovy/ChannelPipelineTest.groovy

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* disable epoll to see whether it makes any difference

* fix netty with epoll/kqueue native library

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-19 10:01:56 -07:00
Trask Stalnaker 9f7cfd27b3
Avoid loading advice classes in agent class loader, part 2 (#3031) 2021-05-19 09:53:27 -07:00
Lauri Tulmin 87bc1c69dc
Exclude failing netty version from muzzle (#3038) 2021-05-19 09:53:09 -07:00
Lauri Tulmin 42728c4b1f
Exclude broken spring-ws version from muzzle (#3037) 2021-05-19 19:05:31 +03:00
Trask Stalnaker d1946f6774
Don't use type annotation style (#3023) 2021-05-18 10:23:09 -07:00
Mateusz Rzeszutek bb8f515083
Refactor TypeInstrumentation#transformers() method (#3019)
* Refactor TypeInstrumentation#transformers() method part 1

Add TypeInstrumentation and its implementations

* Refactor TypeInstrumentation#transformers() method part 2

Use the new method in all existing TypeInstrumentation implementations

* Drift

* Spotless

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
Trask Stalnaker 1535834d46
Update Apache HttpClient 2.0 to Instrumenter API (#3012) 2021-05-17 17:15:10 -07:00
Lauri Tulmin 2675364897
Remove span isRecording check from servlet advice (#3022) 2021-05-18 08:51:24 +09:00
Lauri Tulmin b4b102dbec
Enable http client connection failure tests (#2998) 2021-05-17 12:15:48 -07:00
Trask Stalnaker e54a007dc1
Remove unnecessary method in test harness (#3016) 2021-05-17 12:12:56 -07:00
Trask Stalnaker 32399ea7a9
A small test cleanup (#3014) 2021-05-17 12:12:40 -07:00
Nikita Salnikov-Tarnovski 3ecce72298
Replace embedded Redis server with testcontainers in tests (#3011)
* Replace embedded Redis server with testcontainers in tests

* Update instrumentation/lettuce/lettuce-5.0/javaagent/src/test/groovy/LettuceReactiveClientTest.groovy

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-17 09:57:13 +03:00
Trask Stalnaker 85522cb2ed
Avoid loading advice classes in agent class loader (#3008)
* Lettuce 5.0

* Lettuce 4.0

* Ratpack

* Cassandra 4.0

* Grizzly

* KHttp

* External annotations

* Test

* Jdbc

* Method instrumentation

* OTel annotations
2021-05-16 20:07:20 -07:00
Lauri Tulmin dea25f3b1b
Fix rabbitmq latest dep test (#3004) 2021-05-15 14:15:58 -07:00
Anuraag Agrawal 95c16c4a3c
Start migrating Muzzle plugin to Java (#2996) 2021-05-15 16:22:05 +09:00
Anuraag Agrawal fe41885ee6
Switch to colon notation for dependencies. (#2994)
* Switch to colon notation for dependencies.

* Even more cleanup

* Revert mistake
2021-05-15 15:31:06 +09:00
Lauri Tulmin 406eabef20
Simplify servlet advice (#2972)
* Simplify servlet advice

* fix sampling

* Trigger Build

* use the same logic as previously, maybe this helps agains glassfish smoke-test failure
2021-05-14 18:49:32 +03:00
Anuraag Agrawal 4b1714c3f4
Update to Gradle 7.0 (#2983)
* Update to Gradle 7.0

* Fix scala

* Restore accidental

* Fix deprecations
2021-05-14 11:52:20 +09:00
Trask Stalnaker 28d814c813
Add HTTP client error test (#2932) 2021-05-13 13:34:45 -07:00
Anuraag Agrawal a3be8e3613
More lazy Gradle configuration (#2973) 2021-05-13 16:24:40 +09:00
Trask Stalnaker f413e5a3aa
Remove RequestDispatcherAdvice (#2942) 2021-05-12 21:37:48 -07:00
Anuraag Agrawal 3edc4a7f77
Remove logging of context mismatch which will always be logged. (#2970) 2021-05-12 10:02:47 -07:00
Anuraag Agrawal 057d8861fa
Record HTTP server metrics in instrumenter API. (#2877)
* Record HTTP server metrics in instrumenter API.

* Fix

* Response attributes

* Start cleaning

* Docs

* Test

* Finish test

* Cleanups

* Cleanups
2021-05-12 17:49:12 +09:00
Trask Stalnaker 5f18691818
Fix Grails application error (#2815) 2021-05-11 18:01:42 -07:00
Lauri Tulmin d29bf39428
Don't set span status to unset (#2956) 2021-05-11 16:14:19 -07:00
Trask Stalnaker 8379404ae8
Uncomment and fix JAX-RS default method tests (#2930) 2021-05-11 11:22:11 -07:00
Trask Stalnaker 1086bce0b0
Add comment to JDBC DataSource instrumentation (#2940) 2021-05-11 09:52:42 -07:00
Mateusz Rzeszutek 871f9a0d24
InstrumentationModule cleanup (#2925) 2021-05-11 09:24:31 -07:00
Lauri Tulmin 3b807e0efb
Assert spans in grpc client error test (#2928) 2021-05-11 17:01:25 +03:00
Anuraag Agrawal abeca79e24
Some Gradle optimizations (#2949)
* Gradle optimizations

* Finish
2021-05-11 17:45:54 +09:00
Anuraag Agrawal 23dca77428
Instrument okhttp builder constructor instead of client (#2946)
* Instrument okhttp builder constructor instead of client

* Comment
2021-05-11 12:08:41 +09:00
Trask Stalnaker 3528d63b92
Remove HelperInjectorAccess (#2936) 2021-05-10 13:58:26 -07:00
Trask Stalnaker 79d5789d1d
Small gradle cleanup (#2935) 2021-05-10 10:14:23 -07:00
Trask Stalnaker 10db083e77
Update to OTel API/SDK 1.2.0 (#2945)
* Update to OTel API/SDK 1.2.0

* TCP.IP -> tcp_ip

* Fix smoke tests
2021-05-10 10:14:07 -07:00
Anuraag Agrawal 24998f5080
Raise gRPC version floor to 1.6 and use new context bridge API (#2948)
* Raise gRPC version floor to 1.6 and use new context bridge API

* Drift

* Drift
2021-05-10 16:33:48 +09:00
Trask Stalnaker cd3dd581f9
Fix some remote connection tests (#2933) 2021-05-10 12:19:39 +09:00
Trask Stalnaker 6a84c2b2ec
Remove unnecessary generic type args (#2937)
* Remove unnecessary generic type args

* Revert one
2021-05-10 12:18:30 +09:00
Nikita Salnikov-Tarnovski 83c7a40211
Fix potential test flakiness (#2943) 2021-05-09 17:04:44 -07:00
Trask Stalnaker 1dda1e2659
Clean up old references to continuation concept (#2934) 2021-05-09 19:29:37 +03:00
Trask Stalnaker 65995388e6
Clean up Java 7 references (#2931)
* Clean up Java 7 references

* Use Java 8 stuff!

* Spotless
2021-05-09 14:16:42 +03:00
Lauri Tulmin 6924656a60
Run tests with latest spring data version (#2927) 2021-05-07 11:31:30 -07:00
Mateusz Rzeszutek f2d7e0ed74
Fix compilation failure on main (#2926)
* Fix compilation failure on main

* Fix muzzle (probably)

* Fix muzzle (probably)

* Fix muzzle (probably)

* Fix muzzle (probably)

* Remove unnecessary dependency

* Revert "Remove unnecessary dependency"

This reverts commit 3fc1e68c99.

* spotless + random change in javaagent-tooling
2021-05-07 15:54:07 +03:00
Mateusz Rzeszutek 9c7fae3b04
Extract javaagent-extension-api from tooling & spi (#2879) 2021-05-06 23:30:25 -07:00