Trask Stalnaker
93175522d4
Rename kafka propagation setting and clarify behavior ( #6957 )
2022-10-24 08:49:48 -07:00
Trask Stalnaker
94e2248940
Use new semantic attribute constants ( #6946 )
2022-10-23 09:32:03 -07:00
Mateusz Rzeszutek
b6ded1f9a0
End reactor-netty HTTP client span properly on `Mono#timeout()` ( #6891 )
...
Calling `Mono#timeout()` with a timeout value smaller than the HTTP
client timeout caused the on request/response end callbacks to be simply
discarded; and the HTTP span was never finished.
2022-10-17 13:29:02 -07:00
jack-berg
fcd5876e1a
Add HTTP client and server tests ( #6836 )
...
Resolves #6835 .
2022-10-11 20:12:48 +00:00
jack-berg
d5aadbab04
Split out :instrumentation:netty:netty-4.1 library ( #6820 )
...
Resolves #6734 . Builds on #6811 .
2022-10-10 16:01:14 -07:00
Mateusz Rzeszutek
77035fc88c
Extract `net.peer.{name,port}` on start for CLIENT spans ( #6828 )
...
The [HTTP
spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client )
says these two attributes must be provided at span creation time - I
think it makes sense to extend it over to all `net`-related
instrumentations, cause these are supposed to be the logical peer
name/port, which are supposed to be known before the connection is
started/exchange is made.
2022-10-10 16:00:19 -07:00
jack-berg
1fcea2017b
Publish :instrumentation:netty:netty-4-common as library instrumentation ( #6811 )
...
Related to #6734 . Builds on #6805 .
I'll follow it up by splitting out `:instrumentation:netty:netty-4.1` in
a separate PR.
2022-10-06 08:50:25 -07:00
jack-berg
4c91ec9f42
Publish :instrumentation:netty:netty-common as library instrumentation ( #6805 )
...
Related to #6734 .
This first stage splits out the shared utilities in
`:instrumentation:netty:netty-common`. I'll follow it up by splitting
out `:instrumentation:netty:netty-4-common`,
`:instrumentation:netty:netty-4.1` in separate PRs. If there is
appetite, I can also split out library instrumentation for
`:instrumentation:netty:netty-4.0` and
`:instrumentation:netty:netty-3.8`, though I have no need for these.
2022-10-05 09:24:44 -07:00
jamesmartinpp
2cfaf2d7ee
Propagate client span context in doOnRequest ( #6621 )
...
Copying the changes from Mike W. This fixes the problem where the jaxrs
and http client request spans are siblings instead of parent/child.
@mateuszrzeszutek please review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-20 17:47:46 -07:00
Liudmila Molkova
97bc4a4fda
Reactor instrumentation: do not make root context current ( #6593 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-14 11:23:18 -07:00
Trask Stalnaker
512e9f700c
Optimize ReactorNettyNetClientAttributesGetter ( #6600 )
...
* Optimize ReactorNettyNetClientAttributesGetter
* Update
2022-09-13 08:33:23 -07:00
Mateusz Rzeszutek
f50f1fed3b
Fix instrumentation-api-semconv packages ( #6590 )
...
* Fix instrumentation-api-semconv packages
* Move test
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-12 14:51:27 -07:00
Mateusz Rzeszutek
cfdbe758f2
Net attributes getters changes (in preparation for HTTP spec impl) ( #6503 )
...
* Net attributes getters changes: instrumentation-api-semconv changes
* Net attributes getters changes: getter implementations
* Net attributes getters changes: test fixes
* Remove net.sock.host.name
* code review comments
* default getter methods & getPeerSocketAddress() method name
* set authority in grpc earlier
2022-09-12 09:20:27 -07:00
Mateusz Rzeszutek
892fb8a38e
Refactor Reactor-Netty 1.0 tests to Java ( #6497 )
2022-08-26 10:37:33 +02:00
Trask Stalnaker
f1774cabe2
Update net semantic convention changes ( #6268 )
...
* New net conventions: option a
* Feedback + sock.family + sock.peer.name
* peer.service + tests
* server net attributes attempt 1
* server net attributes attempt 2
* Javadoc
* Revisions
* Apply to instrumentations
* Feedback
* One more default method
* Spotless
* Fix javadoc
2022-08-18 09:02:23 -07:00
Mateusz Rzeszutek
6cd79b2a94
Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode() ( #6466 )
...
* Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode()
* fix liberty
2022-08-12 17:11:11 -07:00
Mateusz Rzeszutek
b2c90c79b5
Extract HTTP request & response content length from headers ( #6415 )
...
* Extract HTTP request & response content length from headers
* remove unused method
* fix camel tests
* fix google http client tests
* fix HttpUrlConnection tests
* fix k8s and jaxrs tests
* fix aws tests
* actually fix aws tests 🤞
* fix elasticsearch tests
* fix ratpack tests
* fix spring webflux tests
* fix vertx tests
* fix reactor netty tests
2022-08-05 10:55:47 -07:00
Trask Stalnaker
c3c4fb7101
Finish annotation move ( #6386 )
...
* Update tests with new annotation
* more
* Fix build
* More
2022-08-01 09:19:58 -07:00
Mateusz Rzeszutek
5a152cd289
Deprecate uncompressed content length HTTP attributes ( #6383 )
2022-07-29 06:17:38 +02:00
Mateusz Rzeszutek
82b39b1012
Rename `newInstrumenter()` into `buildInstrumenter()` ( #6363 )
...
* Rename newInstrumenter() into buildInstrumenter()
* spotless
2022-07-25 12:02:46 -07:00
Mateusz Rzeszutek
3af56e7d22
InstrumentationConfig part 3: HTTP headers and peer service mappings ( #6302 )
2022-07-15 14:52:52 -07:00
Trask Stalnaker
fb784aa877
Support new annotations (and change of instrumentation name for opentelemetry-annotations) ( #6296 )
...
* Support new annotations
* Consistency
* Simplify
* Annotation
* oops
2022-07-11 14:34:26 -07:00
Mateusz Rzeszutek
7bbe918008
InstrumentationConfig part 2 ( #6292 )
2022-07-11 09:47:19 +02:00
Lauri Tulmin
3726c54c40
Enable read timeout test for reactor netty ( #6156 )
2022-06-13 13:16:42 -07:00
Trask Stalnaker
d3be07eb1a
Better muzzle instrumentation exclusion ( #6044 )
...
* Better muzzle instrumentation exclusion
* set
2022-05-18 11:15:57 -07:00
Lauri Tulmin
4d79013a88
Fix sorting spans in reactor netty connection span tests ( #6061 )
...
* Fix sorting spans in reactor netty connection span tests
* revert changes for reactor-netty-0.9
2022-05-18 11:14:45 -07:00
Mateusz Rzeszutek
6a0ca530b7
Instrumentation API changes: VirtualField ( #6017 )
...
* Instrumentation API changes: VirtualField
* change class name in string constant
2022-05-12 11:17:24 -07:00
Mateusz Rzeszutek
87b412fb40
Instrumentation API changes: OperationMetrics, OperationListener ( #6016 )
...
* Instrumentation API changes: OperationMetrics, OperationListener
* errorprone
2022-05-12 11:16:46 -07:00
Trask Stalnaker
45d0518d69
Update netty 4 common package name ( #5991 )
2022-05-07 20:55:37 -07:00
Trask Stalnaker
cfe4a22307
Remove netty-4.1-common ( #5985 )
...
* Remove netty-4.1-common
* reactor-netty-1.0
2022-05-06 11:51:02 -07:00
Mateusz Rzeszutek
d919f84cf8
Merge javaagent-instrumentation-api into javaagent-extension-api ( #5936 )
...
* Merge javaagent-instrumentation-api into javaagent-extension-api
* remove some leftover references to javaagent-instrumentation-api
* add missing instrumentation-api to distro example
2022-04-28 20:11:15 -07:00
Mateusz Rzeszutek
e9fbb367b3
Rename netty `always-create-connect-span` property to `connection-tel… ( #5834 )
...
* Rename netty `always-create-connect-span` property to `connection-telemetry`
* formatting
* warn when deprecated property is used
* errorprone
2022-04-15 13:38:04 +02:00
Anuraag Agrawal
213057d057
Run check during testing and assemble during building ( #5619 )
2022-03-18 13:48:51 +09:00
Lauri Tulmin
8c6cd97cc7
Sort netty RESOLVE, CONNECT and SSL handshake spans ( #5394 )
2022-02-17 20:20:08 -08:00
Trask Stalnaker
186c657b4e
Avoid potential for reverse name lookup ( #5305 )
2022-02-07 17:39:16 -08:00
Trask Stalnaker
022914139e
test latest deps cleanup ( #5269 )
...
* test latest deps cleanup
* Revert currently irrelevant change
* Update instrumentation/lettuce/lettuce-4.0/javaagent/build.gradle.kts
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2022-02-01 09:49:07 -08:00
Mateusz Rzeszutek
8b767ac435
Refactor HTTP attributes extractors to use composition over inheritance ( #5267 )
...
* Refactor HTTP attributes extractors to use composition over inheritance
* Rename remaining variables: *Extractor to *Getter
2022-01-31 09:25:27 -08:00
Trask Stalnaker
23b33adb0a
Auto-format groovy files in Intellij ( #5260 )
...
* Auto-format groovy files in Intellij
* A bit of clean up
2022-01-28 09:29:46 -08:00
jason plumb
c5c0a2bcdf
NetClientAttributesAdapter - favor composition over inheritance ( #5030 )
...
* first pass at separating NetAttributesAdapter interface and make NetClientAttributesExtractor concrete
* rename the implementations extractor -> adapter
* hide constructor and make factory method
* rename to client and add javadoc
* spotless
* finish javadoc thought
* rebase
* renamed NetClientAttributesAdapter to NetClientAttributesGetter
* fix lettuce
* code review comments
* code review comments -- renaming for consistency
* adapter -> getter
* fix ratpack
* adapter -> getter
2022-01-20 10:51:13 -08:00
Anuraag Agrawal
ec375116be
Fix more lint warnings ( #5174 )
...
* Fix more lint warnings
* Redisable lint
* Drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-20 12:48:46 +09:00
Fabrizio Ferri-Benedetti
4d7a5d5062
Add settings docs for instrumentations ( #4981 )
...
* First commit
* Add other instrumentation docs
* Peer edits
* Update instrumentation/kafka/kafka-clients/README.md
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
* Update instrumentation/methods/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/netty/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/reactor/reactor-netty/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/servlet/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Fixes
* Update instrumentation/couchbase/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/rocketmq-client-4.8/README.md
Well spotted!
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/spring/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2022-01-03 10:24:48 -08:00
Trask Stalnaker
6884d66c09
Reduce top level instrumentation directories ( #4965 )
...
* akka
* dropwizard
* kafka
* reactor
* vertx
2021-12-22 10:16:13 -08:00