Commit Graph

96 Commits

Author SHA1 Message Date
Trask Stalnaker ffda571dd4
Remove deprecated HTTP library methods (#13150) 2025-02-01 08:05:03 +02:00
Trask Stalnaker c66816fa49
Rename setSetEmit... to internalSetEmit... (#13034) 2025-01-14 07:47:25 +02:00
Trask Stalnaker 1a506cb246
Document (and remove some) upper version test limits (#12945) 2024-12-27 08:54:10 -08:00
Trask Stalnaker e5a9d1cfb7
Change `setKnownMethods(Set)` to `setKnownMethods(Collection)` (#12902) 2024-12-24 10:29:15 -08:00
Trask Stalnaker 6b9e68ebfd
Change `setCaptured*Headers(List)` to `setCaptured*Headers(Collection)` (#12901) 2024-12-23 15:49:55 -08:00
Trask Stalnaker b08d272e23
Remove experimental methods out of (to-be-public) TelemetryBuilder classes (#12847) 2024-12-16 18:40:06 -08:00
Trask Stalnaker 4cc4e1c0b2
Consistent naming of addAttributesExtractor (#12860) 2024-12-10 12:45:20 -08:00
Gregor Zeitlinger b9f09cae88
Http server builder (#11651) 2024-10-07 09:41:24 -07:00
Lauri Tulmin bed7a6f07b
Read timeout in jetty http client tests (#12184) 2024-09-06 21:32:13 +03:00
Lauri Tulmin 7bb0c6bb85
Test whether http client span ends after headers or body is received (#12149) 2024-09-04 15:52:16 +03:00
Gregor Zeitlinger b00ccd7834
use DefaultHttpClientInstrumenterBuilder and DefaultHttpServerInstrumenterBuilder for armeria (#11797)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2024-08-14 17:37:24 -07:00
Liu Ziming 7f30056b57
support jettyclient 12 (#11519)
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2024-07-09 01:21:13 +00:00
Gregor Zeitlinger 0e218de455
Remove reflection from builder (#11673) 2024-06-27 07:38:54 +00:00
Gregor Zeitlinger 47ebb94253
re-use logic for http client configuration (#11620)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2024-06-21 16:58:41 -07:00
Lauri Tulmin de11929bea
Simplify jetty9 http client instrumentation (#11595) 2024-06-18 16:09:34 -07:00
Lauri Tulmin 4d3802a7ea
jetty9 http client: don't implement Response.CompleteListener (#11579) 2024-06-14 15:19:25 +03:00
Steve Rao 31c32a0d00
Add final modifier to the class in jetty-httpclient (#11522) 2024-06-03 14:38:05 +03:00
Lauri Tulmin 7a06507f80
Allow library instrumentations to override span name (#11355)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2024-05-17 12:10:32 +03:00
Lauri Tulmin a2d4148067
Remove http stable semconv tests (#10087) 2023-12-21 08:30:26 -08:00
Mateusz Rzeszutek 65ee9510f5
Rename the `instrumentation-api-semconv` module into `instrumentation-api-incubator` (#9985) 2023-12-04 08:28:10 +01:00
Mateusz Rzeszutek dc81aae72f
Move HTTP classes to instrumentation-api (#9977) 2023-12-01 12:04:06 +01:00
Mateusz Rzeszutek d6c2aff7c2
Change `http.request.body.size` and `http.response.body.size` attributes from recommended to opt-in (#9799) 2023-11-02 11:20:50 -07:00
Mateusz Rzeszutek b193ca00a1
Change `user_agent.original` from recommended to opt-in on HTTP client spans (#9776) 2023-10-30 17:20:10 +02:00
Matthieu MOREL 9a1c178d58
PeerService Resolver (#9061)
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: jason plumb <75337021+breedx-splk@users.noreply.github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-10-12 07:52:05 -07:00
Trask Stalnaker 3b77cc4b2d
Semconv 1.21 (#9408)
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-09-13 19:20:23 +00:00
Lauri Tulmin d157b68efb
Use HTTP instead of non-known method in http span name (#9441)
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-09-13 10:14:30 -07:00
Lauri Tulmin b9e459da07
Test http client stable semconv (#9178) 2023-08-13 10:22:04 -07:00
Mateusz Rzeszutek d81630331b
Make `HttpClientAttributesGetter` extend `NetClientAttributesGetter` (#9015) 2023-07-31 11:09:09 -07:00
pg.yang 976dfb2bc5
Convert jetty-httpclient Groovy tests to Java (#9072) 2023-07-31 11:43:14 +02:00
Mateusz Rzeszutek cabf0dfdf4
Refactor setKnownMethods() in HTTP instrumentations to avoid nullable… (#8994) 2023-07-23 20:03:14 -07:00
Mateusz Rzeszutek 59e2da5aa3
Extract HTTP client experimental metrics to a separate class (#8769) 2023-07-18 08:34:39 -07:00
Mateusz Rzeszutek cc8160cffb
Support the `http.request.method_original` attribute (#8779) 2023-07-17 09:41:41 +00:00
Mateusz Rzeszutek cde2e70148
Implement new stable server semantic conventions (#8663) 2023-06-13 11:07:59 +02:00
Mateusz Rzeszutek 506ccb6b7d
Implement new stable network semantic conventions (#8616) 2023-06-12 16:51:47 +02:00
Mateusz Rzeszutek 5b03ae655f
Implement new stable HTTP semantic conventions (#8632) 2023-06-08 20:02:45 -07:00
Mateusz Rzeszutek 8ee63d4441
Implement new stable URL semantic conventions (#8491) 2023-06-05 15:22:22 +00:00
Mateusz Rzeszutek c10108bbe0
Enable HTTP client read timeout tests by default (#8530) 2023-05-19 10:24:49 -07:00
Mateusz Rzeszutek e3944a53a5
Make net.transport an optional attribute (#8279) 2023-04-20 08:14:03 -07:00
OpenTelemetry Bot 22df5866b0
Update the OpenTelemetry SDK version to 1.25.0 (#8262)
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-04-10 18:12:57 -07:00
Mateusz Rzeszutek f501569106
Switch from http.flavor to net.protocol.* in HTTP client instrumentat… (#8131) 2023-04-07 13:39:42 +02:00
Lauri Tulmin a51535d08e
Test http client captured headers (#7993) 2023-03-07 20:05:29 +02:00
Mateusz Rzeszutek e1895e548c
Rename all methods in all Getters to use the `get*()` naming scheme (#7619)
Resolves #6562

This PR only contains renames; the actual content is in the `*Getter`
interfaces, the rest of changes is just IntelliJ doing its job.
2023-01-23 09:28:11 +00:00
jason plumb c5e384fe9f
Http testing refactor prework (#7623)
As part of discussions #7616, the idea of trying to do a more piecemeal
approach came up. A reasonable ask.

This is the first step in refactoring the http client tests. It factors
out the `HttpClientResult` inner class of the `AbstractHttpClientTest`
so that this can be reused by new test framework later. It also factors
the relevant abstract methods in the abstract class to a new type
adapter, which will also be reused.

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-01-20 18:20:42 +00:00
Lauri Tulmin e683fd9bee
Preserve original exception in jetty http client wrappers (#7455)
Same issue as in
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/7452
2022-12-21 09:26:44 +01:00
Mateusz Rzeszutek 95ec4a8c1f
HTTP semconv: filter out default peer/host ports (#7258)
After a loooong break, the next part of the HTTP semconv implementation:
filtering out default HTTP ports, client and server.

>  [5]: If not default (80 for http scheme, 443 for https).


https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client
2022-11-22 17:14:20 +00:00
Aaron Ai 3911cacfdc
Fix typos (#6961) 2022-10-24 09:06:01 -07:00
Mateusz Rzeszutek 77035fc88c
Extract `net.peer.{name,port}` on start for CLIENT spans (#6828)
The [HTTP
spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client)
says these two attributes must be provided at span creation time - I
think it makes sense to extend it over to all `net`-related
instrumentations, cause these are supposed to be the logical peer
name/port, which are supposed to be known before the connection is
started/exchange is made.
2022-10-10 16:00:19 -07:00
Mateusz Rzeszutek 714ba9189e
Remove deprecated `http.host` and `http.server_name` attributes (#6709)
... and make sure the `TemporaryMetricsView` follows the current spec
2022-09-24 11:02:21 -07:00
Trask Stalnaker 429ecfc713
Update error prone (#6646)
(note that change from BDDMockito is due to
https://github.com/google/error-prone/issues/3396)
2022-09-23 11:24:40 -07:00
Mateusz Rzeszutek f50f1fed3b
Fix instrumentation-api-semconv packages (#6590)
* Fix instrumentation-api-semconv packages

* Move test

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-12 14:51:27 -07:00