6eb8ae19df
Allow injection of helper bytecode as resources ( #9752 )
2023-11-06 09:37:52 -08:00
f811bf6840
Second attempt at fixing flaky spring rabbit test ( #9809 )
2023-11-06 16:50:16 +02:00
70e3962a87
Always set messaging operation ( #9791 )
2023-11-06 12:30:27 +02:00
702ae30076
feat: get route info in spring-cloud-gateway ( #9597 )
2023-11-03 09:40:35 -07:00
bf931abe74
Fix flaky spring webflux test ( #9802 )
2023-11-02 13:30:03 -07:00
d6c2aff7c2
Change `http.request.body.size` and `http.response.body.size` attributes from recommended to opt-in ( #9799 )
2023-11-02 11:20:50 -07:00
a1b849e168
Fix flaky spring rabbit test ( #9795 )
2023-11-02 08:42:22 -07:00
96d59d5539
Refactor HTTP server `server.address` and `server.port` attributes ( #9760 )
2023-10-30 08:55:30 +01:00
e6ec4f52ef
Make the JDBC driver config work with the OTel starter ( #9625 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-10-23 09:59:36 -07:00
e9026cd591
Deprecate old server/client socket getter methods ( #9716 )
2023-10-19 17:36:57 +02:00
9cb157492c
Replace `(client|server).socket.(address|port)` attributes with `network.(peer|local).(address|port)` ( #9676 )
2023-10-18 10:36:32 +00:00
3b08db75cd
convert spring-webflux groovy test to java ( #9677 )
...
Co-authored-by: Jean Bisutti <jean.bisutti@gmail.com>
2023-10-17 07:10:40 -07:00
e7db2c0246
Allow enabling receive telemetry in kafka library instrumentation ( #9693 )
2023-10-17 15:47:11 +02:00
48a19d7e54
fix typo in SprintJpaTest ( #9678 )
2023-10-13 09:35:20 -07:00
9a1c178d58
PeerService Resolver ( #9061 )
...
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: jason plumb <75337021+breedx-splk@users.noreply.github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-10-12 07:52:05 -07:00
de7cdcc22b
Run tests with java 21 ( #9620 )
2023-10-09 17:07:46 +03:00
553eaa576c
Spring webflux: add user spans as children of the controller span ( #9572 )
2023-09-28 21:25:34 +03:00
b464369253
Improve spring data reactive instrumentation ( #9561 )
2023-09-27 21:16:04 +03:00
7d2259742a
Transform inline advice to delegating advice and test indy modules ( #9508 )
2023-09-22 11:15:39 +03:00
e73118b434
Add Spring Boot service version finder / ResourceProvider ( #9480 )
2023-09-21 17:37:08 +02:00
d6c6e8a110
Support application.yaml files in SpringBootServiceNameDetector ( #9515 )
2023-09-21 15:33:10 +03:00
3136916749
Add HTTP server tests for non standard methods ( #9446 )
2023-09-15 08:43:36 -07:00
913bebb979
Fix deprecated buildDir warning in gradle scripts ( #9472 )
2023-09-15 08:43:57 +02:00
3b77cc4b2d
Semconv 1.21 ( #9408 )
...
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-09-13 19:20:23 +00:00
d157b68efb
Use HTTP instead of non-known method in http span name ( #9441 )
...
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-09-13 10:14:30 -07:00
f7128b0d59
Add null check ( #9434 )
2023-09-11 09:00:38 -07:00
cc4e1bf1ae
Update semconv to 1.21.0, PART 2 - HTTP ( #9372 )
2023-09-07 08:25:23 -07:00
323be549f5
Pin hibernate version in spring data latest dep tests ( #9366 )
2023-09-01 08:55:10 +02:00
133de2486a
Extract HTTP server experimental metrics to a separate class ( #9259 )
2023-08-30 08:49:42 -07:00
d7a34f90ba
Refactor and rename `HttpClientResend` and `HttpRouteHolder` ( #9280 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-08-26 00:37:25 +00:00
88961cc8ad
Remove outdated spring documentation ( #9248 )
2023-08-18 08:18:20 -07:00
23c20dadaf
Add http client test with non-standard request method ( #9204 )
2023-08-18 09:01:53 +03:00
d9f7cde77d
Remove outdated spring starter doc ( #9205 )
2023-08-15 16:23:16 +00:00
7e7d7ca866
Set http client read timeout only for the read timeout test ( #9194 )
2023-08-15 09:25:46 +03:00
b9e459da07
Test http client stable semconv ( #9178 )
2023-08-13 10:22:04 -07:00
849e0d5229
Combine two netty context attributes into one ( #9160 )
2023-08-10 13:39:25 +03:00
fc9229334f
Fix link do spring-integration docs ( #9174 )
2023-08-10 10:21:20 +02:00
bf000fef98
Netty 4.1: handle closing connection before the request completes ( #9157 )
2023-08-09 18:05:42 +03:00
27faf8f5b7
Make `HttpServerAttributesGetter` extend `NetServerAttributesGetter` ( #9088 )
2023-08-02 08:52:44 -07:00
d81630331b
Make `HttpClientAttributesGetter` extend `NetClientAttributesGetter` ( #9015 )
2023-07-31 11:09:09 -07:00
cabf0dfdf4
Refactor setKnownMethods() in HTTP instrumentations to avoid nullable… ( #8994 )
2023-07-23 20:03:14 -07:00
bd8ddf4db3
Allow overriding span name in spring web library instrumentation ( #8933 )
2023-07-21 13:45:05 +02:00
fd8e361e6c
Refactor Spring starter's instrumentation auto configuration classes ( #8950 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-07-21 11:35:41 +00:00
6e573289ae
Replace NetAttributes with SemanticAttributes ( #8992 )
2023-07-21 11:27:54 +02:00
aabd14fb6e
Apply Prettier to yaml files ( #8969 )
2023-07-20 02:54:31 +00:00
2bdddafdc4
Apply Prettier to markdown files ( #8968 )
2023-07-19 12:22:35 -07:00
59e2da5aa3
Extract HTTP client experimental metrics to a separate class ( #8769 )
2023-07-18 08:34:39 -07:00
cc8160cffb
Support the `http.request.method_original` attribute ( #8779 )
2023-07-17 09:41:41 +00:00
6f745e8f53
Include OTel appenders in the Spring Starter ( #8945 )
2023-07-13 12:56:56 +00:00
55368a52d7
Rename messaging operation "send" to "publish" per spec ( #8929 )
...
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-07-12 08:59:38 -07:00
8815952300
Initialize appenders in the spring boot starter ( #8888 )
...
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-07-11 08:47:01 -07:00
acbab58a46
Update the OpenTelemetry SDK version to 1.28.0 ( #8897 )
...
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-07-10 12:45:01 -07:00
029e187281
Refactor the `FallbackNamePortGetter` in preparation for `client.port` ( #8865 )
2023-07-05 10:10:05 -07:00
15337549e3
Adds spring-data test verifying error spans on JPA repository query failures ( #8857 )
2023-07-05 09:34:22 +02:00
f2799056f3
Correct class name in javadoc code snippet ( #8840 )
2023-06-30 08:17:33 -07:00
f25cd6354c
Convert spring rabbitmq tests from groovy to java ( #8765 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
Co-authored-by: SylvainJuge <763082+SylvainJuge@users.noreply.github.com>
Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>
2023-06-28 10:51:27 +02:00
4f12fba9c3
Implement new stable client semantic conventions ( #8704 )
2023-06-13 17:00:27 -07:00
cde2e70148
Implement new stable server semantic conventions ( #8663 )
2023-06-13 11:07:59 +02:00
bbb05276be
Update the OpenTelemetry SDK version to 1.27.0 ( #8688 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-06-13 12:02:11 +03:00
506ccb6b7d
Implement new stable network semantic conventions ( #8616 )
2023-06-12 16:51:47 +02:00
188d4c249a
Only instrument the actual Spring `TaskScheduler` implementations ( #8676 )
2023-06-12 08:01:29 +00:00
5b03ae655f
Implement new stable HTTP semantic conventions ( #8632 )
2023-06-08 20:02:45 -07:00
6b285b0df3
Use "micrometer" instrumentation name in the Spring Actuator instrume… ( #8677 )
2023-06-08 07:28:06 -07:00
84a818794b
OTLP log export for the OpenTelemetry Spring Starter ( #8493 )
...
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-06-07 17:06:34 -07:00
1263e47ec2
Fix JMS tests by disabling ActiveMQ Artemis persistence (2nd try) ( #8667 )
2023-06-07 16:58:44 +02:00
7b0918ef18
Fix JMS tests by disabling ActiveMQ Artemis persistence ( #8666 )
2023-06-07 14:48:45 +02:00
8ee63d4441
Implement new stable URL semantic conventions ( #8491 )
2023-06-05 15:22:22 +00:00
c74fa61b5d
Add wait strategy to the artemis container in spring jms 6 tests ( #8646 )
2023-06-05 11:07:01 +02:00
fa5d1744ed
Enable http pipelining test on spring webflux ( #8501 )
2023-06-02 18:35:00 +03:00
0ea2d7b8d8
Fix flaky spring rabbit test ( #8631 )
2023-06-01 17:23:21 +02:00
2c06c00c58
Support otel.sdk.disabled in the spring boot starter ( #8602 )
2023-06-01 10:48:06 +02:00
c4ee60dad4
Deprecate InetSocketAddressNetServerAttributesGetter and move its met… ( #8341 )
2023-05-29 10:04:32 +02:00
d8da949f09
Remove usages of classes shaded in testcontainers from tests ( #8551 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-05-23 18:38:52 +00:00
c10108bbe0
Enable HTTP client read timeout tests by default ( #8530 )
2023-05-19 10:24:49 -07:00
233ca9111d
feat: Added Spring's configuration annotation processor to produce th… ( #8516 )
2023-05-18 14:06:50 +03:00
8ba8082f44
Refactor resend/redirect tests in AbstractHttpClientTest so that they… ( #8500 )
2023-05-16 12:13:40 -07:00
48f85fb5f2
Replace target with path and query in HttpServerAttributesGetter ( #8382 )
2023-05-11 12:47:00 -07:00
d4c5164809
Add classLoaderMatcher() for Spring WebMVC instrumentations ( #8463 )
2023-05-11 10:10:51 +02:00
3122897b2e
Bump errorProneVersion from 2.18.0 to 2.19.0 ( #8459 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-05-10 09:49:55 -07:00
b09bddd6e4
Update gradle to 8.1.1 ( #8433 )
2023-05-07 09:28:30 +03:00
413890d246
Test http pipelining ( #8403 )
2023-05-04 10:23:48 +03:00
6295c67def
Fix a todo ( #8343 )
2023-04-24 20:49:30 -07:00
e87584fac6
change endpoint from enum to regular class ( #8325 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-04-24 16:31:32 +00:00
d1b7356ffe
AddingSpanAttributes annotation ( #7787 )
...
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-04-24 08:58:28 -07:00
0f258c669a
Use hasAttributesSatisfyingExactly instead of hasAttributesSatisfying ( #8336 )
2023-04-24 11:57:45 +02:00
ffb63d68eb
Fix nested http.route ( #8282 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-04-21 09:27:28 +02:00
e3944a53a5
Make net.transport an optional attribute ( #8279 )
2023-04-20 08:14:03 -07:00
22df5866b0
Update the OpenTelemetry SDK version to 1.25.0 ( #8262 )
...
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-04-10 18:12:57 -07:00
5b271c4917
Switch from http.flavor to net.protocol.* in HTTP server instrumentat… ( #8244 )
2023-04-09 08:47:33 -07:00
f501569106
Switch from http.flavor to net.protocol.* in HTTP client instrumentat… ( #8131 )
2023-04-07 13:39:42 +02:00
1cd634b341
Replace deprecated method ( #8230 )
2023-04-06 14:43:36 -07:00
7c9cf7ab1b
Spring scheduling: run error handler with the same context as task ( #8220 )
2023-04-06 08:39:33 -07:00
506ca93699
webflux 5.0 groovy to java tests part 2 ( #7776 )
...
@trask @mateuszrzeszutek hello, what do you think about
SingleThreadedSpringWebfluxTest, the test contains dependencies on new
reactor netty classes in testLatestDeps case. I tried use reflection for
rewriting the test to java but it was not trivial and I not reach the
result
---------
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-04-05 19:33:23 -07:00
46e5219f19
Remove some Optional usages ( #8190 )
...
I applied [this
comment](https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/8131#discussion_r1151076724 )
to the whole codebase and removed some `Optional`s that were used in the
hot path
2023-04-03 09:13:59 +02:00
d6271cccc7
Spring boot service name ( #8006 )
...
resolves #7998
---------
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-04-01 18:58:43 -07:00
a9fa5aacea
Add testcontainersBuildService to spring kafka tests that don't have it ( #8186 )
2023-03-31 10:26:06 +02:00
d8b0771929
Use the same kafka docker image in all kafka tests ( #8187 )
...
currently we use `confluentinc/cp-kafka:5.4.3` and
`confluentinc/cp-kafka:6.1.9`
2023-03-31 10:25:38 +02:00
b23af1bcfe
Convert spring-core tests from groovy to java ( #8166 )
...
Related to #7195 .
Converts spring core instrumentation tests from groovy to java.
---------
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-03-31 10:09:31 +02:00
d24d7986ad
Make spring boot service name detector handle BOOT-INF/classes ( #8101 )
...
When spring boot application is packaged in one jar
`application.properties` and `application.yml` are under
`BOOT-INF/classes/`.
2023-03-28 12:32:40 +02:00
aa2c2436c2
Convert spring-data tests from groovy to java ( #8124 )
...
Related to #7195 .
Converts spring data instrumentation tests from groovy to java.
2023-03-27 13:58:15 +02:00
bd3117b165
Fix flaky spring rabbit test ( #8015 )
...
https://ge.opentelemetry.io/scans/tests?search.buildOutcome=success&search.relativeStartTime=P28D&search.tags=CI&search.timeZoneId=Europe/Tallinn&tests.container=ContextPropagationTest&tests.sortField=FLAKY&tests.test=should%20propagate%20context%20to%20consumer%2C%20test%20headers:%20true&tests.unstableOnly=true
On jdk8 we can have 2 spans starting on the same millisecond.
2023-03-23 13:50:55 +02:00
4a87d6b0fd
Remove reference to Tracer bean from javadoc ( #8104 )
2023-03-22 12:59:51 +01:00
2cbfec8ac2
Fix spring boot 3 webmvc autoconfiguration ( #8051 )
...
Related to
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/8028#issuecomment-1466496896
spring boot 3 uses `jakarta.servlet` so we need to use
`WebMvcFilterAutoConfigurationSpring6 ` instead of
`WebMvcFilterAutoConfiguration`
2023-03-14 12:39:58 +01:00
2bd2bbcdee
Make the Spring autoconfiguration work with Spring Boot 3 ( #8028 )
...
This PR makes the Spring autoconfiguration work from Spring Boot 2.7.
[The way to declare autoconfiguration has indeed changed from Spring
Boot
2.7](https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7-Release-Notes#building-jars-with-maven-shade-plugin-and-gradle-shadow-plugin ).
A workaround is to use @EnableOpenTelemetry.
2023-03-13 17:15:19 +01:00
a793c247e6
Remove duplicate -Xmx from kafka memory options ( #8022 )
2023-03-09 22:02:33 +02:00
67b6b6cc7c
Limit kafka memory usage ( #8018 )
2023-03-09 16:37:09 +02:00
1649a90e29
Add protocol name&version to net attribute getters ( #7994 )
...
In preparation for
https://github.com/open-telemetry/opentelemetry-specification/pull/3272
2023-03-09 11:37:52 +00:00
998e781009
Remove deprecated messaging.url attribute from messaging getter ( #8008 )
2023-03-09 11:41:51 +01:00
3f45f755a9
Spring Webflux Library Instrumentation ( #7899 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7436
* Created new Module `spring-webflux-5.3` which contains only
server-side library instrumentation
* Minimum supported version is 5.3 because there are various problems in
older versions of reactor and webflux that prevent a few of the tests
from passing.
* Moved existing `spring-webflux-5.0` (webclient instrumentation) into a
common `spring-webflux` folder next to the 5.3 (server) instrumentation.
Moved the README to the parent folder so the docs are cohesive between
client/server instrumentation.
* Implemented `WebFilter` which instruments the server-side
* Depends on the `reactor-3.1` instrumentation to pass the context
around. Registers the react hook when it creates the `WebFilter`
* Tests using the standard HTTP server test suite
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-03-08 08:43:46 +01:00
a51535d08e
Test http client captured headers ( #7993 )
2023-03-07 20:05:29 +02:00
c721852d5f
Convert spring-jms tests to test suites ( #7945 )
...
Part of
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7911
2023-03-01 11:24:04 -08:00
85c541ef92
Implement kafka client id and consumer id attributes ( #7860 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7771
Adds `messaging.consumer_id` and `messaging.kafka.client_id` attributes
to kafka spans.
2023-02-21 07:31:28 -08:00
12ea869855
Implement `messaging.kafka.*` attributes spec (part 1) ( #7824 )
...
Part 1 of #7771
It's a lot more than I initially expected it to be; I'll introduce the
clientId attribute in part 2
2023-02-16 13:22:17 -08:00
d9b0eee503
Remove deprecated instrumentation-api-semconv code ( #7838 )
2023-02-16 13:16:52 -08:00
4fd52c5a7c
Encode version in library instrumentations' package names ( #7764 )
...
Another part of #932
In this PR I changed all the library instrumentation packages -- these
are breaking changes, so I figured the earlier we do this the less
painful it'll be to the users. I know that at least some of them are
actively used, so we'll need to spell this out in the release notes.
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-14 23:25:59 +00:00
ea237e3a80
Update HTTP span name extractors ( #7730 )
...
Implements
https://github.com/open-telemetry/opentelemetry-specification/issues/2998
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-14 07:40:05 -08:00
f074b93110
Update the OpenTelemetry SDK version to 1.23.0 ( #7800 )
...
Update the OpenTelemetry SDK version to `1.23.0`.
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-13 20:22:09 +00:00
c61996f5a4
Change Spring Scheduling to not capture span for one-time jobs (only repeated jobs) ( #7760 )
...
We are seeing examples where Spring Scheduling INTERNAL spans are
created inside of an existing parent span, which creates unnecessary
noise.
And these spans don't necessary make sense as these are not "background
jobs" (since they occur inside of an existing span).
(see for example
https://github.com/microsoft/ApplicationInsights-Java/issues/2870 )
This PR changes Spring Scheduling instrumentation to only instrumenting
repeating jobs, not one-time scheduled jobs (which corresponds to
ScheduledExecutorService behavior where context is not propagated to
runnable)
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-13 12:05:06 -08:00
54d7241c05
Fix autoconfigure for spring boot 3 ( #7784 )
...
See
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7312
2023-02-13 10:45:23 +01:00
c5649cc987
Document spring-rmi latest dep limit ( #7774 )
2023-02-09 17:07:24 +01:00
7993ef2433
Fix intellij warnings ( #7734 )
2023-02-06 09:21:30 +01:00
a9c065930d
Return interface instead of concrete implementation in instrumentatio… ( #7658 )
...
…n-api-semconv
We're already doing that for `SpanNameExtractor`, `OperationMetrics`,
`ContextCustomizer`, etc., so I figured we should do the same for
`AttributesExtractor` implementation. Also, none of the implementations
have any additional public surface - aside from the builder/factory
method users can just simply use the interface everywhere.
2023-01-31 13:21:28 +01:00
db6b764421
More HTTP testing refactor prework ( #7630 )
...
This is another follow-up from #7616 . This makes the test options class
immutable and uses `@AutoValue` and `@AutoValue.Builder`. As a result, a
bunch of the configuration/setup code for these said options now flings
around a builder instance. This isn't great, but I think it's an
incremental improvement that can be seen in the `@BeforeAll
AbstractHttpClientTest.setupOptions()` method, where the immutable
options are (finally) instantiated.
2023-01-23 09:42:32 -08:00
e1895e548c
Rename all methods in all Getters to use the `get*()` naming scheme ( #7619 )
...
Resolves #6562
This PR only contains renames; the actual content is in the `*Getter`
interfaces, the rest of changes is just IntelliJ doing its job.
2023-01-23 09:28:11 +00:00
9f9d6fee95
webflux 5.0 groovy to java tests part 1 ( #7625 )
...
I decided splitting changes on different PRs due to there are a lot of
lines of code in tests here and it should simplify review process.
Another option is I can add additional commit to this PR with conversion
of other groovy files.
2023-01-23 08:59:19 +01:00
c5e384fe9f
Http testing refactor prework ( #7623 )
...
As part of discussions #7616 , the idea of trying to do a more piecemeal
approach came up. A reasonable ask.
This is the first step in refactoring the http client tests. It factors
out the `HttpClientResult` inner class of the `AbstractHttpClientTest`
so that this can be reused by new test framework later. It also factors
the relevant abstract methods in the abstract class to a new type
adapter, which will also be reused.
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-01-20 18:20:42 +00:00
eaac709162
Update SQL span name for procedures ( #7557 )
...
This PR includes updates to the SQLSanitizer, DbClientSpanNameExtractor
and SqlStatementInfo to name spans according to procedure name for CALL
statements. The updates to the naming logic are in the SqlSanitizer and
table has been renamed to identifier as using the table variable for the
procedure name would not be idiomatic. SqlStatementInfo has been updated
so that the db.sql.table attribute is not included for procedures.
2023-01-19 11:01:36 -08:00
268165c668
Fix NoClassDefFoundError happening when snakeyaml is used on a custom JRE ( #7598 )
...
Fixes #7580
2023-01-19 10:30:18 -08:00
b2f42ec3fa
Encode version in spring instrumentations' package names ( #7608 )
...
Part of #932
I wanted to get this done before starting the spring boot starter v3
work.
2023-01-19 10:03:17 +00:00
d89932098a
Disable YodaCondition check and revert some of the changes ( #7596 )
...
Let's keep close to the SDK repo config.
I reverted some of the changes, only left those that I think make sense
anyway (e.g. comparing enums with `==`)
2023-01-17 19:44:15 -08:00
743df7b3da
Convert Spring Webflux client tests to Java; add library instrumentat… ( #7566 )
...
…ion tests
2023-01-17 11:53:24 +01:00
ca85a0db3d
Support Spring Web 6 in library instrumentation ( #7551 )
...
Part of
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7312
2023-01-12 21:08:15 -08:00
fadd29fa90
Fix build (merge conflict) ( #7559 )
...
Resolves #7558
2023-01-12 08:12:44 -08:00
fb5cf9fd97
Support Spring JMS 6.0 ( #7438 )
...
Part of #7203
The instrumentation is 100% copy-pasted, tests are rewritten from
scratch in Java because of way too many class name changes.
Depends on
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/7418
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-01-12 04:47:45 +00:00
09b63d2294
Use new reactor contextWrite when available (from reactor 3.4.0) ( #7538 )
...
Related to #7107 and #7202
Support WebFlux 6.
Supporting reactor 3.5 seems pretty straightforward, the
`subscriberContext()` was deprecated in 3.4 in favor of
`contextWrite()`. In 3.5, `subscriberContext()` was removed.
This PR doesn't bump `latestDepTestLibrary` to 3.5 yet because there are
a couple of tests that succeed in 3.4 using `contextWrite()` but fail in
3.5 using `contextWrite()`.
My proposal is to review/merge this PR, and then I can ping our resident
reactor experts to see if they have thoughts on the failing tests in
3.5.
2023-01-11 20:26:12 -08:00
f335861136
Bump errorProneVersion from 2.17.0 to 2.18.0 ( #7532 )
...
Bumps `errorProneVersion` from 2.17.0 to 2.18.0.
Updates `error_prone_annotations` from 2.17.0 to 2.18.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/error-prone/releases ">error_prone_annotations's
releases</a>.</em></p>
<blockquote>
<h2>Error Prone 2.18.0</h2>
<p>New Checkers:</p>
<ul>
<li><a
href="https://errorprone.info/bugpattern/InjectOnBugCheckers "><code>InjectOnBugCheckers</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/LabelledBreakTarget "><code>LabelledBreakTarget</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/UnusedLabel "><code>UnusedLabel</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/YodaCondition "><code>YodaCondition</code></a></li>
</ul>
<p>Fixes issues: <a
href="https://github-redirect.dependabot.com/google/error-prone/issues/1650 ">#1650</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/2706 ">#2706</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3404 ">#3404</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3493 ">#3493</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3504 ">#3504</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3519 ">#3519</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3579 ">#3579</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3610 ">#3610</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3632 ">#3632</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3638 ">#3638</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3645 ">#3645</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3646 ">#3646</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3652 ">#3652</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3690 ">#3690</a></p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/google/error-prone/compare/v2.17.0...v2.18.0 ">https://github.com/google/error-prone/compare/v2.17.0...v2.18.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="34730decfeee1e7778d3bb9ede9f257f459e14cda57309b018181f9918bc360ed99da2c06c7b8b6e0f5753f67bf36a502b5fhttps://github.com/google/error-prone/compare/v2.17.0...v2.18.0 ">compare
view</a></li>
</ul>
</details>
<br />
Updates `error_prone_core` from 2.17.0 to 2.18.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/error-prone/releases ">error_prone_core's
releases</a>.</em></p>
<blockquote>
<h2>Error Prone 2.18.0</h2>
<p>New Checkers:</p>
<ul>
<li><a
href="https://errorprone.info/bugpattern/InjectOnBugCheckers "><code>InjectOnBugCheckers</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/LabelledBreakTarget "><code>LabelledBreakTarget</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/UnusedLabel "><code>UnusedLabel</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/YodaCondition "><code>YodaCondition</code></a></li>
</ul>
<p>Fixes issues: <a
href="https://github-redirect.dependabot.com/google/error-prone/issues/1650 ">#1650</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/2706 ">#2706</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3404 ">#3404</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3493 ">#3493</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3504 ">#3504</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3519 ">#3519</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3579 ">#3579</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3610 ">#3610</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3632 ">#3632</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3638 ">#3638</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3645 ">#3645</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3646 ">#3646</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3652 ">#3652</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3690 ">#3690</a></p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/google/error-prone/compare/v2.17.0...v2.18.0 ">https://github.com/google/error-prone/compare/v2.17.0...v2.18.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="34730decfeee1e7778d3bb9ede9f257f459e14cda57309b018181f9918bc360ed99da2c06c7b8b6e0f5753f67bf36a502b5fhttps://github.com/google/error-prone/compare/v2.17.0...v2.18.0 ">compare
view</a></li>
</ul>
</details>
<br />
Updates `error_prone_test_helpers` from 2.17.0 to 2.18.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/error-prone/releases ">error_prone_test_helpers's
releases</a>.</em></p>
<blockquote>
<h2>Error Prone 2.18.0</h2>
<p>New Checkers:</p>
<ul>
<li><a
href="https://errorprone.info/bugpattern/InjectOnBugCheckers "><code>InjectOnBugCheckers</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/LabelledBreakTarget "><code>LabelledBreakTarget</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/UnusedLabel "><code>UnusedLabel</code></a></li>
<li><a
href="https://errorprone.info/bugpattern/YodaCondition "><code>YodaCondition</code></a></li>
</ul>
<p>Fixes issues: <a
href="https://github-redirect.dependabot.com/google/error-prone/issues/1650 ">#1650</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/2706 ">#2706</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3404 ">#3404</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3493 ">#3493</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3504 ">#3504</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3519 ">#3519</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3579 ">#3579</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3610 ">#3610</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3632 ">#3632</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3638 ">#3638</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3645 ">#3645</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3646 ">#3646</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3652 ">#3652</a>,
<a
href="https://github-redirect.dependabot.com/google/error-prone/issues/3690 ">#3690</a></p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/google/error-prone/compare/v2.17.0...v2.18.0 ">https://github.com/google/error-prone/compare/v2.17.0...v2.18.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="34730decfeee1e7778d3bb9ede9f257f459e14cda57309b018181f9918bc360ed99da2c06c7b8b6e0f5753f67bf36a502b5fhttps://github.com/google/error-prone/compare/v2.17.0...v2.18.0 ">compare
view</a></li>
</ul>
</details>
<br />
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-01-11 20:25:46 -08:00
cd470080b7
Support spring-data 3.0 (test only) ( #7376 )
...
Part of #7203
2023-01-11 20:10:38 -08:00
ca310b4ddb
Support Spring Web MVC in library instrumentation ( #7552 )
...
Part of
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7312
This is pretty much a copy of the `spring-webvmc-5.3:library` module
with `s/javax/jakarta/` applied. I'm planning on removing the 5.3
instrumentation after #7312 is done.
2023-01-11 17:22:55 -08:00
30de9ff266
Disable internal TaskScheduler spans in Spring Kafka instrumentation ( #7553 )
...
Resolves #7511
I used the same pattern we already have for suppressing the wrapping of
the Kafka consumer records lists.
2023-01-11 17:19:43 -08:00
789b66d455
Bump spotless-plugin-gradle from 6.12.0 to 6.12.1 ( #7500 )
...
Bumps [spotless-plugin-gradle](https://github.com/diffplug/spotless )
from 6.12.0 to 6.12.1.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="718a504c12c13acee213552aabf876https://github-redirect.dependabot.com/diffplug/spotless/issues/1421 ">#1421</a>)</li>
<li><a
href="4063e9f6d1https://github-redirect.dependabot.com/diffplug/spotless/issues/1432 ">#1432</a>
fixes <a
href="https://github-redirect.dependabot.com/diffplug/spotless/issues/1430 ">#1430</a>)</li>
<li><a
href="062e8358468f7e00594d9a8ccae9ecfb4277d2b1b44d70d00ab3d8e89002https://github.com/diffplug/spotless/compare/gradle/6.12.0...gradle/6.12.1 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-01-03 09:58:06 +00:00
8c64a9e6e1
Fix class file load error when using spring-guice together with sprin… ( #7447 )
...
…g-web instrumentation
Fixes
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7428
2023-01-02 11:00:51 +01:00
1eb0477acd
Limit spring-cloud-stream version ( #7442 )
2022-12-17 08:18:15 -08:00
7b87423571
Skip muzzle for broken spring-web versions ( #7435 )
2022-12-15 22:02:22 +00:00
2602cf681a
Add serlvet filter test to spring-webmvc-6.0 ( #7406 )
2022-12-15 09:07:42 +01:00
17e1e22072
Correct annotation name in spring-boot-autoconfigure readme ( #7394 )
2022-12-13 08:40:23 +01:00
33c7ce927e
spring-webmvc-6.0: skip muzzle check of broken versions ( #7395 )
...
https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/runs/3679126152/jobs/6223205591
copied the excludes from spring-webmvc-3.1
2022-12-12 22:42:56 +00:00
f3a21e86f5
Allow disabling muzzle checks for specific methods ( #7289 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/2556
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7265
made me wonder whether it would help when we could sometimes skip muzzle
checks.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-12-12 21:18:17 +00:00
d971e26501
Extract a common JMS module before implementing Jakarta JMS instrumen… ( #7377 )
...
…tation
We need to instrument Jakarta JMS (3.0) before instrumenting Spring JMS
6.0
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-12-12 10:22:00 -08:00
59b7513cd0
Instrument spring-web 6 & spring-webmvc 6 ( #7366 )
...
Part of #7203
This PR is mostly copy-paste and working around the differences,
conceptually the new instrumentation is the same as the old one
2022-12-12 09:31:08 -08:00
4856377642
Support spring-scheduling 6.0 (test only) ( #7375 )
...
Part of #7203
2022-12-09 17:13:54 -08:00
ebb0141032
Populate `messaging.kafka.message.offset` in all kafka instrumentations ( #7374 )
2022-12-09 17:13:31 -08:00
17b3fdb04a
Make preparations for Spring Web & WebMVC 6 instrumentations ( #7343 )
...
Just moving things around, extracting parent dir for `spring-web` and
`spring-webmvc`
2022-12-01 13:08:32 +01:00
69938b3f79
Support Spring Kafka 3 ( #7271 )
...
Fixes #7265
I took a look at the new Observation API, and I think that it still
makes sense to continue using the interceptors to implement this
instrumentation: they implement the OTel spec (which includes way more
attributes than the default observation convention implemented in
Spring), and cooperate with the Kafka client instrumentation and link
the receive and process spans together. And it's quite a simple change
in one of our interceptors, instead of rewriting everything.
(Draft because Spring Boot 3 hasn't released yet, and it is required to
run the tests. If we're not in a hurry this PR can wait a bit for that)
2022-11-29 12:07:57 +02:00
2b8f13830a
Limit spring boot version in grails latest dep tests ( #7310 )
...
Fixes #7309
Fixes #7308
2022-11-25 15:14:09 +01:00
6ea1c2414a
Limit Spring Batch versions and exclude newly released 5.0 ( #7305 )
2022-11-24 14:08:12 +01:00
88c79ee3f5
Temporarily limit latest dependency tests for spring-integration ( #7278 )
...
Created tracking issue for supporting version 6+: #7277
Resolves #7276
Resolves #7286
2022-11-22 20:55:26 -08:00
05471b053b
Webflux instrumentation fix ( #7251 )
...
When a webflux filter is added which throws an exception, the
instrumentation does not currently capture the `http.status_code`.
The fix is to move `WebClientTracingFilter` from the first to the last
filter in the chain, which I think(?) is the general strategy we've
taken for other client instrumentation, e.g. so that if a filter makes
another http call it won't be suppressed.
I don't love the test coverage I added, so let me know if you have any
better suggestions?
EDIT: btw, I did archaeology to confirm that behavior (adding to the
beginning of the chain) has been in place since the webflux
instrumentation was added originally
6f472a62a0 (diff-493ad89b5bde807c90387aa2bb67eb10d3bcef6b6a388bd31e11796a6d01ac38R36)
2022-11-22 15:09:22 -08:00
95ec4a8c1f
HTTP semconv: filter out default peer/host ports ( #7258 )
...
After a loooong break, the next part of the HTTP semconv implementation:
filtering out default HTTP ports, client and server.
> [5]: If not default (80 for http scheme, 443 for https).
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client
2022-11-22 17:14:20 +00:00
ae49d4f642
Fix rabbitmq latest deps test ( #7262 )
...
Resolves #7269
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-11-21 20:24:40 -08:00
94ba33e395
Use contrib AwsXrayPropagator ( #7234 )
...
Reflects move of `AwsXrayPropagator` to
[opentelemetry-java-contrib/aws-xray-propagator](https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/aws-xray-propagator ).
2022-11-21 11:31:17 -08:00
4379cfbeec
Limit latest dep spring data version ( #7237 )
...
Spring data 3 depends on spring 6
2022-11-18 11:44:36 -08:00
61ed2d14db
Update SDK version ( #7223 )
...
Resolves #7221
Resolves #7222
2022-11-18 18:13:39 +00:00
2d7395c44b
Introduce markdown lint check ( #7175 )
...
Fixes #7129
2022-11-16 20:48:42 -08:00
51f0e17a63
Temporarily limit instrumentation to exclude Spring 6 ( #7202 )
...
Tracking issue to support Spring 6 #7203
2022-11-16 22:36:48 +00:00
2107109d0d
Avoid NPE when DirectWithAttributesChannel class is not available ( #7133 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7123
2022-11-11 10:46:34 -08:00
597b2a5321
More spotless ( #7126 )
2022-11-11 05:01:21 +00:00
5345c87680
End groovy files with newline ( #7127 )
2022-11-10 12:21:55 +01:00
d40377bbd7
Add muzzle limits to fix CI ( #7106 )
...
~I'll create a tracking issue to remove these and support new versions.~
Tracking issue added to support latest project reactor 3.5.0 and revert
these limits: #7107
2022-11-08 13:05:57 -08:00
71b3e3e027
Library doc cleanup ( #6948 )
...
Related to #6947 , but just cleans up the library module doc that already
existed (mostly for uniformity). Does not introduce any new doc.
2022-10-24 10:26:21 -07:00
93175522d4
Rename kafka propagation setting and clarify behavior ( #6957 )
2022-10-24 08:49:48 -07:00
94e2248940
Use new semantic attribute constants ( #6946 )
2022-10-23 09:32:03 -07:00
33b06889fa
Auto-detect service name based on the jar name ( #6817 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-10-22 18:10:21 -07:00
397a5a89b5
fix spring-webflux cast to PathPattern throws ClassCastException ( #6872 )
...
when
ServerWebExchange.getAttributes().put(HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE,
"path string type").
opentelemetry javaagent will throw exception.
[企业微信截图_76344afd-4541-482c-a90f-0606ad720351](https://user-images.githubusercontent.com/15957476/195615160-45559fb5-5e0c-4c25-8678-7d8aa603f346.png )
2022-10-21 10:35:33 +02:00
f488d94403
Capture net.host.name for netty ( #6892 )
...
This may be a regression in 1.19.0 because you can no longer reconstruct
the original url for netty server spans (previously `http.host` was
captured which could be used).
2022-10-19 09:21:50 -07:00
aeac361816
Upgrade to otel java 1.19.0 ( #6757 )
...
Working PR to capture all the changes required to update to otel java
1.19.0. The new log API force allows
`:instrumentation-appender-api-internal` and
`:instrumentation-appender-sdk-internal`, but necessitates a decent
amount of refactoring as a result.
The PR points at the `1.19.0-SNAPSHOT`, which I'll update upon
publication.
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2022-10-12 09:19:37 -07:00
77035fc88c
Extract `net.peer.{name,port}` on start for CLIENT spans ( #6828 )
...
The [HTTP
spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client )
says these two attributes must be provided at span creation time - I
think it makes sense to extend it over to all `net`-related
instrumentations, cause these are supposed to be the logical peer
name/port, which are supposed to be known before the connection is
started/exchange is made.
2022-10-10 16:00:19 -07:00
6f6af66c04
Update to slf4j 2.0.2 ( #6774 )
...
~testLatestDeps is failing, see #6791~
2022-10-06 01:28:53 +00:00
0d32150059
Assert on instrumentation version ( #6773 )
...
To catch issues like #6770
2022-09-29 10:53:10 +03:00
5e2df2b81f
Run integration tests against Java 19 ( #6690 )
...
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2022-09-24 12:31:15 -07:00
714ba9189e
Remove deprecated `http.host` and `http.server_name` attributes ( #6709 )
...
... and make sure the `TemporaryMetricsView` follows the current spec
2022-09-24 11:02:21 -07:00
429ecfc713
Update error prone ( #6646 )
...
(note that change from BDDMockito is due to
https://github.com/google/error-prone/issues/3396 )
2022-09-23 11:24:40 -07:00
e994f8f840
Add classLoaderMatcher() for the spring-boot-actuator-autoconfigure i… ( #6695 )
...
…nstrumentation
See #6636
2022-09-22 09:53:19 -07:00
5224194740
Move versions to dependencyManagement ( #6648 )
...
Part of #6645
2022-09-19 12:05:06 +03:00
2f344d3689
Fix new properties ( #6633 )
...
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2022-09-18 13:59:51 +03:00
e51eda26b6
Mitigates GHSA-9w3m-gqgf-c4p9 ( #6642 )
2022-09-18 12:34:32 +03:00
97bc4a4fda
Reactor instrumentation: do not make root context current ( #6593 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-14 11:23:18 -07:00
5afd6b346b
Fix spring boot @WithSpan handling ( #6619 )
2022-09-14 09:29:13 -07:00
d5c6453636
Remove external usages of ClassNames (and move it to internal) ( #6584 )
...
* Reduce dependency on simpleName
* Move ClassNames to internal
* Javadoc
* Updates
* Fix
* Spotless
* Rename
* Add test
2022-09-13 13:58:19 -07:00
e8e573c2ee
Add experimental span attribute job.system ( #6586 )
...
* Add experimental span attribute job.system
* spring-batch
2022-09-13 07:22:43 -07:00
9081ced1ea
Use ConditionalResourceProvider in the Spring Boot service name provider ( #6587 )
...
* Use ConditionalResourceProvider in the Spring Boot service name provider
* make it a bit simpler
* add order=100
* add comment
* spellcheck
2022-09-13 07:20:09 -07:00
f50f1fed3b
Fix instrumentation-api-semconv packages ( #6590 )
...
* Fix instrumentation-api-semconv packages
* Move test
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-12 14:51:27 -07:00
cfdbe758f2
Net attributes getters changes (in preparation for HTTP spec impl) ( #6503 )
...
* Net attributes getters changes: instrumentation-api-semconv changes
* Net attributes getters changes: getter implementations
* Net attributes getters changes: test fixes
* Remove net.sock.host.name
* code review comments
* default getter methods & getPeerSocketAddress() method name
* set authority in grpc earlier
2022-09-12 09:20:27 -07:00
ae209d9289
Rename ErrorCauseExtractor.jdk() to getDefault() ( #6580 )
...
* Rename ErrorCauseExtractor.jdk() to ErrorCauseExtractor.getDefault()
* jApiCmp
2022-09-12 17:36:34 +03:00
af61a8b578
Update to otel 1.18.0 ( #6575 )
2022-09-11 10:35:05 -07:00
f63eae5ad0
Add gradle plugin for SDK extensions ( #6558 )
2022-09-08 15:06:32 -07:00
6d22758ac2
Use micrometer library instrumentation in agent ( #6560 )
...
* Use micrometer library instrumentation in agent
* PR feedback
2022-09-08 09:34:20 -07:00
61fd14fde1
Fix spring webmvc instrumentation name ( #6557 )
2022-09-08 11:15:48 +02:00
56f4e52a64
Add Spring Boot service name guesser / ResourceProvider ( #6516 )
...
* Add spring boot service name guesser.
* add encoding
* improve commandline handling
* move guesser to own module
* use readAllBytes which exists in java 8
* spotless
* add note and link to spring docs
* group for readability
* repackage
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* code review comments
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-09-07 08:15:47 -07:00
abf601c678
Refactor RestTemplate tests to Java ( #6485 )
2022-08-22 09:48:16 +02:00
f1774cabe2
Update net semantic convention changes ( #6268 )
...
* New net conventions: option a
* Feedback + sock.family + sock.peer.name
* peer.service + tests
* server net attributes attempt 1
* server net attributes attempt 2
* Javadoc
* Revisions
* Apply to instrumentations
* Feedback
* One more default method
* Spotless
* Fix javadoc
2022-08-18 09:02:23 -07:00
4605be3241
Disable crashing tests on openj9 18 ( #6481 )
2022-08-17 09:21:18 -07:00
5862ace233
Tweak naming of spring autoconfigure and starter modules ( #6453 )
2022-08-15 22:07:08 -07:00
6cd79b2a94
Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode() ( #6466 )
...
* Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode()
* fix liberty
2022-08-12 17:11:11 -07:00
faa99b2eeb
Update SDK to 1.17.0 ( #6467 )
...
* Update SDK to 1.17.0
* Fix
* Update licenses
* Spotless
* license
2022-08-12 17:10:46 -07:00
08f013f9d6
Update gradle to 7.5.1 ( #6359 )
...
* Update gradle to 7.5
* Bump to 7.5.1
* gradle 7.5.1 with jdk17
* spotless
* one more --add-opens
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2022-08-12 12:03:43 +02:00
07d7cfd551
Capture messaging header value as span attribute ( #6454 )
...
* Capture messaging header value as span attribute
* add comment
2022-08-11 17:28:04 -07:00
68a9f20eb3
Enable PrivateConstructorForUtilityClass errorprone check ( #6427 )
...
* PrivateConstructorForUtilityClass
* Advice
* More advice
* More
* More advice
* More
* Spotless
* Fix
* Fix
* Fix
* A better solution
* Revert
* More
* Fix
* Spotless
* Fix
2022-08-10 11:30:22 +03:00
0d1cc8ea0a
Set http.route in spring-autoconfigure webmvc instrumentation ( #6414 )
...
* Set http.route in spring-autoconfigure webmvc instrumentation
* Bump spring-webmvc library instrumentation version to 5.3
* nit: protected -> private
* Remove duplicated test (already covered by HttpSpanStatusExtractorTest)
* Move the README to the correct module
* fix link
* fix more links
* liiiiiiinks
* fix tests
* remove not needed weakref
2022-08-09 09:36:28 -07:00
5d6465fe0f
Simplify a couple of type matchers ( #6438 )
2022-08-08 08:30:11 -07:00
b2c90c79b5
Extract HTTP request & response content length from headers ( #6415 )
...
* Extract HTTP request & response content length from headers
* remove unused method
* fix camel tests
* fix google http client tests
* fix HttpUrlConnection tests
* fix k8s and jaxrs tests
* fix aws tests
* actually fix aws tests 🤞
* fix elasticsearch tests
* fix ratpack tests
* fix spring webflux tests
* fix vertx tests
* fix reactor netty tests
2022-08-05 10:55:47 -07:00
faa367395f
Fix @WithSpan in spring autoconfigure ( #6398 )
2022-08-02 09:37:40 +02:00
61aef2e413
Clean up spring-boot-autoconfigure exporter logic ( #6374 )
2022-08-02 09:35:19 +02:00
c3c4fb7101
Finish annotation move ( #6386 )
...
* Update tests with new annotation
* more
* Fix build
* More
2022-08-01 09:19:58 -07:00
9e460e28ef
Fix build ( #6389 )
2022-07-31 10:50:42 +03:00
cf313eb361
Bump Spring Boot version for autoconfigure and starters ( #6379 )
2022-07-29 13:25:57 +02:00
5a152cd289
Deprecate uncompressed content length HTTP attributes ( #6383 )
2022-07-29 06:17:38 +02:00
54b8b6af89
Add Kafka instrumentation to the Spring Boot starter ( #6371 )
2022-07-28 12:44:53 +02:00
561ce5e3cc
Support new @WithSpan annotation in spring-boot-autoconfigure ( #6378 )
2022-07-28 11:48:59 +02:00
6a24080fe9
Add code attributes to several instrumentations ( #6365 )
...
* Add code attributes to several instrumentations
* fix servlet tests
* fix tests
* fix elasticsearch tests
* fix context bridge test
* fix rxjava tests
* fix spring webmvc tests
2022-07-27 09:37:01 +02:00
82b39b1012
Rename `newInstrumenter()` into `buildInstrumenter()` ( #6363 )
...
* Rename newInstrumenter() into buildInstrumenter()
* spotless
2022-07-25 12:02:46 -07:00
8be51b3dde
Fix spring kafka latest dep tests ( #6339 )
2022-07-19 08:04:08 -07:00
b917b3bf9c
Use ConfigProperties instead of Config in the agent code ( #6322 )
...
* Use ConfigProperties instead of Config in the agent code
* Fix merge conflict
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-07-18 19:04:48 -07:00
5bc7abf178
Spring Kafka library instrumentation ( #6283 )
...
* Spring Kafka library instrumentation
* Merge and fix prior merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-07-18 14:38:44 -07:00
3af56e7d22
InstrumentationConfig part 3: HTTP headers and peer service mappings ( #6302 )
2022-07-15 14:52:52 -07:00
2a59d0faee
Add (more) Spring JMS support ( #6308 )
...
* Add (more) Spring JMS support
* Remove duplication
* Better advice matcher
2022-07-13 15:37:26 -07:00
b23db97a28
Use ConfigProperties in javaagent SPIs ( #6285 )
...
* Use ConfigProperties in javaagent SPIs
* remove deprecated
* errorprone
* fix javaagent build
* fix javaagent-tooling tests
* spotless
2022-07-12 08:41:01 +02:00
7bbe918008
InstrumentationConfig part 2 ( #6292 )
2022-07-11 09:47:19 +02:00
177f0aec7c
Rename instrumentation-api-annotation-support ( #6288 )
2022-07-08 17:07:41 -07:00
e7887ac929
Idea: deprecate `Config`, add agent-only `InstrumentationConfig` ( #6264 )
...
* Idea: deprecate Config, add agent-only InstrumentationConfig
* fix
* fix camel test
* fix external-annotation tests
2022-07-08 16:20:49 +02:00
9058ad6f40
Add metrics & micrometer support to spring-boot-autoconfigure ( #6270 )
...
* Add metrics & micrometer support to spring-boot-autoconfigure
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* code review comments
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-07-07 07:51:25 -07:00
f3f2e61542
Add api dep on "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure-spi" ( #6254 )
2022-07-04 10:21:39 +02:00
f38939134c
Correct spelling of opentelemetry-exporter-logging ( #6253 )
2022-07-01 21:09:04 +03:00
701ed54311
Use "class loader" instead of "classloader" consistently in docs and comments ( #6236 )
...
* Use "class loader" consistently instead of classloader
* Java comments too
* Fix bad merge
2022-06-30 14:57:07 -07:00
4f7c2416fd
Fix deprecated gradle warnings ( #6221 )
2022-06-27 10:22:58 -07:00
71e19d83e4
Show correct runnable name in spring scheduling actuator ( #6140 )
...
* Show correct runnable name in spring scheduling actuator
* spotless
2022-06-08 13:34:55 +03:00
a54631f00e
Centralize all plugin versions ( #6064 )
2022-05-18 20:22:24 -07:00
6a0ca530b7
Instrumentation API changes: VirtualField ( #6017 )
...
* Instrumentation API changes: VirtualField
* change class name in string constant
2022-05-12 11:17:24 -07:00
87b412fb40
Instrumentation API changes: OperationMetrics, OperationListener ( #6016 )
...
* Instrumentation API changes: OperationMetrics, OperationListener
* errorprone
2022-05-12 11:16:46 -07:00
d1ee692479
Update to OTel 1.14 ( #5999 )
...
* Update to OTel 1.14
* Fix test
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-05-10 14:23:56 -07:00
2fad192fc1
Implement vertx-kafka-client instrumentation; batch processing ( #5982 )
...
* Implement vertx-kafka-client instrumentation; batch processing
* try-finally just in case
* Add to supported libraries list
* Update instrumentation/vertx/vertx-kafka-client-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/v3_6/InstrumentedBatchRecordsHandler.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-05-10 12:00:54 +02:00
802f5aa3ea
Instrumentation API and Javadoc cleanup ( #5954 )
2022-05-09 22:13:45 -07:00
30945cc85e
Remove unused SLF4J_VERSION ( #5964 )
2022-05-02 19:12:08 -07:00
47128f3a3d
Wait a bit before retrying ( #5965 )
2022-05-02 19:11:59 -07:00
d919f84cf8
Merge javaagent-instrumentation-api into javaagent-extension-api ( #5936 )
...
* Merge javaagent-instrumentation-api into javaagent-extension-api
* remove some leftover references to javaagent-instrumentation-api
* add missing instrumentation-api to distro example
2022-04-28 20:11:15 -07:00
72a4637d0e
Fix flaky spring batch test ( #5935 )
...
* Fix flaky spring batch test
* set only completion policy
2022-04-27 10:23:22 -07:00
1345a6665e
Test spring-kafka instrumentation with receive telemetry disabled ( #5913 )
...
* Test spring-kafka instrumentation with receive telemetry disabled
* checkstyle and code review comment
2022-04-25 15:56:55 +02:00
7d5555432c
Refactor KafkaInstrumenterFactory a bit ( #5911 )
2022-04-22 08:34:26 -07:00
28825724db
Spring-kafka single record instrumentation ( #5904 )
2022-04-21 14:42:49 -07:00
4e3f19d469
Enable span suppression by SpanKey by default ( #5779 )
...
* Enable span suppression by SpanKey by default
* fix HTTP tests (probably)
* add exception for camel
* remove suppression tests from @WithSpan instrumentations
* remove suppression tests from @WithSpan instrumentation; spring boot autoconfigure
* fix twilio tests
* fix netty-based HTTP clients, remove AWS SDK 1.11 unit test
* fix elasticsearch tests
* codenarc
* spotless
* fix AWS SDK 1.11 tests
* remove a TODO
* code review comments
* fix merge conflict
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-04-19 14:13:09 -07:00
0d92a21f37
Rename javaagent executor package names ( #5847 )
...
* Rename package javaconcurrent -> executors
* Rename package concurrent -> executors
2022-04-18 22:15:28 -07:00
Jonas Kunz
Lauri Tulmin
Liu Ziming
Mateusz Rzeszutek
Jean Bisutti
Liu Ziming
Matthieu MOREL
Hayanesh
Trask Stalnaker
jason plumb
OpenTelemetry Bot
Steven Swartz
Abhinandan Seshadri
Kevin Loveland
dependabot[bot]
Helen
siyuniu-ms
sfriberg
Andrei Chugunov
adamleantech
Abhinandan Seshadri
James Moessis
Alex Kats
jack-berg
Aaron Ai
王展城
Liudmila Molkova
mingchuno
Lauri Tulmin
Anuraag Agrawal
