c10108bbe0
Enable HTTP client read timeout tests by default ( #8530 )
2023-05-19 10:24:49 -07:00
079e0faa2d
Add HttpServerResponseCustomizer support for Netty ( #8094 )
...
Add `HttpServerResponseCustomizer` support for Netty 3.8, 4.0 and 4.1
instrumentations and enable testing for it in their respective
`HttpServerTest` tests.
2023-03-23 11:11:24 +01:00
ea237e3a80
Update HTTP span name extractors ( #7730 )
...
Implements
https://github.com/open-telemetry/opentelemetry-specification/issues/2998
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-14 07:40:05 -08:00
a2d5302acc
Netty refactoring ( #7738 )
...
~Built on top of other netty PRs, will rebase after those are merged.~
2023-02-07 20:26:18 -08:00
7be766a78b
Remove write context ( #7735 )
...
~(currently built on top of #7732 )~
2023-02-06 17:34:12 +00:00
b9918ab513
End netty client span before callbacks ( #7737 )
...
netty 3.8 already ends client span before callbacks:
b17f20c08e/instrumentation/netty/netty-3.8/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/client/HttpClientResponseTracingHandler.java (L33-L46)
2023-02-06 08:16:11 -08:00
e7820f8e9e
Use super to make netty instrumentation clearer ( #7736 )
...
I think it makes it clearer that these classes are decorating the super
methods.
2023-02-06 08:15:53 -08:00
9979d8f620
Remove some no longer needed netty instrumentation ( #7732 )
...
Will follow-up with some related clean-up of `WRITE_CONTEXT` (wanted to
split the changes for clearer review).
2023-02-06 08:15:34 -08:00
c5e384fe9f
Http testing refactor prework ( #7623 )
...
As part of discussions #7616 , the idea of trying to do a more piecemeal
approach came up. A reasonable ask.
This is the first step in refactoring the http client tests. It factors
out the `HttpClientResult` inner class of the `AbstractHttpClientTest`
so that this can be reused by new test framework later. It also factors
the relevant abstract methods in the abstract class to a new type
adapter, which will also be reused.
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-01-20 18:20:42 +00:00
93175522d4
Rename kafka propagation setting and clarify behavior ( #6957 )
2022-10-24 08:49:48 -07:00
94e2248940
Use new semantic attribute constants ( #6946 )
2022-10-23 09:32:03 -07:00
d5aadbab04
Split out :instrumentation:netty:netty-4.1 library ( #6820 )
...
Resolves #6734 . Builds on #6811 .
2022-10-10 16:01:14 -07:00
1fcea2017b
Publish :instrumentation:netty:netty-4-common as library instrumentation ( #6811 )
...
Related to #6734 . Builds on #6805 .
I'll follow it up by splitting out `:instrumentation:netty:netty-4.1` in
a separate PR.
2022-10-06 08:50:25 -07:00
4c91ec9f42
Publish :instrumentation:netty:netty-common as library instrumentation ( #6805 )
...
Related to #6734 .
This first stage splits out the shared utilities in
`:instrumentation:netty:netty-common`. I'll follow it up by splitting
out `:instrumentation:netty:netty-4-common`,
`:instrumentation:netty:netty-4.1` in separate PRs. If there is
appetite, I can also split out library instrumentation for
`:instrumentation:netty:netty-4.0` and
`:instrumentation:netty:netty-3.8`, though I have no need for these.
2022-10-05 09:24:44 -07:00
cfdbe758f2
Net attributes getters changes (in preparation for HTTP spec impl) ( #6503 )
...
* Net attributes getters changes: instrumentation-api-semconv changes
* Net attributes getters changes: getter implementations
* Net attributes getters changes: test fixes
* Remove net.sock.host.name
* code review comments
* default getter methods & getPeerSocketAddress() method name
* set authority in grpc earlier
2022-09-12 09:20:27 -07:00
b7cec3b115
Fix netty issue ( #6469 )
...
* Fix
* Comment
2022-08-18 11:19:24 -07:00
f1774cabe2
Update net semantic convention changes ( #6268 )
...
* New net conventions: option a
* Feedback + sock.family + sock.peer.name
* peer.service + tests
* server net attributes attempt 1
* server net attributes attempt 2
* Javadoc
* Revisions
* Apply to instrumentations
* Feedback
* One more default method
* Spotless
* Fix javadoc
2022-08-18 09:02:23 -07:00
68a9f20eb3
Enable PrivateConstructorForUtilityClass errorprone check ( #6427 )
...
* PrivateConstructorForUtilityClass
* Advice
* More advice
* More
* More advice
* More
* Spotless
* Fix
* Fix
* Fix
* A better solution
* Revert
* More
* Fix
* Spotless
* Fix
2022-08-10 11:30:22 +03:00
9fe3761731
Document upper version limits ( #6436 )
2022-08-08 10:08:40 -07:00
7bbe918008
InstrumentationConfig part 2 ( #6292 )
2022-07-11 09:47:19 +02:00
81de0d8906
Don't wait for netty to shut down ( #6271 )
2022-07-06 13:00:27 -07:00
8fac01e736
Enable error prone's UnusedVariable check ( #6217 )
...
* Enable error prone's UnusedVariable check
* Spotless
2022-06-27 10:55:27 +02:00
528360db8c
Update dependencies ( #6007 )
...
* Update dependencies
* Add maven to plugin repos
* Fix tests that fail with groovy 4.0.2 (#42 )
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
2022-05-17 14:12:36 -07:00
6a0ca530b7
Instrumentation API changes: VirtualField ( #6017 )
...
* Instrumentation API changes: VirtualField
* change class name in string constant
2022-05-12 11:17:24 -07:00
45d0518d69
Update netty 4 common package name ( #5991 )
2022-05-07 20:55:37 -07:00
d919f84cf8
Merge javaagent-instrumentation-api into javaagent-extension-api ( #5936 )
...
* Merge javaagent-instrumentation-api into javaagent-extension-api
* remove some leftover references to javaagent-instrumentation-api
* add missing instrumentation-api to distro example
2022-04-28 20:11:15 -07:00
e9fbb367b3
Rename netty `always-create-connect-span` property to `connection-tel… ( #5834 )
...
* Rename netty `always-create-connect-span` property to `connection-telemetry`
* formatting
* warn when deprecated property is used
* errorprone
2022-04-15 13:38:04 +02:00
213057d057
Run check during testing and assemble during building ( #5619 )
2022-03-18 13:48:51 +09:00
b3496381f1
Write http server tests in java ( #5501 )
...
* Write http server tests in java
* typo
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* add comments
* address review comments
* use Predicate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-03-08 14:21:59 -08:00
022914139e
test latest deps cleanup ( #5269 )
...
* test latest deps cleanup
* Revert currently irrelevant change
* Update instrumentation/lettuce/lettuce-4.0/javaagent/build.gradle.kts
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2022-02-01 09:49:07 -08:00
9381d5a264
Expected server span name for null route should be HTTP GET ( #5197 )
2022-01-21 19:35:48 -08:00
872c6c7d80
Add `http.route` to the server span when `ServerSpanNaming` is updated ( #5086 )
...
* Add `http.route` to the server span when `ServerSpanNaming` is updated
* fix camel tests
* fix test compilation failure
* assert route in camel instrumentation
2022-01-14 13:52:06 -08:00
6b6b22de96
Update Armeria for testing ( #4730 )
...
* Update Armeria for testing
* Fix aws sdk and netty tests for armeria update (#4841 )
* Fix aws sdk tests for armeria update
* fix flaky aws11 test
* send path instread of full uri
* send path instread of full uri
* fix flaky aws11 test
* fix netty tests
* spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2021-12-09 08:53:56 +09:00
ce4cef76f9
Clean up groovy assertions ( #4805 )
2021-12-05 23:23:58 -08:00
313979a467
Fix http.url handing in vert.x 3 http client ( #4739 )
...
* Fix http.url handing in vert.x 3 http client
* correct version
* fix build
* if https test is disabled use http for non routable aadress test
* if https test is disabled use http for non routable aadress test
* use StringBuilder
2021-12-01 10:51:53 -08:00
7caa4022d4
Trace SSL handshakes in netty 4.0 ( #4635 )
2021-11-16 08:35:54 +01:00
d53c276b96
Ensure that netty 4.0 instrumentation is not applied to 4.1 ( #4626 )
...
* Enusre that netty 4.0 instrumentation is not applied to 4.1
* formatting
* cross test netty instrumentation
2021-11-11 08:38:56 -08:00
4719e4cc79
Trace SSL handshakes in netty 4.1 ( #4604 )
...
* Trace SSL handshakes in netty 4.1
* Update testing-common/src/main/java/io/opentelemetry/instrumentation/testing/junit/http/HttpClientTestServer.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* remove unneeded bit of code
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-11-10 13:43:59 -08:00
958f1c039c
Trace DNS resolution in Netty 4.1 ( #4587 )
...
* Trace DNS resolution in Netty 4.1
* Fix reactor-netty 0.9 tests
* Update instrumentation/netty/netty-4.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/client/InstrumentedAddressResolverGroup.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-11-05 11:37:54 -07:00
e9ba87d6b3
Migrate Netty 3.8 CONNECT instrumentation to Instrumenter API ( #4492 )
...
* Migrate Netty 3.8 CONNECT instrumentation to Instrumenter API
* Move shouldStart()
2021-10-26 17:28:31 +02:00
25f6864602
Migrate reactor-netty CONNECT instrumentation to Instrumenter API ( #4493 )
2021-10-25 13:43:30 -07:00
413d7d1fa6
Migrate Netty 4.x CONNECT instrumentation to Instrumenter API ( #4461 )
2021-10-25 12:44:20 +02:00
ef131acd6d
Enable http server concurrency test everywhere ( #4465 )
...
* Enable http server concurrency test everywhere
* remove testConcurrency method as test is now always enabled
* rebase
2021-10-22 08:39:30 -07:00
2e97a4d3d5
Netty: preserve caught exception in the context instead of calling end() ( #4413 )
2021-10-19 13:40:11 -07:00
ac91dc090a
Type annotation placement ( #4406 )
...
* switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable`
* code format
2021-10-17 17:38:43 -07:00
ac479d4b34
Migrate Netty 4.x client instrumentations (except CONNECT) to Instrum… ( #4381 )
...
* Migrate Netty 4.x client instrumentations (except CONNECT) to Instrumenter API
* Revert testReadTimeout changes
2021-10-15 17:06:02 -07:00
2904578875
Test HTTP headers capturing on Netty-based server frameworks ( #4395 )
...
* Test HTTP headers capturing on Netty-based server frameworks
* fix vertx circuit breaker tests
* fix play async tests
2021-10-15 12:30:24 -07:00
25bfb49b80
Migrate Netty 4.x server instrumentations to Instrumenter API ( #4342 )
...
* Migrate Netty 4.x server instrumentations to Instrumenter API
* fix vertx tests
* codenarc
* code review comments
* fix broken assertion
* Update instrumentation/netty/netty-4-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/common/server/NettyServerInstrumenterFactory.java
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2021-10-13 15:32:24 +02:00
354699647a
Test captured HTTP headers - HTTP server tests, part 2 ( #4328 )
...
* Test captured HTTP headers - HTTP server tests, part 2
* Turn off captured HTTP headers testing for grizzly
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-08 13:05:35 -07:00
dafc97f96e
Simplify gradle files ( #4292 )
2021-10-04 21:53:35 -07:00
Mateusz Rzeszutek
Ago Allikmaa
Trask Stalnaker
jason plumb
jack-berg
Lauri Tulmin
Anuraag Agrawal
Martin