Commit Graph

5 Commits

Author SHA1 Message Date
Trask Stalnaker 5f7d1706c2
Remove special CI build dir (#1738)
* Remove special CI build dir

* Add isCI directly to spotbugs.gradle
2020-11-23 15:41:45 +02:00
Ioannis Mavroukakis 020d445dd3
spotbugs upgrade and fixes for JMS1 tests (#1346)
* spotless upgrade and fixes for JMS1 tests

* includes missed bugs in KotlinCoroutineTests

* create spotBugs XML reports on CI, HTML locally

* use updatedCodeNarc rules with lowercase tolerance

* remove if and move bool to each property

* allow spotBugs gradle plugin to upgrade the spotbugs tool

* revert to original test

* exclude all kotlin source from spotbugs

* remove default location for spotBugs report

* do not pass null to a Span's attribute
2020-10-09 11:19:00 +03:00
Ioannis Mavroukakis 9523f9ffe6
fix and/or ignore spotbugs errors (#1325) 2020-10-06 19:39:17 -07:00
Trask Stalnaker 269b3575ef
Format gradle files (#1070) 2020-08-19 19:05:45 -07:00
John Bley 00ae1eca3d
Integrate SpotBugs into build (ignoreFailures=true), fix most found issues (#216)
* Integrate SpotBugs (FindBugs) into build.  Set ignoreFailures so spotted bugs do not break the build.

* Fix many SpotBugs-found items, mostly making things final, but also a redundant null check and a reliance on platform character encoding.  2 items remain which will need further work/review, but as ignoreFailures is set, they will not fail the check stage.

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-03-09 10:47:49 -07:00