open-telemetry
/
opentelemetry-java-instrumentation
mirror of https://github.com/open-telemetry/opentelemetry-java-instrumentation.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
8,735 Commits 77 Branches 113 Tags 276 MiB
Commit Graph

58 Commits

Author SHA1 Message Date
moznion 7e8d76a83b
Put `http.route` attribute onto `http.server.duration` on Play framework request processing (#7801) 
Basically, `akka-http` instrumenter has the responsibility to instrument
the `http.server.duration` for the Play framework application, but the
current implementation has not marked the `http.route` attribute.
ref:
8e8161cb2e/instrumentation/akka/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/server/AkkaHttpServerAttributesGetter.java (L59)

Actually, it's hard to record that attribute by only the akka-http layer
because that library's request object doesn't hold the route
information, e.g. placeholder.

So this patch delegates that job to the `play-mvc` instrumenter and when
that has been able to get the route info, the instrumenter puts
`http.route` attribute onto `http.server.duration`.

For example, when the routes configuration of the Play is like the
following:

```
GET  /foo/:bar  controllers.HomeController.doSomething(bar: String)
```

and when it tries to access that API, then OTEL instruments like so:

```prometheus
http_server_duration_count{otel_scope_name="io.opentelemetry.akka-http-10.0",otel_scope_version="1.23.0-alpha-SNAPSHOT",http_flavor="1.1",http_method="GET",http_route="/foo/$bar<[^/]+>",http_scheme="http",http_status_code="200",net_host_name="localhost",net_host_port="9000"} 1.0 1676078079798
http_server_duration_sum{otel_scope_name="io.opentelemetry.akka-http-10.0",otel_scope_version="1.23.0-alpha-SNAPSHOT",http_flavor="1.1",http_method="GET",http_route="/foo/$bar<[^/]+>",http_scheme="http",http_status_code="200",net_host_name="localhost",net_host_port="9000"} 12183.558843 1676078079798
http_server_duration_bucket{otel_scope_name="io.opentelemetry.akka-http-10.0",otel_scope_version="1.23.0-alpha-SNAPSHOT",http_flavor="1.1",http_method="GET",http_route="/foo/$bar<[^/]+>",http_scheme="http",http_status_code="200",net_host_name="localhost",net_host_port="9000",le="0.0"} 0.0 1676078079798
...
http_server_duration_bucket{otel_scope_name="io.opentelemetry.akka-http-10.0",otel_scope_version="1.23.0-alpha-SNAPSHOT",http_flavor="1.1",http_method="GET",http_route="/foo/$bar<[^/]+>",http_scheme="http",http_status_code="200",net_host_name="localhost",net_host_port="9000",le="+Inf"} 1.0 1676078079798
```

Rel: #1415

---------

Signed-off-by: moznion <moznion@mail.moznion.net>
 2023-02-14 14:05:59 +02:00
Lauri Tulmin 2e599633df
Update link to restlet framework website (#7617) 
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7614
 2023-01-19 10:43:54 +01:00
Trask Stalnaker 72f8b94342
Update change log for 1.22 (#7556) 2023-01-12 16:32:49 +00:00
Trask Stalnaker 09b63d2294
Use new reactor contextWrite when available (from reactor 3.4.0) (#7538) 
Related to #7107 and #7202

Support WebFlux 6. 

Supporting reactor 3.5 seems pretty straightforward, the
`subscriberContext()` was deprecated in 3.4 in favor of
`contextWrite()`. In 3.5, `subscriberContext()` was removed.

This PR doesn't bump `latestDepTestLibrary` to 3.5 yet because there are
a couple of tests that succeed in 3.4 using `contextWrite()` but fail in
3.5 using `contextWrite()`.

My proposal is to review/merge this PR, and then I can ping our resident
reactor experts to see if they have thoughts on the failing tests in
3.5.
 2023-01-11 20:26:12 -08:00
Mateusz Rzeszutek ca310b4ddb
Support Spring Web MVC in library instrumentation (#7552) 
Part of
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7312

This is pretty much a copy of the `spring-webvmc-5.3:library` module
with `s/javax/jakarta/` applied. I'm planning on removing the 5.3
instrumentation after #7312 is done.
 2023-01-11 17:22:55 -08:00
Trask Stalnaker 05e5316b84
Update supported versions doc (#7549) 2023-01-11 17:12:17 +00:00
Trask Stalnaker 02fb579470
Fix markdown lint error (#7371) 2022-12-08 13:32:26 -08:00
jack-berg 1dfec3b928
Semconv docs (#7272) 
More documentation about the semantic conventions implemented by
instrumentation.

Resolves #6735.
 2022-12-08 09:27:48 -08:00
Mateusz Rzeszutek 17b3fdb04a
Make preparations for Spring Web & WebMVC 6 instrumentations (#7343) 
Just moving things around, extracting parent dir for `spring-web` and
`spring-webmvc`
 2022-12-01 13:08:32 +01:00
Felix Wong d0158c4bff
Rename WebSphere Liberty Profile to Open Liberty (#7349) 
fixes #7346 

Rename "WebSphere Liberty Profile" to "Open Liberty" and updated the
link.
 2022-12-01 12:03:22 +01:00
Trask Stalnaker a4740264c2
Use windows-latest (#7299) 2022-11-29 07:54:03 -08:00
Aaron Ai 2d7395c44b
Introduce markdown lint check (#7175) 
Fixes #7129
 2022-11-16 20:48:42 -08:00
Aaron Ai 97773819c8
Add RocketMQ gRPC/Protobuf-based Client into supported-libraries.md (#7198) 
Add RocketMQ gRPC/Protobuf-based Client into supported-libraries.md

related issue: #6764
 2022-11-16 09:35:32 +01:00
jack-berg 78e6744463
Add semantic conventions column to supported libraries doc (#6974) 
Related to #6735.

Want to get buy in on the approach before going further.
 2022-11-01 11:26:41 -07:00
Lauri Tulmin 7d01a221a6
Update websphere link (#6602) 2022-09-13 12:44:25 +02:00
Trask Stalnaker 9fe3761731
Document upper version limits (#6436) 2022-08-08 10:08:40 -07:00
Will Li c0cacb8544
add missing jboss-logmanager to supported libraries list (#6369) 
* add missing jboss-logmanager to supported libraries list

Signed-off-by: Cuichen Li <cuichli@cisco.com>

* Update docs/supported-libraries.md

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
 2022-07-25 11:38:13 -07:00
Mateusz Rzeszutek db1250d8c9
Add a dropwizard-metrics -> OTel metrics bridge (#6259) 
* Add a dropwizard-metrics -> OTel metrics bridge

* disable by default

* enable metrics for test
 2022-07-15 14:48:52 -07:00
Lauri Tulmin ae2a908256
Run tests with dubbo3 (#6247) 
* Run tests with dubbo3

* remove muzzle limit

* fill peer name on dubbo 3
 2022-07-01 08:14:23 -07:00
Lauri Tulmin b992e894bc
Run tests with latest play mvc (#6157) 
* Run tests with latest play mvc

* restart build

* spotless
 2022-06-13 13:02:15 -07:00
Lauri Tulmin 157ab7f754
Implement Oracle UCP connection pool metrics (#6099) 
* Implement Oracle UCP connection pool metrics

* add additional instrumentation name

* change asserting no metrics reported after shutdown
 2022-06-02 22:47:04 -07:00
jason plumb f1a746dca5
Add tomcat-jdbc connection pool metrics instrumentation (#6102) 
* add tomcat-jdbc connection pool metrics instrumentation

* use duration

* code review comments

* remove unnecessary awaits

* udpate supported-libraries.md

* add comment about weakmap

* add sleeps for safety
 2022-06-02 16:18:07 -07:00
Lauri Tulmin b95b64ba88
Implement Vibur DBCP connection pool metrics (#6092) 
* Implement Vibur DBCP connection pool metrics

* Apply suggestions from code review

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* address review comments

* don't check for metircs that aren't reported

* rework library test setup

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
 2022-05-26 11:26:02 +03:00
Lauri Tulmin a1626ccc8c
Add OSHI to supported libraries (#6073) 2022-05-20 09:11:33 -07:00
Lauri Tulmin 6c44340f1c
Enable grizzly instrumentation by default (#6049) 2022-05-17 14:18:29 -07:00
Mateusz Rzeszutek 5bcab32379
Implement HikariCP connection pool metrics (#6003) 
* Implement HikariCP connection pool metrics

* rebase after SDK update

* fix muzzle

* code review comments
 2022-05-12 18:48:07 -07:00
Mateusz Rzeszutek 2fad192fc1
Implement vertx-kafka-client instrumentation; batch processing (#5982) 
* Implement vertx-kafka-client instrumentation; batch processing

* try-finally just in case

* Add to supported libraries list

* Update instrumentation/vertx/vertx-kafka-client-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/v3_6/InstrumentedBatchRecordsHandler.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
 2022-05-10 12:00:54 +02:00
Trask Stalnaker 4facb78c7a
Update docs to reflect Java 17 (#5610) 
* Update docs to reflect Java 17

* Update JVM distros
 2022-03-18 10:31:25 +02:00
Lauri Tulmin 2ebe912fe4
GraphQL java instrumentation (#5583) 
* GraphQL Java Initial Commit

* [WIP] First steps for GraphQL instrumentation, totally not ready

[skip ci]

* GraphQL Java instrumentation

* address review comments

* Apply suggestions from code review

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* review feedback

* scope handling

* Apply suggestions from code review

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* use spotless:off

* trigger build

* review comments

Co-authored-by: Jordie <xd@jrdie.nl>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
 2022-03-17 08:55:45 -07:00
Trask Stalnaker ab9169cd25
Add Azure SDK instrumentation (#5467) 
* Add Azure SDK instrumentation

* Add to supported libraries table

* Keep suppression for 1.19
 2022-03-04 13:08:50 -08:00
Trask Stalnaker bd7bf94d71
Move http4k to library instrumentation docs (#5426) 
* Move http4k to library instrumentation docs

* Update docs/standalone-library-instrumentation.md

Co-authored-by: Lauri Tulmin <tulmin@gmail.com>

Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
 2022-02-22 21:12:38 -08:00
Trask Stalnaker 022914139e
test latest deps cleanup (#5269) 
* test latest deps cleanup

* Revert currently irrelevant change

* Update instrumentation/lettuce/lettuce-4.0/javaagent/build.gradle.kts

Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>

Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
 2022-02-01 09:49:07 -08:00
Trask Stalnaker 1832772ccd
Update supported libraries (#5092) 
* Update supported libraries

* One row per library
 2022-01-13 18:02:08 -08:00
Lauri Tulmin b4784c8432
Update supported frameworks and suppressing instrumentation docs (#4818) 
* Update supported frameworks and suppressing instrumentation docs

* Update docs/suppressing-instrumentation.md

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
 2021-12-07 11:49:59 +02:00
Trask Stalnaker 09d5883fb8
Update supported application servers (#4715) 
* Update naming to Payara

* Alphabetize

* Update supported application servers

* A little more clarity?
 2021-11-25 08:15:35 -08:00
Lauri Tulmin db0d0c350a
Change supported websphere version from 8.5.x to 8.5.5.x (#4668) 2021-11-18 15:42:15 +02:00
Lauri Tulmin 4e39f1ad5a
Add smoke test for websphere, update smoke test server versions (#4613) 
* Add smoke test for websphere, update smoke test server versions

* update workflows

* fix workflow

* Apply suggestions from code review

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* revert accidental change

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
 2021-11-10 13:43:30 -08:00
Mateusz Rzeszutek d6c8e3a1f2
Update supported libs list (#4077) 2021-09-09 08:07:04 -07:00
Nikita Salnikov-Tarnovski 40490a8a0f
Remove khttp from the list of supported libraries (#3769) 2021-08-04 14:34:36 +03:00
Trask Stalnaker f1beb2397f
Intellij cleanup of markdown and yaml (#3284) 
* Intellij cleanup of markdown and yaml

* Revert required yaml param
 2021-06-14 13:13:01 +03:00
Trask Stalnaker 9a3c657291
Add library instrumentation docs (#3176) 2021-06-03 14:14:37 -07:00
Trask Stalnaker 500590e597
Add Java HttpClient to docs (#3001) 2021-05-17 12:13:30 -07:00
Anuraag Agrawal 08c155add3
Update supported gRPC version (#2952) 2021-05-10 18:37:58 +03:00
Lauri Tulmin 30b1f3df3b
Add supported jax-rs and jax-ws frameworks (#2921) 2021-05-06 22:19:25 +03:00
Trask Stalnaker eb81e8958c
Remove play-2.3 instrumentation and remove typesafe repo (#2783) 
* Remove typesafe repo

* Use play 2.3.9 instead of 2.3.0

* Exclude missing optional dependency

* Remove play-2.3 module

* Update supported libraries doc
 2021-04-13 11:50:29 +03:00
Trask Stalnaker 3dcb29d1ea
Update supported library versions (#2766) 
* Update supported library versions

* Lettuce too
 2021-04-11 13:04:03 +03:00
Nikita Salnikov-Tarnovski 8f4056ba03
Update supported-libraries.md (#2717) 
Update TOC
 2021-04-05 12:03:50 +03:00
Ago Allikmaa 19cf89ec1e
Document supported JVMs as a separate section (#2704) 2021-04-05 08:58:57 +03:00
Lauri Tulmin 3f5980f9b8
Add support for Tapestry web framework (#2690) 2021-04-01 17:56:55 -07:00
Lauri Tulmin 3c11613aed
Add support for GWT (#2652) 
* Add support for GWT

* formatting

* review fixes
 2021-03-29 19:41:03 +03:00