Tyler Benson
55276148b9
Merge pull request #1251 from DataDog/devinsba/fast-reference-matcher
...
Fail fast in the matcher, let the debug outputs use the cache
2020-02-28 09:56:45 -08:00
Nikolay Martynov
cf5fe9feff
Merge branch 'master' into mar-kolya/speedup-context-injection-matchers
2020-02-28 02:07:37 +01:00
Nikolay Martynov
3d4ab93888
Merge branch 'master' into mar-kolya/speedup-context-injection-matchers
2020-02-28 02:01:33 +01:00
Nikolay Martynov
0b196ed3ec
Merge branch 'master' into mar-kolya/constantify-decorator-matcher
2020-02-28 01:41:02 +01:00
Lev Priima
885212ee36
ClassLoaderHasNoResourceMatcher: put to cache outside critical section
2020-02-27 13:12:23 -08:00
Tyler Benson
68e4bf8375
Merge pull request #1266 from DataDog/tyler/imply-not-interface
...
Imply not(isInterface()) call for expensive matchers
2020-02-27 12:54:15 -08:00
Tyler Benson
35e00686b3
Imply not(isInterface()) call for expensive matchers
...
Also remove from simple named("some.name") matchers to avoid metadata lookup.
2020-02-27 12:13:42 -08:00
dougqh
7c68238f6a
Merge branch 'master' of github.com:DataDog/dd-trace-java
2020-02-27 14:50:11 -05:00
Tyler Benson
ed061b6979
Merge pull request #1268 from DataDog/tyler/aws-uri
...
Remove conversion from URI to String back to URI
2020-02-27 11:17:00 -08:00
Tyler Benson
4e8e098330
Merge pull request #1257 from DataDog/tyler/caching-typedescription
...
Return TypePool.Resolution that caches TypeDescription calls.
2020-02-27 11:12:40 -08:00
Laplie Anderson
6ed5f56bb7
Merge pull request #1255 from DataDog/landerson/spring-blacklist
...
Add list of blacklisted spring classes
2020-02-27 14:07:42 -05:00
Tyler Benson
300c795e72
Remove conversion from URI to String back to URI
...
Apply same change as here: https://github.com/open-telemetry/opentelemetry-auto-instr-java/pull/191
2020-02-27 10:21:06 -08:00
Nikolay Martynov
2f71ad850f
Constantify non decorator matcher
2020-02-27 17:52:20 +01:00
Nikolay Martynov
d53c138016
Make FieldBackedProvider inject fields only once
2020-02-27 16:24:01 +01:00
Nikolay Martynov
6e10eee6ee
Use isEmpty
2020-02-27 15:53:48 +01:00
Nikolay Martynov
70bed6f4ac
Remove javadoc from some inappropriate places
2020-02-27 15:53:47 +01:00
Nikolay Martynov
5a17e57e99
Provide `toString` for SafeExtendsClassMatcher
2020-02-27 15:53:46 +01:00
Nikolay Martynov
06b052c4d9
Minor cleanup
2020-02-27 15:53:45 +01:00
dougqh
7511dede5d
Merge branch 'master' of github.com:DataDog/dd-trace-java
2020-02-26 15:57:39 -05:00
Tyler Benson
f431d5285a
Return TypePool.Resolution that caches
...
Caching focused on the expensive calls primarily used by our instrumentation.
2020-02-26 12:47:48 -08:00
Laplie Anderson
84c7be64b5
Add blacklist directly to global ignores
2020-02-26 11:59:21 -05:00
Tyler Benson
2ec0c1acb7
Merge pull request #1258 from DataDog/tyler/fix-whitelist-logging
...
Apply matcher if debug logging enabled to avoid confusing log output.
2020-02-26 08:57:17 -08:00
Brian Devins-Suresh
30e1d56023
Address comments
2020-02-26 09:14:49 -05:00
Tyler Benson
eb8de0d3ab
Apply matcher if debug logging enabled to avoid confusing log output.
...
Otherwise it was "Skipping" every unrelated class.
2020-02-25 18:04:27 -08:00
Laplie Anderson
fa3f449ec4
Add list of blacklisted spring classes
2020-02-25 16:33:39 -05:00
Nikolay Martynov
96f74d0fef
Compare loader hashes
2020-02-25 21:53:12 +01:00
Nikolay Martynov
82dd2aa1b3
Revert "Make sure that same classloaders get same weak ref"
...
This reverts commit 50793e5244
.
2020-02-25 21:47:42 +01:00
Brian Devins-Suresh
815bd0e9f6
Fix comment
2020-02-25 10:31:52 -05:00
Brian Devins-Suresh
2441ca3332
No more arraylist(0)
2020-02-25 10:02:53 -05:00
dougqh
65c6d17df6
Merge branch 'master' of github.com:DataDog/dd-trace-java
2020-02-25 09:41:40 -05:00
Brian Devins-Suresh
3b78d4593f
Don't need to collect mismatches in the critical path
2020-02-25 09:36:00 -05:00
Nikolay Martynov
50793e5244
Make sure that same classloaders get same weak ref
2020-02-25 14:32:35 +01:00
Nikolay Martynov
aefcc477cb
Simplify TypePoolCacheKey equals
...
We have to check string equivalence regardless of classloader state
2020-02-25 11:58:18 +01:00
Nikolay Martynov
31b5652d10
Remove reference check from TypeCacheKey
2020-02-25 10:19:47 +01:00
Nikolay Martynov
41db97ea0f
Merge branch 'master' into mar-kolya/improve-hash-calclulation-cache-pool
2020-02-25 10:18:25 +01:00
Brian Devins-Suresh
5ebc13cafa
Increase performance on java 8
2020-02-24 17:10:41 -05:00
Brian Devins-Suresh
af67dfa720
Need to cache the boolean. The list can be taken later as debug is expected to be slower
2020-02-24 14:39:17 -05:00
Brian Devins-Suresh
75af71584c
Refactor an agent usage, and fix logic issue
2020-02-24 14:39:17 -05:00
Brian Devins-Suresh
e65177a143
Fail fast in the matcher, let the debug outputs use the cache
2020-02-24 14:39:17 -05:00
Tyler Benson
c13cb2e60f
Move a few other classes.
2020-02-24 08:35:19 -08:00
Tyler Benson
3559ffb21c
Add unit tests for matchers
2020-02-24 08:35:19 -08:00
Tyler Benson
bd82166b58
Rename methods that don't require disambiguation.
2020-02-24 08:35:19 -08:00
Tyler Benson
f70c35842d
Move matchers to separate package and split matcher classes out
2020-02-24 08:31:12 -08:00
Nikolay Martynov
833f67816e
Merge pull request #1248 from DataDog/mar-kolya/reduce-superclass-matcher-exposure
...
Avoid calling superclass matcher where possible
2020-02-21 21:16:52 -05:00
Tyler Benson
b27b30d913
Merge pull request #1247 from DataDog/tyler/bb-raw
...
Set ByteBuddy raw setting at startup
2020-02-21 16:30:24 -08:00
Nikolay Martynov
b6d374e3a0
Avoid calling superclass matcher where possible
...
Saves about 100ms of startup time on test app
2020-02-21 15:08:39 -05:00
Tyler Benson
ecf9bcc655
Make sure CallDepthThreadLocalMap is always reset ( #1227 )
...
Make sure CallDepthThreadLocalMap is always reset
2020-02-21 11:03:51 -08:00
Tyler Benson
faccb0d483
Set ByteBuddy raw setting at startup
...
This reduces the complexity of TypeDefinitions.
```
Benchmark Mode Cnt Score Error Units
ClassRetransformingBenchmark.WithAgent.testTracedRetransform avgt 22.450 ms/op
ClassRetransformingBenchmark.WithAgent.testUntracedRetransform avgt 6.842 ms/op
ClassRetransformingBenchmark.WithAgentMaster.testTracedRetransform avgt 23.188 ms/op
ClassRetransformingBenchmark.WithAgentMaster.testUntracedRetransform avgt 7.009 ms/op
```
It also improved startup time by about 1 sec.
2020-02-21 10:35:20 -08:00
Nikolay Martynov
1f8acafc42
Merge pull request #1245 from DataDog/mar-kolya/single-ignores-matcher
...
Single ignores matcher
2020-02-21 12:42:18 -05:00
Tyler Benson
e4d29e37ef
Update JMH benchmarks ( #1242 )
...
Update JMH benchmarks
2020-02-21 09:38:34 -08:00