25bfb49b80
Migrate Netty 4.x server instrumentations to Instrumenter API ( #4342 )
...
* Migrate Netty 4.x server instrumentations to Instrumenter API
* fix vertx tests
* codenarc
* code review comments
* fix broken assertion
* Update instrumentation/netty/netty-4-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/common/server/NettyServerInstrumenterFactory.java
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2021-10-13 15:32:24 +02:00
354699647a
Test captured HTTP headers - HTTP server tests, part 2 ( #4328 )
...
* Test captured HTTP headers - HTTP server tests, part 2
* Turn off captured HTTP headers testing for grizzly
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-08 13:05:35 -07:00
92394ad9ae
Remove url from HttpServerAttributesExtractor ( #4209 )
...
* Remove url from HttpServerAttributesExtractor
* Remove UriBuilder
* Tracers too
* apache-camel
* Finatra
* jsp
* Ratpack
* Ratpack library
* Ratpack
* Spark
* Feedback
* Fix Undertow
* Vertx
* vertx-web
* play-2.4
* webflux
* jaxrs
* Spotless
* Update semantic-conventions.md
* Update smoke tests
* More realistic target
* Remove outdated doc
* Wording
2021-10-03 09:17:23 -07:00
c421b66d56
Remove unnecessary VirtualField#setIfNull() method ( #4262 )
2021-10-02 13:17:48 -07:00
c11b96e4d0
Make it possible to use InstrumentationContext (now VirtualField) fro… ( #4218 )
...
* Make it possible to use InstrumentationContext (now VirtualField) from library instrumentation
* fix tests
* fix javadocs
* fix some more tests
* code review comments
* setIfNull, computeIfNull
2021-10-01 11:13:11 +02:00
3bc0e07c60
#4056 remove oringin handler when removelast in netty ( #4123 )
...
* removelast
* removelast
* addAfter and removeLast
* addAfter and removeLast
* addAfter and removeLast
2021-09-17 13:23:20 -07:00
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
23fc4ce443
Fix memleak in the Netty ChannelPipeline instrumentation ( #4053 )
2021-09-07 14:16:08 -07:00
58d640a373
Fix netty strict context checks ( #4002 )
...
* Fix netty strict context leaks
* And netty-4.0
* ClassValue and more
2021-08-30 09:02:16 -07:00
1889c1adfb
Limit netty exception capture to netty spans ( #3809 )
...
* Limit Netty exception capture to Netty span
* Rename constant
* Fix var name
* Apply to netty-4.0 also
2021-08-10 20:58:37 -07:00
a04a7a6b72
Add option to create span on new netty connection ( #3707 )
...
* Create span on new netty connection
* add test for connection failure
* add comment
* remove commented out line
* rebase
* test fix
* review comments
* keep connection failure span as client span
2021-07-30 11:32:53 +03:00
47be4a16b4
Convert HttpClientTest to JUnit ( #3652 )
...
* Migrate HttpClientTest to junit to allow both Java or spock tests.
* More
* Update
* Finish
* Cleanup
* Better stack
* Java 15
* Merge
* Fix name
* Cleanup
* ? extends
* Moar
2021-07-27 21:55:40 +09:00
4db7bd5ff3
Move common code from netty 4.0 and 4.1 http client to common superclass ( #3660 )
2021-07-26 11:15:13 +09:00
1b5df6d78a
Netty connection failure handling ( #3569 )
...
* Netty connection failure handling
* Update instrumentation/netty/netty-4-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/common/client/AbstractNettyHttpClientTracer.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Remove unused import
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-07-23 11:21:15 +03:00
1197480f6e
Netty4: handle read timeout ( #3613 )
...
* Netty4: handle read timeout
* spotless
2021-07-21 21:20:21 +03:00
f5ce4c03f8
Inline basic usages of basicSpan ( #3583 )
...
* Inline basic usages of basicSpan
* spock
2021-07-18 21:15:51 +03:00
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
9b56fc9051
Clean up AgentElementMatchers ( #3527 )
...
* Clean up AgentElementMatchers
* remove a TODO
* moved method
2021-07-09 10:02:21 +03:00
c5ba5c3a71
Use local variable for passing CallDepth between advice enter/exit me… ( #3504 )
...
* Use local variable for passing CallDepth between advice enter/exit methods
* fix broken call depth tracking
* checkstyle
* fix javadocs
2021-07-06 12:05:14 -07:00
b9fcb6b498
Reduce CallDepth classes' API surface ( #3497 )
2021-07-06 09:24:19 +02:00
15ed01d4fc
Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} ( #3411 )
...
* Change all instrumentation names to io.opentelemetry.{libName}-{libVersion}
* minumum supported version
2021-06-30 15:34:36 +02:00
bcb282a220
Conform to google style guide checkstyle ( #3399 )
2021-06-24 10:53:23 +03:00
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
80a7403763
Remove insecure trust manager from test ( #3268 )
2021-06-12 12:03:46 +03:00
de7eaa0fe6
Enable https tests ( #3258 )
2021-06-11 17:16:34 -07:00
60aaff8972
Migrate HttpServerTest to Armeria ( #3240 )
...
* Migrate HttpServerTest to Armeria
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpServerTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-11 08:56:02 +09:00
e93ff4d419
Remove references to dropped request test ( #3238 )
2021-06-10 16:21:11 +03:00
f51bace1eb
Netty connection failure span only when first operation fails ( #3228 )
2021-06-09 17:24:02 +09:00
7ae23fc694
Migrate HttpClientTest test server to Armeria ( #3225 )
...
* Use Armeria for test HTTP server.
* Continue
* Migrate test http server to Armeria.
* Finish
* Use junit extension
* Remove unused.
* Use localhost for net peer name.
* Block for full response in recator-netty tests.
* Handle split responses in netty41 and akka
* Typo
2021-06-09 15:05:58 +09:00
cefaecab3f
Use more efficient namedOneOf where possible ( #3200 )
...
* Use more efficient namedOneOf where possible
* Fix - hasClassesNamed does and not or
2021-06-07 11:41:34 +09:00
e1762677da
Refactor HttpClientTest ( #3159 )
...
* Remove unused extraClientSpans() method
* Merge extraAttributes() and hasClientSpanHttpAttributes(uri) into
httpAttributes(uri): this will allow to choose extracted attributes
per URI (for example, OkHttp won't set flavor on connection exception
once it's rewritten to Instrumenter)
2021-06-03 10:54:01 +09:00
e16cf3001f
Add attributes to netty connection failure span ( #3115 )
2021-05-28 15:01:10 -07:00
df078f95a9
Extract HttpServerTest INDEXED_CHILD span attribute collection logic ( #3095 )
...
* Extrawct HttpServerTest INDEXED_CHILD span attribute collection logic
* Adjust whitespace
* Fix context issue with JAX-RS
* Rerun tests
2021-05-27 11:18:11 +03:00
119697b131
Share some code between netty 4.0 and 4.1 instrumentation ( #3048 )
2021-05-20 14:32:37 -07:00
23a40d926c
Netty4.1: remove our handler when original handler is removed ( #3026 )
...
* Netty4.1: remove our handler when orignal handler is removed
* Update instrumentation/netty/netty-4.1/javaagent/src/test/groovy/ChannelPipelineTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* disable epoll to see whether it makes any difference
* fix netty with epoll/kqueue native library
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-19 10:01:56 -07:00
d1946f6774
Don't use type annotation style ( #3023 )
2021-05-18 10:23:09 -07:00
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
b4b102dbec
Enable http client connection failure tests ( #2998 )
2021-05-17 12:15:48 -07:00
cd3dd581f9
Fix some remote connection tests ( #2933 )
2021-05-10 12:19:39 +09:00
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
56d7fd3516
Expose correct Context.current() in reactive-netty callbacks ( #2850 )
2021-04-29 12:29:36 -07:00
77f8be8add
Fix netty 4.1 instrumentation not removing future listeners ( #2851 )
...
* Fix netty 4.1 instrumentation not removing future listeners
* Code review follow-up
* Use InstrumentationContext
2021-04-27 11:22:52 +03:00
8ded533f52
Add another missing Unroll annotation ( #2829 )
2021-04-20 12:40:37 -07:00
9464134ffd
Test failing async http request ( #2812 )
2021-04-19 14:11:27 -07:00
bd829a6494
Remove duplicate status verification ( #2710 )
2021-04-19 11:41:37 -07:00
b922b3ece9
Remove the netty connection interference test ( #2765 )
2021-04-12 13:55:00 -07:00
3bc058b10b
Don't create duplicate headers ( #2727 )
...
* Test infra
* Update examples
* Update instrumentation
* Update tests
* jaxrs-client fixes
* Remove doRequest/doReusedRequest
* Fix muzzle
* some fixes
* fix test
* doc
* not private
* Apply to doRequestWithCallback also
* Update doc
* groovy
* better
* Don't hardcode traceparent
* Reuse request in SpringRestTemplateTest
2021-04-12 12:21:16 +03:00
692bb72f22
Implement concurrent test for Netty http server ( #2750 )
2021-04-08 08:36:42 +03:00
d8f6018ba6
Split HttpClientTest execution methods for sync and callback ( #2675 )
2021-04-06 15:26:01 -07:00
6ea316e22e
Remove timeout annotations ( #2725 )
2021-04-06 16:36:18 +09:00
25dd2cf194
Verify span kind in all tests ( #2715 )
2021-04-05 12:57:48 -07:00
f02b0f8d74
Fix suppressed NPE in netty instrumentation ( #2649 )
2021-03-29 14:44:49 -07:00
c3c5e6b2a6
Finish Netty 4.1 spans after response has completed not when it started. ( #2641 )
...
* Finish Netty 4.1 spans after response has completed not when it started.
* copy pasta bada
* Update instrumentation/netty/netty-4.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/client/HttpClientResponseTracingHandler.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Update instrumentation/netty/netty-4.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/server/HttpServerResponseTracingHandler.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Update instrumentation/netty/netty-4.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/server/HttpServerResponseTracingHandler.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-03-27 13:32:01 +09:00
5a9b0b999f
Test of single connection reuse for Netty ( #2630 )
...
* Test of single connection reuse for Netty
* Format
2021-03-26 16:21:46 +02:00
0ce9ca57d9
Move attributes to span builder for use by samplers ( #2587 )
...
* Move attributes to span builder for sampler use
* Fix test
* Remove unnecessary test
2021-03-17 15:02:56 +02:00
ae23b97ec4
Move and rename NetPeerUtils ( #2548 )
...
* Move and rename NetPeerUtils
* Rename NetPeerUtils to NetPeerAttributes; inject instance instead of using a global var
* Rename SpanAttributeSetter to AttributeSetter (might be used to set on AttributesBuilder in the future, who knows)
* Deprecate default BaseTracer constructor: library instrumentations are supposed to inject all dependencies, the javaagent should explicitly pass globals
* fix compilation failure
* Remove peer.service customization from library instrumentation
2021-03-16 13:50:19 +01:00
fe4d95a689
Refactor BaseTracer#onError() method (and unwrapThrowable()) ( #2513 )
...
* Refactor BaseTracer#onError() method (and unwrapThrowable())
Also remove the deprecated BaseTracer(Tracer) constructor.
* Update BaseTracer javadoc
* fix tests
* Code review comments
2021-03-08 15:08:26 +02:00
72ffb3b7c5
Make BaseTracer fields private ( #2492 )
...
* Make BaseTracer fields private
By making `tracer` private we're forcing all tracer implementation to use the `spanBuilder()` utility method and pass the parent context manually.
2021-03-05 10:54:00 -08:00
c18acb858e
Add BaseTracer#inject() method ( #2453 )
...
* Add BaseTracer#inject() method
And avoid using GlobalOpenTelemetry#getPropagators()
* Code review comments
2021-03-02 15:30:04 +01:00
62f2611486
Update instrumentation names ( #2433 )
2021-03-01 19:34:25 -08:00
68cde08177
Fix netty 4.1 test after adding @Unroll on the base class ( #2412 )
2021-02-25 15:01:55 +01:00
eaa8604e96
Better context passing for Netty 4.1 ( #2361 )
...
* Better context passing for Netty 4.1
* Format
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/context/ContextPropagationDebug.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Return test
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-02-23 10:26:41 +02:00
1f884e4d97
Fix Operation name logging for Netty based applications ( #2317 )
2021-02-19 09:59:50 -08:00
000df967ce
Update to SDK 0.17.0 ( #2338 )
...
* Update to SDK 0.17.0
* Finish
* ottrace
2021-02-19 15:51:55 +09:00
ee090aee1e
Support library instrumentations with HttpServerTest & HttpClientTest ( #2299 )
2021-02-16 09:05:23 -08:00
0fbdcad1dd
Make BaseTracer#startSpan() return Context ( #2232 )
...
* Make BaseTracer#startSpan() return Context
* Update instrumentation/apache-camel-2.20/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachecamel/CamelEventNotifier.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* spotless
* Add Javadocs to BaseTracer
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-12 12:12:40 +01:00
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
e9a4b952dd
Add causality test with multiple concurrent requests ( #2156 )
...
* Add causality test with multiple concurrent requests
* Include support for Reactor Netty 1.0 into README.md
* Fix muzzle conf
* Fix muzzle and version constraints
* More strict causality check
* Better muzzle config
* Fixing muzzle
* Fixing deps
* Better library
* Better naming
2021-02-05 12:39:42 +02:00
8d6ee17c05
Fix netty 4.1 tests ( #2122 )
2021-01-26 10:11:06 -08:00
8b470bf378
Add Netty instrumentation handlers after matched handler rather than at end of pipeline. ( #2100 )
...
* Support latest webflux version.
* Add Netty instrumentation handlers after matched handler rather than at end of pipeline.
* Drift
* Fix
* Raise smoke tests timeout
2021-01-25 16:06:57 +09:00
2eee121931
Match classloader when applying netty instrumentation. ( #2099 )
2021-01-22 12:05:20 +02:00
7c3b183294
Move netty4.1 exception handling to an other method ( #2070 )
2021-01-18 22:14:49 -08:00
afdde0355b
Update to OTel 0.14.1 ( #2059 )
...
* Update SDK dependency to 0.14.1
* WIP
* Finish
* Cleanup
2021-01-18 13:02:04 +09:00
2a4e07dce1
Netty: add exception to span ( #2027 )
2021-01-14 09:36:14 -08:00
077d8b64f6
Move common matchers to tooling/bytebuddy/matcher and ignore matchers to tooling/matcher ( #1965 )
2021-01-10 12:35:53 -08:00
deda1af9c0
HTTP client instrumentation cleanup: netty ( #1909 )
2020-12-15 09:00:31 +02:00
c5a257619a
Make sure AWS SDK spans suppress client spans all the time. ( #1837 )
...
* Make sure AWS SDK spans suppress client spans all the time.
* Make more consistent with other instrumentation
* Update instrumentation/netty/netty-4.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/v4_1/client/NettyHttpClientTracer.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* more dragons
* Grammar
* README
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-12-07 17:10:43 +09:00
65f54e450b
Use Context more in HttpClientTracer ( #1811 )
...
* Use Context more in HttpClientTracer
* Better http-url-connection response object
* Follow database semantic conv for elasticsearch-rest
* Remove unnecessary CallDepth tracking
2020-12-03 11:47:08 -08:00
a2770c311e
Don't use ConfigUtils outside of AgentTestRunner tests ( #1796 )
...
* NetPeerUtilsTest
* RedisCommandNormalizerTest
* InstrumentationModuleTest
* HttpClientTracerTest
* Normalize test config properties
* Create ConfigBuilder in instrumentation-api
* Keep config properties compatible with SDK
2020-12-01 16:52:08 -08:00
0bd85d7b7f
Pass around context more instead of span (HttpServerTracer) ( #1810 )
2020-12-01 14:49:01 -08:00
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00
Mateusz Rzeszutek
Trask Stalnaker
YuDong Tang
Matthew Ho
Lauri Tulmin
Anuraag Agrawal
Ago Allikmaa
Nikita Salnikov-Tarnovski
neinoi
Pavol Loffay