Commit Graph

96 Commits

Author SHA1 Message Date
Lauri Tulmin e207579370
Rename method, use Telemetry instead of Metrics (#13574) 2025-03-25 11:03:32 +02:00
Trask Stalnaker dbe9679777
Simplify Http `*TelemetryBuilder` generic signatures (#12858) 2025-03-13 07:25:24 -07:00
Lauri Tulmin 6c6223b969
Use latest.release instead of + (#13485) 2025-03-11 11:42:21 +00:00
Trask Stalnaker ffda571dd4
Remove deprecated HTTP library methods (#13150) 2025-02-01 08:05:03 +02:00
Trask Stalnaker c66816fa49
Rename setSetEmit... to internalSetEmit... (#13034) 2025-01-14 07:47:25 +02:00
Trask Stalnaker 2ea27b29e2
End span after closing scope (#12952) 2024-12-27 09:22:26 -08:00
Trask Stalnaker e5a9d1cfb7
Change `setKnownMethods(Set)` to `setKnownMethods(Collection)` (#12902) 2024-12-24 10:29:15 -08:00
Trask Stalnaker 6b9e68ebfd
Change `setCaptured*Headers(List)` to `setCaptured*Headers(Collection)` (#12901) 2024-12-23 15:49:55 -08:00
Trask Stalnaker b08d272e23
Remove experimental methods out of (to-be-public) TelemetryBuilder classes (#12847) 2024-12-16 18:40:06 -08:00
Trask Stalnaker 4cc4e1c0b2
Consistent naming of addAttributesExtractor (#12860) 2024-12-10 12:45:20 -08:00
Gregor Zeitlinger b9f09cae88
Http server builder (#11651) 2024-10-07 09:41:24 -07:00
Gregor Zeitlinger e397159bfb
http server and client builder for netty (#12083) 2024-09-24 07:53:18 +03:00
Serkan ÖZAL d64eda3204
Add network peer address attributes to the span for the `okhttp-3.0` instrumentation (#12012) 2024-08-26 15:43:27 -07:00
Gregor Zeitlinger b00ccd7834
use DefaultHttpClientInstrumenterBuilder and DefaultHttpServerInstrumenterBuilder for armeria (#11797)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2024-08-14 17:37:24 -07:00
Gregor Zeitlinger 0e218de455
Remove reflection from builder (#11673) 2024-06-27 07:38:54 +00:00
Gregor Zeitlinger 47ebb94253
re-use logic for http client configuration (#11620)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2024-06-21 16:58:41 -07:00
Lauri Tulmin 99aa42a680
Add http/2 tests for okhttp3 (#11523) 2024-06-12 14:04:25 +03:00
Lauri Tulmin 7a06507f80
Allow library instrumentations to override span name (#11355)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2024-05-17 12:10:32 +03:00
Lauri Tulmin a2d4148067
Remove http stable semconv tests (#10087) 2023-12-21 08:30:26 -08:00
Mateusz Rzeszutek 65ee9510f5
Rename the `instrumentation-api-semconv` module into `instrumentation-api-incubator` (#9985) 2023-12-04 08:28:10 +01:00
Mateusz Rzeszutek dc81aae72f
Move HTTP classes to instrumentation-api (#9977) 2023-12-01 12:04:06 +01:00
Mateusz Rzeszutek d6c2aff7c2
Change `http.request.body.size` and `http.response.body.size` attributes from recommended to opt-in (#9799) 2023-11-02 11:20:50 -07:00
Mateusz Rzeszutek ea8f3d0e24
Rename http.resend_count to http.request.resend_count (#9700) 2023-10-17 11:03:48 -07:00
Lauri Tulmin d157b68efb
Use HTTP instead of non-known method in http span name (#9441)
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-09-13 10:14:30 -07:00
Mateusz Rzeszutek d7a34f90ba
Refactor and rename `HttpClientResend` and `HttpRouteHolder` (#9280)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-08-26 00:37:25 +00:00
Lauri Tulmin b9e459da07
Test http client stable semconv (#9178) 2023-08-13 10:22:04 -07:00
Trask Stalnaker 67f91b8833
Update network.protocol.version 2.0 -> 2 and 3.0 -> 3 (#9145) 2023-08-13 10:01:47 -07:00
Mateusz Rzeszutek d81630331b
Make `HttpClientAttributesGetter` extend `NetClientAttributesGetter` (#9015) 2023-07-31 11:09:09 -07:00
Mateusz Rzeszutek cabf0dfdf4
Refactor setKnownMethods() in HTTP instrumentations to avoid nullable… (#8994) 2023-07-23 20:03:14 -07:00
Mateusz Rzeszutek 59e2da5aa3
Extract HTTP client experimental metrics to a separate class (#8769) 2023-07-18 08:34:39 -07:00
Mateusz Rzeszutek cc8160cffb
Support the `http.request.method_original` attribute (#8779) 2023-07-17 09:41:41 +00:00
Mateusz Rzeszutek cde2e70148
Implement new stable server semantic conventions (#8663) 2023-06-13 11:07:59 +02:00
Mateusz Rzeszutek 506ccb6b7d
Implement new stable network semantic conventions (#8616) 2023-06-12 16:51:47 +02:00
Mateusz Rzeszutek 5b03ae655f
Implement new stable HTTP semantic conventions (#8632) 2023-06-08 20:02:45 -07:00
Mateusz Rzeszutek 8ee63d4441
Implement new stable URL semantic conventions (#8491) 2023-06-05 15:22:22 +00:00
Mateusz Rzeszutek c21ec3f8e8
Implement HTTP resend spec for OkHttp 3 (#7652) 2023-05-15 17:53:22 -07:00
Mateusz Rzeszutek e3944a53a5
Make net.transport an optional attribute (#8279) 2023-04-20 08:14:03 -07:00
Mateusz Rzeszutek f501569106
Switch from http.flavor to net.protocol.* in HTTP client instrumentat… (#8131) 2023-04-07 13:39:42 +02:00
Lauri Tulmin a51535d08e
Test http client captured headers (#7993) 2023-03-07 20:05:29 +02:00
Mateusz Rzeszutek e1895e548c
Rename all methods in all Getters to use the `get*()` naming scheme (#7619)
Resolves #6562

This PR only contains renames; the actual content is in the `*Getter`
interfaces, the rest of changes is just IntelliJ doing its job.
2023-01-23 09:28:11 +00:00
Amir Blum 911b3b5feb
docs(okhttp): fix class name in README (#7578)
for okhttp-3.0 instrumentation, the README uses `OkHttpTracing`:
```java
import io.opentelemetry.instrumentation.okhttp.v3_0.OkHttpTracing;
...
return OkHttpTracing.builder(openTelemetry).build().newCallFactory(createClient());
```

#5624 changed `OkHttpTracing` to `OkHttpTelemetry` but the docs still
show the previous value which no longer works
2023-01-15 09:10:05 -08:00
Mateusz Rzeszutek 95ec4a8c1f
HTTP semconv: filter out default peer/host ports (#7258)
After a loooong break, the next part of the HTTP semconv implementation:
filtering out default HTTP ports, client and server.

>  [5]: If not default (80 for http scheme, 443 for https).


https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client
2022-11-22 17:14:20 +00:00
Aaron Ai 2d7395c44b
Introduce markdown lint check (#7175)
Fixes #7129
2022-11-16 20:48:42 -08:00
Lauri Tulmin b0012b083b
okhttp: run our interceptor before other interceptors (#6997)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/6909
If our interceptor runs before other interceptors then other
interceptors replacing the request won't affect our interceptor.
2022-10-27 12:45:02 -07:00
Trask Stalnaker 71b3e3e027
Library doc cleanup (#6948)
Related to #6947, but just cleans up the library module doc that already
existed (mostly for uniformity). Does not introduce any new doc.
2022-10-24 10:26:21 -07:00
Mateusz Rzeszutek 77035fc88c
Extract `net.peer.{name,port}` on start for CLIENT spans (#6828)
The [HTTP
spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client)
says these two attributes must be provided at span creation time - I
think it makes sense to extend it over to all `net`-related
instrumentations, cause these are supposed to be the logical peer
name/port, which are supposed to be known before the connection is
started/exchange is made.
2022-10-10 16:00:19 -07:00
Trask Stalnaker 429ecfc713
Update error prone (#6646)
(note that change from BDDMockito is due to
https://github.com/google/error-prone/issues/3396)
2022-09-23 11:24:40 -07:00
Mateusz Rzeszutek a83e6ca652
Refactor OkHttp tests to Java (#6484)
* Refactor OkHttp tests to Java

* throws Exception
2022-08-24 09:18:15 -07:00
Trask Stalnaker f1774cabe2
Update net semantic convention changes (#6268)
* New net conventions: option a

* Feedback + sock.family + sock.peer.name

* peer.service + tests

* server net attributes attempt 1

* server net attributes attempt 2

* Javadoc

* Revisions

* Apply to instrumentations

* Feedback

* One more default method

* Spotless

* Fix javadoc
2022-08-18 09:02:23 -07:00
Mateusz Rzeszutek 6cd79b2a94
Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode() (#6466)
* Deprecate the 2-arg variant of HttpCommonAttributesGeter#statusCode()

* fix liberty
2022-08-12 17:11:11 -07:00