b4a1e2e9ee
Fix ClassCastException in JDBC instrumentation ( #6088 )
...
* Move DbInfo to boot loader
* add comment
* add test
* spelling
2022-06-16 12:09:24 -07:00
1c388d46fc
Revert workaround for a spock bug ( #6154 )
2022-06-13 13:12:45 -07:00
6a0ca530b7
Instrumentation API changes: VirtualField ( #6017 )
...
* Instrumentation API changes: VirtualField
* change class name in string constant
2022-05-12 11:17:24 -07:00
2f4d2ab679
Ignore known problematic jdbc wrappers ( #5967 )
2022-05-03 12:16:17 -07:00
d919f84cf8
Merge javaagent-instrumentation-api into javaagent-extension-api ( #5936 )
...
* Merge javaagent-instrumentation-api into javaagent-extension-api
* remove some leftover references to javaagent-instrumentation-api
* add missing instrumentation-api to distro example
2022-04-28 20:11:15 -07:00
8e722cc264
Library instrumentation should read its version from a file ( #5692 )
...
* Library instrumentation should read its version from a file
* errorprone
* animalsniffer
* code review comments
* add name as task input too
* code review comments
2022-04-04 11:52:23 -07:00
56f65e4fab
Convert all logging statements from slf4j to jul - part 1 ( #5628 )
...
* Convert all logging statements from slf4j to jul - part 1
* fix tests
* use placeholders
* fixed all comments, added static imports for Level
2022-03-22 10:35:27 -07:00
e9c1efece2
Update to Groovy 4 ( #5532 )
...
* Update to Groovy 4
* exclude spock from grails tests, update comment
* Update instrumentation/grails-3.0/javaagent/build.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-03-09 15:07:41 -08:00
47f2732aae
Split out DbClientAttributesGetter and SqlClientAttributesGetter ( #5354 )
...
* Split out DbClientAttributesGetter and SqlClientAttributesGetter
* code review comments
2022-03-04 09:58:04 -08:00
27ed47ccda
Split out CodeAttributesGetter ( #5342 )
2022-02-17 16:47:18 -08:00
1077258263
Add InternalJavadoc custom error prone check ( #5277 )
...
* Add InternalJavadoc custom error prone check
* Add example usage
* Move to conventions
* Revert "Move to conventions"
This reverts commit d8a8209b59
2022-02-01 17:54:57 -08:00
c5c0a2bcdf
NetClientAttributesAdapter - favor composition over inheritance ( #5030 )
...
* first pass at separating NetAttributesAdapter interface and make NetClientAttributesExtractor concrete
* rename the implementations extractor -> adapter
* hide constructor and make factory method
* rename to client and add javadoc
* spotless
* finish javadoc thought
* rebase
* renamed NetClientAttributesAdapter to NetClientAttributesGetter
* fix lettuce
* code review comments
* code review comments -- renaming for consistency
* adapter -> getter
* fix ratpack
* adapter -> getter
2022-01-20 10:51:13 -08:00
b7a95857c7
Fix some java lint warnings ( #5120 )
...
* Convert InstrumentationTestRunner from interface to abstract class
* Foo
* Commit
* Revert unintended
2022-01-17 10:26:03 -08:00
f6bcd76219
Update errorprone ( #5016 )
...
* Update errorprone
* gwt
* Remove unnecessary final
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-06 14:21:56 -08:00
ce4cef76f9
Clean up groovy assertions ( #4805 )
2021-12-05 23:23:58 -08:00
c79eed765f
Make JdbcData fields final ( #4738 )
2021-11-29 13:00:49 -08:00
d314d76fce
rename `newBuilder()` to `builder()` ( #4475 )
...
* rename `newBuilder()` to `builder()`
* rename `newBuilder()` to `builder()`
2021-10-22 20:50:43 -07:00
9b8ab5eeec
Migrate to spock 2 ( #4458 )
...
* Migrate to spock 2
* Fix smoke test suites
* address review comments
* review comment
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-22 08:40:58 -07:00
ac91dc090a
Type annotation placement ( #4406 )
...
* switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable`
* code format
2021-10-17 17:38:43 -07:00
63a2383905
Split NetAttributesExtractor into NetClientAttributesExtractor and NetServerAttributesExtractor ( #4287 )
...
* Net Extractors
* Either request or response but not both
* Fix merge conflicts
* Separate by OnStart/OnEnd
* PeerServiceAttributes
* Fix test
* Restructure to client/server
* Fix merge conflict in main
* more
* peer.service
* Feedback
* peer.service is only for clients
* Fix merge conflict
* rename
* Armeria
* peer.service is only for clients
* rename
* WIP
* Sync Dubbo with Armeria
* More Dubbo and Armeria
* gRPC
* Revert some Dubbo changes
* more peer.service
* Fix test
* Fix merge
* Fixes
2021-10-07 15:40:15 -07:00
a48bd9de3f
Move PeerServiceAttributesExtractor from javaagent api to instrumentation api ( #4235 )
...
* Move PeerServiceAttributesExtractor from javaagent api to instrumentation api
* spotless
2021-10-06 12:42:55 -07:00
95651a4f1b
Intern db info ( #4263 )
2021-10-03 19:47:40 -07:00
c11b96e4d0
Make it possible to use InstrumentationContext (now VirtualField) fro… ( #4218 )
...
* Make it possible to use InstrumentationContext (now VirtualField) from library instrumentation
* fix tests
* fix javadocs
* fix some more tests
* code review comments
* setIfNull, computeIfNull
2021-10-01 11:13:11 +02:00
abfcfb9dc7
Fix JDBC instrumentation deadlock ( #4191 )
2021-09-23 08:52:01 -07:00
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
b61113fef6
JDBC: use ContextStore when running as agent ( #3987 )
...
* JDBC: use ContextStore when running as agent
* address review comments
* use singular
2021-08-27 14:14:40 -07:00
e0cb216610
Remove remaining usages of basic span asserts ( #3616 )
2021-07-19 10:09:44 -07:00
f5ce4c03f8
Inline basic usages of basicSpan ( #3583 )
...
* Inline basic usages of basicSpan
* spock
2021-07-18 21:15:51 +03:00
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
dffb12fd44
Add missing test verification ( #3578 )
2021-07-15 09:15:12 +03:00
9b56fc9051
Clean up AgentElementMatchers ( #3527 )
...
* Clean up AgentElementMatchers
* remove a TODO
* moved method
2021-07-09 10:02:21 +03:00
9e4da754c2
Use consistent logger field name ( #3515 )
2021-07-07 10:47:46 -07:00
b304cc2912
Deprecate CallDepth.reset() and get() ( #3511 )
...
* Deprecate CallDepth.reset() and get()
* Don't pass CallDepth around
2021-07-07 09:24:50 -07:00
c5ba5c3a71
Use local variable for passing CallDepth between advice enter/exit me… ( #3504 )
...
* Use local variable for passing CallDepth between advice enter/exit methods
* fix broken call depth tracking
* checkstyle
* fix javadocs
2021-07-06 12:05:14 -07:00
9979bef877
JDBC instrumentation: switch to use api instead of implementation for instrumentation-api. ( #3494 )
...
* Switch to use api instead of implementation for instrumentation-api.
* Removed duplicated dependency.
2021-07-06 09:20:41 -07:00
b9fcb6b498
Reduce CallDepth classes' API surface ( #3497 )
2021-07-06 09:24:19 +02:00
642f213c12
Remove hardcoded version ( #3470 )
...
* Remove hardcoded version
* Codenarc
2021-07-01 23:00:15 -07:00
ed02aff7b5
OpenTelemetry JDBC instrumentation library ( #3367 )
...
* Added jdbc library with ported version of OpenTracing JDBC Instrumentation.
* Gradle 7.1.
* Revert "Gradle 7.1."
This reverts commit e3df35b0
2021-07-01 10:35:07 -07:00
15ed01d4fc
Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} ( #3411 )
...
* Change all instrumentation names to io.opentelemetry.{libName}-{libVersion}
* minumum supported version
2021-06-30 15:34:36 +02:00
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
2f528e4166
Rename *Instrumenters to *Singletons ( #3335 )
2021-06-16 10:12:37 -07:00
224dc51e93
Migrate java.gradle to conventions plugin ( #3289 )
...
* Migrate java.gradle to convention plugin.
* Switch to java-conventions
* Remove old file
* Fix
* Fix merge
* Missing paragraph
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-15 08:10:39 +09:00
62f1f49bcd
Intellij cleanup (Java and Groovy) ( #3285 )
...
* Intellij cleanup
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/messaging/MessagingAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/spring/spring-web-3.1/library/src/test/java/io/opentelemetry/instrumentation/spring/httpclients/RestTemplateInterceptorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Use glassfish version that supports lambdas
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 10:23:01 -07:00
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
e9c3df6dac
Static factory method ordering ( #3206 )
2021-06-07 15:29:30 -07:00
a78ed4c420
Rename some extractor request/response params ( #3202 )
2021-06-07 11:41:47 -07:00
2436499a09
Update to Errorprone 2.7 ( #3181 )
...
* Update to errorprone 2.7
* ToString
* Finish
2021-06-04 10:40:55 +09:00
5e4c5684e6
Moved jdbc-datasource instrumentation to Instrumenter API ( #3160 )
2021-06-02 23:45:11 -07:00
c3dedbb64e
Enable all errorprone checks ( #3155 )
...
* Enable all errorprone checks
* Fixes
* Finish
* Finish
* Add flag to disable error prone
2021-06-01 17:41:08 +09:00
ed88cca533
Migrate from spotbugs to errorprone ( #3122 )
...
* Migrate from spotbugs to errorprone
* Fix hashtable
* try-with-resources
* Fix from merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
c358a35414
Use dependency management pattern for dependency versions ( #3113 )
...
* Use dependency management pattern for dependency versions.
* Add groovy bom too
* Update dependencyManagement/dependencyManagement.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
c8ecd9a619
Add response type parameter to db attributes extractor ( #3093 )
...
* Add response type parameter to DbAttributesExtractor
* AutoValue
* ResultSet
2021-05-26 23:13:33 -07:00
38830ea06e
Fix JdbcInstrumentationTest ( #3089 )
2021-05-26 08:25:20 -07:00
d755654c29
[WIP] Add peer.service to Instrumenter API ( #3050 )
...
* [WIP] Add peer.service to Instrumenter API
* Move PeerServiceAttributesExtractor to javaagent-api and use reflection to add it
* Finish PeerServiceAttributesExtractor
* Fix tests
* Add peer.service to apache-httpclient-5.0, jedis-1.4, lettuce-4.0
2021-05-25 15:31:41 +02:00
329233e576
Change a couple of Longs to Integers in Instrumenter API ( #3043 )
2021-05-20 14:33:22 -07:00
6efae9ad28
Remove duplicate method ( #3032 )
2021-05-19 11:56:34 -07:00
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
85522cb2ed
Avoid loading advice classes in agent class loader ( #3008 )
...
* Lettuce 5.0
* Lettuce 4.0
* Ratpack
* Cassandra 4.0
* Grizzly
* KHttp
* External annotations
* Test
* Jdbc
* Method instrumentation
* OTel annotations
2021-05-16 20:07:20 -07:00
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
1086bce0b0
Add comment to JDBC DataSource instrumentation ( #2940 )
2021-05-11 09:52:42 -07:00
abeca79e24
Some Gradle optimizations ( #2949 )
...
* Gradle optimizations
* Finish
2021-05-11 17:45:54 +09:00
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
c9a3793bf8
Instrumenter API improvements ( #2860 )
...
* Instrumenter API improvements
* Move HTTP & net classes to separate packages
* Remove `db` prefix from method names in `DbAttributesExtractor`
* Add request-only net attributes extractor (it'll be needed in spring-sleuth-otel once we decide to use Instrumenters there)
* One NetAttributesExtractor class, javadocs
* add missing @Nullable
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-06 11:35:38 +02:00
9f8371e77c
Use locale insensitive lower/upper case conversion ( #2838 )
2021-04-22 11:24:13 +09:00
bd829a6494
Remove duplicate status verification ( #2710 )
2021-04-19 11:41:37 -07:00
3faf693631
Fix tests on the main branch ( #2795 )
...
* Fix tests on the main branch
* And fix muzzle by the way
2021-04-13 19:30:13 +02:00
113ef24bef
Use Instrumenter in JDBC instrumentation ( #2739 )
...
* Use Instrumenter in JDBC instrumentation
Except jdbc-datasource, that one is going to be in a separate PR
* Use Instrumenter in JDBC instrumentation - code review comments
2021-04-13 16:19:13 +02:00
d741dc48b9
Minor rename of javaagent unit test modules ( #2784 )
2021-04-13 12:36:30 +03:00
5c280d4c43
Fix JDBC instrumentation: recursive statements inside Connection#getMetaData ( #2756 )
2021-04-09 10:46:12 -07:00
25dd2cf194
Verify span kind in all tests ( #2715 )
2021-04-05 12:57:48 -07:00
79d7e88e53
Use Caffeine for weak maps ( #2601 )
...
* Caffeine weakmap
* Use Caffeine for weak maps
* Drift
* Drift
* Remove weak-lock-free
* Update licenses
* Fix bug
* Restore weaklockfree
* Clean
* Fixes
* Inline expunction
* Synchronized
* More comment
* Fix shading
* Executor
* computeIfAbsent and delete unused.
* Fix license report
2021-03-24 17:12:26 +09:00
ae23b97ec4
Move and rename NetPeerUtils ( #2548 )
...
* Move and rename NetPeerUtils
* Rename NetPeerUtils to NetPeerAttributes; inject instance instead of using a global var
* Rename SpanAttributeSetter to AttributeSetter (might be used to set on AttributesBuilder in the future, who knows)
* Deprecate default BaseTracer constructor: library instrumentations are supposed to inject all dependencies, the javaagent should explicitly pass globals
* fix compilation failure
* Remove peer.service customization from library instrumentation
2021-03-16 13:50:19 +01:00
92d61b5844
Auto value ( #2494 )
...
* SqlStatementInfo as AutoValue
* RequestMeta as AutoValue
* DbInfo as AutoValue
* After merge compilation fix
* CouchbaseQuerySanitizer compilation fix
* JdbcConnectionUrlParserTest compilation fix
* Revert "RequestMeta as AutoValue"
This reverts commit 609b57ee48
2021-03-09 15:07:03 +02:00
94872b1ced
Move DB helpers to instrumentation-api ( #2511 )
...
* Move DB helpers to instrumentation-api
* Fix gradle config
* Remove legacy
2021-03-08 12:32:36 +09:00
5317b7e7f1
Enrich JDBC spans with db.operation and db.sql.table ( #2425 )
2021-02-27 12:44:20 +02:00
fd55ce226a
Refactor DatabaseClientTracer (in preparation for low-cardinality span names) ( #2398 )
...
* Refactor DatabaseClientTracer (in preparation for low-cardinality span names)
* spotless
2021-02-26 15:36:24 +01:00
0adeb85f43
Refactor InMemoryExporter and move some of its methods … ( #2264 )
...
* Refactor InMemoryExporter and move some of its methods to spock base class & junit extension
* codenarc
* spotless
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* fix armeria library tests
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-15 17:36:14 +01:00
0fbdcad1dd
Make BaseTracer#startSpan() return Context ( #2232 )
...
* Make BaseTracer#startSpan() return Context
* Update instrumentation/apache-camel-2.20/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachecamel/CamelEventNotifier.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* spotless
* Add Javadocs to BaseTracer
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-12 12:12:40 +01:00
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
93b3a3b289
testing-common refactoring: replace direct AgentTestRunner usage with… ( #2134 )
...
* testing-common refactoring: replace direct AgentTestRunner usage with spock spec
* Updated instrumentation docs
* Fix reactor-core library tests
ReactorCoreTest was getting a tracer from GlobalOpenTelemetry before LibraryTestTrait had a change to initialize the SDK
2021-02-01 11:32:25 +01:00
c61f3f2949
Use a single configuration property for db.statement sanitization ( #2125 )
...
* Use a single configuration property for db.statement sanitization
* spotless
2021-01-29 16:02:15 +09:00
782a646d89
Cache sql sanitized extraction ( #2094 )
2021-01-27 10:04:58 -08:00
20dadc1b6d
Replace two JavaCC lexers with a single JFlex one ( #2113 )
2021-01-26 14:03:11 -08:00
7122c4b2a5
Rename "normalize" to "sanitize" ( #2087 )
...
* rename SqlNormalizer to SqlSanitizer (more descriptive).
* rename normalize to sanitize.
* rename in comments and messages
* rename in variable to sanitized
* rename normalized -> sanitized in tests
* fixed broken tests
* rename variable.
Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
2021-01-22 15:49:24 +09:00
afdde0355b
Update to OTel 0.14.1 ( #2059 )
...
* Update SDK dependency to 0.14.1
* WIP
* Finish
* Cleanup
2021-01-18 13:02:04 +09:00
077d8b64f6
Move common matchers to tooling/bytebuddy/matcher and ignore matchers to tooling/matcher ( #1965 )
2021-01-10 12:35:53 -08:00
3b88bb75ae
Use SemanticAttributes for DbSystem ( #1991 )
2021-01-07 18:59:56 -08:00
8d74baa2e4
Run tests with javaagent. ( #1643 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-01-04 13:13:24 -08:00
4cbfb361e1
Use Context more in DatabaseClientTracer ( #1836 )
2020-12-07 09:15:15 +02:00
65f54e450b
Use Context more in HttpClientTracer ( #1811 )
...
* Use Context more in HttpClientTracer
* Better http-url-connection response object
* Follow database semantic conv for elasticsearch-rest
* Remove unnecessary CallDepth tracking
2020-12-03 11:47:08 -08:00
ca76c80820
Hardcode expected values in tests ( #1803 )
...
* DEFAULT_SPAN_NAME
* TEMP_DESTINATION_NAME
* LoggingContextConstants
* Remove unnecessary dependencies
* Hardcode expected normalized queries in tests
* Spotless
2020-11-30 09:16:59 +02:00
26f254b10d
Create javaagent dirs for all instrumentations, part 2 ( #1794 )
2020-11-28 22:26:49 -08:00
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00
9a64a628ea
Make instrumentations non final ( #1752 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-11-26 11:22:25 -08:00
50c8ab499d
Remove no longer needed helperClassNames() methods ( #1755 )
2020-11-24 20:50:32 -08:00
45646ff367
Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization() ( #1741 )
...
* Rename TypeInstrumentation#classLoaderMatcher() to classLoaderOptimization()
* Removed no longer needed comments & improved JavaDoc
* Improve TypeInstrumentation Javadoc
2020-11-24 14:27:58 +02:00
308a8f9b0f
Consistent equals implementations ( #1736 )
...
* Consistent equals implementations
* Use direct equals where previous behavior
2020-11-23 15:41:31 +02:00
Lauri Tulmin
Mateusz Rzeszutek
Trask Stalnaker
Lauri Tulmin
jason plumb
Anuraag Agrawal
Martin
Nikita Salnikov-Tarnovski
Matthew Ho
Anuraag Agrawal
Alexey Zhokhov
Piotr Glazar
Pavol Loffay