e3944a53a5
Make net.transport an optional attribute ( #8279 )
2023-04-20 08:14:03 -07:00
e03aaed32c
Disable connection recovery in rabbitmq test ( #8261 )
2023-04-10 19:18:21 -07:00
1b6d25e519
Disable automatic connection recovery in reactor rabbit test ( #8243 )
2023-04-07 06:41:40 -07:00
1cd634b341
Replace deprecated method ( #8230 )
2023-04-06 14:43:36 -07:00
c9c5aebb0b
Attempt to work around flaky reactor rabbitmq test ( #8232 )
2023-04-06 13:08:19 -07:00
46e5219f19
Remove some Optional usages ( #8190 )
...
I applied [this
comment](https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/8131#discussion_r1151076724 )
to the whole codebase and removed some `Optional`s that were used in the
hot path
2023-04-03 09:13:59 +02:00
5a14788fc1
Use .service instead of .getService() to get testcontainersBuildService ( #8188 )
2023-03-31 08:32:24 +00:00
f1411d1cb3
Share timer class used by messaging instrumentations ( #8009 )
...
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/4514
There is also a slightly different timer class in netty instrumentation
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/netty/netty-common/library/src/main/java/io/opentelemetry/instrumentation/netty/common/internal/Timer.java
that I didn't touch.
2023-03-10 10:40:41 +02:00
0dccc3ad56
Fix NPE in the RabbitMQ instrumentation ( #8021 )
...
Fixes #8020
2023-03-09 17:15:27 +00:00
1649a90e29
Add protocol name&version to net attribute getters ( #7994 )
...
In preparation for
https://github.com/open-telemetry/opentelemetry-specification/pull/3272
2023-03-09 11:37:52 +00:00
998e781009
Remove deprecated messaging.url attribute from messaging getter ( #8008 )
2023-03-09 11:41:51 +01:00
f074b93110
Update the OpenTelemetry SDK version to 1.23.0 ( #7800 )
...
Update the OpenTelemetry SDK version to `1.23.0`.
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-13 20:22:09 +00:00
a9c065930d
Return interface instead of concrete implementation in instrumentatio… ( #7658 )
...
…n-api-semconv
We're already doing that for `SpanNameExtractor`, `OperationMetrics`,
`ContextCustomizer`, etc., so I figured we should do the same for
`AttributesExtractor` implementation. Also, none of the implementations
have any additional public surface - aside from the builder/factory
method users can just simply use the interface everywhere.
2023-01-31 13:21:28 +01:00
e1895e548c
Rename all methods in all Getters to use the `get*()` naming scheme ( #7619 )
...
Resolves #6562
This PR only contains renames; the actual content is in the `*Getter`
interfaces, the rest of changes is just IntelliJ doing its job.
2023-01-23 09:28:11 +00:00
5345c87680
End groovy files with newline ( #7127 )
2022-11-10 12:21:55 +01:00
94e2248940
Use new semantic attribute constants ( #6946 )
2022-10-23 09:32:03 -07:00
77035fc88c
Extract `net.peer.{name,port}` on start for CLIENT spans ( #6828 )
...
The [HTTP
spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client )
says these two attributes must be provided at span creation time - I
think it makes sense to extend it over to all `net`-related
instrumentations, cause these are supposed to be the logical peer
name/port, which are supposed to be known before the connection is
started/exchange is made.
2022-10-10 16:00:19 -07:00
ab0c875015
Link RabbitMQ receive span with the producer span ( #6808 )
...
Similar to #6804 , but for RabbitMQ.
Also changed the span kind of the receive span to `CONSUMER`, to match
the spec.
2022-10-06 12:20:19 +03:00
cfdbe758f2
Net attributes getters changes (in preparation for HTTP spec impl) ( #6503 )
...
* Net attributes getters changes: instrumentation-api-semconv changes
* Net attributes getters changes: getter implementations
* Net attributes getters changes: test fixes
* Remove net.sock.host.name
* code review comments
* default getter methods & getPeerSocketAddress() method name
* set authority in grpc earlier
2022-09-12 09:20:27 -07:00
f1774cabe2
Update net semantic convention changes ( #6268 )
...
* New net conventions: option a
* Feedback + sock.family + sock.peer.name
* peer.service + tests
* server net attributes attempt 1
* server net attributes attempt 2
* Javadoc
* Revisions
* Apply to instrumentations
* Feedback
* One more default method
* Spotless
* Fix javadoc
2022-08-18 09:02:23 -07:00
07d7cfd551
Capture messaging header value as span attribute ( #6454 )
...
* Capture messaging header value as span attribute
* add comment
2022-08-11 17:28:04 -07:00
68a9f20eb3
Enable PrivateConstructorForUtilityClass errorprone check ( #6427 )
...
* PrivateConstructorForUtilityClass
* Advice
* More advice
* More
* More advice
* More
* Spotless
* Fix
* Fix
* Fix
* A better solution
* Revert
* More
* Fix
* Spotless
* Fix
2022-08-10 11:30:22 +03:00
82b39b1012
Rename `newInstrumenter()` into `buildInstrumenter()` ( #6363 )
...
* Rename newInstrumenter() into buildInstrumenter()
* spotless
2022-07-25 12:02:46 -07:00
e7887ac929
Idea: deprecate `Config`, add agent-only `InstrumentationConfig` ( #6264 )
...
* Idea: deprecate Config, add agent-only InstrumentationConfig
* fix
* fix camel test
* fix external-annotation tests
2022-07-08 16:20:49 +02:00
512a040025
Remove TimeExtractor and use internal API for setting start/end timestamps ( #6051 )
...
* Remove TimeExtractor and use internal API for setting start/end timestamps
* code review comments
2022-05-19 09:03:11 -07:00
d919f84cf8
Merge javaagent-instrumentation-api into javaagent-extension-api ( #5936 )
...
* Merge javaagent-instrumentation-api into javaagent-extension-api
* remove some leftover references to javaagent-instrumentation-api
* add missing instrumentation-api to distro example
2022-04-28 20:11:15 -07:00
50f91e6dee
Deprecate AttributesExtractor#set() method ( #5749 )
...
* Deprecate AttributesExtractor#set() method
* code review comments
2022-04-05 20:20:02 -07:00
f0bdce973e
Split out MessagingAttributesGetter ( #5626 )
2022-03-18 11:52:23 -07:00
551418c283
Refactor AttributesExtractor so that it extracts route from Context ( #5288 )
...
* Refactor AttributesExtractor so that it extracts route from Context
* typo
* fix tests
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpRouteHolder.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* fix all AttributesExtractors
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-02-08 10:38:41 +01:00
186c657b4e
Avoid potential for reverse name lookup ( #5305 )
2022-02-07 17:39:16 -08:00
23b33adb0a
Auto-format groovy files in Intellij ( #5260 )
...
* Auto-format groovy files in Intellij
* A bit of clean up
2022-01-28 09:29:46 -08:00
c5c0a2bcdf
NetClientAttributesAdapter - favor composition over inheritance ( #5030 )
...
* first pass at separating NetAttributesAdapter interface and make NetClientAttributesExtractor concrete
* rename the implementations extractor -> adapter
* hide constructor and make factory method
* rename to client and add javadoc
* spotless
* finish javadoc thought
* rebase
* renamed NetClientAttributesAdapter to NetClientAttributesGetter
* fix lettuce
* code review comments
* code review comments -- renaming for consistency
* adapter -> getter
* fix ratpack
* adapter -> getter
2022-01-20 10:51:13 -08:00
6884d66c09
Reduce top level instrumentation directories ( #4965 )
...
* akka
* dropwizard
* kafka
* reactor
* vertx
2021-12-22 10:16:13 -08:00
5869df80e5
Fix RabbitMQ instrumentation consumption on empty headers ( #4903 )
...
* Handle null on headers getters
* early returns
2021-12-14 12:01:16 -08:00
d6e69c746e
Fix typo in method name ( #4855 )
2021-12-09 10:16:59 -08:00
3188350f7f
Improve rabbitmq startup check ( #4813 )
2021-12-06 17:26:49 +02:00
ce4cef76f9
Clean up groovy assertions ( #4805 )
2021-12-05 23:23:58 -08:00
f948ef8051
Use containerIpAddress instead of hard-coded 127.0.0.1 in rabbit tests ( #4745 )
...
* Use containerIpAddress instead of hard-coded 127.0.0.1 in rabbit tests
* Fix a situation where testcontainers returns 'localhost' instead of IP
* Fix a situation where testcontainers returns 'localhost' instead of IP
* Don't use the getContainerIpAddress() method, it'll be deprecated anyways
2021-11-30 15:25:23 -08:00
f7efe07b06
Merge start and end time extractors ( #4692 )
2021-11-29 22:07:49 -08:00
4c39b212da
Fix rabbitmq latest dep test ( #4623 )
2021-11-10 12:40:33 -08:00
e7b8cca107
Convert TextMapSetters and TextMapGetters to enums ( #4522 )
...
* Convert TextMapSetters to enums
* Convert TextMapGetters to enums
2021-11-08 22:01:40 +02:00
458ff3e4d7
Convert RabbitMQ to Instrumenter ( #4463 )
...
* Convert RabbitMQ to Instrumenter
* Polish
2021-10-26 18:14:19 -07:00
8ea59f0846
Rename all InjectAdapters to Setters ( #4489 )
...
* Rename all InjectAdapters to Setters
* Errorprone fixes
* Make setter public
2021-10-25 12:36:59 -07:00
9b8ab5eeec
Migrate to spock 2 ( #4458 )
...
* Migrate to spock 2
* Fix smoke test suites
* address review comments
* review comment
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-22 08:40:58 -07:00
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
20c72f3e98
Format kotlin gradle files ( #3942 )
...
* Add ktlint for kotlinGradle
* ktlint fails on wildcard imports
* Auto-format kotlin gradle files
2021-08-25 13:43:57 +09:00
5c71d28ed7
Remove deprecated Config methods ( #3908 )
2021-08-23 16:44:54 -07:00
ff5472a822
Limit number of concurrently running docker tests ( #3664 )
...
* Limit number of concurrently running docker tests
* rename heavy to testcontainers
* use shorter expression
2021-07-27 15:41:39 -07:00
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
016a963640
fixed potential NullPointerException if AMQP.Properties::getHeaders returns null ( #3588 )
2021-07-15 10:27:23 -07:00
Mateusz Rzeszutek
Lauri Tulmin
OpenTelemetry Bot
Trask Stalnaker
jason plumb
Asaf Ben Aharon
Nikita Salnikov-Tarnovski
Matthew Ho
Anuraag Agrawal
Niki