842ab42136
Call shouldStart for Spring handler span ( #3793 )
...
* Call shouldStart for Spring handler span
* Update server span name even if shouldStart returns false
2021-08-09 09:22:43 -07:00
8cbec715ff
Fill HTTP_CLIENT_IP in ServerInstrumenter ( #3756 )
2021-08-05 13:11:30 +09:00
ba4db4801f
Clean up concurrent advice utilities in javaagent-instrumentation-api ( #3757 )
...
* Clean up concurrent advice utilities in javaagent-instrumentation-api
* fix classloading tests
2021-08-03 09:17:19 -07:00
f960456240
Add tests that verify that Span.current() works in spring batch listeners ( #3758 )
2021-08-03 09:17:03 -07:00
77dc1ecf27
Fix warning in build scripts ( #3739 )
2021-08-02 19:37:35 +03:00
b52fd39d8d
Port Spring Boot WithSpanAspect to Instrumenter API ( #3607 )
...
* Start porting WithSpanAspect to use Instrumenter API
* Some cleanup and refactoring
* Switch caching dependency to compile only
* Minor refactors, javadocs
* Fix instrumentation name
* Rename builder methods
* spotless
* Add request type to extract Method and WithSpan annotation, use method references
* Add comment about IntelliJ dependency workaround
* Make cache non-configurable, use AsyncOperationEndSupport directly
* Address PR comments
* Move to static factory method, method-keyed cache
2021-07-30 11:39:09 -07:00
cbd8bb29fd
Spring web instrumenter 2 ( #3731 )
...
* Refactor spring-web library instrumentation to Instrumenter API
* errorprone
* fix typo
2021-07-30 09:28:27 -07:00
0689f86ed3
Fix running tests from intellij ( #3702 )
2021-07-28 10:21:19 -07:00
91b302a7d2
Reduce overhead of unsampled requests ( #3681 )
...
* Optimize sampled out requests
* Comment
2021-07-27 17:00:00 -07:00
ff5472a822
Limit number of concurrently running docker tests ( #3664 )
...
* Limit number of concurrently running docker tests
* rename heavy to testcontainers
* use shorter expression
2021-07-27 15:41:39 -07:00
47be4a16b4
Convert HttpClientTest to JUnit ( #3652 )
...
* Migrate HttpClientTest to junit to allow both Java or spock tests.
* More
* Update
* Finish
* Cleanup
* Better stack
* Java 15
* Merge
* Fix name
* Cleanup
* ? extends
* Moar
2021-07-27 21:55:40 +09:00
e2d23cd8c1
Fix bounds check ( #3612 )
...
* Fix bounds check
* Update instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/aspects/WithSpanAspectAttributeBinder.java
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2021-07-20 09:29:45 +09:00
e0cb216610
Remove remaining usages of basic span asserts ( #3616 )
2021-07-19 10:09:44 -07:00
344e205720
Help out Intellij ( #3595 )
2021-07-16 15:55:30 +09:00
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
814239c8c0
Adds binding of attributes in methods annotated with @WithSpan ( #3188 )
...
* Add binding of span attributes for traced methods
* Spring Aspect support, memoization
* Test with attribute name from ParameterNameDiscoverer
* Refactorings, javadocs and tests
* Refactor out creating AttributeBinding to separate class
* Wrapped attribute bindings for array parameters
* Attribute binding for List and EnumSet
* Attribute binding for subclass of List with reflection helper class
* Fix test failures in JDK 8
* Attribute binding to Set<? extends Enum>
* Move attribute binding to instrumentation-annotation-support project
* Fix copypastaed missing imports in tests
* Simplify ParameterizedClass based on PR feedback and add javadocs
* Remove blank javadoc
* Switch to cache with weak keys for memoizing attribute bindings by method
* Remove binding support for EnumSet<?>
* Clean up javadoc
* Use SpanAttribute annotation from opentelemetry 1.4.0-SNAPSHOT
* Address some PR concerns
* Clean up
* Fix instrumentation dependency in Springboot
* Update documentation
* Switch javaagent dep to compileOnly per PR comment
* spotless
* Kick CI
* Rename annotation support module and packages
* Resolve SpanAttribute annotation at runtime with fallback for older OTel versions
* Remove unnecessary dependency
* Move reflection helper to annotation support module
* Remove unnecessary enum and fields from unit test
2021-07-14 13:32:07 -07:00
e5bbc392c6
Use 'Tasklet' for spans that are produced by custom Spring Batch asklets ( #3528 )
2021-07-13 08:41:31 +02:00
e46ae82e94
Springboot propagators ( #3506 )
...
* set propagators in sdk builder
* add test for propagators
* introduce CompositeTextMapPropagator
* simplify composite TextMapPropagator creation, use SDK names for PropagationType
* Update instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/propagators/PropagationAutoConfiguration.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/propagators/PropagationAutoConfigurationTest.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* replace enum with string, remove unnecessary noop propagator addition
* add warning and test for unsupported value
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-07-12 21:40:09 -07:00
f601863d12
Merge Java TraceUtils into extension and switch to Instrumenter API. ( #3532 )
...
* Merge Java TraceUtils into extension and switch to Instrumenter API.
* Woah
2021-07-10 13:21:12 +09:00
9b56fc9051
Clean up AgentElementMatchers ( #3527 )
...
* Clean up AgentElementMatchers
* remove a TODO
* moved method
2021-07-09 10:02:21 +03:00
9e4da754c2
Use consistent logger field name ( #3515 )
2021-07-07 10:47:46 -07:00
b304cc2912
Deprecate CallDepth.reset() and get() ( #3511 )
...
* Deprecate CallDepth.reset() and get()
* Don't pass CallDepth around
2021-07-07 09:24:50 -07:00
c5ba5c3a71
Use local variable for passing CallDepth between advice enter/exit me… ( #3504 )
...
* Use local variable for passing CallDepth between advice enter/exit methods
* fix broken call depth tracking
* checkstyle
* fix javadocs
2021-07-06 12:05:14 -07:00
b9fcb6b498
Reduce CallDepth classes' API surface ( #3497 )
2021-07-06 09:24:19 +02:00
15ed01d4fc
Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} ( #3411 )
...
* Change all instrumentation names to io.opentelemetry.{libName}-{libVersion}
* minumum supported version
2021-06-30 15:34:36 +02:00
15a64286e9
Fixed Semantic conventions in RabbitMQ ( #3425 )
...
* Fixed Semantic conventions in RabbitMQ
1. Constructed producer span name according to spec rule. (Removed routing key as part of span name)
2. Renamed routing key attribute(part of experiment span attributes feature) according to semantic convention
* Spring integration rabbitmq test fixed
* moved MESSAGING_RABBITMQ_ROUTING_KEY attribute out of CAPTURE_EXPERIMENTAL_SPAN_ATTRIBUTES check
2021-06-29 14:35:47 +03:00
52616dd87f
Skip problematic spring-rabbit muzzle ( #3420 )
2021-06-28 18:47:39 +09:00
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
bcb282a220
Conform to google style guide checkstyle ( #3399 )
2021-06-24 10:53:23 +03:00
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
02098b9353
Ignore task classes using IgnoredTypesConfigurer ( #3380 )
2021-06-23 10:15:02 -07:00
f451aef43c
Improve ignored but instrumented types assertion in javaagent tests ( #3356 )
...
* Improve ignored but instrumented types assertion in javaagent tests
* add one missing ignore
* Add ignored types to spring-rabbit and fix tests
* spotless
2021-06-22 22:37:29 -07:00
57fef6a2e7
Fix merge conflict. ( #3352 )
2021-06-18 11:37:02 +09:00
108b1298cf
Make @RabbitListener propagate context properly ( #3339 )
2021-06-17 10:38:53 -07:00
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
2f528e4166
Rename *Instrumenters to *Singletons ( #3335 )
2021-06-16 10:12:37 -07:00
3e28b01e42
Spring Integration javaagent instrumentation ( #3295 )
...
* Spring Integration javaagent instrumentation
* codenarc
* inline gradle property
* Conditionally create CONSUMER spans instead of always INTERNAL
* merge fix
* Add attributes assertions to rabbitMq test
* minor fix
* fix javadocs
* Code review follow-up
2021-06-16 14:12:39 +03:00
b7bfbf0cc6
Migrate instrumentation-library / common to plugins ( #3320 )
2021-06-15 11:54:48 -07:00
a818f14957
Migrate publish.gradle to convention plugin ( #3312 )
...
* Migrate publish.gradle to convention plugin
* Migrate usages of publish.gradle
* Remove publish.gradle
* Newline
2021-06-15 22:12:48 +09:00
7ad9e7a50b
Move shaded testing dependencies to internal package. ( #3305 )
2021-06-15 13:10:19 +03:00
224dc51e93
Migrate java.gradle to conventions plugin ( #3289 )
...
* Migrate java.gradle to convention plugin.
* Switch to java-conventions
* Remove old file
* Fix
* Fix merge
* Missing paragraph
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-15 08:10:39 +09:00
9f31a057b6
Refactor span names class ( #3281 )
...
* spanNameForMethod
* spanNameForClass
* Cache simple name using ClassValue
2021-06-14 11:56:40 -07:00
62f1f49bcd
Intellij cleanup (Java and Groovy) ( #3285 )
...
* Intellij cleanup
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/messaging/MessagingAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/spring/spring-web-3.1/library/src/test/java/io/opentelemetry/instrumentation/spring/httpclients/RestTemplateInterceptorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Use glassfish version that supports lambdas
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 10:23:01 -07:00
f1beb2397f
Intellij cleanup of markdown and yaml ( #3284 )
...
* Intellij cleanup of markdown and yaml
* Revert required yaml param
2021-06-14 13:13:01 +03:00
b25ac0f1ad
Clean up old operation name terminology ( #3282 )
2021-06-13 22:10:36 -07:00
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
84cc044ddf
Migrate remaining test client calls to Armeria and remove testing-com… ( #3250 )
2021-06-11 11:51:23 -07:00
4c6cfb52ab
Test spring-integration instrumentation with spring-cloud-stream example ( #3241 )
2021-06-11 11:49:16 -07:00
60aaff8972
Migrate HttpServerTest to Armeria ( #3240 )
...
* Migrate HttpServerTest to Armeria
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpServerTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-11 08:56:02 +09:00
e93ff4d419
Remove references to dropped request test ( #3238 )
2021-06-10 16:21:11 +03:00
1cc893b009
Spring Integration library instrumentation ( #3120 )
...
* Spring Integration library instrumentation
* testLatestDeps
* attributesExtractor
* errorprone
* Code review comments
* rename package messaging -> integration
* move package in groovy files too
* thread local map
* Revert "thread local map"
This reverts commit 7c8d614f4c
2021-06-10 14:51:32 +02:00
f9dcd03b4b
Rename unused try-with-resources scope variables ( #3201 )
2021-06-07 11:41:50 +09:00
cefaecab3f
Use more efficient namedOneOf where possible ( #3200 )
...
* Use more efficient namedOneOf where possible
* Fix - hasClassesNamed does and not or
2021-06-07 11:41:34 +09:00
7ef31a0169
Inject ObjectProvider into BeanPostProcessors to avoid premature initialization of OpenTelemetry ( #3171 )
2021-06-03 14:14:17 -07:00
c3dedbb64e
Enable all errorprone checks ( #3155 )
...
* Enable all errorprone checks
* Fixes
* Finish
* Finish
* Add flag to disable error prone
2021-06-01 17:41:08 +09:00
5e8568807b
Update spring-webmvc to Instrumenter API ( #3132 )
...
* Update spring-webmvc to Instrumenter API
* Remove hasExceptionOnServerSpan from grails too
2021-05-31 08:57:51 -07:00
d2906841bd
Fix flaky spring webflux tests ( #3150 )
2021-05-31 08:20:25 -07:00
fb0d047fce
Last type instrumentations to top-level classes ( #3123 )
2021-05-30 16:05:31 -07:00
ed88cca533
Migrate from spotbugs to errorprone ( #3122 )
...
* Migrate from spotbugs to errorprone
* Fix hashtable
* try-with-resources
* Fix from merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
c358a35414
Use dependency management pattern for dependency versions ( #3113 )
...
* Use dependency management pattern for dependency versions.
* Add groovy bom too
* Update dependencyManagement/dependencyManagement.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
df078f95a9
Extract HttpServerTest INDEXED_CHILD span attribute collection logic ( #3095 )
...
* Extrawct HttpServerTest INDEXED_CHILD span attribute collection logic
* Adjust whitespace
* Fix context issue with JAX-RS
* Rerun tests
2021-05-27 11:18:11 +03:00
0a34b2b056
Enable Spring WebFlux concurrency tests ( #3077 )
...
* Enable Spring WebFlux concurrency tests
* Fix Spring WebFlux test application scan scope
* codenarc fix
* Renamed package server.http to server.base
* Addressed PR comments
2021-05-26 08:29:46 -07:00
1313abe5cd
Fix flaky spring batch test ( #3051 )
...
* Fix flaky spring batch test
* Update instrumentation/spring/spring-batch-3.0/javaagent/src/test/groovy/ItemLevelSpanTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-20 14:31:27 -07:00
9f7cfd27b3
Avoid loading advice classes in agent class loader, part 2 ( #3031 )
2021-05-19 09:53:27 -07:00
42728c4b1f
Exclude broken spring-ws version from muzzle ( #3037 )
2021-05-19 19:05:31 +03:00
d1946f6774
Don't use type annotation style ( #3023 )
2021-05-18 10:23:09 -07:00
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
b4b102dbec
Enable http client connection failure tests ( #2998 )
2021-05-17 12:15:48 -07:00
95c16c4a3c
Start migrating Muzzle plugin to Java ( #2996 )
2021-05-15 16:22:05 +09:00
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
5f18691818
Fix Grails application error ( #2815 )
2021-05-11 18:01:42 -07:00
abeca79e24
Some Gradle optimizations ( #2949 )
...
* Gradle optimizations
* Finish
2021-05-11 17:45:54 +09:00
cd3dd581f9
Fix some remote connection tests ( #2933 )
2021-05-10 12:19:39 +09:00
6924656a60
Run tests with latest spring data version ( #2927 )
2021-05-07 11:31:30 -07:00
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
357140c081
Server span naming for servlet filters ( #2887 )
...
* Server span naming for servlet filters
* wildfly default servlet has empty mappings
* jetty11 requires java11
* try a differnt way to disable jetty11 tests on java8
* Update instrumentation/servlet/servlet-5.0/javaagent/src/test/groovy/TomcatServlet5FilterMappingTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* review fix
* rework to use InstrumentationContext
* remove debugging code
* move MappingResolver to avoid ClassCastException on wildfly
* Update instrumentation/servlet/servlet-3.0/javaagent/src/test/groovy/TomcatServlet3FilterMappingTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* review fixes
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-06 13:25:17 +03:00
2ab92f556e
Fix duplicate http client tracing headers ( #2842 )
...
* Fix duplicate spring webclient tracing headers
* Fix Akka Http
* Fix Armeria
* Fix Java 11 Http Client
* Fix OkHttp 2.2
* Fix PlayWS
2021-04-23 13:05:10 -07:00
1824e36b96
Better server span name for Grails and Wicket ( #2814 )
2021-04-22 14:16:54 -07:00
46c1212236
Remove forward and include spans ( #2816 )
2021-04-22 11:36:53 -07:00
c8af5f6e1e
Add missing Uroll annotations ( #2848 )
2021-04-22 16:25:22 +02:00
49cdcada88
Bump OTel API version in spring boot starter docs ( #2833 )
2021-04-21 21:18:41 -07:00
fa359a4a5d
Remove some testNotFound exclusions ( #2813 )
2021-04-19 15:44:58 -07:00
9464134ffd
Test failing async http request ( #2812 )
2021-04-19 14:11:27 -07:00
bd829a6494
Remove duplicate status verification ( #2710 )
2021-04-19 11:41:37 -07:00
9bd028f767
Remove unnecessary genericness ( #2797 )
2021-04-14 00:01:28 -07:00
078603caf5
Generate InstrumentationModule#contextStore() with muzzle ( #2775 )
2021-04-13 20:05:01 -07:00
5719bc30a6
Sync spring-boot-autoconfigure property names with SDK property names ( #2770 )
...
* Sync spring-boot-autoconfigure property names
* Change from otel.instrumentation to otel.springboot
* Remove duplicate/outdated doc
2021-04-12 13:21:40 +03:00
3bc058b10b
Don't create duplicate headers ( #2727 )
...
* Test infra
* Update examples
* Update instrumentation
* Update tests
* jaxrs-client fixes
* Remove doRequest/doReusedRequest
* Fix muzzle
* some fixes
* fix test
* doc
* not private
* Apply to doRequestWithCallback also
* Update doc
* groovy
* better
* Don't hardcode traceparent
* Reuse request in SpringRestTemplateTest
2021-04-12 12:21:16 +03:00
b8f50fe922
Add parent dirs for common instrumentations ( #2767 )
2021-04-10 10:53:56 -07:00
d8f6018ba6
Split HttpClientTest execution methods for sync and callback ( #2675 )
2021-04-06 15:26:01 -07:00
6ea316e22e
Remove timeout annotations ( #2725 )
2021-04-06 16:36:18 +09:00
b39348d640
Add -Werror flag to the build ( #2712 )
...
* Add -Werror to the build
* Add to javadoc also
* Run javadoc
* Change from "check javadoc" to "build"
* Fix javadoc warnings
2021-04-06 10:01:10 +03:00
b062e38117
Pass OpenTelemetry instance to WebFlux lib tracer ( #2730 )
2021-04-06 08:52:27 +03:00
7027006f66
Request handlers and test images for Tomcat 10 and Jetty 11 (Servlet API 5) ( #2703 )
...
* Tomcat 10 and Jetty 11 handlers with Servlet API 5
* Jetty 11 and Tomcat 10 Windows images
2021-04-05 09:45:02 -07:00
92f1223aee
Remove unnecessary skipVersions ( #2671 )
...
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-04-01 19:02:20 -07:00
1406855bb7
Revert "Prevent duplicate telemetry when using both library and auto instrumentation ( #2661 )" ( #2689 )
2021-04-01 16:11:15 -07:00
d5e526b9f3
Cache config values in instrumentations ( #2681 )
...
* Cache config values in instrumentations
* Bring back defaultEnabled()
* comment
* one problem
2021-03-31 22:54:20 -07:00
30434696ae
Prevent duplicate telemetry when using both library and auto instrumentation ( #2661 )
...
* Prevent duplicate telemetry when using both library and auto instrumentation
* Add unit test
* Fix Oshi tests
* Fix couchbase 3.1 tests
2021-03-31 10:57:04 -07:00
0d11dbe565
Fix webflux client filter subscribe ( #2646 )
...
* Fix webflux client filter subscribe
* Add test
* Fix test
* Fix test, take 2
* Fix another test
* Suppress test for another module
* Suppress another library instrumentation
* Another
* Add nested client suppression in Armeria
* Add comments
* Revert extra line
2021-03-31 07:54:41 +03:00
Trask Stalnaker
Anuraag Agrawal
Mateusz Rzeszutek
Lauri Tulmin
HaloFour
Anna Nosek
Rashmi
Ago Allikmaa