Commit Graph

12 Commits

Author SHA1 Message Date
Trask Stalnaker 3e087e8206
Add note about Optional/Stream usage to style guide (#8193)
Based on #8190 and
https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/8131#discussion_r1151528583

---------

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-04-03 20:15:59 +00:00
Trask Stalnaker d18a05b5a2
Add section to coding guidelines on Optional usage (#6894)
This was discussed a long while back, but never documented (and recently
came up in #6889)

Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
2022-10-22 18:07:00 -07:00
Trask Stalnaker c3e0c258d7
Update style guide regarding final local vars (#5055) 2022-01-10 10:01:08 +02:00
Martin ac91dc090a
Type annotation placement (#4406)
* switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable`

* code format
2021-10-17 17:38:43 -07:00
Trask Stalnaker f964a13fc9
Update Intellij setup docs (#4103) 2021-09-13 09:27:15 -07:00
Trask Stalnaker da75a7a6c6
Style guide section for Nullable annotation usage (#3499)
* Style guide section for Nullable annotation usage

* Set default to non-null

* More doc

* Review feedback
2021-07-08 08:54:26 -07:00
Trask Stalnaker b8b2760b44
Sync style guide with otel-java repo (#3265) 2021-06-14 10:02:24 +03:00
Trask Stalnaker e9a8beb231
Document final keyword usage in code style (#3287)
* Document final keyword usage in code style

* Update docs/contributing/style-guideline.md

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 15:36:41 +09:00
Trask Stalnaker e9c3df6dac
Static factory method ordering (#3206) 2021-06-07 15:29:30 -07:00
jason plumb 66dc6c934f
Document the static imports (style guidelines) (#2161)
* document the static imports that we like

* spotless

* Update docs/contributing/style-guideline.md

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-02 11:04:56 +09:00
Trask Stalnaker 6d5ec329d6
Enable checkstyle for google style guide (#1641) 2020-11-16 18:46:59 -08:00
Trask Stalnaker 7418143f5e
Split up the CONTRIBUTING doc (#784)
* Split up the CONTRIBUTING doc

* spotless
2020-07-25 13:54:14 +03:00