Commit Graph

4178 Commits

Author SHA1 Message Date
John Bley f30f5f0779
Fix 3 minor javadoc issues. (#225) 2020-03-11 13:25:39 -07:00
Brian Devins-Suresh db074b199a Make regular test less flaky too 2020-03-11 15:57:15 -04:00
Brian Devins-Suresh 00e331814d Use a different queue per test 2020-03-11 15:38:13 -04:00
Trask Stalnaker 5c4dc47710
Add JBoss logging support (#222) 2020-03-10 17:14:44 -07:00
Trask Stalnaker e5b83218ae
Rename elasticsearch modules (#221) 2020-03-10 16:51:07 -07:00
Trask Stalnaker dec9b95d87
Fix logback instrumentation (#218)
* Fix logback instrumentation

* Remove unnecessary shading
2020-03-10 16:34:09 -07:00
Trask Stalnaker d3a931384d
Add grouping modules (#220)
* Add mongo grouping module

* Add play and play-ws grouping modules

* Add netty grouping module

* Add jaxrs grouping module

* Add jaxrs-client grouping module

* Add jedis grouping module

* Add log4j grouping module

* Add couchbase grouping module

* Add aws-sdk grouping module

* Add apache-httpclient grouping module
2020-03-10 15:56:41 -07:00
Trask Stalnaker 08248e4f09
Fix link behavior (#223) 2020-03-10 15:08:22 -07:00
Tyler Benson 2f64edaea4 Make threshold based on average duration
This should help avoid too frequent of stacktraces when the configured threshold is a normal duration.
Alternatively, we could make it a percentage above the average.
2020-03-10 15:08:12 -07:00
Trask Stalnaker 0ae9ed8a48
Prevent DNS lookup by gRPC instrumentation (#224) 2020-03-10 14:53:04 -07:00
Tyler Benson 1cbb874c7c Replace FilteredStringWriter with direct StackTraceElement usage. 2020-03-10 13:18:22 -07:00
Tyler Benson 2b74487ed6 Add config to capture stacktrace when a span duration exceeds threshold
(But only when span is not errored or finished on a different thread.)

Use the following config:
```
-Ddd.trace.span.duration.stacktrace.millis=1000
```
(One second is the default, 0 disables.)
2020-03-10 13:18:22 -07:00
Tyler Benson e0b46da375 Improve consistency of `@Advice.OnMethodExit` params
And ordering of some `helperClassNames`
2020-03-10 13:11:22 -07:00
Laplie Anderson 872743db91
Merge pull request #1269 from DataDog/landerson/auto-versioning
Use plugin to automatically set version
2020-03-10 15:37:03 -04:00
Pontus Rydin e54ab56b3a
Implemented Apache Geode/Gemfire instrumentation (#215) 2020-03-10 11:18:36 -07:00
Tyler Benson 36c063c4b3
Merge pull request #1303 from trask/fix-for-spring-jms-listeners
Fix for Spring JMS listeners
2020-03-10 09:54:54 -07:00
Laplie Anderson 6d99b138d2 Don't create release tag 2020-03-10 12:26:46 -04:00
Laplie Anderson c14a9276b3 Add a release commit to match previous behavior 2020-03-10 12:26:46 -04:00
Laplie Anderson fa50a54552 Use plugin to automatically set version 2020-03-10 12:26:46 -04:00
Laplie Anderson ad818a1da4
Merge pull request #1305 from DataDog/landerson/fix-ignores-for-google
Fix ignores for com.google.inject
2020-03-10 11:54:48 -04:00
Trask Stalnaker cba031ddcb
Rename hibernate modules (#205)
* Rename hibernate modules

* Update tracer name

* Change from gradle inheritance to composition

This will make it possible to have empty "grouping" modules, e.g.
instrumentation:hibernate.

* Introduce empty hibernate grouping module
2020-03-09 15:33:21 -07:00
Trask Stalnaker 9715ed5d90
Fix the build (#219) 2020-03-09 14:45:57 -07:00
Laplie Anderson 7b5ebe3204
Merge pull request #1304 from DataDog/landerson/httprequest-attributes
Add traceId and spanId as request attributes
2020-03-09 17:43:59 -04:00
Laplie Anderson 645c4de2c9 Fix ignores for com.google.inject 2020-03-09 17:41:15 -04:00
Laplie Anderson 1a35ced75e Tomcat access log tests 2020-03-09 16:15:57 -04:00
Laplie Anderson 4dce8776e1 Add traceId/spanId as request attributes 2020-03-09 16:15:40 -04:00
John Bley 00ae1eca3d
Integrate SpotBugs into build (ignoreFailures=true), fix most found issues (#216)
* Integrate SpotBugs (FindBugs) into build.  Set ignoreFailures so spotted bugs do not break the build.

* Fix many SpotBugs-found items, mostly making things final, but also a redundant null check and a reliance on platform character encoding.  2 items remain which will need further work/review, but as ignoreFailures is set, they will not fail the check stage.

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-03-09 10:47:49 -07:00
Tyler Benson b16f98dece
Merge pull request #1302 from trask/revert-removal-of-non-delegating-loader-check
Revert removal of non-delegating loader check
2020-03-09 10:44:14 -07:00
Trask Stalnaker 279af696f4 Improve test reliability 2020-03-09 09:30:31 -07:00
Trask Stalnaker 7761094280 Fix for Spring JMS listeners 2020-03-08 22:41:58 -07:00
Trask Stalnaker 5834b2cab1 Add comment explaining why keeping delegate check 2020-03-06 13:37:01 -08:00
Trask Stalnaker 0ca384d24c Revert "Remove non-delegating class loader check"
This reverts commit c63c981221.
2020-03-06 13:21:02 -08:00
Trask Stalnaker 7ede895b53 Revert "Cache is not needed anymore"
This reverts commit 166d951a10.
2020-03-06 13:18:08 -08:00
Trask Stalnaker ea74337c10
Redo log capture instrumentation (#212)
Make it clear that this is experimental option, as the specifics of log
capture will definitely change sometime in the future once there is an
agreed on OpenTelemetry spec for this.

Capture logs as spans, to avoid the limitations of current
implementation that captures them as events (no log capture when no
current span, and limited number of events per span).

Change the log instrumentation module names to just reflect the
underlying logger, e.g. "log4j-1.1" instead of "log4j-spans-1.1". This
way we don't end up with an entirely deprecated artifact once the
logging spec is worked out. The spans instrumentation now shares modules
with the MDC instrumentation, which I think is reasonable, as you pick
which one you want via configuration.
2020-03-06 13:05:44 -08:00
Douglas Q Hawkins 3ff5b99cd6
Merge pull request #1285 from DataDog/dougqh/jar-file-collisions
Avoid temporary Jar file collisions
2020-03-06 15:14:25 -05:00
Tyler Benson aca4b9ece9
Merge pull request #1300 from DataDog/tyler/servlet-forward
Stop creating a "top level" servlet span when in a forward/include situation
2020-03-06 11:46:27 -08:00
Nikolay Martynov 98ea5a8e87
Merge pull request #1293 from DataDog/mar-kolya/scale-back-ignores
Scale back ignores
2020-03-06 14:34:08 -05:00
Nikolay Martynov 46b776f76a Include classloading instrumentation into all tests
Classloading instrument core JDK classes so we should make sure this
doesn't have bad effects on other instrumentations.
2020-03-06 13:50:56 -05:00
Nikolay Martynov 517ecca4c1 Remove explicit concurrent instrumentation dependencies
Since we include concurrent instrumentation for all instrumentatin
projects now there is no point in including it in every instrumentation.
2020-03-06 13:50:51 -05:00
Nikolay Martynov 2917034d29 Increase hystrix test timeout 2020-03-06 13:49:55 -05:00
Nikolay Martynov 51630ada62 Unignore `org.h2.util.Task` 2020-03-06 13:49:55 -05:00
Nikolay Martynov 4aac30826d Split Runnable and Callable instrumentations
Otherwise `Runnable` may define `call` method leading to
instrumentation exception.
See `org.h2.util.Task` as an example.
2020-03-06 13:49:55 -05:00
Nikolay Martynov 18f9c653b9 Exceptions for hppc 2020-03-06 13:49:55 -05:00
Nikolay Martynov a261fb4760 More spring exceptions 2020-03-06 13:49:55 -05:00
Nikolay Martynov 930c1fb4e9 One more exception for h2 2020-03-06 13:49:55 -05:00
Nikolay Martynov fd4257627d Do not ignore org.springframework.util.concurrent. 2020-03-06 13:49:55 -05:00
Nikolay Martynov 74161a5872 Add missng dots 2020-03-06 13:49:55 -05:00
Nikolay Martynov ab8b246553 Remove asm matchers - asm is already matched elsewhere 2020-03-06 13:49:55 -05:00
Nikolay Martynov a8c625b8f0 Fix google http client ignore matchers 2020-03-06 13:49:55 -05:00
Nikolay Martynov e301761dc2 Stop ignoring org.springframework.scheduling.annotation
It has some runnables and it is not very big
2020-03-06 13:49:55 -05:00