bb677a0cc3
Consolidate request listener lists ( #5667 )
2022-03-23 10:56:39 -07:00
5ab23f203f
Add InstrumenterBuilder.addRequestListener ( #5655 )
2022-03-22 11:45:05 -07:00
56f65e4fab
Convert all logging statements from slf4j to jul - part 1 ( #5628 )
...
* Convert all logging statements from slf4j to jul - part 1
* fix tests
* use placeholders
* fixed all comments, added static imports for Level
2022-03-22 10:35:27 -07:00
f0bdce973e
Split out MessagingAttributesGetter ( #5626 )
2022-03-18 11:52:23 -07:00
213057d057
Run check during testing and assemble during building ( #5619 )
2022-03-18 13:48:51 +09:00
1ee60aa6e6
Split out RpcAttributesGetter ( #5548 )
...
* Split out RpcAttributesGetter
* code review comments
* go back to RpcAttributesGetter
2022-03-17 11:14:19 +01:00
b92bb41331
Change the way how SpanKeys are extracted in instrumentation-api ( #5546 )
...
* Change the way how SpanKeys are extracted in instrumentation-api
* fix tests
* code review comments
2022-03-15 09:59:11 -07:00
b0d5fc6b99
Remove deprecated methods from instrumentation-api and library instrumentations ( #5575 )
2022-03-15 09:33:48 +09:00
0ad07a10c2
Remove AsyncInstrumentRegistry after update to SDK 1.12 ( #5525 )
...
* Remove AsyncInstrumentRegistry after update to SDK 1.12
* added comments
2022-03-10 13:39:23 +09:00
f6cca58f1f
Deprecate CapturedHttpHeaders and replace it with builder methods ( #5533 )
2022-03-09 12:21:32 -08:00
487a01eb3e
Update Gradle and build dependencies ( #5531 )
2022-03-09 09:09:20 -08:00
4a98dae431
Add builders for setting optional attributes on HTTP extractors ( #5347 )
...
* Add builders for setting optional attributes on HTTP extractors
* errorprone
* fix compilation failure
2022-03-08 17:21:14 +01:00
be79dde0f6
Remove old experimental properties in CapturedHttpHeaders ( #5524 )
2022-03-08 09:54:06 +01:00
4ef6d165a9
Disable the messaging receive span telemetry by default ( #5500 )
...
* Disable the messaging receive span telemetry by default
* fix spring-kafka tests
* remove no longer needed link from the kafka-clients library instrumentation
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-03-07 22:30:40 -08:00
47f2732aae
Split out DbClientAttributesGetter and SqlClientAttributesGetter ( #5354 )
...
* Split out DbClientAttributesGetter and SqlClientAttributesGetter
* code review comments
2022-03-04 09:58:04 -08:00
3ab1b8516f
Add markdown spell check ( #5450 )
...
* Add markdown link check
* Fix links
* update workflows
* move comment
* Add misspell check
* Fix misspellings
* Fix more misspellings
* Run against all files
* Spotless
2022-03-01 19:18:53 -08:00
c8c115d13f
Fix android desugaring for HashMap.forEach ( #5468 )
2022-03-01 08:46:25 +09:00
0a6b87eb69
Remove server span peer name ( #5404 )
...
* Fix server -> client reference
* Remove server span peer name
2022-02-27 11:06:20 -08:00
23ec76742b
Support forwarded proto field and x-forwarded-proto ( #5357 )
...
* Renames for the better
* Support forwarded proto
* fix
* Fix checkstyle complaining about abbrevation
* checkstyle
2022-02-22 13:01:46 -08:00
53a8b85f4c
Updates to http.server_name ( #5369 )
...
* Updates to http.server_name
* Tests
* fix
* armeria
* fix
* fix
* codenarc
2022-02-18 09:38:21 -08:00
27ed47ccda
Split out CodeAttributesGetter ( #5342 )
2022-02-17 16:47:18 -08:00
6774ce5791
Change the way Micrometer LongTaskTimer is bridged ( #5338 )
2022-02-17 16:46:23 -08:00
54e6b1223e
Weak cache optimization ( #5344 )
2022-02-11 09:31:34 -08:00
eeac67bdb1
Fix WeakConcurrentMap memory leak ( #5316 )
2022-02-08 10:36:12 -08:00
ea31ca8be2
Make HttpClientMetrics report low cardinality metrics ( #5319 )
2022-02-08 10:32:44 -08:00
551418c283
Refactor AttributesExtractor so that it extracts route from Context ( #5288 )
...
* Refactor AttributesExtractor so that it extracts route from Context
* typo
* fix tests
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpRouteHolder.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* fix all AttributesExtractors
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-02-08 10:38:41 +01:00
3d0ebce2ba
Fix triggering of DNS lookup ( #5297 )
...
* Fix triggering of DNS lookup
* Update test
* Update test
2022-02-03 08:39:52 -08:00
1077258263
Add InternalJavadoc custom error prone check ( #5277 )
...
* Add InternalJavadoc custom error prone check
* Add example usage
* Move to conventions
* Revert "Move to conventions"
This reverts commit d8a8209b59
2022-02-01 17:54:57 -08:00
8240a5f66f
End jedis span when operation actually ends ( #5256 )
...
* End jedis span when operation actually ends
* address review comments
2022-01-31 20:20:44 -08:00
666c22eb2a
Use `http.route` in `HttpServerMetrics` ( #5266 )
...
* Use http.route in HttpServerMetrics
* remove http.target fallback
2022-01-31 10:33:59 -08:00
8b767ac435
Refactor HTTP attributes extractors to use composition over inheritance ( #5267 )
...
* Refactor HTTP attributes extractors to use composition over inheritance
* Rename remaining variables: *Extractor to *Getter
2022-01-31 09:25:27 -08:00
236a42f111
Make HttpStatusConverter package private ( #5268 )
2022-01-31 09:35:48 +02:00
23b33adb0a
Auto-format groovy files in Intellij ( #5260 )
...
* Auto-format groovy files in Intellij
* A bit of clean up
2022-01-28 09:29:46 -08:00
16335a0c47
Use HttpRouteHolder in spring-webflux instrumentation ( #5239 )
2022-01-28 10:07:19 +01:00
7b04b9c707
Remove a couple of TODOs from instrumentation-api metrics tests ( #5255 )
2022-01-28 13:56:04 +09:00
edc185b133
Rename ServerSpanNaming to HttpRouteHolder ( #5211 )
...
* Rename ServerSpanNaming to HttpRouteHolder
* HttpRouteBiGetter
2022-01-25 09:44:15 -08:00
fe8a132ee9
Factor out NetServerAttributesGetter ( #5194 )
...
* factor out NetServerAttributesGetter and favor composition over inheritance.
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/net/NetServerAttributesGetter.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* errorprone and spotless
* spotless
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2022-01-21 17:01:30 -08:00
c5c0a2bcdf
NetClientAttributesAdapter - favor composition over inheritance ( #5030 )
...
* first pass at separating NetAttributesAdapter interface and make NetClientAttributesExtractor concrete
* rename the implementations extractor -> adapter
* hide constructor and make factory method
* rename to client and add javadoc
* spotless
* finish javadoc thought
* rebase
* renamed NetClientAttributesAdapter to NetClientAttributesGetter
* fix lettuce
* code review comments
* code review comments -- renaming for consistency
* adapter -> getter
* fix ratpack
* adapter -> getter
2022-01-20 10:51:13 -08:00
e6e2190f68
Fix most lint warnings. ( #5180 )
...
* Fix most lint warnings.
* Fix test
2022-01-20 18:28:45 +09:00
ec375116be
Fix more lint warnings ( #5174 )
...
* Fix more lint warnings
* Redisable lint
* Drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-20 12:48:46 +09:00
52394a2ff9
Remove deprecated tracer API ( #5175 )
...
* Remove deprecated tracer API
* Groovy too
2022-01-19 09:52:51 -08:00
1ecf493332
Fix flaky micrometer retries in javaagent test ( #5168 )
...
* Fix flaky micrometer retries in javaagent test
* remove comment
* add clarifying comment
2022-01-19 18:43:50 +09:00
bdd82a899e
Parameterize VirtualField field type ( #5165 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-18 13:42:44 -08:00
b7a95857c7
Fix some java lint warnings ( #5120 )
...
* Convert InstrumentationTestRunner from interface to abstract class
* Foo
* Commit
* Revert unintended
2022-01-17 10:26:03 -08:00
872c6c7d80
Add `http.route` to the server span when `ServerSpanNaming` is updated ( #5086 )
...
* Add `http.route` to the server span when `ServerSpanNaming` is updated
* fix camel tests
* fix test compilation failure
* assert route in camel instrumentation
2022-01-14 13:52:06 -08:00
b8ea362112
Don't capture http.target as metrics attribute ( #5081 )
2022-01-12 17:24:47 +02:00
642f2c1614
Peer service optimization ( #5056 )
2022-01-10 10:01:28 +02:00
1a9c633b4b
Rename some packages, move some classes ( #5043 )
...
* Rename some packages, move some classes
2022-01-09 13:26:51 +02:00
c75c01f871
Update to OTel 1.10 ( #5035 )
...
* Update to OTel 1.10
* Fix metric smoke test
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-07 15:45:20 -08:00
f6bcd76219
Update errorprone ( #5016 )
...
* Update errorprone
* gwt
* Remove unnecessary final
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-06 14:21:56 -08:00
0fd7b8baa0
Fix time units in HTTP & RPC metrics ( #4963 )
2021-12-21 11:51:57 -08:00
5e1e0c2642
Update to OTel 1.10 ( #4866 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-12-16 18:46:17 +09:00
09beb58a8c
Move SpanKey to internal package ( #4869 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-12-14 11:27:37 -08:00
a65e9633ba
Refactor `ServerSpanNaming` (in preparation for `http.route`) ( #4852 )
...
* Refactor ServerSpanNaming (in preparation for http.route)
* fix tests
* Add ServerSpanNaming to all HTTP server instrumentations
* fix tests
2021-12-14 10:11:20 +01:00
331ce287d2
Don't use HttpStatusConverter outside of instrumentation-api ( #4870 )
...
* Don't use HttpStatusConverter outside of instrumentation-api
* add comment
2021-12-14 10:07:18 +01:00
93a3282490
Remove ConfigPropertiesAdatpter as it's no longer needed ( #4888 )
2021-12-13 12:20:11 -08:00
ca2bce9608
Deprecate the Tracer API ( #4868 )
2021-12-12 12:14:36 -08:00
c59bebf6e2
add metrics rpc conventions implement ( #4838 )
...
* add metrics rpc conventions
* handle format violations
* handle format violations
* resolve the comments suggestion
* update RpcClientMetrics format
* update RpcServerMetrics format
* resolve time precision and cardinality issue
* invoke buildServerFallbackView method
* add RpcServerMetricsTest and RpcClientMetricsTest
* server metrics attibutes remove net.perr* and add net.host
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcServerMetrics.java
* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/rpc/RpcClientMetrics.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-12-10 16:29:57 -08:00
0bab0c2aa3
Move `ServletContextPath` to `servlet-common:bootstrap` ( #4824 )
...
* Move ServletContextPath to servlet-common:bootstrap
* fix tests
* Simplify ServletContextPath calls in restlet instrumentation
2021-12-08 15:59:31 +01:00
80790a409d
Add javadoc note about metrics timestamps ( #4820 )
...
* Add javadoc note about metrics timestamps
* Move to class level
2021-12-07 15:35:47 -08:00
075434c5bc
Move `AppServerBridge` and `MappingResolver` to `servlet-common:bootstrap` ( #4817 )
...
* Move AppServerBridge and MappingResolver to servlet-common:bootstrap
* Introduce additional gradle configuration for bootstrap libs
2021-12-07 10:20:33 +01:00
61b0dd3698
Capture servlet request parameters ( #4703 )
...
* Capture servlet request parameters
* use concurrenthashmap for cache
2021-12-05 21:25:31 -08:00
a70682c390
Remove unhelpful benchmarks ( #4766 )
...
* Remove unhelpful benchmarks
* Restore one more benchmark
* spotless
2021-12-02 17:17:39 +02:00
9f4686cc3d
Move cache implementations to internal package ( #4746 )
...
* Move cache implementations to internal package
* Fix import
* Fix import order
2021-11-30 21:43:03 -08:00
f7efe07b06
Merge start and end time extractors ( #4692 )
2021-11-29 22:07:49 -08:00
9a4a68d836
Add Android API-friendliness checks ( #4505 )
...
* Add Android API-friendliness checks
* Improve comments
* Remove ignores
* Handle CompletionException
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-11-24 12:59:11 -08:00
821a4b870b
Drop instrumentation-api-caching module and move weak cache implementation to instrumentation-api ( #4667 )
...
* Drop instrumentation-api-caching module and move weak cache implementation to instrumentation-api
* Some test fixes
* Some cleanup
* Temporary workaround for using weak values in FutureListenerWrappers
* Spotless
* Update ClassNames and SpanNames
* Compilation and comment
* Add bounded cache and clean interface
* Polish
* Add comment
* Vendor ConcurrentLinkedHashMap in
* Let errorprone ignore vendored CLHM for now
* Keep license in java files too
* Convert Netty wrapper cache to VirtualField
* Work around lambda instrumentation failure
Ideally we would ignore instrumenting helper classes...
* Revert "Work around lambda instrumentation failure"
This reverts commit 6d63815b44dac1522a3f
2021-11-24 09:05:12 -08:00
260c603784
Fix exemplars ( #4678 )
2021-11-20 10:42:06 -08:00
ee32c41d35
Remove LongAdder and ClassValue usages from instrumentation-api ( #4671 )
2021-11-18 21:29:45 -08:00
628df63dad
Remove a few unused methods ( #4661 )
2021-11-17 09:40:43 -08:00
625febaeb4
Sql sanitizer: sanitize double quoted strings only in couchbase queries ( #4615 )
...
* Sql sanitizer: sanitize double quotes strings only in couchbase queries
* remove unused method
* use AutoValue
2021-11-10 13:43:03 -08:00
16728e2445
Add a ClassAndMethod class to Instrumentation API ( #4619 )
...
* Add a ClassAndMethod class to Instrumentation API
* remove sentence
* Update docs/contributing/writing-instrumentation.md
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* address review comment
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-11-10 13:33:11 -08:00
21d6648c95
Add version to the InstrumenterBuilder and Instrumenter ( #4611 )
2021-11-09 10:21:05 -08:00
d3f8ab6c82
Update HTTP metrics 'view' code to match the specification ( #4556 )
...
* Update HTTP metrics 'view' code to match the specification, including optional attribute rules.
* Update server metrics test for new logic.
* Fix client metrics test.
* Spotless fix.
* Updates from Java SiG discussion.
* Fixes from review.
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Update spotless from code reivew merge.
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-11-06 09:09:01 -07:00
f3ec9a215b
Document Instrumenter API ( #4544 )
...
* Document Instrumenter API
* Apply suggestions from code review
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
* reformat and code review comments
* code review comments
* Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* formatting
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-11-05 15:15:48 +01:00
e31439ee0d
Fix context propagation in tomcat thread pool ( #4521 )
2021-10-27 16:52:55 -07:00
3d92cd2337
Add javadoc to ServletContextPath method ( #4484 )
...
* Add javadoc to ServletContextPath method
* Normalise span name and add test
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/servlet/ServletContextPathTest.java
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
2021-10-25 13:44:02 -07:00
d314d76fce
rename `newBuilder()` to `builder()` ( #4475 )
...
* rename `newBuilder()` to `builder()`
* rename `newBuilder()` to `builder()`
2021-10-22 20:50:43 -07:00
05a391459b
Stabilize HTTP headers capturing configuration property names ( #4459 )
...
* Stabilize HTTP headers capturing configuration property names
* code review comments
2021-10-21 21:56:20 -07:00
e9022da102
Remove unshaded javax.annotation classes from bootstrap class loader ( #4454 )
...
* Fix shading
* Revert "Fix shading"
This reverts commit 2aad3cfe21
2021-10-21 14:47:50 -07:00
a50c13382f
Don't report 400 level as error for SERVER spans ( #4403 )
...
* don't report 400 level as error for server spans
* fix HttpServerTest base class
* fix JspInstrumentationForward test
* split HttpStatusConverter into client and server implementations, and create two HttpSpanStatusExtractor.create methods, one for server and one for client.
* rebase
* fix test
* spotless
* fix test
* remove unused
* use strongly typed attributes converters and rename to overloaded create()
* fix tests
* remove redundant assert
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-20 13:39:35 -07:00
35dd350625
Capture metric dimensions from end attributes also ( #4430 )
...
* Capture metric dimensions from end attributes also
* Fix test
* Update tests
2021-10-20 09:29:03 -07:00
b6728de75f
Migrate Grizzly to Instrumenter API ( #4409 )
...
* Migrate Grizzly to Instrumenter API
* javax.annotation.Nullable
* Preserve the caught exception in the Context until end() is called
* rename to GrizzlyErrorHolder
2021-10-18 22:55:17 -07:00
6d9e3618d3
rename `newBuilder()` to `builder()` ( #4407 )
...
* rename `newBuilder()` to `builder()`
* code format
2021-10-18 10:00:49 -07:00
c119fa1bf6
Remove more usages of checker's Nullable ( #4410 )
2021-10-18 17:32:25 +03:00
ac91dc090a
Type annotation placement ( #4406 )
...
* switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable`
* code format
2021-10-17 17:38:43 -07:00
efddb72cef
Convert AttributesExtractor to interface ( #4363 )
2021-10-14 08:36:47 +03:00
ff8696586d
Remove VirtualField#computeIfNull() method ( #4354 )
2021-10-12 11:37:35 -07:00
55f987613a
Remove deprecated ServerSpanNaming.updateSource method ( #4327 )
...
* Remove deprecated ServerSpanNaming.updateSource method
2021-10-12 13:45:18 +03:00
51cf64bb3f
Add @UnstableApi annotation to the ExperimentalConfig class ( #4346 )
2021-10-11 12:50:11 -07:00
f208ba72b7
Update to OTel 1.7 ( #4340 )
...
* Update to OTel 1.7
* Fix metrics tests
2021-10-11 19:52:50 +09:00
99f6bcde92
Convert AwsSdk1 to Instrumenter API ( #4315 )
...
* Convert AwsSdk1 to Instrumenter API
* Apply suggestions from code review
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Polish
* Polish and tests
* Polish
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-10-08 10:48:41 -07:00
63a2383905
Split NetAttributesExtractor into NetClientAttributesExtractor and NetServerAttributesExtractor ( #4287 )
...
* Net Extractors
* Either request or response but not both
* Fix merge conflicts
* Separate by OnStart/OnEnd
* PeerServiceAttributes
* Fix test
* Restructure to client/server
* Fix merge conflict in main
* more
* peer.service
* Feedback
* peer.service is only for clients
* Fix merge conflict
* rename
* Armeria
* peer.service is only for clients
* rename
* WIP
* Sync Dubbo with Armeria
* More Dubbo and Armeria
* gRPC
* Revert some Dubbo changes
* more peer.service
* Fix test
* Fix merge
* Fixes
2021-10-07 15:40:15 -07:00
9476f86920
Remove deprecated ServerSpanNaming.updateServerSpanName method ( #4318 )
2021-10-07 10:16:50 -07:00
a48bd9de3f
Move PeerServiceAttributesExtractor from javaagent api to instrumentation api ( #4235 )
...
* Move PeerServiceAttributesExtractor from javaagent api to instrumentation api
* spotless
2021-10-06 12:42:55 -07:00
d3dbe415a1
Move HttpHeadersConfig methods back to instrumentation-api ( #4298 )
...
* Move HttpHeadersConfig methods back to instrumentation-api
* remove unnecessary method
2021-10-06 10:51:45 +02:00
c28374615b
Add functionality to generate API changes ( #4285 )
...
* Add functionality to generate API changes
* Update conventions/src/main/kotlin/otel.japicmp-conventions.gradle.kts
Co-authored-by: John Watson <jkwatson@gmail.com>
* Do not commit any API changes until we have stable release
Co-authored-by: John Watson <jkwatson@gmail.com>
2021-10-06 09:59:01 +03:00
66d58aa0a6
Move clientIp extraction to HttpServerAttributesExtractor ( #4301 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-05 16:08:17 -07:00
7791be24e0
Remove implementations of host() and userAgent() in HTTP extractors ( #4299 )
...
* Remove implementations of host() and userAgent() in HTTP extractors
* fix broken headers copying
2021-10-05 10:25:45 -07:00
7473eff1e6
Extract HTTP request/response headers as span attributes ( #4237 )
...
* Extract HTTP request/response headers as span attributes
* fix muzzle
* code review comments
* fix compilation failure after merge conflict
* avoid using streams API when transforming the headers list
* fix liberty extractor
* fix spring webmvc extractor
2021-10-05 10:20:59 +02:00
Trask Stalnaker
Mateusz Rzeszutek
Anuraag Agrawal
Lauri Tulmin
Oleg Zasymenko
jason plumb
Nikita Salnikov-Tarnovski
yangtaoran
Roberto Cortez
Josh Suereth
Martin