Commit Graph

56 Commits

Author SHA1 Message Date
Mateusz Rzeszutek d1c0b3d47e
Do not install GC metrics when GarbageCollectionNotificationInfo is n… (#7405)
…ot available

Hopefully fix #7401
2022-12-13 08:11:51 -08:00
Aaron Ai 2d7395c44b
Introduce markdown lint check (#7175)
Fixes #7129
2022-11-16 20:48:42 -08:00
jack-berg e39e5a68ed
Replace runtime.jvm.gc.time/runtime.jvm.gc.count metrics with process.runtime.jvm.gc.duration histogram (#6964)
Replaces #6362.

I've reduced the attributes to only record the gc name and the action
that was taken (i.e. I've removed the gc cause). If needed we can add
the cause later, but for now this should be sufficient to determine
total time spent in GC, and categorize time spent as stop the world or
parallel.
2022-11-15 14:01:36 -08:00
jack-berg 177d9cd531
Record memory usage after garbage collection (#6963)
Per conversation in #6362.
2022-11-08 22:44:48 +00:00
jack-berg fce5a5f881
Add readme for runtime-metrics (#7012)
In the 10/27 java sig we discussed that it would be valuable to
enumerate the attributes reported for memory pool and gc metrics when
different gcs are used.

I've went ahead and added a readme for the runtime metrics which
includes detailed information on the attributes reported. Note that I
also have the same data for gc metrics added in #6964 and #6963, but
will wait to add until those PRs are merged.
2022-11-02 14:46:07 -07:00
Lauri Tulmin 9b4d490e81
Fix metric unit in BufferPoolsTest (#6953) 2022-10-23 09:13:55 -07:00
jack-berg 015dbf90b0
Add meter version to runtime metrics (#6874)
Runtime metrics doesn't include the meter version. This adds it from the
utility method in the instrumentation-api
`EmbeddedInstrumentationProperties.findVersion`. I know I can read the
properties file for this module, but its repetitive to implement that in
many places.
2022-10-22 18:09:44 -07:00
Trask Stalnaker 9ce68fb937
Fix metric units (#6931)
Follow-up to #6930
2022-10-22 10:00:48 -07:00
Peter Findeisen 598ee82659
6929 - fixing unit for runtime.jvm.gc.count (#6930) 2022-10-20 17:43:01 -07:00
Trask Stalnaker 0e0bbf6564
Small daemon threads implementation clean up (#6740) 2022-09-28 12:05:39 +03:00
Hao Tu 878dfc35af
add daemon attribute to process.runtime.jvm.threads.count (#6635)
Signed-off-by: HaoTu <haotu@alauda.io>

#6561  has closed

Signed-off-by: HaoTu <haotu@alauda.io>
2022-09-24 11:03:00 -07:00
Mateusz Rzeszutek 59cb9ca0df
Remove deprecated code (#6501)
* Remove deprecated code

* unnecessary semicolon

* fix distro and extension examples
2022-08-24 14:36:57 -07:00
Trask Stalnaker 68a9f20eb3
Enable PrivateConstructorForUtilityClass errorprone check (#6427)
* PrivateConstructorForUtilityClass

* Advice

* More advice

* More

* More advice

* More

* Spotless

* Fix

* Fix

* Fix

* A better solution

* Revert

* More

* Fix

* Spotless

* Fix
2022-08-10 11:30:22 +03:00
Mateusz Rzeszutek 8a3d283941
Move buffer pool metrics out of the experimental block (#6370) 2022-07-26 07:54:59 +02:00
Mateusz Rzeszutek a559effa01
Remove config property name normalization (#6320)
* Remove config property name normalization

* fix test
2022-07-13 15:33:04 -07:00
Mateusz Rzeszutek 198dad00d6
Prefer using ConfigProperties over Config in AgentListener (#6202)
* Prefer using ConfigProperties over Config in AgentListener

* normalize property name

* add TODOs
2022-07-07 15:44:32 +02:00
Will Li 661af204d9
add runtime metrics for buffer pool (#6177)
* add runtime metrics for buffer pool

Signed-off-by: Cuichen Li <cuichli@cisco.com>

* update based on comments

Signed-off-by: Cuichen Li <cuichli@cisco.com>

* update based on comment

Signed-off-by: Cuichen Li <cuichli@cisco.com>

* add missing unit test

Signed-off-by: Cuichen Li <cuichli@cisco.com>
2022-06-28 13:31:54 +03:00
jack-berg 9b8f74515a
Rename p.r.j.memory.max to p.r.j.memory.limit (#6161)
* Rename p.r.j.memory.max to p.r.j.memory.limit

* Fix build
2022-06-13 13:17:04 -07:00
jack-berg cbf5bc31da
Add jvm cpu metrics (#6107)
* Add jvm cpu metrics

* Spotless

* PR feedback
2022-06-02 17:30:49 -07:00
jack-berg 1f9de2ed7c
Add jvm threads instrumentation (#6070)
* Add jvm threads instrumentation

* Use up down counter
2022-05-20 09:11:05 -07:00
jack-berg 6f0f608cbb
Add JVM classes instrumentation (#6069)
* Add JVM classes instrumentation

* Add unit of 1

* Assert monotonicity
2022-05-19 16:14:14 -07:00
Mateusz Rzeszutek fd52ed52d4
Hide the GC runtime metrics behind an experimental config flag (#5990)
* Hide the GC runtime metrics behind an experimental config flag

* Fix smoke tests
2022-05-06 11:51:38 -07:00
Trask Stalnaker cef9e1925c
Fix default enabled for runtime and oshi metrics (#5989) 2022-05-06 10:43:57 +03:00
Mateusz Rzeszutek 65717dae3e
Cleanup Config & ConfigBuilder API (#5733)
* Cleanup Config & ConfigBuilder API

* errorprone

* errorprone & spotless

* spotless
2022-04-05 20:20:52 -07:00
jack-berg fbc100a0f6
Update runtime memory metrics to reflect semantic conventions (#5718)
* Update runtime memory metrics to reflect semantic conventions

* Fix SpringBootSmokeTest

* Fix PrometheusSmokeTest
2022-03-31 09:56:58 -07:00
Eduardo Narros 2852d1d0c7
Allows passing an OpenTelemetry instance to registerObservers() methods. (#5716)
* Allows passing an OpenTelemetry instance to registerObservers() methods.

* Deprecated registerObserver methods that were using the GlobalOpenTelemetry instance.
2022-03-31 11:44:57 +09:00
Anuraag Agrawal 14372adb68
Migrate Guava tests to Java (#5668)
* Migrate Guava tests to Java

* Update instrumentation/guava-10.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/guava/ListenableFutureTest.java

Co-authored-by: Lauri Tulmin <tulmin@gmail.com>

* Workaround inline mock issue

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
2022-03-24 14:14:09 +09:00
Anuraag Agrawal ec375116be
Fix more lint warnings (#5174)
* Fix more lint warnings

* Redisable lint

* Drift

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-20 12:48:46 +09:00
Anuraag Agrawal c75c01f871
Update to OTel 1.10 (#5035)
* Update to OTel 1.10

* Fix metric smoke test

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-07 15:45:20 -08:00
Anuraag Agrawal a9aee8ed45
Fix some gauge types (#4962) 2021-12-21 12:40:13 -08:00
Anuraag Agrawal 5e1e0c2642
Update to OTel 1.10 (#4866)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-12-16 18:46:17 +09:00
jack-berg 2f47e8a3d3
Update garbage collector instruments to be async counters (#4600) 2021-11-05 13:16:32 -07:00
Trask Stalnaker 20c72f3e98
Format kotlin gradle files (#3942)
* Add ktlint for kotlinGradle

* ktlint fails on wildcard imports

* Auto-format kotlin gradle files
2021-08-25 13:43:57 +09:00
Anuraag Agrawal d8eae4997d
Update to SDK 1.5.0 (#3847) 2021-08-17 08:43:11 -07:00
Anuraag Agrawal 761b9c280b
Migrate instrumentation gradle files to kotlin (#3414)
* Migrate instrumentation gradle files to kotlin

* Convert

* Muzzle
2021-06-28 17:27:12 +09:00
Anuraag Agrawal 785dc6adf2
Rename build files to build.gradle (#3409)
* Rename build files to build.gradle

* Rename smoke-tests

* Fix already broken
2021-06-25 16:10:31 +09:00
Anuraag Agrawal deb0e255cf
Use plugins block everywhere for applying plugins (#3386)
* Use plugins block everywhere for applying plugins

* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
Anuraag Agrawal 80f43b7a6a
Migrate javaagent-instrumentation to plugin (#3328)
* Migrate instrumentation.gradle to plugin

* Migrate usages

* Remove old

* Fix

* Revert example

* afterEvaluate

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
Anuraag Agrawal b7bfbf0cc6
Migrate instrumentation-library / common to plugins (#3320) 2021-06-15 11:54:48 -07:00
Trask Stalnaker dc316609ee
Remove unnecessary final on params and local vars (#3283)
* Remove unnecessary final on params and local vars

* Fix gwt

* Keep final for non-initialized var

* Keep final for non-initialized var

* Keep final for non-initialized var
2021-06-14 07:13:11 +03:00
Mateusz Rzeszutek 99be242e22
Rename ComponentInstaller to AgentListener and add #order() method (#3182)
* Rename ComponentInstaller to AgentListener and add #order() method

* Code review comments

* Update javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/SafeServiceLoader.java

Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>

Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2021-06-07 19:50:19 +02:00
Anuraag Agrawal c3dedbb64e
Enable all errorprone checks (#3155)
* Enable all errorprone checks

* Fixes

* Finish

* Finish

* Add flag to disable error prone
2021-06-01 17:41:08 +09:00
Anuraag Agrawal ed88cca533
Migrate from spotbugs to errorprone (#3122)
* Migrate from spotbugs to errorprone

* Fix hashtable

* try-with-resources

* Fix from merge

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
Anuraag Agrawal c358a35414
Use dependency management pattern for dependency versions (#3113)
* Use dependency management pattern for dependency versions.

* Add groovy bom too

* Update dependencyManagement/dependencyManagement.gradle.kts

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
Mateusz Rzeszutek 9c7fae3b04
Extract javaagent-extension-api from tooling & spi (#2879) 2021-05-06 23:30:25 -07:00
Anuraag Agrawal a4ea1c9db2
Update to OTel 1.1.0 (#2744)
* Update to OTel 1.1.0

* Use transform safe logger

* Finish

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-04-08 16:01:16 +09:00
Felix Barnsteiner 1b0438439a
Fix typo in javadoc (nonheap vs non_heap) (#2627) 2021-03-25 22:39:23 -07:00
Felix Barnsteiner 56c52bc315
Add runtime.jvm.gc.collection.count metric (#2616)
* Add runtime.jvm.gc.collection.count metric

* Fix format violation

* Rename gc.collection to gc.collection.time

* Another rename 😅
2021-03-23 14:11:23 +02:00
jason plumb 6ea1e8d0ef
Let the ComponentInstaller be passed a Config instance (#2569)
* Let the ComponentInstaller be passed a Config instance, and prefer using Config over Properties

* revert span exporter factory and metric exporter factory and stick with the ol' properties for now.

* rollback
2021-03-18 00:11:42 +02:00
Mateusz Rzeszutek f8dd8c8f56
Move RuntimeMetricsInstaller to correct package (#2567) 2021-03-12 09:49:25 -08:00