the current implementation of Start and End around the invocation of a
Jax WS is asymmetric around the JAX-WS Handler Chain.
Current behavior:
(execution of incoming MessageHandlers) -> (TracingStartInInterceptor)
-> (WebService Invocation) -> (execution of outgoing MessageHandlers) ->
(TracingEndInInterceptor)
if I understood the code of this cxf instrumentation correctly, the
intent was to build the span close around the WebService Invocation
(without Handler Chains).
So the desired behavior would look like this:
(execution of incoming MessageHandlers) -> (TracingStartInInterceptor)
-> (WebService Invocation) -> (TracingEndInInterceptor) -> (execution of
outgoing MessageHandlers)
Unfortunately CXF is calling the Outgoing Chain inside the POST_INVOKE
Phase of Cxf (so the outgoing chain is technically a sub-chain in the
incoming chain... which is documented but quite surprising...).
So the solution in the fix at least guarantees the the outgoing chain is
invoked AFTER end of tracing. For any extra Interceptors in the
POST_INVOKE Phase there is still no guarantee of ordering, but I think
this is not a opentelemetry issue but a design-flaw of CXF...
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
this is a follow-up to #7043
I tried to add a test when that PR was opened:
*
d2c6399a6e
but it doesn't really verify anything, since the NPE is throw/caught and
same behavior occurs
This PR allows:
* Executing the OTel Logback appender tests as GraalVM native
executables
* Executing the native tests once a day on Github
---------
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Bumps `byteBuddyVersion` from 1.14.2 to 1.14.3.
Updates `net.bytebuddy:byte-buddy` from 1.14.2 to 1.14.3
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/raphw/byte-buddy/releases">net.bytebuddy:byte-buddy's
releases</a>.</em></p>
<blockquote>
<h2>Byte Buddy 1.14.3</h2>
<ul>
<li>Make <code>MethodGraph.Compiler</code> failsafe when processing
incomplete methods.</li>
<li>Update ASM.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/raphw/byte-buddy/blob/master/release-notes.md">net.bytebuddy:byte-buddy's
changelog</a>.</em></p>
<blockquote>
<h3>13. March 2023: version 1.14.3</h3>
<ul>
<li>Make <code>MethodGraph.Compiler</code> failsafe when processing
incomplete methods.</li>
<li>Update ASM.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="bee0115cf7"><code>bee0115</code></a>
[maven-release-plugin] prepare release byte-buddy-1.14.3</li>
<li><a
href="2e50ec0ce7"><code>2e50ec0</code></a>
[release] Release new version.</li>
<li><a
href="57e32d779a"><code>57e32d7</code></a>
[release] Release new version.</li>
<li><a
href="389e408f41"><code>389e408</code></a>
Fjerner import.</li>
<li><a
href="c66e3086eb"><code>c66e308</code></a>
Add fail safe wrapper to registry.</li>
<li><a
href="9609c3232e"><code>9609c32</code></a>
Update internal Byte Buddy and checksums.</li>
<li><a
href="518c31d9a5"><code>518c31d</code></a>
[maven-release-plugin] prepare for next development iteration</li>
<li>See full diff in <a
href="https://github.com/raphw/byte-buddy/compare/byte-buddy-1.14.2...byte-buddy-1.14.3">compare
view</a></li>
</ul>
</details>
<br />
Updates `net.bytebuddy:byte-buddy-dep` from 1.14.2 to 1.14.3
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/raphw/byte-buddy/releases">net.bytebuddy:byte-buddy-dep's
releases</a>.</em></p>
<blockquote>
<h2>Byte Buddy 1.14.3</h2>
<ul>
<li>Make <code>MethodGraph.Compiler</code> failsafe when processing
incomplete methods.</li>
<li>Update ASM.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/raphw/byte-buddy/blob/master/release-notes.md">net.bytebuddy:byte-buddy-dep's
changelog</a>.</em></p>
<blockquote>
<h3>13. March 2023: version 1.14.3</h3>
<ul>
<li>Make <code>MethodGraph.Compiler</code> failsafe when processing
incomplete methods.</li>
<li>Update ASM.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="bee0115cf7"><code>bee0115</code></a>
[maven-release-plugin] prepare release byte-buddy-1.14.3</li>
<li><a
href="2e50ec0ce7"><code>2e50ec0</code></a>
[release] Release new version.</li>
<li><a
href="57e32d779a"><code>57e32d7</code></a>
[release] Release new version.</li>
<li><a
href="389e408f41"><code>389e408</code></a>
Fjerner import.</li>
<li><a
href="c66e3086eb"><code>c66e308</code></a>
Add fail safe wrapper to registry.</li>
<li><a
href="9609c3232e"><code>9609c32</code></a>
Update internal Byte Buddy and checksums.</li>
<li><a
href="518c31d9a5"><code>518c31d</code></a>
[maven-release-plugin] prepare for next development iteration</li>
<li>See full diff in <a
href="https://github.com/raphw/byte-buddy/compare/byte-buddy-1.14.2...byte-buddy-1.14.3">compare
view</a></li>
</ul>
</details>
<br />
Updates `net.bytebuddy:byte-buddy-agent` from 1.14.2 to 1.14.3
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/raphw/byte-buddy/releases">net.bytebuddy:byte-buddy-agent's
releases</a>.</em></p>
<blockquote>
<h2>Byte Buddy 1.14.3</h2>
<ul>
<li>Make <code>MethodGraph.Compiler</code> failsafe when processing
incomplete methods.</li>
<li>Update ASM.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/raphw/byte-buddy/blob/master/release-notes.md">net.bytebuddy:byte-buddy-agent's
changelog</a>.</em></p>
<blockquote>
<h3>13. March 2023: version 1.14.3</h3>
<ul>
<li>Make <code>MethodGraph.Compiler</code> failsafe when processing
incomplete methods.</li>
<li>Update ASM.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="bee0115cf7"><code>bee0115</code></a>
[maven-release-plugin] prepare release byte-buddy-1.14.3</li>
<li><a
href="2e50ec0ce7"><code>2e50ec0</code></a>
[release] Release new version.</li>
<li><a
href="57e32d779a"><code>57e32d7</code></a>
[release] Release new version.</li>
<li><a
href="389e408f41"><code>389e408</code></a>
Fjerner import.</li>
<li><a
href="c66e3086eb"><code>c66e308</code></a>
Add fail safe wrapper to registry.</li>
<li><a
href="9609c3232e"><code>9609c32</code></a>
Update internal Byte Buddy and checksums.</li>
<li><a
href="518c31d9a5"><code>518c31d</code></a>
[maven-release-plugin] prepare for next development iteration</li>
<li>See full diff in <a
href="https://github.com/raphw/byte-buddy/compare/byte-buddy-1.14.2...byte-buddy-1.14.3">compare
view</a></li>
</ul>
</details>
<br />
Updates `net.bytebuddy:byte-buddy-gradle-plugin` from 1.14.2 to 1.14.3
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
I noticed some kotlin deprecation warnings in the build output, so I
thought I would try and fix them up.
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Bumps
[net.bytebuddy:byte-buddy-dep](https://github.com/raphw/byte-buddy) from
1.14.2 to 1.14.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/raphw/byte-buddy/releases">net.bytebuddy:byte-buddy-dep's
releases</a>.</em></p>
<blockquote>
<h2>Byte Buddy 1.14.3</h2>
<ul>
<li>Make <code>MethodGraph.Compiler</code> failsafe when processing
incomplete methods.</li>
<li>Update ASM.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/raphw/byte-buddy/blob/master/release-notes.md">net.bytebuddy:byte-buddy-dep's
changelog</a>.</em></p>
<blockquote>
<h3>13. March 2023: version 1.14.3</h3>
<ul>
<li>Make <code>MethodGraph.Compiler</code> failsafe when processing
incomplete methods.</li>
<li>Update ASM.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="bee0115cf7"><code>bee0115</code></a>
[maven-release-plugin] prepare release byte-buddy-1.14.3</li>
<li><a
href="2e50ec0ce7"><code>2e50ec0</code></a>
[release] Release new version.</li>
<li><a
href="57e32d779a"><code>57e32d7</code></a>
[release] Release new version.</li>
<li><a
href="389e408f41"><code>389e408</code></a>
Fjerner import.</li>
<li><a
href="c66e3086eb"><code>c66e308</code></a>
Add fail safe wrapper to registry.</li>
<li><a
href="9609c3232e"><code>9609c32</code></a>
Update internal Byte Buddy and checksums.</li>
<li><a
href="518c31d9a5"><code>518c31d</code></a>
[maven-release-plugin] prepare for next development iteration</li>
<li>See full diff in <a
href="https://github.com/raphw/byte-buddy/compare/byte-buddy-1.14.2...byte-buddy-1.14.3">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is handy to enable consistent local version numbers rather than
updating file paths each release.
Add the following to enable locally `~/.gradle/gradle.properties`
```
removeJarVersionNumbers=true
```
Bumps `asmVersion` from 9.4 to 9.5.
Updates `org.ow2.asm:asm` from 9.4 to 9.5
Updates `org.ow2.asm:asm-tree` from 9.4 to 9.5
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Bumps
[com.jayway.jsonpath:json-path](https://github.com/jayway/JsonPath) from
2.7.0 to 2.8.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="8a0d2fd594"><code>8a0d2fd</code></a>
Fix archive signing</li>
<li><a
href="8bae57fcbc"><code>8bae57f</code></a>
Merge branch 'master' of github.com:json-path/JsonPath</li>
<li><a
href="08830e92f4"><code>08830e9</code></a>
Upgrade org.json:json from 20140107 to 20230227 (<a
href="https://redirect.github.com/jayway/JsonPath/issues/907">#907</a>)</li>
<li><a
href="edf52aa667"><code>edf52aa</code></a>
Release and fix docs</li>
<li><a
href="4a59845a74"><code>4a59845</code></a>
Revert to deprecated 'baseName'</li>
<li><a
href="1e6647bbce"><code>1e6647b</code></a>
Fix dependency issues in gradle build files</li>
<li><a
href="9a77472cc1"><code>9a77472</code></a>
Update dependencies</li>
<li><a
href="9729cb048b"><code>9729cb0</code></a>
Defines the pattern for taking item from collection of JSONArray by
index (<a
href="https://redirect.github.com/jayway/JsonPath/issues/842">#842</a>)</li>
<li><a
href="2eed3b9675"><code>2eed3b9</code></a>
Fix description for sub-array index example in table (<a
href="https://redirect.github.com/jayway/JsonPath/issues/861">#861</a>)</li>
<li><a
href="b9860126d4"><code>b986012</code></a>
Update build.gradle (<a
href="https://redirect.github.com/jayway/JsonPath/issues/866">#866</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/jayway/JsonPath/compare/json-path-2.7.0...json-path-2.8.0">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps com.gradle.enterprise from 3.12.5 to 3.12.6.
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [io.grpc:grpc-bom](https://github.com/grpc/grpc-java) from 1.53.0
to 1.54.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="e988f84d14"><code>e988f84</code></a>
Bump version to 1.54.0</li>
<li><a
href="abdb6980ec"><code>abdb698</code></a>
Update README etc to reference 1.54.0</li>
<li><a
href="61ec299352"><code>61ec299</code></a>
Remove sleep from Observability Interop Test binary now that its done in
clos...</li>
<li><a
href="9f26b7dd08"><code>9f26b7d</code></a>
gcp-o11y: add default custom tag for metrics exporter</li>
<li><a
href="fefa2d9b16"><code>fefa2d9</code></a>
examples: add gcp-observability examples (v1.54.x backport) (<a
href="https://redirect.github.com/grpc/grpc-java/issues/9987">#9987</a>)</li>
<li><a
href="882a27bcb6"><code>882a27b</code></a>
gcp-o11y: add sleep in Observability close()</li>
<li><a
href="2e41c9a5cb"><code>2e41c9a</code></a>
disable recording real-time metrics using in gcp-o11y</li>
<li><a
href="132bf3e573"><code>132bf3e</code></a>
interop-testing: Do not System.exit(0) from interop client</li>
<li><a
href="85ce900dfc"><code>85ce900</code></a>
gcp-observability, census: add trace information to logs (<a
href="https://redirect.github.com/grpc/grpc-java/issues/9963">#9963</a>)</li>
<li><a
href="bb39ca3ec9"><code>bb39ca3</code></a>
gcp-observability: Update logging fields for GA and use custom
BatchingSettin...</li>
<li>Additional commits viewable in <a
href="https://github.com/grpc/grpc-java/compare/v1.53.0...v1.54.0">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
You can trigger a rebase of this PR by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Lauri Tulmin
dependabot[bot]
Trask Stalnaker
Nitesh S
pellmont
Mateusz Rzeszutek
adamleantech
Abhinandan Seshadri
Jean Bisutti
jason plumb
Robert Toyonaga
Tyler Benson
Abhinandan Seshadri