Commit Graph

64 Commits

Author SHA1 Message Date
Trask Stalnaker f11d176c15
Enforce library instrumentation package names matching their module names (#12957) 2025-03-12 11:58:43 -07:00
xiepuhuan ab09fcee98
Implement ExtendedTextMapGetter in kafka-clients instrumentation (#13068) 2025-01-20 17:43:48 -08:00
Lumian Zhang 59e3318d9d
fix: Kafka initialization occasionally failed due to concurrent injection of OpenTelemetryMetricsReporter (to #12538) (#12583) 2024-11-07 07:59:07 -08:00
Trask Stalnaker 2371589ec5
Statically import semconv constants in tests (#12575) 2024-11-06 08:17:57 -08:00
renovate[bot] 855c7a0fad
fix(deps): update dependency io.opentelemetry.semconv:opentelemetry-semconv to v1.28.0-alpha (#12292)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2024-10-28 10:55:06 -07:00
renovate[bot] 8245d8e9e3
fix(deps): update testcontainers-java monorepo to v1.20.2 (patch) (#12370)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2024-10-02 08:15:35 +03:00
Lauri Tulmin 31e5eea3bc
Closing a kafka producer/consumer should not disable metrics from other consumers/producers (#11975) 2024-08-14 15:50:54 -07:00
Lauri Tulmin b0818cb3ed
Update kafka docker image (#11938) 2024-08-01 11:42:07 -07:00
Gregor Zeitlinger 798bdd5569
config properties support for spring starter clients (#11605) 2024-07-02 16:49:39 +03:00
Lauri Tulmin 9efbec6fd5
Replace messaging.kafka.destination.partition with messaging.destination.partition.id (#11086) 2024-04-11 09:16:50 +03:00
SylvainJuge 955470a63a
Semconv 1.25.0 migration (#10983)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-04-09 11:25:52 -07:00
Lauri Tulmin 61ca2133d5
Configure kafka metrics reporter as class (#10855) 2024-03-14 18:22:48 +02:00
Lauri Tulmin f62aa9c1f3
Fix kafka clients latest dep tests (#10687) 2024-02-27 11:16:19 +02:00
Lauri Tulmin c3e5245354
Remove unused kafka metrics from doc (#10371) 2024-02-01 07:44:36 -08:00
Lauri Tulmin f52a3b404a
Warn when deprecated kafka property is used (#10354) 2024-01-31 09:46:34 +02:00
jason plumb 7e35f0c34a
Remove deprecated config properties (#10349) 2024-01-31 05:16:50 +00:00
Lauri Tulmin b57c1a023b
Update semconv (#10272) 2024-01-30 17:10:35 +00:00
Lauri Tulmin 6313391d71
Rewrite @Advice.Enter for indy advice (#9887) 2023-11-17 07:49:19 -08:00
Lauri Tulmin 977a6f9c38
Move kafka metrics to separate instrumentation module (#9862) 2023-11-16 13:52:30 +02:00
Lauri Tulmin 70e3962a87
Always set messaging operation (#9791) 2023-11-06 12:30:27 +02:00
Lauri Tulmin 5a2f52978f
Make kafka library and javaagent instrumentations more similar (#9738) 2023-10-24 09:08:03 -07:00
Lauri Tulmin 0de1dcff45
Fail test if advice threw an exception (#9654)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-10-11 19:17:20 +00:00
OpenTelemetry Bot dec59cb2cb
Update the OpenTelemetry SDK version to 1.31.0 (#9619)
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-10-09 12:39:00 +00:00
Lauri Tulmin 795c053dc6
Fix spec links (#9603) 2023-10-04 17:54:35 +03:00
Lauri Tulmin 7d2259742a
Transform inline advice to delegating advice and test indy modules (#9508) 2023-09-22 11:15:39 +03:00
Trask Stalnaker 3b77cc4b2d
Semconv 1.21 (#9408)
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-09-13 19:20:23 +00:00
Lauri Tulmin 54d0e0718f
Handle kafka METRIC_REPORTER_CLASSES_CONFIG being set to a List (#9155) 2023-08-09 14:48:58 +03:00
renovate[bot] 3f46b7111a
Update errorProneVersion to v2.21.0 (#9112)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-08-02 09:31:40 +02:00
jason plumb 55368a52d7
Rename messaging operation "send" to "publish" per spec (#8929)
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-07-12 08:59:38 -07:00
OpenTelemetry Bot bbb05276be
Update the OpenTelemetry SDK version to 1.27.0 (#8688)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Lauri Tulmin <ltulmin@splunk.com>
2023-06-13 12:02:11 +03:00
Lauri Tulmin 69d0001f2f
Fix failure when kafka metrics reporter is set to an empty string (#8523) 2023-05-18 14:28:41 +02:00
Lauri Tulmin d8b0771929
Use the same kafka docker image in all kafka tests (#8187)
currently we use `confluentinc/cp-kafka:5.4.3` and
`confluentinc/cp-kafka:6.1.9`
2023-03-31 10:25:38 +02:00
Lauri Tulmin 39f7816572
Kafka: avoid registering duplicate metrics reporter (#8099)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/8085
2023-03-22 12:59:29 +01:00
Lauri Tulmin f1411d1cb3
Share timer class used by messaging instrumentations (#8009)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/4514
There is also a slightly different timer class in netty instrumentation
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/netty/netty-common/library/src/main/java/io/opentelemetry/instrumentation/netty/common/internal/Timer.java
that I didn't touch.
2023-03-10 10:40:41 +02:00
Lauri Tulmin a793c247e6
Remove duplicate -Xmx from kafka memory options (#8022) 2023-03-09 22:02:33 +02:00
Lauri Tulmin 67b6b6cc7c
Limit kafka memory usage (#8018) 2023-03-09 16:37:09 +02:00
Lauri Tulmin 85c541ef92
Implement kafka client id and consumer id attributes (#7860)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7771
Adds `messaging.consumer_id` and `messaging.kafka.client_id` attributes
to kafka spans.
2023-02-21 07:31:28 -08:00
Mateusz Rzeszutek 12ea869855
Implement `messaging.kafka.*` attributes spec (part 1) (#7824)
Part 1 of #7771

It's a lot more than I initially expected it to be; I'll introduce the
clientId attribute in part 2
2023-02-16 13:22:17 -08:00
Mateusz Rzeszutek 4fd52c5a7c
Encode version in library instrumentations' package names (#7764)
Another part of #932

In this PR I changed all the library instrumentation packages -- these
are breaking changes, so I figured the earlier we do this the less
painful it'll be to the users. I know that at least some of them are
actively used, so we'll need to spell this out in the release notes.

---------

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-14 23:25:59 +00:00
OpenTelemetry Bot f074b93110
Update the OpenTelemetry SDK version to 1.23.0 (#7800)
Update the OpenTelemetry SDK version to `1.23.0`.

---------

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2023-02-13 20:22:09 +00:00
Will Li d3326db0cf
Convert kafka-clients unit test from groovy to java (#7770)
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2023-02-13 10:58:55 +01:00
Lauri Tulmin 5d182557a1
Ensure kafka configuration remains serializable (#7754)
Resolves
https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/7597
I wasn't able to reproduce this. Figuring out how to run beam, flink and
kafka together feels like too much effort. Without reproducing it is too
hard to tell why the configuration is serialized, but my hunch is that
it is enough to ensure that the configuration can be serialized.
2023-02-09 08:45:39 +02:00
Mateusz Rzeszutek ebb0141032
Populate `messaging.kafka.message.offset` in all kafka instrumentations (#7374) 2022-12-09 17:13:31 -08:00
Trask Stalnaker 5345c87680
End groovy files with newline (#7127) 2022-11-10 12:21:55 +01:00
Trask Stalnaker 93175522d4
Rename kafka propagation setting and clarify behavior (#6957) 2022-10-24 08:49:48 -07:00
Mateusz Rzeszutek c96a49e253
Add kafka client metrics to the javaagent instrumentation (#6533)
* Add kafka client metrics to the javaagent instrumentation

* Don't override user-set metrics reporter

* Add kafka metric reporter config property
2022-09-12 20:36:14 -07:00
Lauri Tulmin 07d7cfd551
Capture messaging header value as span attribute (#6454)
* Capture messaging header value as span attribute

* add comment
2022-08-11 17:28:04 -07:00
Mateusz Rzeszutek 7bbe918008
InstrumentationConfig part 2 (#6292) 2022-07-11 09:47:19 +02:00
Mateusz Rzeszutek e7887ac929
Idea: deprecate `Config`, add agent-only `InstrumentationConfig` (#6264)
* Idea: deprecate Config, add agent-only InstrumentationConfig

* fix

* fix camel test

* fix external-annotation tests
2022-07-08 16:20:49 +02:00
jack-berg 3e08f36cfa
Add kafka client metrics (#6138)
* Add kafka client metrics

* Spotless

* Refactor to general purpose bridge between kafka client metrics and opentelemetry metrics

* Include kafka prefix, fix typo

* Spotless, update readme with latest metric names

* PR feedback

* Map rate measureables to gauges instead of up down counters

* Spotless, quote attributes, log placeholder

* Move metric table printing to test, only retain most granular attribute set

* PR feedback

* Remove synchornization from metricChange

* remove kafka dependency

* PR feedback

* Fix reset

* Adjust configuration pattern to not rely on GlobalOpenTelemetry

* Merge into KafkaTelemetry

* Relocate readme and fix typo
2022-07-06 09:34:14 -07:00