Trask Stalnaker
1077258263
Add InternalJavadoc custom error prone check ( #5277 )
...
* Add InternalJavadoc custom error prone check
* Add example usage
* Move to conventions
* Revert "Move to conventions"
This reverts commit d8a8209b59
.
* Just get it working
* Clearer error message
* versions
* Apply almost everywhere
* feedback
* Always at the end of javadoc
* Fix test
* Missed (at least) one
* No longer internal
* Fix NPE
* Spotless
* Convert awslambda Java test to JUnit 5 so can reduce visibility
* Reduce visibility
* Rename the check
* More
* Move into errorprone-convention
* Fix UserExcludedClassesConfigurerTest
2022-02-01 17:54:57 -08:00
jason plumb
c5c0a2bcdf
NetClientAttributesAdapter - favor composition over inheritance ( #5030 )
...
* first pass at separating NetAttributesAdapter interface and make NetClientAttributesExtractor concrete
* rename the implementations extractor -> adapter
* hide constructor and make factory method
* rename to client and add javadoc
* spotless
* finish javadoc thought
* rebase
* renamed NetClientAttributesAdapter to NetClientAttributesGetter
* fix lettuce
* code review comments
* code review comments -- renaming for consistency
* adapter -> getter
* fix ratpack
* adapter -> getter
2022-01-20 10:51:13 -08:00
Anuraag Agrawal
b7a95857c7
Fix some java lint warnings ( #5120 )
...
* Convert InstrumentationTestRunner from interface to abstract class
* Foo
* Commit
* Revert unintended
2022-01-17 10:26:03 -08:00
Anuraag Agrawal
f6bcd76219
Update errorprone ( #5016 )
...
* Update errorprone
* gwt
* Remove unnecessary final
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2022-01-06 14:21:56 -08:00
Trask Stalnaker
ce4cef76f9
Clean up groovy assertions ( #4805 )
2021-12-05 23:23:58 -08:00
Lauri Tulmin
c79eed765f
Make JdbcData fields final ( #4738 )
2021-11-29 13:00:49 -08:00
Martin
d314d76fce
rename `newBuilder()` to `builder()` ( #4475 )
...
* rename `newBuilder()` to `builder()`
* rename `newBuilder()` to `builder()`
2021-10-22 20:50:43 -07:00
Lauri Tulmin
9b8ab5eeec
Migrate to spock 2 ( #4458 )
...
* Migrate to spock 2
* Fix smoke test suites
* address review comments
* review comment
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-22 08:40:58 -07:00
Martin
ac91dc090a
Type annotation placement ( #4406 )
...
* switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable`
* code format
2021-10-17 17:38:43 -07:00
Trask Stalnaker
63a2383905
Split NetAttributesExtractor into NetClientAttributesExtractor and NetServerAttributesExtractor ( #4287 )
...
* Net Extractors
* Either request or response but not both
* Fix merge conflicts
* Separate by OnStart/OnEnd
* PeerServiceAttributes
* Fix test
* Restructure to client/server
* Fix merge conflict in main
* more
* peer.service
* Feedback
* peer.service is only for clients
* Fix merge conflict
* rename
* Armeria
* peer.service is only for clients
* rename
* WIP
* Sync Dubbo with Armeria
* More Dubbo and Armeria
* gRPC
* Revert some Dubbo changes
* more peer.service
* Fix test
* Fix merge
* Fixes
2021-10-07 15:40:15 -07:00
Nikita Salnikov-Tarnovski
a48bd9de3f
Move PeerServiceAttributesExtractor from javaagent api to instrumentation api ( #4235 )
...
* Move PeerServiceAttributesExtractor from javaagent api to instrumentation api
* spotless
2021-10-06 12:42:55 -07:00
Lauri Tulmin
95651a4f1b
Intern db info ( #4263 )
2021-10-03 19:47:40 -07:00
Mateusz Rzeszutek
c11b96e4d0
Make it possible to use InstrumentationContext (now VirtualField) fro… ( #4218 )
...
* Make it possible to use InstrumentationContext (now VirtualField) from library instrumentation
* fix tests
* fix javadocs
* fix some more tests
* code review comments
* setIfNull, computeIfNull
2021-10-01 11:13:11 +02:00
Trask Stalnaker
abfcfb9dc7
Fix JDBC instrumentation deadlock ( #4191 )
2021-09-23 08:52:01 -07:00
Matthew Ho
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
Lauri Tulmin
b61113fef6
JDBC: use ContextStore when running as agent ( #3987 )
...
* JDBC: use ContextStore when running as agent
* address review comments
* use singular
2021-08-27 14:14:40 -07:00
Anuraag Agrawal
e0cb216610
Remove remaining usages of basic span asserts ( #3616 )
2021-07-19 10:09:44 -07:00
Anuraag Agrawal
f5ce4c03f8
Inline basic usages of basicSpan ( #3583 )
...
* Inline basic usages of basicSpan
* spock
2021-07-18 21:15:51 +03:00
Anuraag Agrawal
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
Trask Stalnaker
dffb12fd44
Add missing test verification ( #3578 )
2021-07-15 09:15:12 +03:00
Mateusz Rzeszutek
9b56fc9051
Clean up AgentElementMatchers ( #3527 )
...
* Clean up AgentElementMatchers
* remove a TODO
* moved method
2021-07-09 10:02:21 +03:00
Trask Stalnaker
9e4da754c2
Use consistent logger field name ( #3515 )
2021-07-07 10:47:46 -07:00
Trask Stalnaker
b304cc2912
Deprecate CallDepth.reset() and get() ( #3511 )
...
* Deprecate CallDepth.reset() and get()
* Don't pass CallDepth around
2021-07-07 09:24:50 -07:00
Mateusz Rzeszutek
c5ba5c3a71
Use local variable for passing CallDepth between advice enter/exit me… ( #3504 )
...
* Use local variable for passing CallDepth between advice enter/exit methods
* fix broken call depth tracking
* checkstyle
* fix javadocs
2021-07-06 12:05:14 -07:00
Alexey Zhokhov
9979bef877
JDBC instrumentation: switch to use api instead of implementation for instrumentation-api. ( #3494 )
...
* Switch to use api instead of implementation for instrumentation-api.
* Removed duplicated dependency.
2021-07-06 09:20:41 -07:00
Mateusz Rzeszutek
b9fcb6b498
Reduce CallDepth classes' API surface ( #3497 )
2021-07-06 09:24:19 +02:00
Trask Stalnaker
642f213c12
Remove hardcoded version ( #3470 )
...
* Remove hardcoded version
* Codenarc
2021-07-01 23:00:15 -07:00
Alexey Zhokhov
ed02aff7b5
OpenTelemetry JDBC instrumentation library ( #3367 )
...
* Added jdbc library with ported version of OpenTracing JDBC Instrumentation.
* Gradle 7.1.
* Revert "Gradle 7.1."
This reverts commit e3df35b0
* Code style fixes.
* Code style fixes.
* Moved some JDBC utilities classes to the library module.
* javax.annotation.Nullable -> org.checkerframework.checker.nullness.qual.Nullable
* Build fix.
* Spotless fixes.
* Cache prepared statements.
* Cache connection info.
* Tracing for JDBC statement and prepared statement.
* Added some API dependencies.
* Fixed ending the span.
* Removed proxy usage.
* Cleanup.
* Implemented datasource with tracing support.
* Renamed Tracing prefix with OpenTelemetry.
* Renamed Tracing prefix with OpenTelemetry.
* Moved utilities classes to io.opentelemetry.instrumentation.jdbc.internal subpackage.
* Build fix.
* Build fix.
* Cleanup.
* Moved some shared classes to instrumentation-api module.
* Code review fixes.
* Make OpenTelemetryDriver final.
* Spotless fixes.
* Moved test classes from javaagent-unit-tests module to library module.
* Removed javaagent-unit-tests module.
* Covered OpenTelemetryDriver with tests.
* Cleanup.
* Covered OpenTelemetryDataSource with tests.
* Covered OpenTelemetryConnection with tests.
* Revert TestPreparedStatement.
* Added README.
* Build fix.
* Checkstyle fixes.
* Spotless fixes.
* Rename to build.gradle
* Fix build.gradle format.
* INSTANCE package scope.
* Documented OpenTelemetryDataSource usage.
* Renamed CheckedCallable to ThrowingSupplier.
* Update instrumentation/jdbc/library/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/jdbc/library/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/jdbc/library/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Update instrumentation/jdbc/library/README.md
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* Removed javaagent-api module usage.
* Removed useless checking.
* Moved javaagent test classes to testing module.
* Move common JDBC test classes to testing module.
* Spotless fixes.
* Code format.
* Moved PeerServiceAttributesExtractor back to javaagent-api module.
* Rename JavaAgentJdbcSingletons to JdbcSingletons.
* Fixed JdbcSingletons import.
* Cleanup.
* Codenarc fixes.
* Update instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/OpenTelemetryDriver.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Parse InstrumentationVersion.VERSION.
* Store major and minor version in private static fields.
* Make the datasource way a preferred way.
* Removed interceptor mode.
* Rename build.gradle -> build.gradle.kts.
* Switch to Gradle Kotlin DSL.
Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-07-01 10:35:07 -07:00
Mateusz Rzeszutek
15ed01d4fc
Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} ( #3411 )
...
* Change all instrumentation names to io.opentelemetry.{libName}-{libVersion}
* minumum supported version
2021-06-30 15:34:36 +02:00
Anuraag Agrawal
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
Anuraag Agrawal
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
Anuraag Agrawal
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
Anuraag Agrawal
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
Mateusz Rzeszutek
2f528e4166
Rename *Instrumenters to *Singletons ( #3335 )
2021-06-16 10:12:37 -07:00
Anuraag Agrawal
224dc51e93
Migrate java.gradle to conventions plugin ( #3289 )
...
* Migrate java.gradle to convention plugin.
* Switch to java-conventions
* Remove old file
* Fix
* Fix merge
* Missing paragraph
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-15 08:10:39 +09:00
Trask Stalnaker
62f1f49bcd
Intellij cleanup (Java and Groovy) ( #3285 )
...
* Intellij cleanup
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/code/CodeAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/DbAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/db/SqlAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation-api/src/test/java/io/opentelemetry/instrumentation/api/instrumenter/messaging/MessagingAttributesExtractorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/spring/spring-web-3.1/library/src/test/java/io/opentelemetry/instrumentation/spring/httpclients/RestTemplateInterceptorTest.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Use glassfish version that supports lambdas
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-06-14 10:23:01 -07:00
Trask Stalnaker
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
Trask Stalnaker
e9c3df6dac
Static factory method ordering ( #3206 )
2021-06-07 15:29:30 -07:00
Trask Stalnaker
a78ed4c420
Rename some extractor request/response params ( #3202 )
2021-06-07 11:41:47 -07:00
Anuraag Agrawal
2436499a09
Update to Errorprone 2.7 ( #3181 )
...
* Update to errorprone 2.7
* ToString
* Finish
2021-06-04 10:40:55 +09:00
Mateusz Rzeszutek
5e4c5684e6
Moved jdbc-datasource instrumentation to Instrumenter API ( #3160 )
2021-06-02 23:45:11 -07:00
Anuraag Agrawal
c3dedbb64e
Enable all errorprone checks ( #3155 )
...
* Enable all errorprone checks
* Fixes
* Finish
* Finish
* Add flag to disable error prone
2021-06-01 17:41:08 +09:00
Anuraag Agrawal
ed88cca533
Migrate from spotbugs to errorprone ( #3122 )
...
* Migrate from spotbugs to errorprone
* Fix hashtable
* try-with-resources
* Fix from merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
Anuraag Agrawal
c358a35414
Use dependency management pattern for dependency versions ( #3113 )
...
* Use dependency management pattern for dependency versions.
* Add groovy bom too
* Update dependencyManagement/dependencyManagement.gradle.kts
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 11:32:08 +09:00
Trask Stalnaker
c8ecd9a619
Add response type parameter to db attributes extractor ( #3093 )
...
* Add response type parameter to DbAttributesExtractor
* AutoValue
* ResultSet
2021-05-26 23:13:33 -07:00
Lauri Tulmin
38830ea06e
Fix JdbcInstrumentationTest ( #3089 )
2021-05-26 08:25:20 -07:00
Mateusz Rzeszutek
d755654c29
[WIP] Add peer.service to Instrumenter API ( #3050 )
...
* [WIP] Add peer.service to Instrumenter API
* Move PeerServiceAttributesExtractor to javaagent-api and use reflection to add it
* Finish PeerServiceAttributesExtractor
* Fix tests
* Add peer.service to apache-httpclient-5.0, jedis-1.4, lettuce-4.0
2021-05-25 15:31:41 +02:00
Trask Stalnaker
329233e576
Change a couple of Longs to Integers in Instrumenter API ( #3043 )
2021-05-20 14:33:22 -07:00
Trask Stalnaker
6efae9ad28
Remove duplicate method ( #3032 )
2021-05-19 11:56:34 -07:00
Mateusz Rzeszutek
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00