Trask Stalnaker
b304cc2912
Deprecate CallDepth.reset() and get() ( #3511 )
...
* Deprecate CallDepth.reset() and get()
* Don't pass CallDepth around
2021-07-07 09:24:50 -07:00
Mateusz Rzeszutek
c5ba5c3a71
Use local variable for passing CallDepth between advice enter/exit me… ( #3504 )
...
* Use local variable for passing CallDepth between advice enter/exit methods
* fix broken call depth tracking
* checkstyle
* fix javadocs
2021-07-06 12:05:14 -07:00
Mateusz Rzeszutek
b9fcb6b498
Reduce CallDepth classes' API surface ( #3497 )
2021-07-06 09:24:19 +02:00
Lauri Tulmin
5d6be8764e
Remove jetty-server exclude ( #3453 )
2021-07-01 09:12:26 +09:00
Anuraag Agrawal
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
Anuraag Agrawal
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
Anuraag Agrawal
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
Anuraag Agrawal
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
Anuraag Agrawal
7ad9e7a50b
Move shaded testing dependencies to internal package. ( #3305 )
2021-06-15 13:10:19 +03:00
Trask Stalnaker
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
Anuraag Agrawal
84cc044ddf
Migrate remaining test client calls to Armeria and remove testing-com… ( #3250 )
2021-06-11 11:51:23 -07:00
Anuraag Agrawal
60aaff8972
Migrate HttpServerTest to Armeria ( #3240 )
...
* Migrate HttpServerTest to Armeria
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpServerTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-11 08:56:02 +09:00
Anuraag Agrawal
2436499a09
Update to Errorprone 2.7 ( #3181 )
...
* Update to errorprone 2.7
* ToString
* Finish
2021-06-04 10:40:55 +09:00
Anuraag Agrawal
ed88cca533
Migrate from spotbugs to errorprone ( #3122 )
...
* Migrate from spotbugs to errorprone
* Fix hashtable
* try-with-resources
* Fix from merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-28 14:23:40 -07:00
Ago Allikmaa
df078f95a9
Extract HttpServerTest INDEXED_CHILD span attribute collection logic ( #3095 )
...
* Extrawct HttpServerTest INDEXED_CHILD span attribute collection logic
* Adjust whitespace
* Fix context issue with JAX-RS
* Rerun tests
2021-05-27 11:18:11 +03:00
Ago Allikmaa
fd132d463d
Change Async Servlet span end logic to fix race condition on Undertow ( #2992 )
...
* Attach servlet async listener with asyncStart instrumentation
* Exclude Spring packages containing servlet request classes from global ignores
* Exclude Tapestry HSR proxy with global ignore
* Improve comments.
* Fix for Liberty - request response when adding async listener
* Removed unused methods
* Explicit response to async listeners on all servlet engines
* Attach response to request on Jetty
* Fix broken build due to rebase, improved a comment
* Address PR comments
* Added a comment.
* Addressed PR comments
2021-05-25 20:46:37 -07:00
Lauri Tulmin
2675364897
Remove span isRecording check from servlet advice ( #3022 )
2021-05-18 08:51:24 +09:00
Anuraag Agrawal
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
Lauri Tulmin
406eabef20
Simplify servlet advice ( #2972 )
...
* Simplify servlet advice
* fix sampling
* Trigger Build
* use the same logic as previously, maybe this helps agains glassfish smoke-test failure
2021-05-14 18:49:32 +03:00
Mateusz Rzeszutek
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
Lauri Tulmin
357140c081
Server span naming for servlet filters ( #2887 )
...
* Server span naming for servlet filters
* wildfly default servlet has empty mappings
* jetty11 requires java11
* try a differnt way to disable jetty11 tests on java8
* Update instrumentation/servlet/servlet-5.0/javaagent/src/test/groovy/TomcatServlet5FilterMappingTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* review fix
* rework to use InstrumentationContext
* remove debugging code
* move MappingResolver to avoid ClassCastException on wildfly
* Update instrumentation/servlet/servlet-3.0/javaagent/src/test/groovy/TomcatServlet3FilterMappingTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
* review fixes
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-05-06 13:25:17 +03:00
Ago Allikmaa
109318b404
Implement concurrency test for Async Servlets ( #2899 )
2021-05-04 12:54:20 +03:00
Trask Stalnaker
1824e36b96
Better server span name for Grails and Wicket ( #2814 )
2021-04-22 14:16:54 -07:00
Trask Stalnaker
46c1212236
Remove forward and include spans ( #2816 )
2021-04-22 11:36:53 -07:00
Trask Stalnaker
bd829a6494
Remove duplicate status verification ( #2710 )
2021-04-19 11:41:37 -07:00
Nikita Salnikov-Tarnovski
38e98ebdad
Implement concurrent test for Vert.x http server ( #2749 )
...
* Implement concurrent test for Vert.x http server
* Format
2021-04-08 09:27:11 +03:00
Ago Allikmaa
7027006f66
Request handlers and test images for Tomcat 10 and Jetty 11 (Servlet API 5) ( #2703 )
...
* Tomcat 10 and Jetty 11 handlers with Servlet API 5
* Jetty 11 and Tomcat 10 Windows images
2021-04-05 09:45:02 -07:00
Nikita Salnikov-Tarnovski
86ec1d7211
Concurrent server test ( #2680 )
...
* Concurrent server test
* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpServerTest.groovy
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
2021-04-05 14:12:07 +03:00
Ago Allikmaa
69c2644774
Servlet 5 API, reorganize servlet modules ( #2609 )
...
* Servlet 5.0 API support, refactored other servlet modules
* Include correct servlet instrumentation module for grails tests
* Reapply spotless after rebase
* Fix checkstyle
* Spotless
* Addressed PR suggestions
* Fixed files in wrong package.
* Fixed mixed up instrumentation names.
* Fixed incomplete instrumentation name.
* Addressed PR suggestions
* Addressed PR suggestions
2021-03-23 14:11:43 +02:00
Trask Stalnaker
811259376e
Update servlet attr names to match log attr names ( #2593 )
2021-03-18 14:03:06 +02:00
Lauri Tulmin
29790d8472
Low cardinality name for servlet span ( #2417 )
2021-03-04 12:39:37 -08:00
Lauri Tulmin
e39b0b44c9
Fix flaky tomcat access log tests ( #2448 )
2021-03-01 17:41:44 +02:00
Trask Stalnaker
b4c8354b56
Hide non-specd attributes behind experimental flag ( #2376 )
2021-02-24 12:33:21 -08:00
Lauri Tulmin
1ca7276593
Remove HttpServerTest.testExceptionBody and redirectHasBody ( #2346 )
2021-02-19 15:57:11 +02:00
Lauri Tulmin
bc77ab0c82
jetty 9.4 behave differently from earlier versions ( #2335 )
2021-02-18 15:38:45 -08:00
Lauri Tulmin
80f389c778
Instrument all jetty handlers ( #2320 )
2021-02-18 11:51:48 +02:00
Mateusz Rzeszutek
ee090aee1e
Support library instrumentations with HttpServerTest & HttpClientTest ( #2299 )
2021-02-16 09:05:23 -08:00
Lauri Tulmin
e76d3b19d1
Fix ServletContextPath.prepend for app server spans ( #2089 )
...
* ServletContextPath.prepend doesn't work when server span is created from app server integration
* move ServletContextPath context creation to servlet-common, make servlet2&3 depend on servlet-common so that it would be used in tests that depend on servlet3
* fix failing test
* add servlet-common dependency to modules that depend on servlet3
* add servlet-common dependency to mojarra and myfaces
* run context path instrumentation after servlet instrumentation
* add servlet-common dependency to wicket
* move servlet context path handling
* enable jetty instrumentation for all handlers
* run springmvc tests with tomcat integration, fix peer port and peer ip reporting on tomcat
* jetty integration is now enabled for all handlers
* update expected span name
* Revert "jetty integration is now enabled for all handlers"
This reverts commit 82cbb663f5
.
* Revert "update expected span name"
This reverts commit c034496fc5
.
* Revert "enable jetty instrumentation for all handlers"
This reverts commit 8a3d077600
.
* Trigger Build
2021-02-15 23:34:15 -08:00
Anuraag Agrawal
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
John Watson
4c1144ce78
Distinguish between the various servlet tracers for easier debugging. ( #1979 )
...
* Distinguish between the various servlet tracers for easier debugging.
* change to use the `common` suffix for that module
* Update instrumentation/servlet/servlet-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v2_2/Servlet2HttpServerTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/Servlet3HttpServerTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/dispatcher/RequestDispatcherTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
* Update instrumentation/servlet/servlet-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/http/HttpServletResponseTracer.java
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-01-20 16:33:13 +02:00
Lauri Tulmin
9825ab0afa
Instrument jsf action calls ( #2018 )
2021-01-19 21:34:41 -08:00
Mateusz Rzeszutek
660f0e5225
Remove testing-common dependency on guava ( #2062 )
...
* Remove testing-common dependency on guava
* Use nano time
* Add guava dep to opentelemetry-api-metrics
2021-01-19 12:07:27 +09:00
Lauri Tulmin
11ad12289b
Jetty server span handling ( #2029 )
2021-01-14 09:31:57 -08:00
Pavol Loffay
077d8b64f6
Move common matchers to tooling/bytebuddy/matcher and ignore matchers to tooling/matcher ( #1965 )
2021-01-10 12:35:53 -08:00
Lauri Tulmin
5f816c5d43
Enable servlet forward and include tests ( #1968 )
2021-01-06 11:01:47 -08:00
Lauri Tulmin
2b97c42e01
Improve servlet22 response status handling ( #1985 )
...
* imporve servlet22 response status handling
* Update instrumentation/servlet/servlet-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v2_2/Servlet2Advice.java
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-01-06 14:02:51 +09:00
Anuraag Agrawal
8d74baa2e4
Run tests with javaagent. ( #1643 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-01-04 13:13:24 -08:00
Lauri Tulmin
79433966fb
Liberty server span handling ( #1929 )
...
* Liberty server span handling
* review fixes
* review fixes
* add doc about using compile stubs
* Update instrumentation/liberty/liberty/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/liberty/LibertyInstrumentationModule.java
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
* Update instrumentation/liberty/liberty/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/liberty/ThreadLocalContext.java
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
* add links to advice classes
* add commnet, remove unneeded dependency
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
2020-12-22 15:00:58 +02:00
Nikita Salnikov-Tarnovski
0888711574
Add support for Undertow server runtime ( #1917 )
...
* Add support for Undertow server runtime
* Polish
* Damn be classloaders
* Fix correct span name
* Polish
2020-12-22 14:13:50 +02:00
Vladimir Šor
135ba344cb
Tomcat server handlers ( #1902 )
...
* Tomcat server handler with passing integration and smoke tests.
* Update server span name from the servlet integration instead of trying to mimic it from the server handler.
* Cleanup and more javadocs.
* Use Java8BytecodeBridge in advice code.
* Use Java8BytecodeBridge in advice code.
* Use earliest version for compilation and muzzling.
* Use consistent instrumentation name.
* Record throwables only if the context is managed by something else.
* Getting scope handling right. Moved server span renaming logic via AppServerBridge to the ServletHttpServerTracer.
* codenarc
* more PR comments addressed
* Pass Method to startServerSpan
2020-12-16 16:59:54 +02:00
Trask Stalnaker
fa09451aea
Prefix custom attributes with instrumentation name ( #1784 )
2020-12-03 20:56:31 -08:00
Trask Stalnaker
0bd85d7b7f
Pass around context more instead of span (HttpServerTracer) ( #1810 )
2020-12-01 14:49:01 -08:00
Trask Stalnaker
26f254b10d
Create javaagent dirs for all instrumentations, part 2 ( #1794 )
2020-11-28 22:26:49 -08:00
Trask Stalnaker
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00