8b767ac435
Refactor HTTP attributes extractors to use composition over inheritance ( #5267 )
...
* Refactor HTTP attributes extractors to use composition over inheritance
* Rename remaining variables: *Extractor to *Getter
2022-01-31 09:25:27 -08:00
c5c0a2bcdf
NetClientAttributesAdapter - favor composition over inheritance ( #5030 )
...
* first pass at separating NetAttributesAdapter interface and make NetClientAttributesExtractor concrete
* rename the implementations extractor -> adapter
* hide constructor and make factory method
* rename to client and add javadoc
* spotless
* finish javadoc thought
* rebase
* renamed NetClientAttributesAdapter to NetClientAttributesGetter
* fix lettuce
* code review comments
* code review comments -- renaming for consistency
* adapter -> getter
* fix ratpack
* adapter -> getter
2022-01-20 10:51:13 -08:00
331ce287d2
Don't use HttpStatusConverter outside of instrumentation-api ( #4870 )
...
* Don't use HttpStatusConverter outside of instrumentation-api
* add comment
2021-12-14 10:07:18 +01:00
ce4cef76f9
Clean up groovy assertions ( #4805 )
2021-12-05 23:23:58 -08:00
b287c8d1d0
Enable read timeout test for some http clients ( #4702 )
...
* Enable read timeout test for some http clients
* remove unused import
* use separate client for read timeout request
2021-11-28 13:18:26 -08:00
fac60ddb3c
Enable read timeout test for HttpURLConnection ( #4699 )
2021-11-23 10:30:45 -08:00
81cb8e61db
More metrics ( #4541 )
2021-10-29 10:17:35 +03:00
8ea59f0846
Rename all InjectAdapters to Setters ( #4489 )
...
* Rename all InjectAdapters to Setters
* Errorprone fixes
* Make setter public
2021-10-25 12:36:59 -07:00
d314d76fce
rename `newBuilder()` to `builder()` ( #4475 )
...
* rename `newBuilder()` to `builder()`
* rename `newBuilder()` to `builder()`
2021-10-22 20:50:43 -07:00
9b8ab5eeec
Migrate to spock 2 ( #4458 )
...
* Migrate to spock 2
* Fix smoke test suites
* address review comments
* review comment
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-22 08:40:58 -07:00
a50c13382f
Don't report 400 level as error for SERVER spans ( #4403 )
...
* don't report 400 level as error for server spans
* fix HttpServerTest base class
* fix JspInstrumentationForward test
* split HttpStatusConverter into client and server implementations, and create two HttpSpanStatusExtractor.create methods, one for server and one for client.
* rebase
* fix test
* spotless
* fix test
* remove unused
* use strongly typed attributes converters and rename to overloaded create()
* fix tests
* remove redundant assert
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-10-20 13:39:35 -07:00
8739cdf73e
Capture response headers for HttpUrlConnection ( #4417 )
2021-10-19 10:18:19 -07:00
ac91dc090a
Type annotation placement ( #4406 )
...
* switch annotation `org.checkerframework.checker.nullness.qual.Nullable` to `javax.annotation.Nullable`
* code format
2021-10-17 17:38:43 -07:00
63a2383905
Split NetAttributesExtractor into NetClientAttributesExtractor and NetServerAttributesExtractor ( #4287 )
...
* Net Extractors
* Either request or response but not both
* Fix merge conflicts
* Separate by OnStart/OnEnd
* PeerServiceAttributes
* Fix test
* Restructure to client/server
* Fix merge conflict in main
* more
* peer.service
* Feedback
* peer.service is only for clients
* Fix merge conflict
* rename
* Armeria
* peer.service is only for clients
* rename
* WIP
* Sync Dubbo with Armeria
* More Dubbo and Armeria
* gRPC
* Revert some Dubbo changes
* more peer.service
* Fix test
* Fix merge
* Fixes
2021-10-07 15:40:15 -07:00
a48bd9de3f
Move PeerServiceAttributesExtractor from javaagent api to instrumentation api ( #4235 )
...
* Move PeerServiceAttributesExtractor from javaagent api to instrumentation api
* spotless
2021-10-06 12:42:55 -07:00
d3dbe415a1
Move HttpHeadersConfig methods back to instrumentation-api ( #4298 )
...
* Move HttpHeadersConfig methods back to instrumentation-api
* remove unnecessary method
2021-10-06 10:51:45 +02:00
7791be24e0
Remove implementations of host() and userAgent() in HTTP extractors ( #4299 )
...
* Remove implementations of host() and userAgent() in HTTP extractors
* fix broken headers copying
2021-10-05 10:25:45 -07:00
7473eff1e6
Extract HTTP request/response headers as span attributes ( #4237 )
...
* Extract HTTP request/response headers as span attributes
* fix muzzle
* code review comments
* fix compilation failure after merge conflict
* avoid using streams API when transforming the headers list
* fix liberty extractor
* fix spring webmvc extractor
2021-10-05 10:20:59 +02:00
c11b96e4d0
Make it possible to use InstrumentationContext (now VirtualField) fro… ( #4218 )
...
* Make it possible to use InstrumentationContext (now VirtualField) from library instrumentation
* fix tests
* fix javadocs
* fix some more tests
* code review comments
* setIfNull, computeIfNull
2021-10-01 11:13:11 +02:00
9ea33edf08
Remove attrs from http client attributes extractor ( #4210 )
...
* Remove scheme/host/target from HttpClientAttributesExtractor
* And jaxrs-client
* Remove unused methods
2021-09-28 12:58:42 -07:00
a277a8b636
Separate HTTP client/server AttributesExtractors ( #4195 )
2021-09-24 10:06:23 -07:00
6967484a97
Update groovy import order to match default IntelliJ ( #1708 ) ( #4047 )
...
* Update groovy import order to match default IntelliJ (#1708 )
* organized imports for .groovy files to follow default IntelliJ import settings
* updated intellij-setup.md
* Spotless
* drift
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-09-11 11:53:08 -07:00
2c044253e8
HttpURLConnection response code edge case ( #4062 )
2021-09-08 07:55:21 -07:00
f89933b67c
Transition http-url-connection module to instrumenter API ( #4044 )
...
* Convert http-url-connection to instrumenter API
* Replace HttpUrlResponse with response status code Integer
2021-09-07 14:54:16 -07:00
7a705d861e
Move SpringRestTemplateTest ( #3870 )
2021-08-19 12:58:24 +03:00
47be4a16b4
Convert HttpClientTest to JUnit ( #3652 )
...
* Migrate HttpClientTest to junit to allow both Java or spock tests.
* More
* Update
* Finish
* Cleanup
* Better stack
* Java 15
* Merge
* Fix name
* Cleanup
* ? extends
* Moar
2021-07-27 21:55:40 +09:00
d3b62de8a5
Replace most uses of TraceUtils with testRunner runWithSpan. ( #3582 )
2021-07-15 10:30:34 -07:00
b9fcb6b498
Reduce CallDepth classes' API surface ( #3497 )
2021-07-06 09:24:19 +02:00
15ed01d4fc
Change all instrumentation names to io.opentelemetry.{libName}-{libVersion} ( #3411 )
...
* Change all instrumentation names to io.opentelemetry.{libName}-{libVersion}
* minumum supported version
2021-06-30 15:34:36 +02:00
761b9c280b
Migrate instrumentation gradle files to kotlin ( #3414 )
...
* Migrate instrumentation gradle files to kotlin
* Convert
* Muzzle
2021-06-28 17:27:12 +09:00
785dc6adf2
Rename build files to build.gradle ( #3409 )
...
* Rename build files to build.gradle
* Rename smoke-tests
* Fix already broken
2021-06-25 16:10:31 +09:00
deb0e255cf
Use plugins block everywhere for applying plugins ( #3386 )
...
* Use plugins block everywhere for applying plugins
* Actually it's library instrumentation
2021-06-24 11:13:35 +09:00
80f43b7a6a
Migrate javaagent-instrumentation to plugin ( #3328 )
...
* Migrate instrumentation.gradle to plugin
* Migrate usages
* Remove old
* Fix
* Revert example
* afterEvaluate
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-06-17 23:13:14 +09:00
b25ac0f1ad
Clean up old operation name terminology ( #3282 )
2021-06-13 22:10:36 -07:00
4c80c62ce7
Add unused to remaining advice classes ( #3280 )
...
* Add unused to remaining advice classes
* Add newlines for visual separation
2021-06-14 11:12:02 +09:00
7ae23fc694
Migrate HttpClientTest test server to Armeria ( #3225 )
...
* Use Armeria for test HTTP server.
* Continue
* Migrate test http server to Armeria.
* Finish
* Use junit extension
* Remove unused.
* Use localhost for net peer name.
* Block for full response in recator-netty tests.
* Handle split responses in netty41 and akka
* Typo
2021-06-09 15:05:58 +09:00
1b63e3265f
Always include server span in HTTP client tests. ( #3214 )
...
* Always include server span in HTTP client tests.
* Scrub
2021-06-08 11:39:06 +09:00
b8aec6a671
Remove no longer needed NameMatchers class ( #3179 )
2021-06-03 14:36:36 -07:00
c1c052318b
Move more type instrumentations to top-level classes ( #3118 )
2021-05-28 17:24:19 -07:00
bb8f515083
Refactor TypeInstrumentation#transformers() method ( #3019 )
...
* Refactor TypeInstrumentation#transformers() method part 1
Add TypeInstrumentation and its implementations
* Refactor TypeInstrumentation#transformers() method part 2
Use the new method in all existing TypeInstrumentation implementations
* Drift
* Spotless
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-05-18 09:50:26 +02:00
fe41885ee6
Switch to colon notation for dependencies. ( #2994 )
...
* Switch to colon notation for dependencies.
* Even more cleanup
* Revert mistake
2021-05-15 15:31:06 +09:00
28d814c813
Add HTTP client error test ( #2932 )
2021-05-13 13:34:45 -07:00
d29bf39428
Don't set span status to unset ( #2956 )
2021-05-11 16:14:19 -07:00
10db083e77
Update to OTel API/SDK 1.2.0 ( #2945 )
...
* Update to OTel API/SDK 1.2.0
* TCP.IP -> tcp_ip
* Fix smoke tests
2021-05-10 10:14:07 -07:00
9c7fae3b04
Extract javaagent-extension-api from tooling & spi ( #2879 )
2021-05-06 23:30:25 -07:00
9464134ffd
Test failing async http request ( #2812 )
2021-04-19 14:11:27 -07:00
bd829a6494
Remove duplicate status verification ( #2710 )
2021-04-19 11:41:37 -07:00
078603caf5
Generate InstrumentationModule#contextStore() with muzzle ( #2775 )
2021-04-13 20:05:01 -07:00
3bc058b10b
Don't create duplicate headers ( #2727 )
...
* Test infra
* Update examples
* Update instrumentation
* Update tests
* jaxrs-client fixes
* Remove doRequest/doReusedRequest
* Fix muzzle
* some fixes
* fix test
* doc
* not private
* Apply to doRequestWithCallback also
* Update doc
* groovy
* better
* Don't hardcode traceparent
* Reuse request in SpringRestTemplateTest
2021-04-12 12:21:16 +03:00
d8f6018ba6
Split HttpClientTest execution methods for sync and callback ( #2675 )
2021-04-06 15:26:01 -07:00
6ea316e22e
Remove timeout annotations ( #2725 )
2021-04-06 16:36:18 +09:00
ae23b97ec4
Move and rename NetPeerUtils ( #2548 )
...
* Move and rename NetPeerUtils
* Rename NetPeerUtils to NetPeerAttributes; inject instance instead of using a global var
* Rename SpanAttributeSetter to AttributeSetter (might be used to set on AttributesBuilder in the future, who knows)
* Deprecate default BaseTracer constructor: library instrumentations are supposed to inject all dependencies, the javaagent should explicitly pass globals
* fix compilation failure
* Remove peer.service customization from library instrumentation
2021-03-16 13:50:19 +01:00
0c7aff28e5
Enable disabled tests for HttpUrlConnection ( #2382 )
...
* Enable disabled tests for HttpUrlConnection
* review fix
2021-02-23 23:34:50 +02:00
f7b825466d
Fix VerifyError in HttpUrlConnectionInstrumentation ( #2380 )
2021-02-23 17:32:54 +01:00
000df967ce
Update to SDK 0.17.0 ( #2338 )
...
* Update to SDK 0.17.0
* Finish
* ottrace
2021-02-19 15:51:55 +09:00
3fc1765446
Include status code for HttpUrlConnection exceptions ( #2272 )
...
* work in progress
* set span state to error and cleanup
* build test
* gotta get spotless
* cleanup
* move getResponseCode advice to its own advice class.
* remove dynamic type from annotation
* Update instrumentation/http-url-connection/javaagent/src/test/groovy/HttpUrlConnectionTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Update instrumentation/http-url-connection/javaagent/src/test/groovy/HttpUrlConnectionTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2021-02-17 22:02:02 +02:00
ee090aee1e
Support library instrumentations with HttpServerTest & HttpClientTest ( #2299 )
2021-02-16 09:05:23 -08:00
fc410706d0
Update to Sdk 0.16.0 ( #2221 )
...
* Update to 0.16.0-SNAPSHOT
* Finish
* Finish
* Update to 0.16.0
* Finish
2021-02-09 18:00:54 +09:00
93b3a3b289
testing-common refactoring: replace direct AgentTestRunner usage with… ( #2134 )
...
* testing-common refactoring: replace direct AgentTestRunner usage with spock spec
* Updated instrumentation docs
* Fix reactor-core library tests
ReactorCoreTest was getting a tracer from GlobalOpenTelemetry before LibraryTestTrait had a change to initialize the SDK
2021-02-01 11:32:25 +01:00
afdde0355b
Update to OTel 0.14.1 ( #2059 )
...
* Update SDK dependency to 0.14.1
* WIP
* Finish
* Cleanup
2021-01-18 13:02:04 +09:00
077d8b64f6
Move common matchers to tooling/bytebuddy/matcher and ignore matchers to tooling/matcher ( #1965 )
2021-01-10 12:35:53 -08:00
9e38f521f8
HTTP client instrumentation cleanup: http-url-connection ( #1908 )
...
* HttpClientTracer cleanup: http-url-connection
* Checkstyle
* Feedback
2020-12-16 07:52:16 +02:00
3b8827b8ab
Update to SDK 0.12.0 ( #1830 )
...
* Update to SDK 0.12.0
* Update error message to the current world.
* Bump referenced smoke test versions
* fixes
* dependency hell
* Suppress unused call
* Bump missed smoke tests
* Bump image, bump smoke tests gRPC version
2020-12-07 17:16:47 +09:00
65f54e450b
Use Context more in HttpClientTracer ( #1811 )
...
* Use Context more in HttpClientTracer
* Better http-url-connection response object
* Follow database semantic conv for elasticsearch-rest
* Remove unnecessary CallDepth tracking
2020-12-03 11:47:08 -08:00
ca76c80820
Hardcode expected values in tests ( #1803 )
...
* DEFAULT_SPAN_NAME
* TEMP_DESTINATION_NAME
* LoggingContextConstants
* Remove unnecessary dependencies
* Hardcode expected normalized queries in tests
* Spotless
2020-11-30 09:16:59 +02:00
26f254b10d
Create javaagent dirs for all instrumentations, part 2 ( #1794 )
2020-11-28 22:26:49 -08:00
41bd489a77
Format groovy files ( #1793 )
2020-11-28 21:22:14 -08:00
5f263644da
Create javaagent dirs for all instrumentations ( #1668 )
...
* Create javaagent dirs for all instrumentation
* Add note about kotlin coroutine library instrumentation
* Feedback
2020-11-28 21:04:16 -08:00
9a64a628ea
Make instrumentations non final ( #1752 )
...
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-11-26 11:22:25 -08:00
50c8ab499d
Remove no longer needed helperClassNames() methods ( #1755 )
2020-11-24 20:50:32 -08:00
cecdfc2cd0
Update instrumentation names to be consistent ( #1671 )
...
* Update instrumentation names to be consistent
* Remove amqp from rabbitmq package name
2020-11-18 19:53:31 -08:00
6d5ec329d6
Enable checkstyle for google style guide ( #1641 )
2020-11-16 18:46:59 -08:00
aa3ba8d165
Refactor Instrumenters into InstrumentationModules - D, E, F, G, H ( #1557 )
2020-11-09 14:41:12 -08:00
d3b60a5e33
Rename TRACER to tracer() ( #1540 )
2020-11-02 20:49:51 -08:00
c6eee70660
Update to latest snapshot. ( #1524 )
2020-10-29 18:54:09 -07:00
3565775b00
Format groovy ( #1475 )
...
* Apply Intellij format to groovy
* spotless
2020-10-26 11:47:12 +09:00
f6ad05b8e3
Update to latest SDK snapshot ( #1384 )
...
* Update to latest SDK snapshot
* Use published snapshot
* Fixes
* Cleans
* spotless
* Most
* Clean
* Merge
* Temporarily remove context interop
* WIP
* Prepare for intercepting propagated span
* Bump SDK
* IDE updates
* Lots
* compileJava
* Done?
* bar
* Spot
* drugs
* Groovy--
* green for me
* Spot
* Remove grpc import
* Scrub
2020-10-25 15:14:32 +09:00
6875faa3a0
Fix HttpURLConnection instrumentation on WebLogic ( #1439 )
2020-10-22 09:48:53 +03:00
c739f7db6b
Remove unnecessary scopes ( #1351 )
2020-10-11 14:31:37 -07:00
1b51d4a6b1
Rename packages ( #1367 )
2020-10-11 13:54:35 -07:00
f2de47a150
SpanAssert method names should reflect underlying Span method names ( #1307 )
2020-10-05 16:04:08 +09:00
dadaac9a8c
Use 2-line license header to match SDK repo ( #1321 )
...
* Use 2-line license header to match SDK repo
* Apply change
2020-10-05 14:29:56 +09:00
beb1901f5f
Review semantic convention for Http Client spans ( #1214 )
...
* Review semantic convention for Http Client spans
* Polish
* Update instrumentation/google-http-client-1.19/src/test/groovy/AbstractGoogleHttpClientTest.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-09-18 17:52:08 +03:00
e8b54885c4
Enhance AWS DynamoDB instrumentation ( #1191 )
2020-09-18 10:48:56 +03:00
bc98955176
Update to latest otel-java snapshot ( #1057 )
...
* Update to latest otel-java snapshot
* Upgrade to working otel-java snapshot
* Update to latest otel-java snapshot
* Update to latest otel-java snapshot
2020-08-26 22:03:28 +03:00
41bf322c6c
Remove UrlInstrumentation. ( #1059 )
2020-08-19 21:54:44 -07:00
c4c4558b09
More refactoring ( #1040 )
2020-08-19 15:43:48 -07:00
5d2ae07797
Use startScope() on all HttpClientTracers ( #971 )
2020-08-18 16:59:30 -07:00
7159d04b8d
Change groovy import order ( #1013 )
...
* Update docs
* Format all groovy code
* Organize imports
2020-08-15 23:19:27 -07:00
414213f2d1
Remove final from parameters ( #1003 )
2020-08-15 22:35:51 -07:00
f893ca540b
Scripted package renaming ( #988 )
2020-08-15 21:55:01 -07:00
bb235a0aa3
Update package name for tracers ( #991 )
2020-08-14 21:07:18 -07:00
888ebe17a2
Delete HttpClientDecorator ( #967 )
2020-08-14 13:10:56 -07:00
7818e33178
Package renaming ( #970 )
2020-08-13 20:14:46 -07:00
c4a494cd68
Add instrumentation for Armeria WebClient. ( #920 )
...
* Add instrumentation for Armeria WebClient.
* Format:
* httpurlconnection
* Docs and consistency:
2020-08-12 17:33:36 +09:00
b5fbf90977
Extract instrumentation api module ( #884 )
2020-08-09 22:52:33 -07:00
1fcb807590
Refactor HttpClient typed Decorators to Tracers ( #893 )
...
* initial work
* Change OkHttp decorators to tracers
* Change AkkaHttpClient decorator to tracer
* Change ClientDecorator to GrizzlyClientTracer
* Change NettyClientDecorator to Tracer
* Change netty3.8 client decorator to tracer
* Update netty4.1 client decorator to tracer
* Override startScope in child tracers when applicable
* Change KHttpDecorator to tracer
* Change HttpUrlConnectionDecorator to tracer
* Fix muzzle validation failure for grizzly client
* Fix a ratpack client test failure
* Address feedback
* Update delegate for setPeer
* Remove nested try
* Remove unnecessary null check
* Remove asserts
* Add a comment for overriding startSpan(String spanName)
* Remove an irrelevant comment
* Throw an exception when getSetter is null
* Change onPeerConnection to static
* Change getSetter() to be abstract
2020-08-06 17:14:19 -07:00
f6594e1a67
Use Span.recordException for logging throwable ( #813 )
...
* Use Span.recordException
* Fix tests
* Cleanup
* Update instrumentation/jsp-2.3/src/test/groovy/JSPInstrumentationBasicTests.groovy
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
* Spotless (IntelliJ acts weird with groovy files for me :()
* Update for merge
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
2020-07-28 14:44:42 +09:00
509a234ee3
Refactor net.peer.name and net.peer.ip ( #742 )
2020-07-22 20:29:12 -07:00
86c438b154
Remove final from local variables ( #732 )
...
* Remove final from local variables
2020-07-20 13:53:34 +09:00
Mateusz Rzeszutek
jason plumb
Trask Stalnaker
Lauri Tulmin
Nikita Salnikov-Tarnovski
Martin
Matthew Ho
jack-berg
Anuraag Agrawal
Pavol Loffay
Ago Allikmaa
Ioannis Mavroukakis
Jakub Wach
dengliming
Helen Y