From 0ab6915b3cbdd0e4417ddf58e867f6ff319b558c Mon Sep 17 00:00:00 2001
From: Maksym Ochenashko <maxochenashko@gmail.com>
Date: Thu, 1 Jun 2023 16:20:13 +0300
Subject: [PATCH] Add meaningful `.toString` to `NoopLogRecordProcessor` and
 `DefaultOpenTelemetry` (#5493)

---
 .../java/io/opentelemetry/api/DefaultOpenTelemetry.java  | 5 +++++
 .../java/io/opentelemetry/api/OpenTelemetryTest.java     | 9 +++++++++
 .../opentelemetry/sdk/logs/NoopLogRecordProcessor.java   | 5 +++++
 .../sdk/logs/NoopLogRecordProcessorTest.java             | 5 +++++
 4 files changed, 24 insertions(+)

diff --git a/api/all/src/main/java/io/opentelemetry/api/DefaultOpenTelemetry.java b/api/all/src/main/java/io/opentelemetry/api/DefaultOpenTelemetry.java
index 6267a61293..137a805b73 100644
--- a/api/all/src/main/java/io/opentelemetry/api/DefaultOpenTelemetry.java
+++ b/api/all/src/main/java/io/opentelemetry/api/DefaultOpenTelemetry.java
@@ -46,4 +46,9 @@ final class DefaultOpenTelemetry implements OpenTelemetry {
   public ContextPropagators getPropagators() {
     return propagators;
   }
+
+  @Override
+  public String toString() {
+    return "DefaultOpenTelemetry{" + "propagators=" + propagators + "}";
+  }
 }
diff --git a/api/all/src/test/java/io/opentelemetry/api/OpenTelemetryTest.java b/api/all/src/test/java/io/opentelemetry/api/OpenTelemetryTest.java
index 5acab04f81..42a4cd3147 100644
--- a/api/all/src/test/java/io/opentelemetry/api/OpenTelemetryTest.java
+++ b/api/all/src/test/java/io/opentelemetry/api/OpenTelemetryTest.java
@@ -85,6 +85,15 @@ class OpenTelemetryTest {
         .hasStackTraceContaining("getOpenTelemetry");
   }
 
+  @Test
+  void toString_noop_Valid() {
+    assertThat(OpenTelemetry.noop().toString())
+        .isEqualTo(
+            "DefaultOpenTelemetry{"
+                + "propagators=DefaultContextPropagators{textMapPropagator=NoopTextMapPropagator}"
+                + "}");
+  }
+
   private static void setOpenTelemetry() {
     GlobalOpenTelemetry.set(OpenTelemetry.noop());
   }
diff --git a/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/NoopLogRecordProcessor.java b/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/NoopLogRecordProcessor.java
index 518cdfa785..31f3350f13 100644
--- a/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/NoopLogRecordProcessor.java
+++ b/sdk/logs/src/main/java/io/opentelemetry/sdk/logs/NoopLogRecordProcessor.java
@@ -18,4 +18,9 @@ final class NoopLogRecordProcessor implements LogRecordProcessor {
 
   @Override
   public void onEmit(Context context, ReadWriteLogRecord logRecord) {}
+
+  @Override
+  public String toString() {
+    return "NoopLogRecordProcessor";
+  }
 }
diff --git a/sdk/logs/src/test/java/io/opentelemetry/sdk/logs/NoopLogRecordProcessorTest.java b/sdk/logs/src/test/java/io/opentelemetry/sdk/logs/NoopLogRecordProcessorTest.java
index 3a209e0204..ed473c0d7f 100644
--- a/sdk/logs/src/test/java/io/opentelemetry/sdk/logs/NoopLogRecordProcessorTest.java
+++ b/sdk/logs/src/test/java/io/opentelemetry/sdk/logs/NoopLogRecordProcessorTest.java
@@ -25,4 +25,9 @@ class NoopLogRecordProcessorTest {
     assertThat(logRecordProcessor.forceFlush().isSuccess()).isEqualTo(true);
     assertThat(logRecordProcessor.shutdown().isSuccess()).isEqualTo(true);
   }
+
+  @Test
+  void toString_Valid() {
+    assertThat(NoopLogRecordProcessor.getInstance().toString()).isEqualTo("NoopLogRecordProcessor");
+  }
 }