open-telemetry
/
opentelemetry-java
mirror of https://github.com/open-telemetry/opentelemetry-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Wrap instead of copy IDs since they are already copies. (#3263)

This commit is contained in:
Anuraag Agrawal 2021-05-29 13:06:07 +09:00 committed by GitHub
parent 31d87b1cc8
commit 2b0622afc5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
exporters/otlp/common/src/main/java/io/opentelemetry/exporter/otlp/internal/SpanAdapter.java
View File

@ -13,7 +13,7 @@ import static io.opentelemetry.proto.trace.v1.Span.SpanKind.SPAN_KIND_SERVER;
import static io.opentelemetry.proto.trace.v1.Status.DeprecatedStatusCode.DEPRECATED_STATUS_CODE_OK; import static io.opentelemetry.proto.trace.v1.Status.DeprecatedStatusCode.DEPRECATED_STATUS_CODE_OK;
import static io.opentelemetry.proto.trace.v1.Status.DeprecatedStatusCode.DEPRECATED_STATUS_CODE_UNKNOWN_ERROR; import static io.opentelemetry.proto.trace.v1.Status.DeprecatedStatusCode.DEPRECATED_STATUS_CODE_UNKNOWN_ERROR;
import com.google.protobuf.ByteString; import com.google.protobuf.UnsafeByteOperations;
import io.opentelemetry.api.common.Attributes; import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.trace.SpanKind; import io.opentelemetry.api.trace.SpanKind;
import io.opentelemetry.api.trace.StatusCode; import io.opentelemetry.api.trace.StatusCode;
@ -86,12 +86,13 @@ public final class SpanAdapter {
static Span toProtoSpan(SpanData spanData) { static Span toProtoSpan(SpanData spanData) {
final Span.Builder builder = Span.newBuilder(); final Span.Builder builder = Span.newBuilder();
builder.setTraceId(ByteString.copyFrom(spanData.getSpanContext().getTraceIdBytes())); builder.setTraceId(
builder.setSpanId(ByteString.copyFrom(spanData.getSpanContext().getSpanIdBytes())); UnsafeByteOperations.unsafeWrap(spanData.getSpanContext().getTraceIdBytes()));
builder.setSpanId(UnsafeByteOperations.unsafeWrap(spanData.getSpanContext().getSpanIdBytes()));
// TODO: Set TraceState; // TODO: Set TraceState;
if (spanData.getParentSpanContext().isValid()) { if (spanData.getParentSpanContext().isValid()) {
builder.setParentSpanId( builder.setParentSpanId(
ByteString.copyFrom(spanData.getParentSpanContext().getSpanIdBytes())); UnsafeByteOperations.unsafeWrap(spanData.getParentSpanContext().getSpanIdBytes()));
} }
builder.setName(spanData.getName()); builder.setName(spanData.getName());
builder.setKind(toProtoSpanKind(spanData.getKind())); builder.setKind(toProtoSpanKind(spanData.getKind()));
@ -144,8 +145,8 @@ public final class SpanAdapter {
static Span.Link toProtoSpanLink(LinkData link) { static Span.Link toProtoSpanLink(LinkData link) {
final Span.Link.Builder builder = Span.Link.newBuilder(); final Span.Link.Builder builder = Span.Link.newBuilder();
builder.setTraceId(ByteString.copyFrom(link.getSpanContext().getTraceIdBytes())); builder.setTraceId(UnsafeByteOperations.unsafeWrap(link.getSpanContext().getTraceIdBytes()));
builder.setSpanId(ByteString.copyFrom(link.getSpanContext().getSpanIdBytes())); builder.setSpanId(UnsafeByteOperations.unsafeWrap(link.getSpanContext().getSpanIdBytes()));
// TODO: Set TraceState; // TODO: Set TraceState;
Attributes attributes = link.getAttributes(); Attributes attributes = link.getAttributes();
attributes.forEach( attributes.forEach(