From 391043fa1fe438b4b27c2981e3d1df61c785e219 Mon Sep 17 00:00:00 2001 From: Bogdan Drutu Date: Thu, 1 Oct 2020 18:41:56 -0700 Subject: [PATCH] Remove redundant type argument conversion (#1734) Signed-off-by: Bogdan Drutu --- api/src/main/java/io/opentelemetry/trace/TraceState.java | 2 +- .../sdk/trace/export/MultiSpanExporterBenchmark.java | 2 +- .../java/io/opentelemetry/sdk/resources/ResourcesConfig.java | 3 +-- .../main/java/io/opentelemetry/sdk/trace/TestSpanData.java | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/api/src/main/java/io/opentelemetry/trace/TraceState.java b/api/src/main/java/io/opentelemetry/trace/TraceState.java index d6945d3a38..9ddafff56e 100644 --- a/api/src/main/java/io/opentelemetry/trace/TraceState.java +++ b/api/src/main/java/io/opentelemetry/trace/TraceState.java @@ -117,7 +117,7 @@ public abstract class TraceState { // Needs to be in this class to avoid initialization deadlock because super class depends on // subclass (the auto-value generate class). - private static final TraceState EMPTY = create(Collections.emptyList()); + private static final TraceState EMPTY = create(Collections.emptyList()); private Builder(TraceState parent) { Utils.checkNotNull(parent, "parent"); diff --git a/sdk/all/src/jmh/java/io/opentelemetry/sdk/trace/export/MultiSpanExporterBenchmark.java b/sdk/all/src/jmh/java/io/opentelemetry/sdk/trace/export/MultiSpanExporterBenchmark.java index 86815b6360..8e21029fb1 100644 --- a/sdk/all/src/jmh/java/io/opentelemetry/sdk/trace/export/MultiSpanExporterBenchmark.java +++ b/sdk/all/src/jmh/java/io/opentelemetry/sdk/trace/export/MultiSpanExporterBenchmark.java @@ -89,7 +89,7 @@ public class MultiSpanExporterBenchmark { .setHasEnded(true) .build(); } - this.spans = Arrays.asList(spans); + this.spans = Arrays.asList(spans); } @Benchmark diff --git a/sdk/common/src/main/java/io/opentelemetry/sdk/resources/ResourcesConfig.java b/sdk/common/src/main/java/io/opentelemetry/sdk/resources/ResourcesConfig.java index 39b65a53a9..e68a7afb95 100644 --- a/sdk/common/src/main/java/io/opentelemetry/sdk/resources/ResourcesConfig.java +++ b/sdk/common/src/main/java/io/opentelemetry/sdk/resources/ResourcesConfig.java @@ -81,8 +81,7 @@ public abstract class ResourcesConfig { * @return a new {@link Builder}. */ public static Builder newBuilder() { - return new AutoValue_ResourcesConfig.Builder() - .setDisabledResourceProviders(ImmutableSet.of()); + return new AutoValue_ResourcesConfig.Builder().setDisabledResourceProviders(ImmutableSet.of()); } /** diff --git a/testing_internal/src/main/java/io/opentelemetry/sdk/trace/TestSpanData.java b/testing_internal/src/main/java/io/opentelemetry/sdk/trace/TestSpanData.java index d4d2717fbb..8c90624358 100644 --- a/testing_internal/src/main/java/io/opentelemetry/sdk/trace/TestSpanData.java +++ b/testing_internal/src/main/java/io/opentelemetry/sdk/trace/TestSpanData.java @@ -50,10 +50,10 @@ public abstract class TestSpanData implements SpanData { return new AutoValue_TestSpanData.Builder() .setParentSpanId(SpanId.getInvalid()) .setInstrumentationLibraryInfo(InstrumentationLibraryInfo.getEmpty()) - .setLinks(Collections.emptyList()) + .setLinks(Collections.emptyList()) .setTotalRecordedLinks(0) .setAttributes(Attributes.empty()) - .setEvents(Collections.emptyList()) + .setEvents(Collections.emptyList()) .setTotalRecordedEvents(0) .setResource(Resource.getEmpty()) .setTraceState(TraceState.getDefault())