open-telemetry
/
opentelemetry-java
mirror of https://github.com/open-telemetry/opentelemetry-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixes #3494 - Removes ofLongs/ofDoubles when the default is long/double for a builder. (#3873)

This commit is contained in:
Josh Suereth 2021-11-14 15:05:07 -05:00 committed by GitHub
parent c1d3ec9c88
commit 3ee4936ea2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 0 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
api/metrics/src/main/java/io/opentelemetry/api/metrics/DoubleCounterBuilder.java
View File

@ -25,9 +25,6 @@ public interface DoubleCounterBuilder {
*/
DoubleCounterBuilder setUnit(String unit);
/** Sets the counter for recording {@code long} values. */
LongCounterBuilder ofLongs();
/**
* Builds and returns a {@code DoubleCounter} with the desired options.
*

3
api/metrics/src/main/java/io/opentelemetry/api/metrics/DoubleUpDownCounterBuilder.java
View File

@ -25,9 +25,6 @@ public interface DoubleUpDownCounterBuilder {
*/
DoubleUpDownCounterBuilder setUnit(String unit);
/** Sets the counter for recording {@code long} values. */
LongUpDownCounterBuilder ofLongs();
/**
* Builds and returns a {@code DoubleUpDownCounter} with the desired options.
*

3
api/metrics/src/main/java/io/opentelemetry/api/metrics/LongGaugeBuilder.java
View File

@ -25,9 +25,6 @@ public interface LongGaugeBuilder {
*/
LongGaugeBuilder setUnit(String unit);
/** Sets the gauge for recording {@code double} values. */
DoubleGaugeBuilder ofDoubles();
/**
* Builds this asynchronous insturment with the given callback.
*

3
api/metrics/src/main/java/io/opentelemetry/api/metrics/LongHistogramBuilder.java
View File

@ -23,9 +23,6 @@ public interface LongHistogramBuilder {
*/
LongHistogramBuilder setUnit(String unit);
/** Sets the histogram for recording {@code double} values. */
DoubleHistogramBuilder ofDoubles();
/**
* Builds and returns a {@code LongHistogram} with the desired options.
*

20
api/metrics/src/main/java/io/opentelemetry/api/metrics/internal/NoopMeter.java
View File

@ -176,11 +176,6 @@ public class NoopMeter implements Meter {
return this;
}
@Override
public LongCounterBuilder ofLongs() {
return new NoopLongCounterBuilder();
}
@Override
public DoubleCounter build() {
return new NoopDoubleCounter();
@ -280,11 +275,6 @@ public class NoopMeter implements Meter {
return this;
}
@Override
public LongUpDownCounterBuilder ofLongs() {
return new NoopLongUpDownCounterBuilder();
}
@Override
public DoubleUpDownCounter build() {
return new NoopDoubleUpDownCounter();
@ -381,11 +371,6 @@ public class NoopMeter implements Meter {
return this;
}
@Override
public DoubleHistogramBuilder ofDoubles() {
return new NoopDoubleHistogramBuilder();
}
@Override
public LongHistogram build() {
return new NoopLongHistogram();
@ -423,11 +408,6 @@ public class NoopMeter implements Meter {
return this;
}
@Override
public DoubleGaugeBuilder ofDoubles() {
return new NoopDoubleObservableInstrumentBuilder();
}
@Override
public void buildWithCallback(Consumer<ObservableLongMeasurement> callback) {}
}

6
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleCounter.java
View File

@ -9,7 +9,6 @@ import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.metrics.BoundDoubleCounter;
import io.opentelemetry.api.metrics.DoubleCounter;
import io.opentelemetry.api.metrics.DoubleCounterBuilder;
import io.opentelemetry.api.metrics.LongCounterBuilder;
import io.opentelemetry.api.metrics.ObservableDoubleMeasurement;
import io.opentelemetry.context.Context;
import io.opentelemetry.sdk.metrics.common.InstrumentType;
@ -109,11 +108,6 @@ final class SdkDoubleCounter extends AbstractInstrument implements DoubleCounter
InstrumentType.COUNTER, InstrumentValueType.DOUBLE, SdkDoubleCounter::new);
}
@Override
public LongCounterBuilder ofLongs() {
return swapBuilder(SdkLongCounter.Builder::new);
}
@Override
public void buildWithCallback(Consumer<ObservableDoubleMeasurement> callback) {
registerDoubleAsynchronousInstrument(InstrumentType.OBSERVABLE_SUM, callback);

6
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleUpDownCounter.java
View File

@ -9,7 +9,6 @@ import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.metrics.BoundDoubleUpDownCounter;
import io.opentelemetry.api.metrics.DoubleUpDownCounter;
import io.opentelemetry.api.metrics.DoubleUpDownCounterBuilder;
import io.opentelemetry.api.metrics.LongUpDownCounterBuilder;
import io.opentelemetry.api.metrics.ObservableDoubleMeasurement;
import io.opentelemetry.context.Context;
import io.opentelemetry.sdk.metrics.common.InstrumentType;
@ -97,11 +96,6 @@ final class SdkDoubleUpDownCounter extends AbstractInstrument implements DoubleU
InstrumentType.UP_DOWN_COUNTER, InstrumentValueType.DOUBLE, SdkDoubleUpDownCounter::new);
}
@Override
public LongUpDownCounterBuilder ofLongs() {
return swapBuilder(SdkLongUpDownCounter.Builder::new);
}
@Override
public void buildWithCallback(Consumer<ObservableDoubleMeasurement> callback) {
registerDoubleAsynchronousInstrument(InstrumentType.OBSERVABLE_UP_DOWN_SUM, callback);

6
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkLongGaugeBuilder.java
View File

@ -5,7 +5,6 @@
package io.opentelemetry.sdk.metrics;
import io.opentelemetry.api.metrics.DoubleGaugeBuilder;
import io.opentelemetry.api.metrics.LongGaugeBuilder;
import io.opentelemetry.api.metrics.ObservableLongMeasurement;
import io.opentelemetry.sdk.metrics.common.InstrumentType;
@ -30,11 +29,6 @@ final class SdkLongGaugeBuilder extends AbstractInstrumentBuilder<SdkLongGaugeBu
return this;
}
@Override
public DoubleGaugeBuilder ofDoubles() {
return swapBuilder(SdkDoubleGaugeBuilder::new);
}
@Override
public void buildWithCallback(Consumer<ObservableLongMeasurement> callback) {
registerLongAsynchronousInstrument(InstrumentType.OBSERVABLE_GAUGE, callback);

6
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkLongHistogram.java
View File

@ -7,7 +7,6 @@ package io.opentelemetry.sdk.metrics;
import io.opentelemetry.api.common.Attributes;
import io.opentelemetry.api.metrics.BoundLongHistogram;
import io.opentelemetry.api.metrics.DoubleHistogramBuilder;
import io.opentelemetry.api.metrics.LongHistogram;
import io.opentelemetry.api.metrics.LongHistogramBuilder;
import io.opentelemetry.context.Context;
@ -94,10 +93,5 @@ final class SdkLongHistogram extends AbstractInstrument implements LongHistogram
return buildSynchronousInstrument(
InstrumentType.HISTOGRAM, InstrumentValueType.LONG, SdkLongHistogram::new);
}
@Override
public DoubleHistogramBuilder ofDoubles() {
return swapBuilder(SdkDoubleHistogram.Builder::new);
}
}
}