open-telemetry
/
opentelemetry-java
mirror of https://github.com/open-telemetry/opentelemetry-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Ensure done before checking success to help troubleshoot timeout issues (#4833) 

* ensure done before checking success to help troubleshoot timeout issues

* add done check to testDefaultRetryPolicy method as well.

* ensure isDone() before other assertions
This commit is contained in:
jason plumb 2022-10-13 11:13:22 -07:00 committed by GitHub
parent d83d2d8c32
commit 3f4698a536
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java
View File

@ -120,6 +120,10 @@ class OtlpGrpcRetryTest {
CompletableResultCode resultCode =
exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
assertThat(resultCode.isDone())
.as("Exporter didn't complete in time. Consider increasing join timeout?")
.isTrue();
boolean retryable =
RetryUtil.retryableGrpcStatusCodes().contains(String.valueOf(code.value()));
boolean expectedResult = retryable || code == Status.Code.OK;
@ -152,6 +156,9 @@ class OtlpGrpcRetryTest {
// Result should be failure, sever should have received maxAttempts requests
CompletableResultCode resultCode =
exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
assertThat(resultCode.isDone())
.as("Exporter didn't complete in time. Consider increasing join timeout?")
.isTrue();
assertThat(resultCode.isSuccess()).isFalse();
assertThat(serverRequestCountSupplier.get()).isEqualTo(maxAttempts);
}

7
sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java
View File

@ -129,6 +129,10 @@ class OtlpHttpRetryTest {
CompletableResultCode resultCode =
exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
assertThat(resultCode.isDone())
.as("Exporter didn't complete in time. Consider increasing join timeout?")
.isTrue();
boolean retryable = code != 200 && RetryUtil.retryableHttpResponseCodes().contains(code);
boolean expectedResult = retryable || code == 200;
assertThat(resultCode.isSuccess())
@ -159,6 +163,9 @@ class OtlpHttpRetryTest {
// Result should be failure, sever should have received maxAttempts requests
CompletableResultCode resultCode =
exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS);
assertThat(resultCode.isDone())
.as("Exporter didn't complete in time. Consider increasing join timeout?")
.isTrue();
assertThat(resultCode.isSuccess()).isFalse();
assertThat(serverRequestCountSupplier.get()).isEqualTo(maxAttempts);
}