open-telemetry
/
opentelemetry-java
mirror of https://github.com/open-telemetry/opentelemetry-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplified the assertions (#4726)

This commit is contained in:
Sampath 2022-08-29 20:06:59 +01:00 committed by GitHub
parent bb3cc2e3de
commit 45a1593575
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
api/all/src/test/java/io/opentelemetry/api/common/AttributesTest.java
View File

@ -105,8 +105,8 @@ class AttributesTest {
.isInstanceOf(UnsupportedOperationException.class); .isInstanceOf(UnsupportedOperationException.class);
assertThatThrownBy(map::clear).isInstanceOf(UnsupportedOperationException.class); assertThatThrownBy(map::clear).isInstanceOf(UnsupportedOperationException.class);
assertThat(map.keySet().contains(stringKey("key1"))).isTrue(); assertThat(map.containsKey(stringKey("key1"))).isTrue();
assertThat(map.keySet().contains(stringKey("key3"))).isFalse(); assertThat(map.containsKey(stringKey("key3"))).isFalse();
assertThat(map.keySet().containsAll(Arrays.asList(stringKey("key1"), longKey("key2")))) assertThat(map.keySet().containsAll(Arrays.asList(stringKey("key1"), longKey("key2"))))
.isTrue(); .isTrue();
assertThat(map.keySet().containsAll(Arrays.asList(stringKey("key1"), longKey("key3")))) assertThat(map.keySet().containsAll(Arrays.asList(stringKey("key1"), longKey("key3"))))
@ -125,7 +125,7 @@ class AttributesTest {
assertThat(keys).isEmpty(); // Didn't use input array. assertThat(keys).isEmpty(); // Didn't use input array.
assertThatThrownBy(() -> map.keySet().iterator().remove()) assertThatThrownBy(() -> map.keySet().iterator().remove())
.isInstanceOf(UnsupportedOperationException.class); .isInstanceOf(UnsupportedOperationException.class);
assertThat(map.keySet().containsAll(singletonList(stringKey("key1")))).isTrue(); assertThat(map.containsKey(stringKey("key1"))).isTrue();
assertThat(map.keySet().containsAll(Arrays.asList(stringKey("key1"), stringKey("key3")))) assertThat(map.keySet().containsAll(Arrays.asList(stringKey("key1"), stringKey("key3"))))
.isFalse(); .isFalse();
assertThat(map.keySet().isEmpty()).isFalse(); assertThat(map.keySet().isEmpty()).isFalse();
@ -133,7 +133,7 @@ class AttributesTest {
.isInstanceOf(UnsupportedOperationException.class); .isInstanceOf(UnsupportedOperationException.class);
assertThatThrownBy(() -> map.keySet().remove(stringKey("key1"))) assertThatThrownBy(() -> map.keySet().remove(stringKey("key1")))
.isInstanceOf(UnsupportedOperationException.class); .isInstanceOf(UnsupportedOperationException.class);
assertThatThrownBy(() -> map.keySet().addAll(Collections.singletonList(stringKey("key3")))) assertThatThrownBy(() -> map.keySet().add(stringKey("key3")))
.isInstanceOf(UnsupportedOperationException.class); .isInstanceOf(UnsupportedOperationException.class);
assertThatThrownBy(() -> map.keySet().retainAll(Collections.singletonList(stringKey("key3")))) assertThatThrownBy(() -> map.keySet().retainAll(Collections.singletonList(stringKey("key3"))))
.isInstanceOf(UnsupportedOperationException.class); .isInstanceOf(UnsupportedOperationException.class);
@ -142,8 +142,8 @@ class AttributesTest {
assertThatThrownBy(() -> map.keySet().clear()) assertThatThrownBy(() -> map.keySet().clear())
.isInstanceOf(UnsupportedOperationException.class); .isInstanceOf(UnsupportedOperationException.class);
assertThat(map.values().contains("value1")).isTrue(); assertThat(map.containsValue("value1")).isTrue();
assertThat(map.values().contains("value3")).isFalse(); assertThat(map.containsValue("value3")).isFalse();
assertThat(map.toString()).isEqualTo("ReadOnlyArrayMap{key1=value1,key2=333}"); assertThat(map.toString()).isEqualTo("ReadOnlyArrayMap{key1=value1,key2=333}");