Rename buildMeasure to measureBuilder for consistency with trace. (#204)

This commit is contained in:
Bogdan Drutu 2019-04-25 08:18:17 -07:00 committed by GitHub
parent f811e90ec7
commit 50ec66cec8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions

View File

@ -54,7 +54,7 @@ public final class NoopStats {
+ " characters.";
@Override
public Measure.Builder buildMeasure(String name) {
public Measure.Builder measureBuilder(String name) {
Utils.checkArgument(
StringUtils.isPrintableString(name) && name.length() <= NAME_MAX_LENGTH,
ERROR_MESSAGE_INVALID_NAME);

View File

@ -37,7 +37,7 @@ public interface StatsRecorder {
* @return a new builder for a {@code Measure}.
* @since 0.1.0
*/
Measure.Builder buildMeasure(String name);
Measure.Builder measureBuilder(String name);
/**
* Records all given measurements, with the current {@link

View File

@ -36,18 +36,18 @@ public final class MeasureTest {
Arrays.fill(chars, 'a');
String longName = String.valueOf(chars);
thrown.expect(IllegalArgumentException.class);
STATS_RECORDER.buildMeasure(longName).build();
STATS_RECORDER.measureBuilder(longName).build();
}
@Test
public void preventNonPrintableMeasureName() {
thrown.expect(IllegalArgumentException.class);
STATS_RECORDER.buildMeasure("\2").build();
STATS_RECORDER.measureBuilder("\2").build();
}
@Test
public void preventNegativeValue() {
Measure myMeasure = STATS_RECORDER.buildMeasure("MyMeasure").build();
Measure myMeasure = STATS_RECORDER.measureBuilder("MyMeasure").build();
thrown.expect(IllegalArgumentException.class);
myMeasure.createDoubleMeasurement(-5);
}

View File

@ -41,7 +41,7 @@ public final class NoopStatsTest {
private static final Measure MEASURE =
STATS_RECORDER
.buildMeasure("my measure")
.measureBuilder("my measure")
.setDescription("description")
.setType(Measure.Type.DOUBLE)
.setUnit("1")