open-telemetry
/
opentelemetry-java
mirror of https://github.com/open-telemetry/opentelemetry-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Generate SpanId only for sampled spans

This commit is contained in:
Paulo Janotti 2020-05-29 08:06:11 -07:00
parent c90ae9a69d
commit 5b51eaed88
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sdk/src/main/java/io/opentelemetry/sdk/trace/SpanBuilderSdk.java
View File

@ -196,7 +196,6 @@ final class SpanBuilderSdk implements Span.Builder {
public Span startSpan() { public Span startSpan() {
SpanContext parentContext = parent(parentType, parent, remoteParent); SpanContext parentContext = parent(parentType, parent, remoteParent);
TraceId traceId; TraceId traceId;
SpanId spanId = idsGenerator.generateSpanId();
TraceState traceState = TraceState.getDefault(); TraceState traceState = TraceState.getDefault();
if (parentContext == null || !parentContext.isValid()) { if (parentContext == null || !parentContext.isValid()) {
// New root span. // New root span.
@ -225,12 +224,13 @@ final class SpanBuilderSdk implements Span.Builder {
.shouldSample( .shouldSample(
parentContext, traceId, spanName, spanKind, immutableAttributes, immutableLinks); parentContext, traceId, spanName, spanKind, immutableAttributes, immutableLinks);
SpanContext spanContext = SpanId spanId = SpanId.getInvalid();
SpanContext.create( TraceFlags traceFlags = TRACE_OPTIONS_NOT_SAMPLED;
traceId, if (samplingDecision.isSampled()) {
spanId, spanId = idsGenerator.generateSpanId();
samplingDecision.isSampled() ? TRACE_OPTIONS_SAMPLED : TRACE_OPTIONS_NOT_SAMPLED, traceFlags = TRACE_OPTIONS_SAMPLED;
traceState); }
SpanContext spanContext = SpanContext.create(traceId, spanId, traceFlags, traceState);
if (!samplingDecision.isSampled()) { if (!samplingDecision.isSampled()) {
return DefaultSpan.create(spanContext); return DefaultSpan.create(spanContext);