open-telemetry
/
opentelemetry-java
mirror of https://github.com/open-telemetry/opentelemetry-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add DoubleHistogramPointData assertion: hasSumGreaterThan() (#4050)

This commit is contained in:
Mateusz Rzeszutek 2022-01-06 06:26:08 +01:00 committed by GitHub
parent dfb4a74ac5
commit 96b7895173
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sdk/metrics-testing/src/main/java/io/opentelemetry/sdk/testing/assertj/DoubleHistogramPointDataAssert.java
View File

@ -24,6 +24,13 @@ public class DoubleHistogramPointDataAssert
return this;
}
/** Ensures the {@code sum} field contains a greater value than the passed {@code boundary}. */
public DoubleHistogramPointDataAssert hasSumGreaterThan(double boundary) {
isNotNull();
Assertions.assertThat(actual.getSum()).as("sum").isGreaterThan(boundary);
return this;
}
/** Ensures the {@code count} field matches the expected value. */
public DoubleHistogramPointDataAssert hasCount(long expected) {
isNotNull();

37
sdk/metrics-testing/src/test/java/io/opentelemetry/sdk/testing/assertj/MetricAssertionsTest.java
View File

@ -15,6 +15,7 @@ import io.opentelemetry.sdk.metrics.data.AggregationTemporality;
import io.opentelemetry.sdk.metrics.data.DoubleExemplarData;
import io.opentelemetry.sdk.metrics.data.DoubleGaugeData;
import io.opentelemetry.sdk.metrics.data.DoubleHistogramData;
import io.opentelemetry.sdk.metrics.data.DoubleHistogramPointData;
import io.opentelemetry.sdk.metrics.data.DoublePointData;
import io.opentelemetry.sdk.metrics.data.DoubleSumData;
import io.opentelemetry.sdk.metrics.data.DoubleSummaryData;
@ -27,6 +28,7 @@ import io.opentelemetry.sdk.metrics.data.LongSumData;
import io.opentelemetry.sdk.metrics.data.MetricData;
import io.opentelemetry.sdk.metrics.data.ValueAtPercentile;
import io.opentelemetry.sdk.resources.Resource;
import java.util.Arrays;
import java.util.Collections;
import org.junit.jupiter.api.Test;
@ -193,6 +195,10 @@ public class MetricAssertionsTest {
DoubleSummaryPointData.create(
1, 2, Attributes.empty(), 1, 2, Collections.singletonList(PERCENTILE_VALUE));
private static final DoubleHistogramPointData DOUBLE_HISTOGRAM_POINT_DATA =
DoubleHistogramPointData.create(
1, 2, Attributes.empty(), 15, Collections.singletonList(10.0), Arrays.asList(1L, 2L));
@Test
void metric_passing() {
assertThat(HISTOGRAM_METRIC)
@ -439,4 +445,35 @@ public class MetricAssertionsTest {
.hasPercentileValues(ValueAtPercentile.create(1, 1)))
.isInstanceOf(AssertionError.class);
}
@Test
void doubleHistogramPointData_passing() {
assertThat(DOUBLE_HISTOGRAM_POINT_DATA)
.hasCount(3)
.hasSum(15)
.hasSumGreaterThan(10)
.hasEpochNanos(2)
.hasStartEpochNanos(1)
.hasAttributes(Attributes.empty())
.hasBucketBoundaries(10)
.hasBucketCounts(1, 2);
}
@Test
void doubleHistogramPointData_failing() {
assertThatThrownBy(() -> assertThat(DOUBLE_HISTOGRAM_POINT_DATA).hasCount(2))
.isInstanceOf(AssertionError.class);
assertThatThrownBy(() -> assertThat(DOUBLE_HISTOGRAM_POINT_DATA).hasSum(1))
.isInstanceOf(AssertionError.class);
assertThatThrownBy(() -> assertThat(DOUBLE_HISTOGRAM_POINT_DATA).hasSumGreaterThan(20))
.isInstanceOf(AssertionError.class);
assertThatThrownBy(() -> assertThat(DOUBLE_HISTOGRAM_POINT_DATA).hasBucketBoundaries(1, 2, 3))
.isInstanceOf(AssertionError.class);
assertThatThrownBy(() -> assertThat(DOUBLE_HISTOGRAM_POINT_DATA).hasBucketCounts(1, 2, 3))
.isInstanceOf(AssertionError.class);
}
}