open-telemetry
/
opentelemetry-java
mirror of https://github.com/open-telemetry/opentelemetry-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't use hashmap for zpage buckets since the keys are constant. (#3649)

This commit is contained in:
Anuraag Agrawal 2021-09-23 01:02:14 +09:00 committed by GitHub
parent b311d50d03
commit b1e1c47403
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 54 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
sdk-extensions/zpages/src/main/java/io/opentelemetry/sdk/extension/zpages/TracezSpanBuckets.java
View File

@ -10,24 +10,12 @@ import io.opentelemetry.sdk.trace.ReadableSpan;
import io.opentelemetry.sdk.trace.data.StatusData;
import java.util.ArrayList;
import java.util.EnumMap;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
final class TracezSpanBuckets {
private final Map<LatencyBoundary, SpanBucket> latencyBuckets = new HashMap<>();
private final Map<StatusCode, SpanBucket> errorBuckets = new HashMap<>();
TracezSpanBuckets() {
for (LatencyBoundary bucket : LatencyBoundary.values()) {
latencyBuckets.put(bucket, new SpanBucket(/* isLatencyBucket= */ true));
}
for (StatusCode code : StatusCode.values()) {
if (code == StatusCode.ERROR) {
errorBuckets.put(code, new SpanBucket(/* isLatencyBucket= */ false));
}
}
}
private final LatencyBuckets latencyBuckets = new LatencyBuckets();
private final SpanBucket errors = new SpanBucket(/* isLatencyBucket= */ false);
void addToBucket(ReadableSpan span) {
StatusData status = span.toSpanData().getStatus();
@ -35,7 +23,7 @@ final class TracezSpanBuckets {
latencyBuckets.get(LatencyBoundary.getBoundary(span.getLatencyNanos())).add(span);
return;
}
errorBuckets.get(status.getStatusCode()).add(span);
errors.add(span);
}
Map<LatencyBoundary, Integer> getLatencyBoundaryToCountMap() {
@ -48,17 +36,13 @@ final class TracezSpanBuckets {
List<ReadableSpan> getOkSpans() {
List<ReadableSpan> okSpans = new ArrayList<>();
for (SpanBucket latencyBucket : latencyBuckets.values()) {
latencyBucket.addTo(okSpans);
}
latencyBuckets.addTo(okSpans);
return okSpans;
}
List<ReadableSpan> getErrorSpans() {
List<ReadableSpan> errorSpans = new ArrayList<>();
for (SpanBucket errorBucket : errorBuckets.values()) {
errorBucket.addTo(errorSpans);
}
errors.addTo(errorSpans);
return errorSpans;
}
@ -68,4 +52,53 @@ final class TracezSpanBuckets {
spans.addAll(getErrorSpans());
return spans;
}
private static class LatencyBuckets {
final SpanBucket zeroToTenMicros = new SpanBucket(/* isLatencyBucket= */ true);
final SpanBucket tenMicrosToHundredMicros = new SpanBucket(/* isLatencyBucket= */ true);
final SpanBucket hundredMicrosToOneMilli = new SpanBucket(/* isLatencyBucket= */ true);
final SpanBucket oneMilliToTenMillis = new SpanBucket(/* isLatencyBucket= */ true);
final SpanBucket tenMillisToHundredMillis = new SpanBucket(/* isLatencyBucket= */ true);
final SpanBucket hundredMillisToOneSecond = new SpanBucket(/* isLatencyBucket= */ true);
final SpanBucket oneSecondToTenSeconds = new SpanBucket(/* isLatencyBucket= */ true);
final SpanBucket tenSecondsToHundredSeconds = new SpanBucket(/* isLatencyBucket= */ true);
final SpanBucket hundredSecondsToMax = new SpanBucket(/* isLatencyBucket= */ true);
void addTo(List<ReadableSpan> spans) {
zeroToTenMicros.addTo(spans);
tenMicrosToHundredMicros.addTo(spans);
hundredMicrosToOneMilli.addTo(spans);
oneMilliToTenMillis.addTo(spans);
tenMillisToHundredMillis.addTo(spans);
hundredMillisToOneSecond.addTo(spans);
oneSecondToTenSeconds.addTo(spans);
tenSecondsToHundredSeconds.addTo(spans);
hundredSecondsToMax.addTo(spans);
}
SpanBucket get(LatencyBoundary boundary) {
switch (boundary) {
case ZERO_MICROSx10:
return zeroToTenMicros;
case MICROSx10_MICROSx100:
return tenMicrosToHundredMicros;
case MICROSx100_MILLIx1:
return hundredMicrosToOneMilli;
case MILLIx1_MILLIx10:
return oneMilliToTenMillis;
case MILLIx10_MILLIx100:
return tenMillisToHundredMillis;
case MILLIx100_SECONDx1:
return hundredMillisToOneSecond;
case SECONDx1_SECONDx10:
return oneSecondToTenSeconds;
case SECONDx10_SECONDx100:
return tenSecondsToHundredSeconds;
case SECONDx100_MAX:
return hundredSecondsToMax;
}
// Can't happen with aligned versions, just pick an arbitrary one to compile.
return hundredSecondsToMax;
}
}
}