Remove the obsolete HTTP_STATUS_TEXT semantic attribute. (#1679)
This commit is contained in:
parent
e8d24a3aed
commit
bd51a606a7
|
|
@ -78,8 +78,6 @@ public final class SemanticAttributes {
|
|||
public static final AttributeKey<String> HTTP_SCHEME = stringKey("http.scheme");
|
||||
/** HTTP response status code. E.g. 200 (integer) If and only if one was received/sent. */
|
||||
public static final AttributeKey<Long> HTTP_STATUS_CODE = longKey("http.status_code");
|
||||
/** HTTP reason phrase. E.g. "OK" */
|
||||
public static final AttributeKey<String> HTTP_STATUS_TEXT = stringKey("http.status_text");
|
||||
/** Kind of HTTP protocol used: "1.0", "1.1", "2", "SPDY" or "QUIC". */
|
||||
public static final AttributeKey<String> HTTP_FLAVOR = stringKey("http.flavor");
|
||||
/** Value of the HTTP "User-Agent" header sent by the client. */
|
||||
|
|
|
|||
|
|
@ -192,12 +192,7 @@ class ZipkinSpanExporterTest {
|
|||
void generateSpan_AlreadyHasHttpStatusInfo() {
|
||||
Attributes attributeMap =
|
||||
Attributes.of(
|
||||
SemanticAttributes.HTTP_STATUS_CODE,
|
||||
404L,
|
||||
SemanticAttributes.HTTP_STATUS_TEXT,
|
||||
"NOT FOUND",
|
||||
stringKey("error"),
|
||||
"A user provided error");
|
||||
SemanticAttributes.HTTP_STATUS_CODE, 404L, stringKey("error"), "A user provided error");
|
||||
SpanData data =
|
||||
buildStandardSpan()
|
||||
.setAttributes(attributeMap)
|
||||
|
|
@ -211,7 +206,6 @@ class ZipkinSpanExporterTest {
|
|||
.toBuilder()
|
||||
.clearTags()
|
||||
.putTag(SemanticAttributes.HTTP_STATUS_CODE.getKey(), "404")
|
||||
.putTag(SemanticAttributes.HTTP_STATUS_TEXT.getKey(), "NOT FOUND")
|
||||
.putTag("error", "A user provided error")
|
||||
.build());
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue