Remove resource setter and getter from Tracer (#387)
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
This commit is contained in:
parent
c75cc68123
commit
c62fe501b8
|
@ -21,7 +21,6 @@ import io.opentelemetry.context.propagation.BinaryFormat;
|
||||||
import io.opentelemetry.context.propagation.HttpTextFormat;
|
import io.opentelemetry.context.propagation.HttpTextFormat;
|
||||||
import io.opentelemetry.context.propagation.TraceContextFormat;
|
import io.opentelemetry.context.propagation.TraceContextFormat;
|
||||||
import io.opentelemetry.internal.Utils;
|
import io.opentelemetry.internal.Utils;
|
||||||
import io.opentelemetry.resources.Resource;
|
|
||||||
import io.opentelemetry.trace.unsafe.ContextUtils;
|
import io.opentelemetry.trace.unsafe.ContextUtils;
|
||||||
import java.util.Map;
|
import java.util.Map;
|
||||||
import javax.annotation.Nullable;
|
import javax.annotation.Nullable;
|
||||||
|
@ -66,16 +65,6 @@ public final class DefaultTracer implements Tracer {
|
||||||
Utils.checkNotNull(spanData, "spanData");
|
Utils.checkNotNull(spanData, "spanData");
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
public void setResource(Resource resource) {
|
|
||||||
// do nothing
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
|
||||||
public Resource getResource() {
|
|
||||||
return Resource.getEmpty();
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public BinaryFormat<SpanContext> getBinaryFormat() {
|
public BinaryFormat<SpanContext> getBinaryFormat() {
|
||||||
return BINARY_FORMAT;
|
return BINARY_FORMAT;
|
||||||
|
|
|
@ -20,7 +20,6 @@ import com.google.errorprone.annotations.MustBeClosed;
|
||||||
import io.opentelemetry.context.Scope;
|
import io.opentelemetry.context.Scope;
|
||||||
import io.opentelemetry.context.propagation.BinaryFormat;
|
import io.opentelemetry.context.propagation.BinaryFormat;
|
||||||
import io.opentelemetry.context.propagation.HttpTextFormat;
|
import io.opentelemetry.context.propagation.HttpTextFormat;
|
||||||
import io.opentelemetry.resources.Resource;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Tracer is a simple, interface for {@link Span} creation and in-process context interaction.
|
* Tracer is a simple, interface for {@link Span} creation and in-process context interaction.
|
||||||
|
@ -152,23 +151,6 @@ public interface Tracer {
|
||||||
*/
|
*/
|
||||||
Span.Builder spanBuilder(String spanName);
|
Span.Builder spanBuilder(String spanName);
|
||||||
|
|
||||||
/**
|
|
||||||
* Sets the {@link Resource} to be associated with all {@link Span} and {@link SpanData} objects
|
|
||||||
* recorded by this {@link Tracer}.
|
|
||||||
*
|
|
||||||
* @param resource Resource to be associated with all {@link Span} and {@link SpanData} objects.
|
|
||||||
*/
|
|
||||||
void setResource(Resource resource);
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Gets the {@link Resource} that is associating with all the {@link Span} and {@link SpanData}
|
|
||||||
* objects recorded by this {@link Tracer}.
|
|
||||||
*
|
|
||||||
* @return {@link Resource} that is associating with all {@link Span} and {@link SpanData}
|
|
||||||
* objects.
|
|
||||||
*/
|
|
||||||
Resource getResource();
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Records a {@link SpanData}. This API allows to send a pre-populated span object to the
|
* Records a {@link SpanData}. This API allows to send a pre-populated span object to the
|
||||||
* exporter. Sampling and recording decisions as well as other collection optimizations is a
|
* exporter. Sampling and recording decisions as well as other collection optimizations is a
|
||||||
|
|
|
@ -31,7 +31,6 @@ import io.opentelemetry.metrics.Measure;
|
||||||
import io.opentelemetry.metrics.Measurement;
|
import io.opentelemetry.metrics.Measurement;
|
||||||
import io.opentelemetry.metrics.Meter;
|
import io.opentelemetry.metrics.Meter;
|
||||||
import io.opentelemetry.metrics.spi.MeterProvider;
|
import io.opentelemetry.metrics.spi.MeterProvider;
|
||||||
import io.opentelemetry.resources.Resource;
|
|
||||||
import io.opentelemetry.tags.DefaultTagger;
|
import io.opentelemetry.tags.DefaultTagger;
|
||||||
import io.opentelemetry.tags.TagMap;
|
import io.opentelemetry.tags.TagMap;
|
||||||
import io.opentelemetry.tags.Tagger;
|
import io.opentelemetry.tags.Tagger;
|
||||||
|
@ -215,14 +214,6 @@ public class OpenTelemetryTest {
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
public void setResource(Resource resource) {}
|
|
||||||
|
|
||||||
@Override
|
|
||||||
public Resource getResource() {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void recordSpanData(SpanData span) {}
|
public void recordSpanData(SpanData span) {}
|
||||||
|
|
||||||
|
|
|
@ -20,7 +20,6 @@ import io.opentelemetry.context.Scope;
|
||||||
import io.opentelemetry.context.propagation.BinaryFormat;
|
import io.opentelemetry.context.propagation.BinaryFormat;
|
||||||
import io.opentelemetry.context.propagation.HttpTextFormat;
|
import io.opentelemetry.context.propagation.HttpTextFormat;
|
||||||
import io.opentelemetry.context.propagation.TraceContextFormat;
|
import io.opentelemetry.context.propagation.TraceContextFormat;
|
||||||
import io.opentelemetry.resources.Resource;
|
|
||||||
import io.opentelemetry.sdk.trace.config.TraceConfig;
|
import io.opentelemetry.sdk.trace.config.TraceConfig;
|
||||||
import io.opentelemetry.trace.Span;
|
import io.opentelemetry.trace.Span;
|
||||||
import io.opentelemetry.trace.SpanContext;
|
import io.opentelemetry.trace.SpanContext;
|
||||||
|
@ -51,14 +50,6 @@ public class TracerSdk implements Tracer {
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
public void setResource(Resource resource) {}
|
|
||||||
|
|
||||||
@Override
|
|
||||||
public Resource getResource() {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void recordSpanData(SpanData span) {}
|
public void recordSpanData(SpanData span) {}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue