From feedef236676edf08387b0064f8deb210cf5d7d8 Mon Sep 17 00:00:00 2001 From: Bogdan Drutu Date: Wed, 9 Dec 2020 20:19:31 -0800 Subject: [PATCH] Rename accumulator to processor to match Go (#2255) Signed-off-by: Bogdan Drutu --- .../AbstractAsynchronousInstrument.java | 48 +++++++++---------- .../sdk/metrics/AbstractInstrument.java | 2 +- .../AbstractSynchronousInstrument.java | 15 +++--- .../sdk/metrics/DoubleCounterSdk.java | 12 ++--- .../sdk/metrics/DoubleSumObserverSdk.java | 4 +- .../sdk/metrics/DoubleUpDownCounterSdk.java | 12 ++--- .../metrics/DoubleUpDownSumObserverSdk.java | 4 +- .../sdk/metrics/DoubleValueObserverSdk.java | 4 +- .../sdk/metrics/DoubleValueRecorderSdk.java | 12 ++--- ...umulator.java => InstrumentProcessor.java} | 18 +++---- .../sdk/metrics/LongCounterSdk.java | 13 +++-- .../sdk/metrics/LongSumObserverSdk.java | 4 +- .../sdk/metrics/LongUpDownCounterSdk.java | 12 ++--- .../sdk/metrics/LongUpDownSumObserverSdk.java | 4 +- .../sdk/metrics/LongValueObserverSdk.java | 4 +- .../sdk/metrics/LongValueRecorderSdk.java | 12 ++--- .../opentelemetry/sdk/metrics/MeterSdk.java | 5 +- .../sdk/metrics/ViewRegistry.java | 8 ++-- .../sdk/metrics/ViewRegistryTest.java | 16 +++---- 19 files changed, 103 insertions(+), 106 deletions(-) rename sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/{InstrumentAccumulator.java => InstrumentProcessor.java} (94%) diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractAsynchronousInstrument.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractAsynchronousInstrument.java index cd13ddbccf..5239820709 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractAsynchronousInstrument.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractAsynchronousInstrument.java @@ -18,15 +18,15 @@ abstract class AbstractAsynchronousInstrument { @Nullable private final Callback metricUpdater; private final ReentrantLock collectLock = new ReentrantLock(); - private final InstrumentAccumulator instrumentAccumulator; + private final InstrumentProcessor instrumentProcessor; AbstractAsynchronousInstrument( InstrumentDescriptor descriptor, - InstrumentAccumulator instrumentAccumulator, + InstrumentProcessor instrumentProcessor, @Nullable Callback metricUpdater) { super(descriptor); this.metricUpdater = metricUpdater; - this.instrumentAccumulator = instrumentAccumulator; + this.instrumentProcessor = instrumentProcessor; } @Override @@ -36,14 +36,14 @@ abstract class AbstractAsynchronousInstrument> extends AbstractInstrument.Builder { @@ -60,29 +60,29 @@ abstract class AbstractAsynchronousInstrument { AbstractLongAsynchronousInstrument( InstrumentDescriptor descriptor, - InstrumentAccumulator instrumentAccumulator, + InstrumentProcessor instrumentProcessor, @Nullable Callback metricUpdater) { - super(descriptor, instrumentAccumulator, metricUpdater); + super(descriptor, instrumentProcessor, metricUpdater); } @Override - LongResultSdk newResult(InstrumentAccumulator instrumentAccumulator) { - return new LongResultSdk(instrumentAccumulator); + LongResultSdk newResult(InstrumentProcessor instrumentProcessor) { + return new LongResultSdk(instrumentProcessor); } private static final class LongResultSdk implements LongResult { - private final InstrumentAccumulator instrumentAccumulator; + private final InstrumentProcessor instrumentProcessor; - private LongResultSdk(InstrumentAccumulator instrumentAccumulator) { - this.instrumentAccumulator = instrumentAccumulator; + private LongResultSdk(InstrumentProcessor instrumentProcessor) { + this.instrumentProcessor = instrumentProcessor; } @Override public void observe(long sum, Labels labels) { - Aggregator aggregator = instrumentAccumulator.getAggregator(); + Aggregator aggregator = instrumentProcessor.getAggregator(); aggregator.recordLong(sum); - instrumentAccumulator.batch(labels, aggregator, /* mappedAggregator= */ false); + instrumentProcessor.batch(labels, aggregator, /* mappedAggregator= */ false); } } } @@ -91,29 +91,29 @@ abstract class AbstractAsynchronousInstrument { AbstractDoubleAsynchronousInstrument( InstrumentDescriptor descriptor, - InstrumentAccumulator instrumentAccumulator, + InstrumentProcessor instrumentProcessor, @Nullable Callback metricUpdater) { - super(descriptor, instrumentAccumulator, metricUpdater); + super(descriptor, instrumentProcessor, metricUpdater); } @Override - DoubleResultSdk newResult(InstrumentAccumulator instrumentAccumulator) { - return new DoubleResultSdk(instrumentAccumulator); + DoubleResultSdk newResult(InstrumentProcessor instrumentProcessor) { + return new DoubleResultSdk(instrumentProcessor); } private static final class DoubleResultSdk implements DoubleResult { - private final InstrumentAccumulator instrumentAccumulator; + private final InstrumentProcessor instrumentProcessor; - private DoubleResultSdk(InstrumentAccumulator instrumentAccumulator) { - this.instrumentAccumulator = instrumentAccumulator; + private DoubleResultSdk(InstrumentProcessor instrumentProcessor) { + this.instrumentProcessor = instrumentProcessor; } @Override public void observe(double sum, Labels labels) { - Aggregator aggregator = instrumentAccumulator.getAggregator(); + Aggregator aggregator = instrumentProcessor.getAggregator(); aggregator.recordDouble(sum); - instrumentAccumulator.batch(labels, aggregator, /* mappedAggregator= */ false); + instrumentProcessor.batch(labels, aggregator, /* mappedAggregator= */ false); } } } diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java index 58ba2f10d9..2483268a06 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java @@ -101,7 +101,7 @@ abstract class AbstractInstrument implements Instrument { return meterSharedState.getInstrumentRegistry().register(instrument); } - protected InstrumentAccumulator getBatcher(InstrumentDescriptor descriptor) { + protected InstrumentProcessor getBatcher(InstrumentDescriptor descriptor) { return meterSdk.createBatcher(descriptor, meterProviderSharedState, meterSharedState); } } diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractSynchronousInstrument.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractSynchronousInstrument.java index ed55ed7771..04b7ad11f2 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractSynchronousInstrument.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractSynchronousInstrument.java @@ -17,14 +17,14 @@ abstract class AbstractSynchronousInstrument extends AbstractInstrument { private final ConcurrentHashMap boundLabels; private final ReentrantLock collectLock; - private final InstrumentAccumulator instrumentAccumulator; + private final InstrumentProcessor instrumentProcessor; AbstractSynchronousInstrument( - InstrumentDescriptor descriptor, InstrumentAccumulator instrumentAccumulator) { + InstrumentDescriptor descriptor, InstrumentProcessor instrumentProcessor) { super(descriptor); boundLabels = new ConcurrentHashMap<>(); collectLock = new ReentrantLock(); - this.instrumentAccumulator = instrumentAccumulator; + this.instrumentProcessor = instrumentProcessor; } public B bind(Labels labels) { @@ -36,7 +36,7 @@ abstract class AbstractSynchronousInstrument } // Missing entry or no longer mapped, try to add a new entry. - binding = newBinding(instrumentAccumulator); + binding = newBinding(instrumentProcessor); while (true) { B oldBound = boundLabels.putIfAbsent(labels, binding); if (oldBound != null) { @@ -68,14 +68,13 @@ abstract class AbstractSynchronousInstrument // acquire but because we requested a specific value only one will succeed. boundLabels.remove(entry.getKey(), entry.getValue()); } - instrumentAccumulator.batch( - entry.getKey(), entry.getValue().getAggregator(), !unmappedEntry); + instrumentProcessor.batch(entry.getKey(), entry.getValue().getAggregator(), !unmappedEntry); } - return instrumentAccumulator.completeCollectionCycle(); + return instrumentProcessor.completeCollectionCycle(); } finally { collectLock.unlock(); } } - abstract B newBinding(InstrumentAccumulator instrumentAccumulator); + abstract B newBinding(InstrumentProcessor instrumentProcessor); } diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleCounterSdk.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleCounterSdk.java index 05a8bafd1a..994b0ee0b0 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleCounterSdk.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleCounterSdk.java @@ -15,8 +15,8 @@ final class DoubleCounterSdk extends AbstractSynchronousInstrument metricUpdater) { - super(descriptor, instrumentAccumulator, metricUpdater); + super(descriptor, instrumentProcessor, metricUpdater); } static final class Builder diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleUpDownCounterSdk.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleUpDownCounterSdk.java index 9b6fd39e0e..240238a296 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleUpDownCounterSdk.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleUpDownCounterSdk.java @@ -15,8 +15,8 @@ final class DoubleUpDownCounterSdk extends AbstractSynchronousInstrument metricUpdater) { - super(descriptor, instrumentAccumulator, metricUpdater); + super(descriptor, instrumentProcessor, metricUpdater); } static final class Builder diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueObserverSdk.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueObserverSdk.java index e016b4c884..785a410f43 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueObserverSdk.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueObserverSdk.java @@ -16,9 +16,9 @@ final class DoubleValueObserverSdk extends AbstractDoubleAsynchronousInstrument DoubleValueObserverSdk( InstrumentDescriptor descriptor, - InstrumentAccumulator instrumentAccumulator, + InstrumentProcessor instrumentProcessor, @Nullable Callback metricUpdater) { - super(descriptor, instrumentAccumulator, metricUpdater); + super(descriptor, instrumentProcessor, metricUpdater); } static final class Builder diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueRecorderSdk.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueRecorderSdk.java index 09c2f91897..b512a453a6 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueRecorderSdk.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/DoubleValueRecorderSdk.java @@ -15,8 +15,8 @@ final class DoubleValueRecorderSdk extends AbstractSynchronousInstrument implements LongCounter { - private LongCounterSdk( - InstrumentDescriptor descriptor, InstrumentAccumulator instrumentAccumulator) { - super(descriptor, instrumentAccumulator); + private LongCounterSdk(InstrumentDescriptor descriptor, InstrumentProcessor instrumentProcessor) { + super(descriptor, instrumentProcessor); } @Override @@ -35,15 +34,15 @@ final class LongCounterSdk extends AbstractSynchronousInstrument metricUpdater) { - super(descriptor, instrumentAccumulator, metricUpdater); + super(descriptor, instrumentProcessor, metricUpdater); } static final class Builder diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongUpDownCounterSdk.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongUpDownCounterSdk.java index defe1c13dd..f18354dbff 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongUpDownCounterSdk.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongUpDownCounterSdk.java @@ -15,8 +15,8 @@ final class LongUpDownCounterSdk extends AbstractSynchronousInstrument metricUpdater) { - super(descriptor, instrumentAccumulator, metricUpdater); + super(descriptor, instrumentProcessor, metricUpdater); } static final class Builder diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongValueObserverSdk.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongValueObserverSdk.java index f6e55bd7d1..aa98af7a96 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongValueObserverSdk.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongValueObserverSdk.java @@ -16,9 +16,9 @@ final class LongValueObserverSdk extends AbstractLongAsynchronousInstrument LongValueObserverSdk( InstrumentDescriptor descriptor, - InstrumentAccumulator instrumentAccumulator, + InstrumentProcessor instrumentProcessor, @Nullable Callback metricUpdater) { - super(descriptor, instrumentAccumulator, metricUpdater); + super(descriptor, instrumentProcessor, metricUpdater); } static final class Builder diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongValueRecorderSdk.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongValueRecorderSdk.java index 0d687f4aa1..02871f65db 100644 --- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongValueRecorderSdk.java +++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/LongValueRecorderSdk.java @@ -15,8 +15,8 @@ final class LongValueRecorderSdk extends AbstractSynchronousInstrument