Commit Graph

57 Commits

Author SHA1 Message Date
Anuraag Agrawal 86cd56441c
Deprecate StatusData.isUnset (#2500)
* Deprecate StatusData.isUnset

* Cleanup

* option 2
2021-01-13 13:58:30 +09:00
Anuraag Agrawal b68fc82b89
Make classes that can be shutdown Closeable (#2285)
* Make classes that can be shutdown Closeable

* Glad not my password

* Drift
2021-01-13 13:57:20 +09:00
Bogdan Drutu ca661b8c40
Avoid using inner classes in SpanData (#2495)
* Avoid using inner classes in SpanData

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Javadoc cleanups

* Remove non-existent type param

Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
2021-01-12 19:12:00 -08:00
Anuraag Agrawal 62251dd3d2
Accept TimeUnit and Duration for BSP values instead of forcing millis. (#2444)
* Accept TimeUnit and Duration for BSP values instead of forcing millis.

* Test invalid

* Clean
2021-01-08 11:44:51 -08:00
Anuraag Agrawal 75e01110e4
Deprecate OpenTelemetry SPI. (#2453) 2021-01-08 13:37:44 +09:00
Anuraag Agrawal 4b8a0c8591
Add TraceConfig.builder() (#2445) 2021-01-07 10:02:53 -08:00
Anuraag Agrawal bdbab03332
Deprecate ConfigBuilder. (#2442) 2021-01-07 08:52:39 -08:00
John Watson aa8433d87f
Add a test for the RECORD_ONLY span (#2440)
And remove the old TODOs from the BSP test.
2021-01-06 18:23:08 -08:00
John Watson e1cf785475
Have a default span name in case instrumentation sends in a blank/empty/null name (#2433)
* Have a default span name in case instrumentation sends in a blank/empty/null name.

* add a test for the null name
2021-01-07 09:01:05 +09:00
John Watson 015708b7a7
Move the semantic conventions generated code into its own module (#2423)
* Move the semantic conventions generated code into its own module

* remove un-needed dependencies

* move the semconv module to the top level, out of the API namespace

* Update README.md

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>

* move SemanticAttributes to a more appropriate package and deprecate the old ones in the api package.

* Apply suggestions from code review

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-01-06 08:25:17 -08:00
John Watson 3b3f1ae540
Change the SdkTracerManagement shutdown method to return CompletableResultCode (#2422)
* Change the SdkTracerManagement shutdown method to return CompletableResultCode

* protect against a possible NPE due to a race condition

* cleanup from PR feedback

* move the mock to where it's used.
2021-01-06 08:23:49 -08:00
Anuraag Agrawal 4121cdc693
Remove sampling probability attribute when was not accepted to spec. (#2432)
* Remove sampling probability attribute when was not accepted to spec.

* Remove unused

* Remove unused
2021-01-06 08:03:29 -08:00
Anuraag Agrawal 4dbbe807c9
Deprecate addSpanProcessor mutator (#2385) 2021-01-04 08:43:52 -08:00
Anuraag Agrawal 66d08f4f00
Deprecate updateActiveTraceConfig (#2405)
* Deprecate updateActiveTraceConfig

* Spot

* Foo

* Spot++
2020-12-25 11:11:54 +09:00
Anuraag Agrawal 2d1bdaff73
Merge non-metrics API into API artifact. (#2369)
* Merge non-metrics API into API artifact.

* Revert kotlin newline
2020-12-24 14:13:54 +09:00
Anuraag Agrawal 9f675da85a
Remove usage of updateTraceConfig in tests. (#2402)
* Remove usage of updateTraceConfig in tests.

* Clean
2020-12-23 08:15:50 -08:00
Anuraag Agrawal 24ef29efea
Add SimpleSpanProcessor.create and deprecate SimpleSpanProcessorBuilder (#2374)
* Deprecate SimpleSpanProcessorBuilder

* Null test
2020-12-23 12:31:02 +09:00
Anuraag Agrawal d48eab6aa9
Allow registering TraceConfigSupplier and use it from zpages. (#2390)
* Allow registering TraceConfigSupplier and use it from zpages.

* Finish

* Remove unnecessary method

* Same method name
2020-12-23 11:52:17 +09:00
Anuraag Agrawal 8fc4e627ca
Reduce usage of GlobalOpenTelemetry (#2386)
* Reduce usage of GlobalOpenTelemetry

* Cleanup
2020-12-23 10:17:46 +09:00
Anuraag Agrawal 70f665992e
Migrate assertThrows -> assertThatThrownBy (#2375) 2020-12-21 08:57:33 -08:00
Bogdan Drutu 95163d71fb
Avoid using mutable addSpanProcessor when trivial to change (#2365)
* Run go mod tidy on the master

* Fixes

Co-authored-by: Anuraag Agrawal <aanuraag@amazon.co.jp>
2020-12-21 12:22:36 +09:00
John Watson e9062d61f2
remove some deprecated SpanData methods (#2367) 2020-12-18 16:19:49 -08:00
Anuraag Agrawal fb5b497986
Allow adding span processors when building a tracer provider. (#2223)
* Allow adding span processors when building a tracer provider.

* Drift

* Mutate provided providers too for now.

* Spot
2020-12-18 13:04:24 -08:00
Anuraag Agrawal 4de9c43ac0
Use public readProperties instead of protected fromConfigMap to avoid annoying pattern of initializing a subclass for testing. (#2357) 2020-12-18 08:10:50 -08:00
Anuraag Agrawal 6954d1f624
Use normal filesystem-based Gradle paths. (#2332)
* Use normal filesystem-based Gradle paths.

* Update workflow by making agnostic to jacoco project name

* More merge
2020-12-18 12:07:33 +09:00
Bogdan Drutu a8b30ea503
Remove deprecated code in the API (#2341)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-17 13:18:05 -08:00
Bogdan Drutu 5e5d60584b
Consistent naming for SPI classes (#2326)
Follow the java convention to name Factories, ${CLASS_NAME}Factory.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-17 11:18:18 -08:00
Anuraag Agrawal 17fa4e9c97
Only apply java-library to projects and configure reactively. (#2319)
* Use java-library

* Only apply java-library to projects and configure reactively.

* Consistency

* Cleanup
2020-12-17 09:11:44 +09:00
Anuraag Agrawal 7c0b452097
Move SdkTracerProviderBuilder and OpenTelemetrySdkBuilder to top-level. (#2318) 2020-12-16 10:56:49 -08:00
Anuraag Agrawal 8a369e3695
Make public src/main classes final where possible. (#2309)
* Make public src/main classes final where possible.

* methods

* Spot
2020-12-16 13:13:04 +09:00
Bogdan Drutu dbb1ae91f9
Deprecate metrics from opentelemetry-api, add a global version in metrics api (#2279)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-15 15:14:50 -08:00
Bogdan Drutu 25bf879df7
Split global functionality into a separate class (#2233)
This ensure clear separation of functionality. This PR does not change any functionality, it just restructures the code to separate global functionality from
the Default implementation. Also helps to ensure that Global initialization does not happen by mistake when working only with the default implementation.

Also it helps with methods like `OpenTelemetry.get()` and `OpenTelemetry.set()` to understand they are interacting with global instance

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-15 10:27:35 -08:00
Anuraag Agrawal 3701a8bdf6
Move DaemonThreadFactory to internal package. (#2288) 2020-12-14 21:06:00 -08:00
Anuraag Agrawal 262dd7a866
Use key as AttributeKey.toString (#2175)
* Use key as AttributeKey.toString

* Fix / more tests

* Add toString test for SpanWrapper

* Quote string values

* Fix
2020-12-15 12:49:45 +09:00
Anuraag Agrawal 7ff20f6db6
Move Sampler builder to top level (#2291)
* Move Sampler builder to top level

* Hide implementation class

* Ordering
2020-12-15 10:16:08 +09:00
Anuraag Agrawal 91dc119181
Move Sdk to be prefix of implementation classes instead of suffix/midfix. (#2292) 2020-12-14 11:59:28 -08:00
Anuraag Agrawal f626cb9705
Move export processor builders to top level. (#2286) 2020-12-14 11:38:03 -08:00
Bogdan Drutu ca1f31dfb5
Use standard Java interfaces instead of defining custom ones (#2261)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-10 09:16:24 -08:00
Bogdan Drutu 396fa44601
Change ComponentRegistry to be a final class that accepts a factory method (#2256)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-09 20:26:06 -08:00
Anuraag Agrawal 56235a1114
Move TraceConfig.Builder to the top level (#2241)
* Move TraceConfig.Builder to the top level

* Remove builder
2020-12-09 19:54:07 -08:00
Anuraag Agrawal f199e133fa
Implement more Span default methods. (#2242)
* Implement more Span default methods.

* A bit more
2020-12-09 13:08:52 -08:00
John Watson a511af4b85
Add a section to the TracerSdkManagement.shutdown javadoc to make it clear it is a terminal operation. (#2229) 2020-12-08 12:54:05 -08:00
Anuraag Agrawal e4e3dfbdb0
Rename Link.getContext -> Link.getSpanContext (#2224) 2020-12-08 10:43:26 -08:00
Bogdan Drutu 5732395b83
Mark as package protected deprecated Multi classes in SDK (#2217)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-07 18:16:57 -08:00
Bogdan Drutu 69208f8f79
Remove version of checkArgument not used (#2213)
This PR fixes an inconsistency that MaxLengthOfAttributeValues was allowed to be set to 0, then thrown internal exception.
We should check for arguments only at public APIs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2020-12-07 13:39:33 -08:00
John Watson c03efbcc13
Add an option to the SDK builder to specify an initial TraceConfig (#2192)
* Add an option to set the initial TraceConfig when building an SDK, and a TracerSdkProvider.

* add the missing javadoc
2020-12-04 14:12:48 +09:00
Anuraag Agrawal 4762c6a25d
Remove ReadableAttributes (#2187)
* Remove ReadableAttributes

* Don't rewrite history

* Drift
2020-12-03 11:26:24 -08:00
John Watson d7ab0addfa
Add an option to set an IdGenerator when building an SDK. (#2185)
rename a few lingering pluralized idGenerator symbols.
2020-12-03 09:18:05 +09:00
Armin Ruech 5585e73611
Remove "semver" prefix from instrumentation library version (#2180) 2020-12-02 10:29:11 -08:00
Anuraag Agrawal cf5b582c5b
Replace AttributeConsumer with BiConsumer (#2174)
* Replace AttributeConsumer with BiConsumer

* Forgot to delete
2020-12-02 16:52:06 +09:00