Commit Graph

739 Commits

Author SHA1 Message Date
Anuraag Agrawal 5320f208cb
Fix nullness in trace-propagators (#3656) 2021-09-24 09:15:04 -07:00
Anuraag Agrawal b311d50d03
Fix some nullness. (#3647)
* Fix some nullness.

* Log
2021-09-22 09:00:57 -07:00
Anuraag Agrawal ece161f6e0
Preencode attribute keys into utf8 bytes. (#3576)
* Use constants for AttributeKeys in JMH

* Preencode attribute keys into utf8 bytes.

* Spot

* Ignore

* Be lazy

* Boil
2021-09-10 10:35:26 +09:00
Trask Stalnaker 86eea94b76
Allow creating a SpanContext without validation for internal use (#3564)
* Avoid unnecessary calls to TraceId and SpanId.isValid()

* Alternative: move ImmutableSpanContext to internal package

* javadoc

* Only skip for safe IdGenerators

* Simplify

* Errorprone

* Add test and fix boolean logic

* Spotless

* Add test

* Revert toString test change
2021-08-31 11:09:19 -07:00
Anuraag Agrawal 9e73bfe9e5
Remove branches from isValidBase16 (#3566) 2021-08-31 08:57:35 +09:00
Trask Stalnaker e2564eb95e
Cache AttributeKey hashCode (#3563)
* Cache AttributeKey hashCode

* Don't call instance method from constructor
2021-08-30 16:15:15 -07:00
Anuraag Agrawal 6ef3091cfb
Copy in spotless-conventions from instrumentation repo (#3554)
* Copy in spotless-conventions from instrumentation repo.

* Reformat

* A few more dotfiles
2021-08-27 08:28:31 -07:00
John Watson 4b4f0167ed
Optimize 1 & 2 element attributes creation (#3502)
* optimize the single-attribute creation flow to avoid unneeded allocations

* Optimize the implementations of 1 and 2 element Attributes instances.

* Refactor to *actually* save allocations and fix a couple of bugs.
2021-08-18 16:14:32 -07:00
Anuraag Agrawal 87f2b5e0a8
Update error-prone (#3485) 2021-08-13 09:44:29 -07:00
Anuraag Agrawal 182455023a
Update nullaway and add a Contract for StringUtils. (#3432)
* Update nullaway and add a Contract for StringUtils.

* RUNTIME

* SOURCE

* Cleanup
2021-08-12 14:50:39 +09:00
Christian Neumüller dd7cae97d5
Fix OpenTelemetrySdk(.tracerProvider).tracerBuilder() being noop. (#3466)
* Add test for obfuscated tracerBuilder.

* Fix bug, add more tests.
2021-08-11 09:02:09 -07:00
Josh Suereth 0ef19291c2
Swap old Metrics API for currently specified Metrics API (#3423)
* Update the API to the latest SDK specification.

* API updates to other sdk areas.

* First half of SDK updates for API.

Passing off to other cmoputer.

* Get SDK compiling again.

* Get tests compiling again (and failing).

* Fix bad copy-paste error.

* Get all SDK tests passing.

* More fixes to builds across SDK impls.

* Remove unecessary publics

* more fixes for new API.

* spotless fixes.

* Make tests for metric points order independent.

* Restore readme.

* Fix readmes.

* Add noop meter provider tests for code coverage.

* Add code coverage for assertion library.

* Fix wierd test failure that gradle cache is preventing me from seeing locally.

* Fix javadoc/spelling comments from review.

* Remove marker interfaces.

* Switch from atomic ref to volatile.

* Fixes from review.

* Apply suggestions from code review

Co-authored-by: John Watson <jkwatson@gmail.com>

* Fixes from review.

* Fixes from review.

* Update OTLP HTTP exporter to use new metrics api

Co-authored-by: John Watson <jkwatson@gmail.com>
2021-08-05 13:58:49 -07:00
Trask Stalnaker 60c3c5ca0c
Format build.gradle.kts files (#3427) 2021-07-29 13:21:38 +09:00
Anuraag Agrawal ce9c8854c7
Extract publishing and animalsniffer plugins. (#3334) 2021-06-22 08:23:16 +09:00
Anuraag Agrawal 864508983e
Extract JMH conventions plugin. (#3324) 2021-06-17 08:37:49 -07:00
Anuraag Agrawal 7f544416e4
Define an extension for otel-specific configuration of Java. (#3317) 2021-06-17 15:54:25 +09:00
Anuraag Agrawal b9ca09b6c1
Extract java conventions plugin. (#3316) 2021-06-15 12:29:47 -07:00
John Watson ca92a9ab03
Introduce usage of the OpenTelemetry schema with a Tracer/MeterBuilder (#3309)
* Add the OpenTelemetry schema URL to the InstrumentationLibraryInfo and the corresponding API calls.

* small refactoring and doc tweaks from feedback

* make the instrumentation version nullable on the method that takes a schema

* update the apidiffs

* add since tags and a few more missing nullable annotations

* Switch to using a Builder rather than method overloads.
2021-06-11 20:50:23 -07:00
Anuraag Agrawal d6849219a7
Use constant for baggage validation bitsets (#3274)
* Use constant for baggage validation bitsets

* Spot

* Move to element

* private
2021-06-03 17:26:00 -07:00
Anuraag Agrawal d044890a7c
Don't create Supplier when decoding byte (#3273) 2021-06-04 08:31:40 +09:00
Nikita Salnikov-Tarnovski ff85102a46
Remove unnecessary string allocation on hot path (#3272) 2021-06-03 08:57:16 +09:00
Valeriy 34494e609b
javadocs: fix code examples (#3269)
Problem:
Javadocs comments at Tracer interface contains call of unexistent method OpenTelemetry.getTracer()

Solution:
Replace OpenTelemetry.getTracer() with openTelemetry.getTracer(String, String) in examples at javadocs
2021-06-01 12:58:59 -07:00
Anuraag Agrawal 1bfc7871bd
Add doc for AttributesBuider accident. (#3265) 2021-05-30 08:22:12 -07:00
Anuraag Agrawal cb77a8d364
Move TemporaryBuffers to internal and use it everywhere. (#3226)
* Move TemporaryBuffers to internal and use it everywhere.

* blurb
2021-05-13 11:18:50 +09:00
Anuraag Agrawal 672330bf51
Upgrade to Gradle 7.0 (#3228) 2021-05-13 08:21:22 +09:00
Jakub Wach ad6ceccc4c
baggage parsing improvements (#3180)
* baggage parsing improvements

* added JMH benchmark for W3C baggage propagator

* clean-up

* removed old implementation code

* post-review changes
2021-05-12 09:41:21 -07:00
Anuraag Agrawal 77f0b0adc4
Allow enabling nullaway and fix some nullness issues (#3218)
* Add support for enabling nullaway and fix a couple of projects.

* Finish

* Finish

* Cleanup
2021-05-12 08:43:32 +09:00
John Watson a8a85c6129
Add tests and update behavior to verify propagators do not alter the … (#3194)
* Add tests and update behavior to verify propagators do not alter the context when failing to parse inputs.

* Ad a couple tests around null contexts

* formatting
2021-05-07 08:58:42 +09:00
John Watson f396965196
Add @since tags for new public methods. (#3209)
* Add @since tags for new public methods.

* remove errant since tags
2021-05-07 08:26:55 +09:00
Anuraag Agrawal d4b63fbbb6
Coerce null AttributeKey to empty string (#3186) 2021-04-30 10:31:34 +09:00
HaloFour 7d31cddf19
Add Span#setAllAttributes method to add Attributes to a Span (#2799) 2021-04-27 14:41:26 -07:00
James Gan f5f0e1f63f
Improve key validity code documentation for trace state (#3142)
* Improve key validity documentation for trace state

* Address code style issues

Addressed line length, indentation

* spotlessapply to fix indent of javadoc param comment
2021-04-08 10:40:34 -07:00
Anuraag Agrawal 531abc0d24
Fix more tracestate testsuite cases. (#3120) 2021-04-06 15:54:57 -07:00
Anuraag Agrawal d110a6075c
Don't crash on empty tracestate value (#3104) 2021-04-05 08:13:39 -07:00
Jakub Wach 71ad8ff646
X-Ray traceid extraction - 64bit support (#3087)
* X-Ray traceid extraction - 64bit support

* perf improvement - separate methods depending on traceid length

* code review

* code review - scare-comment for internal util

* added new unit tests

* Update api/all/src/main/java/io/opentelemetry/api/internal/StringUtils.java

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
2021-04-02 17:52:07 +09:00
John Watson 14fd81a8b9
Rename GlobalMetricsProvider to GlobalMeterProvider (#3048) 2021-03-29 08:09:24 -07:00
Anuraag Agrawal 761c8510d0
Better PropagatedSpan.toString (#3055) 2021-03-26 13:56:30 +09:00
John Watson e7cc57d911
Add a note to the TracerProvider javadoc about instrumentation name. (#3050) 2021-03-23 11:40:53 +09:00
Anuraag Agrawal f113c03483
Ignore null / invalid spancontext and handle null attributes for links. (#2985)
* Ignore null / invalid spancontext and handle null attributes for links.

* Cleanup

* Fix
2021-03-07 09:03:33 -08:00
Anuraag Agrawal f553aa0a6b
Add an internal GuardedBy annotation to enable our own error prone ch… (#2978)
* Add an internal GuardedBy annotation to enable our own error prone checker without affecting downstream.

* Method
2021-03-05 11:37:24 +09:00
John Watson 1883b5919a
Make the ReadOnlyArrayMap extend AbstractMap for equals/hashcode implementation (#2963)
* Make the ReadOnlyArrayMap extend AbstractMap for equals/hashcode implementation

* formatting

* use guava's EqualsTester to save a few lines

* remove redundant hashcode verifications

* add an empty map to the equals test
2021-03-03 14:05:18 -08:00
Anuraag Agrawal f967b0a95b
Move api/context to context. (#2959)
* Move api/context to context.

* git commit
2021-03-02 10:44:27 -08:00
Bogdan Drutu 17fb50cd31
Remove usage of not well defined fromHex in w3c context (#2947)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-02-26 15:49:42 -08:00
Bogdan Drutu b29a7123ce
Small nit fix in propagation TemporaryBuffers (#2946)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-02-26 14:27:59 -08:00
John Watson 6dd3eac097
Remove the documentation about explicit exceptions thrown when TraceFlags are invalid. (#2945) 2021-02-26 09:58:48 -08:00
John Watson 1102efae1d
Update the docs on the TextMapPropagator to be closer to the specification. (#2931) 2021-02-24 13:06:57 -08:00
Bogdan Drutu bf5fa57df5
Move c-like comment to javadoc in TextMapPropagator (#2930)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
2021-02-24 12:19:03 -08:00
Anuraag Agrawal 18df74eb19
Don't throw on null in propagator implementations. (#2904)
* Don't throw on null in propagator implementations.

* Baggage too
2021-02-24 09:28:16 -08:00
Anuraag Agrawal b393a587dd
Have AttributesMap extend HashMap instead of contain LinkedHashMap (#2906)
* Reduce HashMp allocations for AttributeMap.

* Finish

* Add comment on why wrapper is actually needed.
2021-02-24 09:24:25 -08:00
Anuraag Agrawal 0b973d9a3c
Defend against null in a few more places. (#2928) 2021-02-24 08:05:24 -08:00