open-telemetry
/
opentelemetry-js
mirror of https://github.com/open-telemetry/opentelemetry-js.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[http] fix: use url.URL (#960) 

url.URL from the standard library should be used instead of the global URL which comes from the dom lib.

Signed-off-by: Naseem <naseem@transit.app>
This commit is contained in:
Naseem 2020-04-16 14:14:50 -04:00 committed by GitHub
parent 7412d9b518
commit 1959930f77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/opentelemetry-plugin-http/src/http.ts
View File

@ -145,7 +145,7 @@ export class HttpPlugin extends BasePlugin<Http> {
protected _getPatchOutgoingGetFunction( protected _getPatchOutgoingGetFunction(
clientRequest: ( clientRequest: (
options: RequestOptions | string | URL, options: RequestOptions | string | url.URL,
...args: HttpRequestArgs ...args: HttpRequestArgs
) => ClientRequest ) => ClientRequest
) { ) {
@ -161,7 +161,7 @@ export class HttpPlugin extends BasePlugin<Http> {
// https://nodejs.org/dist/latest/docs/api/http.html#http_http_get_options_callback // https://nodejs.org/dist/latest/docs/api/http.html#http_http_get_options_callback
// https://github.com/googleapis/cloud-trace-nodejs/blob/master/src/plugins/plugin-http.ts#L198 // https://github.com/googleapis/cloud-trace-nodejs/blob/master/src/plugins/plugin-http.ts#L198
return function outgoingGetRequest< return function outgoingGetRequest<
T extends RequestOptions | string | URL T extends RequestOptions | string | url.URL
>(options: T, ...args: HttpRequestArgs): ClientRequest { >(options: T, ...args: HttpRequestArgs): ClientRequest {
const req = clientRequest(options, ...args); const req = clientRequest(options, ...args);
req.end(); req.end();