open-telemetry
/
opentelemetry-js
mirror of https://github.com/open-telemetry/opentelemetry-js.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(sdk-metrics): fix flaky LastValueAggregator test by using fake timer (#3587) 

* fix(sdk-metrics): fix flaky LastValueAggregator test by using fake timers

* fix(changelog): add changelog entry.

* fix(sdk-metrics): change LastValueAggregation timer increment to 100ms
This commit is contained in:
Marc Pichler 2023-02-06 22:55:01 +01:00 committed by GitHub
parent 2b59c2820c
commit 461dc4ba9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -19,6 +19,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
### :house: (Internal) ### :house: (Internal)
* fix(sdk-metrics): ix flaky LastValueAggregator test by using fake timer [#3587](https://github.com/open-telemetry/opentelemetry-js/pull/3587) @pichlermarc
## 1.9.1 ## 1.9.1
### :bug: (Bug Fix) ### :bug: (Bug Fix)

23
packages/sdk-metrics/test/aggregator/LastValue.test.ts
View File

@ -16,15 +16,26 @@
import { HrTime } from '@opentelemetry/api'; import { HrTime } from '@opentelemetry/api';
import * as assert from 'assert'; import * as assert from 'assert';
import * as sinon from 'sinon';
import { AggregationTemporality } from '../../src'; import { AggregationTemporality } from '../../src';
import { import {
LastValueAccumulation, LastValueAccumulation,
LastValueAggregator, LastValueAggregator,
} from '../../src/aggregator'; } from '../../src/aggregator';
import { MetricData, DataPointType } from '../../src/export/MetricData'; import { MetricData, DataPointType } from '../../src/export/MetricData';
import { commonValues, defaultInstrumentDescriptor, sleep } from '../util'; import { commonValues, defaultInstrumentDescriptor } from '../util';
describe('LastValueAggregator', () => { describe('LastValueAggregator', () => {
let clock: sinon.SinonFakeTimers;
beforeEach(() => {
clock = sinon.useFakeTimers();
});
afterEach(() => {
sinon.restore();
});
describe('createAccumulation', () => { describe('createAccumulation', () => {
it('no exceptions on createAccumulation', () => { it('no exceptions on createAccumulation', () => {
const aggregator = new LastValueAggregator(); const aggregator = new LastValueAggregator();
@ -47,16 +58,16 @@ describe('LastValueAggregator', () => {
assert.deepStrictEqual(aggregator.merge(prev, delta), expected); assert.deepStrictEqual(aggregator.merge(prev, delta), expected);
}); });
it('return the newly sampled accumulation', async () => { it('return the newly sampled accumulation', () => {
const aggregator = new LastValueAggregator(); const aggregator = new LastValueAggregator();
const accumulation1 = aggregator.createAccumulation([0, 0]); const accumulation1 = aggregator.createAccumulation([0, 0]);
const accumulation2 = aggregator.createAccumulation([1, 1]); const accumulation2 = aggregator.createAccumulation([1, 1]);
accumulation1.record(2); accumulation1.record(2);
await sleep(1); clock.tick(100);
accumulation2.record(3); accumulation2.record(3);
// refresh the accumulation1 // refresh the accumulation1
await sleep(1); clock.tick(100);
accumulation1.record(4); accumulation1.record(4);
assert.deepStrictEqual( assert.deepStrictEqual(
@ -92,7 +103,7 @@ describe('LastValueAggregator', () => {
assert.deepStrictEqual(aggregator.diff(prev, curr), expected); assert.deepStrictEqual(aggregator.diff(prev, curr), expected);
}); });
it('return the newly sampled accumulation', async () => { it('return the newly sampled accumulation', () => {
const aggregator = new LastValueAggregator(); const aggregator = new LastValueAggregator();
const accumulation1 = aggregator.createAccumulation([0, 0]); const accumulation1 = aggregator.createAccumulation([0, 0]);
const accumulation2 = aggregator.createAccumulation([1, 1]); const accumulation2 = aggregator.createAccumulation([1, 1]);
@ -100,7 +111,7 @@ describe('LastValueAggregator', () => {
accumulation1.record(2); accumulation1.record(2);
accumulation2.record(3); accumulation2.record(3);
// refresh the accumulation1 // refresh the accumulation1
await sleep(1); clock.tick(100);
accumulation1.record(4); accumulation1.record(4);
assert.deepStrictEqual( assert.deepStrictEqual(