fix(otlp-http-exporter): remove content length header (#2879)

This commit is contained in:
Svetlana Brennan 2022-04-06 13:28:22 -05:00 committed by GitHub
parent 5d9ed3faa5
commit 9890767c98
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 7 deletions

View File

@ -8,6 +8,7 @@ All notable changes to experimental packages in this project will be documented
* [#2707](https://github.com/open-telemetry/opentelemetry-js/pull/2707) feat(sdk-metrics-base): update metric exporter interfaces ([@srikanthccv](https://github.com/srikanthccv))
* [#2687](https://github.com/open-telemetry/opentelemetry-js/pull/2687) feat(api-metrics): remove observable types ([@legendecas](https://github.com/legendecas))
* [#2879](https://github.com/open-telemetry/opentelemetry-js/pull/2879) fix(otlp-http-exporter): remove content length header ([@svetlanabrennan](https://github.com/svetlanabrennan))
### :rocket: (Enhancement)

View File

@ -50,7 +50,6 @@ export function sendWithHttp<ExportItem, ServiceRequest>(
path: parsedUrl.pathname,
method: 'POST',
headers: {
'Content-Length': Buffer.byteLength(data),
'Content-Type': contentType,
...collector.headers,
},
@ -96,9 +95,7 @@ export function sendWithHttp<ExportItem, ServiceRequest>(
break;
}
default:
req.write(data);
req.end();
req.end(data);
break;
}
}

View File

@ -148,7 +148,7 @@ describe('OTLPMetricExporter - node with json over http', () => {
describe('export', () => {
beforeEach(async () => {
stubRequest = sinon.stub(http, 'request').returns(fakeRequest as any);
stubWrite = sinon.stub(fakeRequest, 'write');
stubWrite = sinon.stub(fakeRequest, 'end');
collectorExporterConfig = {
headers: {
foo: 'bar',

View File

@ -179,9 +179,9 @@ describe('OTLPMetricExporter - node with proto over http', () => {
collectorExporter.export(metrics, () => {});
sinon.stub(http, 'request').returns({
end: () => {},
write: () => {},
on: () => {},
write: (...writeArgs: any[]) => {
end: (...writeArgs: any[]) => {
const ExportTraceServiceRequestProto = getExportRequestProto();
const data = ExportTraceServiceRequestProto?.decode(writeArgs[0]);
const json = data?.toJSON() as otlpTypes.opentelemetryProto.collector.metrics.v1.ExportMetricsServiceRequest;