fix(ci): correctly pull containers from container builds in build-and-test.yaml (#344)

* don't require HTTPS if pushing to localhost:5000

* fix variable scope

* add missing image pull from the temporary container registry

* clean up registry push script

.github/workflows/build-and-test.yaml

@@ -87,6 +87,7 @@ jobs:
         
         # Export reducer container
         mkdir -p container-exports
+        docker pull localhost:5000/reducer
         docker save localhost:5000/reducer > container-exports/reducer.tar
         
         # Clean up registry
@@ -134,6 +135,7 @@ jobs:
         
         # Export kernel-collector container
         mkdir -p container-exports
+        docker pull localhost:5000/kernel-collector
         docker save localhost:5000/kernel-collector > container-exports/kernel-collector.tar
         
         # Clean up registry
@@ -181,6 +183,7 @@ jobs:
         
         # Export kernel-collector-test container
         mkdir -p container-exports
+        docker pull localhost:5000/kernel-collector-test
         docker save localhost:5000/kernel-collector-test > container-exports/kernel-collector-test.tar
         
         # Clean up registry

dev/docker-registry-push.sh

@@ -49,8 +49,14 @@ if [[ "${do_login}" == true ]]; then
   "${EBPF_NET_SRC_ROOT}/dev/docker-registry-login.sh" "${login_args}" "${docker_registry}"
 fi
 
+# add --tls-verify=false for default registry (localhost:5000)
+push_args=""
+if [[ "${docker_registry}" == "localhost:5000" ]]; then
+  push_args="--tls-verify=false"
+fi
+
 (set -x; \
   podman tag "${image_name}:${image_tag}" \
     "${docker_registry}/${image_name}:${image_tag}"; \
-  podman push "${docker_registry}/${image_name}:${image_tag}"; \
+  podman push ${push_args} "${docker_registry}/${image_name}:${image_tag}"; \
 )