open-telemetry
/
opentelemetry-php
mirror of https://github.com/open-telemetry/opentelemetry-php.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove redundant interface

This commit is contained in:
Brett McBride 2022-10-12 20:35:43 +11:00
parent 2e019e4f1b
commit 350d40cdfe
3 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Contrib/Grpc/GrpcTransportFactory.php
View File

@ -12,7 +12,6 @@ use function in_array;
use InvalidArgumentException;
use function json_encode;
use OpenTelemetry\API\Common\Signal\Signals;
use OpenTelemetry\Contrib\Otlp\OtlpTransportFactoryInterface;
use OpenTelemetry\Contrib\Otlp\OtlpUtil;
use OpenTelemetry\SDK\Behavior\LogsMessagesTrait;
use OpenTelemetry\SDK\Common\Environment\EnvironmentVariablesTrait;
@ -24,7 +23,7 @@ use function parse_url;
use RuntimeException;
use function sprintf;
final class GrpcTransportFactory implements TransportFactoryInterface, OtlpTransportFactoryInterface
final class GrpcTransportFactory implements TransportFactoryInterface
{
use EnvironmentVariablesTrait;
use LogsMessagesTrait;

14
src/Contrib/Otlp/OtlpTransportFactoryInterface.php
View File

@ -1,14 +0,0 @@
<?php
declare(strict_types=1);
namespace OpenTelemetry\Contrib\Otlp;
use OpenTelemetry\SDK\Common\Export\TransportFactoryInterface;
interface OtlpTransportFactoryInterface
{
public function withSignal(string $signal): TransportFactoryInterface;
public function withProtocol(string $protocol): TransportFactoryInterface;
}

3
src/Contrib/OtlpHttp/OtlpHttpTransportFactory.php
View File

@ -6,7 +6,6 @@ namespace OpenTelemetry\Contrib\OtlpHttp;
use InvalidArgumentException;
use OpenTelemetry\API\Common\Signal\Signals;
use OpenTelemetry\Contrib\Otlp\OtlpTransportFactoryInterface;
use OpenTelemetry\Contrib\Otlp\OtlpUtil;
use OpenTelemetry\Contrib\Otlp\Protocols;
use OpenTelemetry\SDK\Common\Environment\EnvironmentVariablesTrait;
@ -16,7 +15,7 @@ use OpenTelemetry\SDK\Common\Export\Http\PsrTransportFactory;
use OpenTelemetry\SDK\Common\Export\TransportFactoryInterface;
use OpenTelemetry\SDK\Common\Otlp\HttpEndpointResolver;
class OtlpHttpTransportFactory implements TransportFactoryInterface, OtlpTransportFactoryInterface
class OtlpHttpTransportFactory implements TransportFactoryInterface
{
use EnvironmentVariablesTrait;