From 55cc8b6ff1cb3318723485bdc65e5ecd6cc113ca Mon Sep 17 00:00:00 2001
From: Bob Strecansky <bob.strecansky@gmail.com>
Date: Fri, 15 May 2020 16:27:38 -0400
Subject: [PATCH] Update Examples with SpanKind (#82)

* Update Examples with SpanKind

* make style
---
 examples/AlwaysOffTraceExample.php | 18 ++++++++++--------
 examples/AlwaysOnTraceExample.php  |  4 +++-
 examples/JaegerExporterExample.php | 10 +++++++++-
 3 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/examples/AlwaysOffTraceExample.php b/examples/AlwaysOffTraceExample.php
index 9e3ede3f..d73fa76d 100644
--- a/examples/AlwaysOffTraceExample.php
+++ b/examples/AlwaysOffTraceExample.php
@@ -7,18 +7,20 @@ use OpenTelemetry\Sdk\Trace\AlwaysOffSampler;
 use OpenTelemetry\Sdk\Trace\Attributes;
 use OpenTelemetry\Sdk\Trace\SamplingResult;
 use OpenTelemetry\Sdk\Trace\TracerProvider;
+use OpenTelemetry\Trace as API;
 
 $sampler = new AlwaysOffSampler();
 $samplingResult = $sampler->shouldSample(
     null,
     md5((string) microtime(true)),
     substr(md5((string) microtime(true)), 16),
-    'io.opentelemetry.example'
+    'io.opentelemetry.example',
+    API\SpanKind::KIND_INTERNAL
 );
 
 if (SamplingResult::RECORD_AND_SAMPLED === $samplingResult) {
     $tracer = TracerProvider::getInstance()
-        ->getTracer('io.opentelemetry.contrib.php');
+    ->getTracer('io.opentelemetry.contrib.php');
 
     // start a span, register some events
     $span = $tracer->startAndActivateSpan('session.generate');
@@ -26,15 +28,15 @@ if (SamplingResult::RECORD_AND_SAMPLED === $samplingResult) {
     $span->setAttribute('country', 'USA');
 
     $span->addEvent('found_login', new Attributes([
-      'id' => 12345,
-      'username' => 'otuser',
-    ]));
+    'id' => 12345,
+    'username' => 'otuser',
+  ]));
     $span->addEvent('generated_session', new Attributes([
-      'id' => md5(microtime(true)),
-    ]));
+    'id' => md5(microtime(true)),
+  ]));
 
     $span->end(); // pass status as an optional argument
-    print_r($span);  // print the span as a resulting output
+  print_r($span);  // print the span as a resulting output
 } else {
     echo PHP_EOL . 'Sampling is not enabled';
 }
diff --git a/examples/AlwaysOnTraceExample.php b/examples/AlwaysOnTraceExample.php
index ed81e496..8af23a0e 100644
--- a/examples/AlwaysOnTraceExample.php
+++ b/examples/AlwaysOnTraceExample.php
@@ -9,13 +9,15 @@ use OpenTelemetry\Sdk\Trace\SamplingResult;
 use OpenTelemetry\Sdk\Trace\SimpleSpanProcessor;
 use OpenTelemetry\Sdk\Trace\TracerProvider;
 use OpenTelemetry\Sdk\Trace\ZipkinExporter;
+use OpenTelemetry\Trace as API;
 
 $sampler = new AlwaysOnSampler();
 $samplingResult = $sampler->shouldSample(
     null,
     md5((string) microtime(true)),
     substr(md5((string) microtime(true)), 16),
-    'io.opentelemetry.example'
+    'io.opentelemetry.example',
+    API\SpanKind::KIND_INTERNAL
 );
 
 $zipkinExporter = new ZipkinExporter(
diff --git a/examples/JaegerExporterExample.php b/examples/JaegerExporterExample.php
index 0bb6b5d1..4dbec597 100644
--- a/examples/JaegerExporterExample.php
+++ b/examples/JaegerExporterExample.php
@@ -8,8 +8,16 @@ use OpenTelemetry\Sdk\Trace\Attributes;
 use OpenTelemetry\Sdk\Trace\JaegerExporter;
 use OpenTelemetry\Sdk\Trace\SimpleSpanProcessor;
 use OpenTelemetry\Sdk\Trace\TracerProvider;
+use OpenTelemetry\Trace as API;
 
-$sampler = (new AlwaysOnSampler())->shouldSample();
+$sampler = new AlwaysOnSampler();
+$samplingResult = $sampler->shouldSample(
+    null,
+    md5((string) microtime(true)),
+    substr(md5((string) microtime(true)), 16),
+    'io.opentelemetry.example',
+    API\SpanKind::KIND_INTERNAL
+);
 
 $exporter = new JaegerExporter(
     'jaegerExporterExample',